xmlrpc module requires s sl module

[Juha Heinanen]

i tried to play with s xmlrpc module, but got this erroe message on
startup:

Jul  4 15:33:33 localhost /usr/sbin/sip-router[8664]: ERROR: xmlrpc [xmlrpc.c:1989]: This module requires sl module

i do have k sl module loaded, because i use function send_reply that does
not exist in s version of the module.  also, i use stats provided dby k
sl module.

is it possible to change xmlrpc module so that it accepts either s or k
version of sl module?

-- juha


_______________________________________________
sr-dev mailing list
[hidden email]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[Juha Heinanen]

Juha Heinanen writes:

 > is it possible to change xmlrpc module so that it accepts either s or k
 > version of sl module?

i tried to include both modules_k/sl/sl_api.h and modules_s/sl/sl.h to
xmlrpc.c, but there was conflicting types for sl_send_reply_f.  so looks
like #defines should be added to xmlrpc.c to select if k or s version of
sl module it used.

any better ideas?

-- juha

_______________________________________________
sr-dev mailing list
[hidden email]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[Raúl Alexis Betancor Santana]

On Saturday 04 July 2009 15:16:40 Juha Heinanen wrote:

> Juha Heinanen writes:
>  > is it possible to change xmlrpc module so that it accepts either s or k
>  > version of sl module?
>
> i tried to include both modules_k/sl/sl_api.h and modules_s/sl/sl.h to
> xmlrpc.c, but there was conflicting types for sl_send_reply_f.  so looks
> like #defines should be added to xmlrpc.c to select if k or s version of
> sl module it used.
>
> any better ideas?

Umm, we have 2 ways:

1) - modify modules_s/xmlrpc to support both mod_k/sl and mod_s/sl but only
one of them at the same time
2) - try to merge mod_k/sl and mod_s/sl in only one sl module

And also ... why there is sl, mod_k/sl and mod_s/sl .. ?

--
Raúl Alexis Betancor Santana
Dimensión Virtual

_______________________________________________
sr-dev mailing list
[hidden email]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[Juha Heinanen]

Raúl Alexis Betancor Santana writes:

 > 1) - modify modules_s/xmlrpc to support both mod_k/sl and mod_s/sl but only
 > one of them at the same time

this is what i suggested.  add a #define in modules_s/xmlrpc Makefile and
#ifdefs in the code.

 > 2) - try to merge mod_k/sl and mod_s/sl in only one sl module

this would be better, but i don't know how much work it would be.  the
apis are different, k sl has one more function and stats.

 > And also ... why there is sl, mod_k/sl and mod_s/sl .. ?

see above.

-- juha

_______________________________________________
sr-dev mailing list
[hidden email]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[Raúl Alexis Betancor Santana]

On Saturday 04 July 2009 19:43:02 Juha Heinanen wrote:
> Raúl Alexis Betancor Santana writes:
>  > 1) - modify modules_s/xmlrpc to support both mod_k/sl and mod_s/sl but
>  > only one of them at the same time
>
> this is what i suggested.  add a #define in modules_s/xmlrpc Makefile and
> #ifdefs in the code.

That's a a fast solution but not a long time integration

>  > 2) - try to merge mod_k/sl and mod_s/sl in only one sl module
>
> this would be better, but i don't know how much work it would be.  the
> apis are different, k sl has one more function and stats.

I'll check both and see how much work it will be to merge them, maybe it's not
so much


--
Raúl Alexis Betancor Santana
Dimensión Virtual

_______________________________________________
sr-dev mailing list
[hidden email]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[Juha Heinanen]

as first aid, i added Makefile define to choose between s and k sl
api.

-- juha

_______________________________________________
sr-dev mailing list
[hidden email]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev