Jon Stahl wrote:
I'm curious where the "theme rollout team" (limi, elro, ??) folks think
we're at w/r/t clearing up the various post-relaunch bugs, esp. the many
50x errors on various pages.
No pressure from me, but things seem to have been pretty quiet the past
few days. :-)
Work got in the way :)
I'm monitoring the 500 errors in google analytics, the 'Top Content' report filtered on /_500 shows you what's going on.
The main issue with the site now is invalid markup produced by zope.structuredtext and reST. I made a start on fixing zope.structuredtext on Tuesday:
http://zope3.pov.lt/trac/changeset?new=zope.structuredtext%2Ftrunk%2Fsrc%2Fzope%2Fstructuredtext%2Fhtml.py%4098726&old=zope.structuredtext%2Ftrunk%2Fsrc%2Fzope%2Fstructuredtext%2Fhtml.py%4075189This only fixed the nesting errors in p tags, there are other tags that need fixing too.
Once these are fixed we may still have some issues as STX allows you to type in random html and have that added to the rendering. This is not necessarily going to be valid. I'm tempted to just quote it all, but Alex seems to think of it as a feature rather than a bug.
reST will need similar work.
I've checked in a script to reproduce the validity errors (requires lxml):
https://svn.plone.org/svn/plone/Products.PloneOrg/trunk/scripts/html_validity.pyIt runs like this
$python scripts/html_validity.py
http://plone.org/products/plone/releases/3.0Fetching
http://plone.org:5011/VirtualHostBase/http/plone.org:80/plone.org/VirtualHostRoot/products/plone/releases/3.0Parsing...
<li>Updated the language control panel to a new formlib-based version which
shows all the language names localized to your language.
This refs
http://dev.plone.org/plone/ticket/5442.
[hannosch]</li>
<li>Added migration to move the kupu (core) and CMFPlacefulWorkflow (add-on)
control panels to the right categories. This closes
http://dev.plone.org/plone/ticket/6547.
[hannosch]</li>
<li>In plone.app.viewletmanager GenericSetup handler: Added support for
<code>based-on</code> and <code>make-default</code> parameters in <order /> and <hidden />
-------------------------------------------------------------------------------^
Traceback (most recent call last):
File "bin/zopepy", line 148, in ?
execfile(sys.argv[0])
File "scripts/html_validity.py", line 28, in ?
p.feed(chunk)
File "parser.pxi", line 1093, in lxml.etree._FeedParser.feed (src/lxml/lxml.etree.c:61114)
File "parser.pxi", line 534, in lxml.etree._ParserContext._handleParseResult (src/lxml/lxml.etree.c:56605)
File "parser.pxi", line 628, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:57504)
File "parser.pxi", line 568, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:56902)
lxml.etree.XMLSyntaxError: Tag order invalid, line 1245, column 80
It might be easier to fix these problems with a portal_transform that cleans up the html output by the rest and stx renderers, possibly using lxml itself as it seems to be less fussy when you parse the whole document at once.
Laurence
