vmmlib wishlist

3 messages Options
Embed this post
Permalink
Andreas Kirsch (in.tum)

vmmlib wishlist

Reply Threaded More More options
Print post
Permalink
Hello,
I'm currently working with vmmlib in my equalizer project and as far as
I see there are two small features missing which would make my code (and
possibly other's, too) cleaner:

A matrix constructor that takes an array of T and a component-wise one
(would require multiple constructors for the different matrix sizes but
the enable_if trick would make that possible)

A translate method. There are scale and rotation methods, but there is
no translate method. set_translation doesn't pre-multiply the
'translation' by the current matrix, which translate would have to do to
be correct.

Again this is not a big deal, but I don't have commit access, so I can't
add it myself. And I think it would make vmmlib more user-friendly.
Cheers,
 Andreas

_______________________________________________
eq-dev mailing list
[hidden email]
http://www.equalizergraphics.com/cgi-bin/mailman/listinfo/eq-dev
http://www.equalizergraphics.com
Stefan Eilemann

Re: vmmlib wishlist

Reply Threaded More More options
Print post
Permalink
Hi Andreas,

On Thu, Sep 17, 2009 at 9:21 AM, Andreas Kirsch (in.tum)
<[hidden email]> wrote:
> Hello,
> I'm currently working with vmmlib in my equalizer project and as far as
> I see there are two small features missing which would make my code (and
> possibly other's, too) cleaner:
[snip]

Agreed - the fastest way to get there is if you send me a patch, which
I'll review and check in. A slower way is to open a feature request on
the vmmlib sourceforge site, which we'll implement when we find the
time to do so.



Cheers,

Stefan.

_______________________________________________
eq-dev mailing list
[hidden email]
http://www.equalizergraphics.com/cgi-bin/mailman/listinfo/eq-dev
http://www.equalizergraphics.com
Andreas Kirsch (in.tum)

vmmlib's matrix pre_rotate_x and pre_rotate_y probably swapped

Reply Threaded More More options
Print post
Permalink
Hello,

if you look at http://blackhc.pastebin.com/d7a6e4443 (pre_rotate_x and
pre_rotate_y's code in matrix.hpp). You'll notice that pre_rotate_x
changes the x and z components of the column vectors and pre_rotate_y
change the y and z components of the column vectors.
I think the two functions are misnamed, the names should be swapped.
I have not checked for any sign issues, but certainly there is something
wrong since any rotation around the x axis shouldn't change the x
component of the rotated vector (same thing for the y axis and y component).

Cheers,
 Andreas

_______________________________________________
eq-dev mailing list
[hidden email]
http://www.equalizergraphics.com/cgi-bin/mailman/listinfo/eq-dev
http://www.equalizergraphics.com