[review] UC_STRING.area_lower, and area_upper should be exported to {READABLE_STRING_8, READABLE_STRING_32}

[Jocelyn.Fiat.List]

Compiling Gobo's with ISE's "full class checking" option enabled, you
can notice that

In class UC_STRING, the feature  `area_lower', `area_upper' should be
exported to {READABLE_STRING_8, READABLE_STRING_32}

Suggestion: following patch

Index: uc_string.e
===================================================================
--- uc_string.e    (revision 76809)
+++ uc_string.e    (working copy)
@@ -70,6 +70,8 @@
                 is_case_insensitive_equal,
                 valid_code,
                 to_string_32
+            {READABLE_STRING_8, READABLE_STRING_32}
+                area_lower, area_upper
             {ANY}
                 is_string_8,
                 valid_index


Regards,
-- Jocelyn
ps: Maybe, there are other similar cases in UC_STRING, and this class
might benefit a deep review to match recent changes of the STRING_*
interface.



------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
gobo-eiffel-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gobo-eiffel-develop

[Eric Bezault]

Jocelyn wrote:
> Compiling Gobo's with ISE's "full class checking" option enabled, you
> can notice that
>
> In class UC_STRING, the feature  `area_lower', `area_upper' should be
> exported to {READABLE_STRING_8, READABLE_STRING_32}

According to gelint, the problem was only on `area_lower'.
The problem is that this routine does not exist in ISE 6.3
and READABLE_STRING_8 does not exist in ISE 6.2.

I'll try to find another solution.

> ps: Maybe, there are other similar cases in UC_STRING, and this class
> might benefit a deep review to match recent changes of the STRING_*
> interface.

Yes, but it is a huge task, because the XML library will have to be
updated accordingly.

--
Eric Bezault
mailto:[hidden email]
http://www.gobosoft.com

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
gobo-eiffel-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gobo-eiffel-develop

[Emmanuel Stapf]

Should Jocelyn send those specific issues using the sourceforge bug tracker?

Manu

> -----Original Message-----
> From: Eric Bezault [mailto:[hidden email]]
> Sent: Friday, January 23, 2009 8:13 AM
> To: Jocelyn
> Cc: gobodev
> Subject: Re: [gobo-eiffel-develop] [review] UC_STRING.area_lower, and
> area_upper should be exported to {READABLE_STRING_8, READABLE_STRING_32}
>
> Jocelyn wrote:
> > Compiling Gobo's with ISE's "full class checking" option enabled, you
> > can notice that
> >
> > In class UC_STRING, the feature  `area_lower', `area_upper' should be
> > exported to {READABLE_STRING_8, READABLE_STRING_32}
>
> According to gelint, the problem was only on `area_lower'.
> The problem is that this routine does not exist in ISE 6.3
> and READABLE_STRING_8 does not exist in ISE 6.2.
>
> I'll try to find another solution.
>
> > ps: Maybe, there are other similar cases in UC_STRING, and this class
> > might benefit a deep review to match recent changes of the STRING_*
> > interface.
>
> Yes, but it is a huge task, because the XML library will have to be
> updated accordingly.
>
> --
> Eric Bezault
> mailto:[hidden email]
> http://www.gobosoft.com
>
> -------------------------------------------------------------------------
> -----
> This SF.net email is sponsored by:
> SourcForge Community
> SourceForge wants to tell your story.
> http://p.sf.net/sfu/sf-spreadtheword
> _______________________________________________
> gobo-eiffel-develop mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gobo-eiffel-develop

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
gobo-eiffel-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gobo-eiffel-develop

[Eric Bezault]

Emmanuel Stapf [ES] wrote:
> Should Jocelyn send those specific issues using the sourceforge bug tracker?

That would indeed make it easier to follow each issue.

--
Eric Bezault
mailto:[hidden email]
http://www.gobosoft.com

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
gobo-eiffel-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gobo-eiffel-develop

[Eric Bezault]

Eric Bezault wrote:

> Jocelyn wrote:
>> Compiling Gobo's with ISE's "full class checking" option enabled, you
>> can notice that
>>
>> In class UC_STRING, the feature  `area_lower', `area_upper' should be
>> exported to {READABLE_STRING_8, READABLE_STRING_32}
>
> According to gelint, the problem was only on `area_lower'.
> The problem is that this routine does not exist in ISE 6.3
> and READABLE_STRING_8 does not exist in ISE 6.2.
>
> I'll try to find another solution.

I think that this is now fixed in SVN.

--
Eric Bezault
mailto:[hidden email]
http://www.gobosoft.com

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
gobo-eiffel-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gobo-eiffel-develop

[Jocelyn.Fiat.List]

Hi all,

I am now using the gobo-eiffel tracker at
https://sourceforge.net/tracker2/?group_id=24591&atid=381937
I was first using the mailing list, since I was not sure everyone
follows the bug tracker's activity for the gobo-eiffel project.
Anyway, I think Eric will assigned himself or other people to specific
report. So no need to pollute this mailing list.

Best regards,
--Jocelyn

Eric Bezault wrote:
> Emmanuel Stapf [ES] wrote:
>  
>> Should Jocelyn send those specific issues using the sourceforge bug tracker?
>>    
>
> That would indeed make it easier to follow each issue.
>
>  



------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
gobo-eiffel-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gobo-eiffel-develop