patch submission guidelines?
|
|
Steve Hillier
|
Some javascript/style in this post has been disabled (why?)
Hi,
Is there a current standard or guideline on
patch development & submission for the project. Can anyone direct
me?
Thanks,
Steve.
------------------------------------------------------------------------------ _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
Johan Edstrom
|
Some javascript/style in this post has been disabled (why?)
Really nothing more than it compiles against trunk, matches the issue - and is not a monstrous ton of code reformatting :) On Jul 1, 2009, at 8:08 AM, Steve Hillier wrote:
Johan Edstrom They that can give up essential liberty to purchase a little temporary safety, deserve neither liberty nor safety. Benjamin Franklin, Historical Review of Pennsylvania, 1759 ------------------------------------------------------------------------------ _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
||||||||||||||||
David Hustace
|
In reply to this post
by Steve Hillier
Some javascript/style in this post has been disabled (why?)
On Jul 1, 2009, at 10:08 AM, Steve Hillier wrote:
Search for branch management in the wiki. We can create a feature branch if it is something that does provide a considerable amount changes to the code. This way you/we can track trunk in the branch with svnmerge and make merging back to trunk more feasible. David Hustace President The OpenNMS Group, Inc. "Every program attempts to expand until it can read mail. Those programs which cannot so expand are replaced by ones which can." ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
||||||||||||||||
|
Steve Hillier
|
Some javascript/style in this post has been disabled (why?)
Thanks.
I'm still flushing out my prototype but so far, it's
only required changes to 4 source files (although I'm sure that will change as I
go). I don't expect my patch to be too huge - this is simply
composite data type support for the JMX collector.
I'll request further guidance on tracking my changes in
a branch as the prototype develops.
regards,
Steve.
From: [hidden email]
Sent: Tuesday, July 14, 2009 11:58 PM
To: [hidden email]
Subject: Re: [opennms-devel] patch submission
guidelines? On Jul 1, 2009, at 10:08 AM, Steve Hillier wrote:
Search for branch management in the wiki. We can create a feature branch if it is something that does provide a considerable amount changes to the code. This way you/we can track trunk in
the branch with svnmerge and make merging back to trunk more
feasible.
David Hustace
President
The OpenNMS Group, Inc.
"Every program attempts to expand until it can read mail. Those programs
which cannot so expand are replaced by ones which can."
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge
_______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
||||||||||||||||
Matt Brozowski-2
|
The other things to do is... When you have a patch... open an enhancement bug and attach the patch to it. Include in the enhancement bug details about what problem you are solving and why, and how your patch solves the problem. Also, include the revision and branch that your patch should be applied to.
Matt Brozowski
On Thu, Jul 16, 2009 at 1:27 AM, Steve Hillier <[hidden email]> wrote:
------------------------------------------------------------------------------ _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
||||||||||||||||
|
Steve Hillier
|
I sent my patch to the dev list last week when it passed testing in my lab.
I found a pooly named bug that describes the issue I'm trying to address last night, and so I added my patch and spec doc as attachments to it: BUG # 1444 I've run the code for a week in my lab - no errors. Next test phase is scaling it to 30 concurrent jvms undergoing collection which requires my work lab. This will be a linux test env, unlike my windows-based lab env. Performance Problem: One enhancement I can't figure out how to do is to get multiple datapoints stored in a single rrd. With my current patch, all the composite attribute members go to individual rrds. I'm still trying to figure out how to aggregate multiple data points into a single rrd (named for the attribute). Any tips? steve. On Mon, Jul 27, 2009 at 12:29 PM, Matt Brozowski<[hidden email]> wrote: > The other things to do is... When you have a patch... open an enhancement > bug and attach the patch to it. Include in the enhancement bug details > about what problem you are solving and why, and how your patch solves the > problem. Also, include the revision and branch that your patch should be > applied to. > Matt Brozowski > > On Thu, Jul 16, 2009 at 1:27 AM, Steve Hillier <[hidden email]> wrote: >> >> Thanks. >> >> I'm still flushing out my prototype but so far, it's only required changes >> to 4 source files (although I'm sure that will change as I go). I don't >> expect my patch to be too huge - this is simply composite data type support >> for the JMX collector. >> >> I'll request further guidance on tracking my changes in a branch as the >> prototype develops. >> >> regards, >> Steve. >> From: David Hustace >> Sent: Tuesday, July 14, 2009 11:58 PM >> To: OpenNMS Code Development and Bugs >> Subject: Re: [opennms-devel] patch submission guidelines? >> >> On Jul 1, 2009, at 10:08 AM, Steve Hillier wrote: >> >> Is there a current standard or guideline on patch development & submission >> for the project. Can anyone direct me? >> >> >> Search for branch management in the wiki. We can create a feature branch if it is something that does provide a considerable amount changes to the code. This way you/we can track trunk in >> the branch with svnmerge and make merging back to trunk more feasible. >> >> David Hustace >> President >> The OpenNMS Group, Inc. >> "Every program attempts to expand until it can read mail. Those programs >> which cannot so expand are replaced by ones which can." >> http://www.jwz.org/ >> >> ________________________________ >> >> >> ------------------------------------------------------------------------------ >> Enter the BlackBerry Developer Challenge >> This is your chance to win up to $100,000 in prizes! For a limited time, >> vendors submitting new applications to BlackBerry App World(TM) will have >> the opportunity to enter the BlackBerry Developer Challenge. See full >> prize >> details at: http://p.sf.net/sfu/Challenge >> >> ________________________________ >> >> _______________________________________________ >> Please read the OpenNMS Mailing List FAQ: >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> opennms-devel mailing list >> >> To *unsubscribe* or change your subscription options, see the bottom of >> this page: >> https://lists.sourceforge.net/lists/listinfo/opennms-devel >> >> >> ------------------------------------------------------------------------------ >> Enter the BlackBerry Developer Challenge >> This is your chance to win up to $100,000 in prizes! For a limited time, >> vendors submitting new applications to BlackBerry App World(TM) will have >> the opportunity to enter the BlackBerry Developer Challenge. See full >> prize >> details at: http://p.sf.net/sfu/Challenge >> _______________________________________________ >> Please read the OpenNMS Mailing List FAQ: >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> opennms-devel mailing list >> >> To *unsubscribe* or change your subscription options, see the bottom of >> this page: >> https://lists.sourceforge.net/lists/listinfo/opennms-devel > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Please read the OpenNMS Mailing List FAQ: > http://www.opennms.org/index.php/Mailing_List_FAQ > > opennms-devel mailing list > > To *unsubscribe* or change your subscription options, see the bottom of this > page: > https://lists.sourceforge.net/lists/listinfo/opennms-devel > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
||||||||||||||||
DJ Gregor-2
|
Steve,
Look at the "store-by-group" feature that's available for SNMP collections. It was written to let you store all of the attributes specified in a single SNMP collection group in the same RRD file, named by the collection group. You might be able to do the same thing for JMX, but some of the "grouping" infrastructure might not be there that is there for SNMP. This is definitely the place to ask questions if you get stuck. - djg On Mon, 27 Jul 2009 18:04 -0400, "Steve Hillier" <[hidden email]> wrote: > I sent my patch to the dev list last week when it passed testing in my > lab. > > I found a pooly named bug that describes the issue I'm trying to > address last night, and so I added my patch and spec doc as > attachments to it: BUG # 1444 > > I've run the code for a week in my lab - no errors. Next test phase is > scaling it to 30 concurrent jvms undergoing collection which requires > my work lab. This will be a linux test env, unlike my windows-based > lab env. > > Performance Problem: > > One enhancement I can't figure out how to do is to get multiple > datapoints stored in a single rrd. With my current patch, all the > composite attribute members go to individual rrds. I'm still trying to > figure out how to aggregate multiple data points into a single rrd > (named for the attribute). Any tips? > > steve. > > On Mon, Jul 27, 2009 at 12:29 PM, Matt Brozowski<[hidden email]> wrote: > > The other things to do is... When you have a patch... open an enhancement > > bug and attach the patch to it. Include in the enhancement bug details > > about what problem you are solving and why, and how your patch solves the > > problem. Also, include the revision and branch that your patch should be > > applied to. > > Matt Brozowski > > > > On Thu, Jul 16, 2009 at 1:27 AM, Steve Hillier <[hidden email]> wrote: > >> > >> Thanks. > >> > >> I'm still flushing out my prototype but so far, it's only required changes > >> to 4 source files (although I'm sure that will change as I go). I don't > >> expect my patch to be too huge - this is simply composite data type support > >> for the JMX collector. > >> > >> I'll request further guidance on tracking my changes in a branch as the > >> prototype develops. > >> > >> regards, > >> Steve. > >> From: David Hustace > >> Sent: Tuesday, July 14, 2009 11:58 PM > >> To: OpenNMS Code Development and Bugs > >> Subject: Re: [opennms-devel] patch submission guidelines? > >> > >> On Jul 1, 2009, at 10:08 AM, Steve Hillier wrote: > >> > >> Is there a current standard or guideline on patch development & submission > >> for the project. Can anyone direct me? > >> > >> > >> Search for branch management in the wiki. We can create a feature branch if it is something that does provide a considerable amount changes to the code. This way you/we can track trunk in > >> the branch with svnmerge and make merging back to trunk more feasible. > >> > >> David Hustace > >> President > >> The OpenNMS Group, Inc. > >> "Every program attempts to expand until it can read mail. Those programs > >> which cannot so expand are replaced by ones which can." > >> http://www.jwz.org/ > >> > >> ________________________________ > >> > >> > >> ------------------------------------------------------------------------------ > >> Enter the BlackBerry Developer Challenge > >> This is your chance to win up to $100,000 in prizes! For a limited time, > >> vendors submitting new applications to BlackBerry App World(TM) will have > >> the opportunity to enter the BlackBerry Developer Challenge. See full > >> prize > >> details at: http://p.sf.net/sfu/Challenge > >> > >> ________________________________ > >> > >> _______________________________________________ > >> Please read the OpenNMS Mailing List FAQ: > >> http://www.opennms.org/index.php/Mailing_List_FAQ > >> > >> opennms-devel mailing list > >> > >> To *unsubscribe* or change your subscription options, see the bottom of > >> this page: > >> https://lists.sourceforge.net/lists/listinfo/opennms-devel > >> > >> > >> ------------------------------------------------------------------------------ > >> Enter the BlackBerry Developer Challenge > >> This is your chance to win up to $100,000 in prizes! For a limited time, > >> vendors submitting new applications to BlackBerry App World(TM) will have > >> the opportunity to enter the BlackBerry Developer Challenge. See full > >> prize > >> details at: http://p.sf.net/sfu/Challenge > >> _______________________________________________ > >> Please read the OpenNMS Mailing List FAQ: > >> http://www.opennms.org/index.php/Mailing_List_FAQ > >> > >> opennms-devel mailing list > >> > >> To *unsubscribe* or change your subscription options, see the bottom of > >> this page: > >> https://lists.sourceforge.net/lists/listinfo/opennms-devel > > > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > > Please read the OpenNMS Mailing List FAQ: > > http://www.opennms.org/index.php/Mailing_List_FAQ > > > > opennms-devel mailing list > > > > To *unsubscribe* or change your subscription options, see the bottom of this > > page: > > https://lists.sourceforge.net/lists/listinfo/opennms-devel > > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Please read the OpenNMS Mailing List FAQ: > http://www.opennms.org/index.php/Mailing_List_FAQ > > opennms-devel mailing list > > To *unsubscribe* or change your subscription options, see the bottom of > this page: > https://lists.sourceforge.net/lists/listinfo/opennms-devel ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
||||||||||||||||
|
Steve Hillier
|
DJ:
Thanks for the information. I'm familiar with snmp store-by-group, and I've been reviewing the SNMP collector code to see how it's used. I'm sure I'll have more questions as I get deeper into the snmp collector code -- I'll pass them along if I need help :) What other enhancements might be worth considering for the JMX collector? Any suggestions? I'd like to try and make it as robust as some of the other collectors in the distribution. thanks, Steve. -------------------------------------------------- From: "DJ Gregor" <[hidden email]> Sent: Tuesday, July 28, 2009 7:51 PM To: "OpenNMS Code Development and Bugs" <[hidden email]> Subject: Re: [opennms-devel] patch submission guidelines? > Steve, > > Look at the "store-by-group" feature that's available for SNMP > collections. It was written to let you store all of the attributes > specified in a single SNMP collection group in the same RRD file, named > by the collection group. You might be able to do the same thing for > JMX, but some of the "grouping" infrastructure might not be there that > is there for SNMP. This is definitely the place to ask questions if you > get stuck. > > > - djg > > On Mon, 27 Jul 2009 18:04 -0400, "Steve Hillier" <[hidden email]> > wrote: >> I sent my patch to the dev list last week when it passed testing in my >> lab. >> >> I found a pooly named bug that describes the issue I'm trying to >> address last night, and so I added my patch and spec doc as >> attachments to it: BUG # 1444 >> >> I've run the code for a week in my lab - no errors. Next test phase is >> scaling it to 30 concurrent jvms undergoing collection which requires >> my work lab. This will be a linux test env, unlike my windows-based >> lab env. >> >> Performance Problem: >> >> One enhancement I can't figure out how to do is to get multiple >> datapoints stored in a single rrd. With my current patch, all the >> composite attribute members go to individual rrds. I'm still trying to >> figure out how to aggregate multiple data points into a single rrd >> (named for the attribute). Any tips? >> >> steve. >> >> On Mon, Jul 27, 2009 at 12:29 PM, Matt Brozowski<[hidden email]> wrote: >> > The other things to do is... When you have a patch... open an >> > enhancement >> > bug and attach the patch to it. Include in the enhancement bug details >> > about what problem you are solving and why, and how your patch solves >> > the >> > problem. Also, include the revision and branch that your patch should >> > be >> > applied to. >> > Matt Brozowski >> > >> > On Thu, Jul 16, 2009 at 1:27 AM, Steve Hillier <[hidden email]> >> > wrote: >> >> >> >> Thanks. >> >> >> >> I'm still flushing out my prototype but so far, it's only required >> >> changes >> >> to 4 source files (although I'm sure that will change as I go). I >> >> don't >> >> expect my patch to be too huge - this is simply composite data type >> >> support >> >> for the JMX collector. >> >> >> >> I'll request further guidance on tracking my changes in a branch as >> >> the >> >> prototype develops. >> >> >> >> regards, >> >> Steve. >> >> From: David Hustace >> >> Sent: Tuesday, July 14, 2009 11:58 PM >> >> To: OpenNMS Code Development and Bugs >> >> Subject: Re: [opennms-devel] patch submission guidelines? >> >> >> >> On Jul 1, 2009, at 10:08 AM, Steve Hillier wrote: >> >> >> >> Is there a current standard or guideline on patch development & >> >> submission >> >> for the project. Can anyone direct me? >> >> >> >> >> >> Search for branch management in the wiki. We can create a feature >> >> branch if it is something that does provide a considerable amount >> >> changes to the code. This way you/we can track trunk in >> >> the branch with svnmerge and make merging back to trunk more feasible. >> >> >> >> David Hustace >> >> President >> >> The OpenNMS Group, Inc. >> >> "Every program attempts to expand until it can read mail. Those >> >> programs >> >> which cannot so expand are replaced by ones which can." >> >> http://www.jwz.org/ >> >> >> >> ________________________________ >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Enter the BlackBerry Developer Challenge >> >> This is your chance to win up to $100,000 in prizes! For a limited >> >> time, >> >> vendors submitting new applications to BlackBerry App World(TM) will >> >> have >> >> the opportunity to enter the BlackBerry Developer Challenge. See full >> >> prize >> >> details at: http://p.sf.net/sfu/Challenge >> >> >> >> ________________________________ >> >> >> >> _______________________________________________ >> >> Please read the OpenNMS Mailing List FAQ: >> >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> >> >> opennms-devel mailing list >> >> >> >> To *unsubscribe* or change your subscription options, see the bottom >> >> of >> >> this page: >> >> https://lists.sourceforge.net/lists/listinfo/opennms-devel >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Enter the BlackBerry Developer Challenge >> >> This is your chance to win up to $100,000 in prizes! For a limited >> >> time, >> >> vendors submitting new applications to BlackBerry App World(TM) will >> >> have >> >> the opportunity to enter the BlackBerry Developer Challenge. See full >> >> prize >> >> details at: http://p.sf.net/sfu/Challenge >> >> _______________________________________________ >> >> Please read the OpenNMS Mailing List FAQ: >> >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> >> >> opennms-devel mailing list >> >> >> >> To *unsubscribe* or change your subscription options, see the bottom >> >> of >> >> this page: >> >> https://lists.sourceforge.net/lists/listinfo/opennms-devel >> > >> > >> > ------------------------------------------------------------------------------ >> > >> > _______________________________________________ >> > Please read the OpenNMS Mailing List FAQ: >> > http://www.opennms.org/index.php/Mailing_List_FAQ >> > >> > opennms-devel mailing list >> > >> > To *unsubscribe* or change your subscription options, see the bottom of >> > this >> > page: >> > https://lists.sourceforge.net/lists/listinfo/opennms-devel >> > >> >> ------------------------------------------------------------------------------ >> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 >> 30-Day >> trial. Simplify your report design, integration and deployment - and >> focus on >> what you do best, core application coding. Discover what's new with >> Crystal Reports now. http://p.sf.net/sfu/bobj-july >> _______________________________________________ >> Please read the OpenNMS Mailing List FAQ: >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> opennms-devel mailing list >> >> To *unsubscribe* or change your subscription options, see the bottom of >> this page: >> https://lists.sourceforge.net/lists/listinfo/opennms-devel > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and focus > on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Please read the OpenNMS Mailing List FAQ: > http://www.opennms.org/index.php/Mailing_List_FAQ > > opennms-devel mailing list > > To *unsubscribe* or change your subscription options, see the bottom of > this page: > https://lists.sourceforge.net/lists/listinfo/opennms-devel > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
||||||||||||||||
|
Steve Hillier
|
In reply to this post
by DJ Gregor-2
Hi,
I have some more questions about store-by-group :) So after reading through a bunch of code, I'm under the impression that each "group" element defined in the config file triggers the creation of an "AttributeGroup" that's added to the CollectionSet. How close is that to reality? If that's accurate, then I would propose the following implementation for the jmx collector: Create an AttributeGroup for each composite attribute defined, and then add the desired 'composite-attribute-members' to the group. Does this sound sensible to you? thanks, steve. -------------------------------------------------- From: "DJ Gregor" <[hidden email]> Sent: Tuesday, July 28, 2009 7:51 PM To: "OpenNMS Code Development and Bugs" <[hidden email]> Subject: Re: [opennms-devel] patch submission guidelines? > Steve, > > Look at the "store-by-group" feature that's available for SNMP > collections. It was written to let you store all of the attributes > specified in a single SNMP collection group in the same RRD file, named > by the collection group. You might be able to do the same thing for > JMX, but some of the "grouping" infrastructure might not be there that > is there for SNMP. This is definitely the place to ask questions if you > get stuck. > > > - djg > > On Mon, 27 Jul 2009 18:04 -0400, "Steve Hillier" <[hidden email]> > wrote: >> I sent my patch to the dev list last week when it passed testing in my >> lab. >> >> I found a pooly named bug that describes the issue I'm trying to >> address last night, and so I added my patch and spec doc as >> attachments to it: BUG # 1444 >> >> I've run the code for a week in my lab - no errors. Next test phase is >> scaling it to 30 concurrent jvms undergoing collection which requires >> my work lab. This will be a linux test env, unlike my windows-based >> lab env. >> >> Performance Problem: >> >> One enhancement I can't figure out how to do is to get multiple >> datapoints stored in a single rrd. With my current patch, all the >> composite attribute members go to individual rrds. I'm still trying to >> figure out how to aggregate multiple data points into a single rrd >> (named for the attribute). Any tips? >> >> steve. >> >> On Mon, Jul 27, 2009 at 12:29 PM, Matt Brozowski<[hidden email]> wrote: >> > The other things to do is... When you have a patch... open an >> > enhancement >> > bug and attach the patch to it. Include in the enhancement bug details >> > about what problem you are solving and why, and how your patch solves >> > the >> > problem. Also, include the revision and branch that your patch should >> > be >> > applied to. >> > Matt Brozowski >> > >> > On Thu, Jul 16, 2009 at 1:27 AM, Steve Hillier <[hidden email]> >> > wrote: >> >> >> >> Thanks. >> >> >> >> I'm still flushing out my prototype but so far, it's only required >> >> changes >> >> to 4 source files (although I'm sure that will change as I go). I >> >> don't >> >> expect my patch to be too huge - this is simply composite data type >> >> support >> >> for the JMX collector. >> >> >> >> I'll request further guidance on tracking my changes in a branch as >> >> the >> >> prototype develops. >> >> >> >> regards, >> >> Steve. >> >> From: David Hustace >> >> Sent: Tuesday, July 14, 2009 11:58 PM >> >> To: OpenNMS Code Development and Bugs >> >> Subject: Re: [opennms-devel] patch submission guidelines? >> >> >> >> On Jul 1, 2009, at 10:08 AM, Steve Hillier wrote: >> >> >> >> Is there a current standard or guideline on patch development & >> >> submission >> >> for the project. Can anyone direct me? >> >> >> >> >> >> Search for branch management in the wiki. We can create a feature >> >> branch if it is something that does provide a considerable amount >> >> changes to the code. This way you/we can track trunk in >> >> the branch with svnmerge and make merging back to trunk more feasible. >> >> >> >> David Hustace >> >> President >> >> The OpenNMS Group, Inc. >> >> "Every program attempts to expand until it can read mail. Those >> >> programs >> >> which cannot so expand are replaced by ones which can." >> >> http://www.jwz.org/ >> >> >> >> ________________________________ >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Enter the BlackBerry Developer Challenge >> >> This is your chance to win up to $100,000 in prizes! For a limited >> >> time, >> >> vendors submitting new applications to BlackBerry App World(TM) will >> >> have >> >> the opportunity to enter the BlackBerry Developer Challenge. See full >> >> prize >> >> details at: http://p.sf.net/sfu/Challenge >> >> >> >> ________________________________ >> >> >> >> _______________________________________________ >> >> Please read the OpenNMS Mailing List FAQ: >> >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> >> >> opennms-devel mailing list >> >> >> >> To *unsubscribe* or change your subscription options, see the bottom >> >> of >> >> this page: >> >> https://lists.sourceforge.net/lists/listinfo/opennms-devel >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Enter the BlackBerry Developer Challenge >> >> This is your chance to win up to $100,000 in prizes! For a limited >> >> time, >> >> vendors submitting new applications to BlackBerry App World(TM) will >> >> have >> >> the opportunity to enter the BlackBerry Developer Challenge. See full >> >> prize >> >> details at: http://p.sf.net/sfu/Challenge >> >> _______________________________________________ >> >> Please read the OpenNMS Mailing List FAQ: >> >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> >> >> opennms-devel mailing list >> >> >> >> To *unsubscribe* or change your subscription options, see the bottom >> >> of >> >> this page: >> >> https://lists.sourceforge.net/lists/listinfo/opennms-devel >> > >> > >> > ------------------------------------------------------------------------------ >> > >> > _______________________________________________ >> > Please read the OpenNMS Mailing List FAQ: >> > http://www.opennms.org/index.php/Mailing_List_FAQ >> > >> > opennms-devel mailing list >> > >> > To *unsubscribe* or change your subscription options, see the bottom of >> > this >> > page: >> > https://lists.sourceforge.net/lists/listinfo/opennms-devel >> > >> >> ------------------------------------------------------------------------------ >> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 >> 30-Day >> trial. Simplify your report design, integration and deployment - and >> focus on >> what you do best, core application coding. Discover what's new with >> Crystal Reports now. http://p.sf.net/sfu/bobj-july >> _______________________________________________ >> Please read the OpenNMS Mailing List FAQ: >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> opennms-devel mailing list >> >> To *unsubscribe* or change your subscription options, see the bottom of >> this page: >> https://lists.sourceforge.net/lists/listinfo/opennms-devel > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and focus > on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Please read the OpenNMS Mailing List FAQ: > http://www.opennms.org/index.php/Mailing_List_FAQ > > opennms-devel mailing list > > To *unsubscribe* or change your subscription options, see the bottom of > this page: > https://lists.sourceforge.net/lists/listinfo/opennms-devel > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
||||||||||||||||
DJ Gregor
|
Steve,
I'm not an expert in this arena, but your take on how grouping for snmp sounds right to me, and your solution for JMX sounds sensible, as well. Would your solution also work for non-composite attributes, as well? On Aug 2, 2009, at 5:21 PM, "Steve Hillier" <[hidden email]> wrote: > Hi, > > I have some more questions about store-by-group :) > > So after reading through a bunch of code, I'm under the impression > that each > "group" element defined in the config file triggers the creation of an > "AttributeGroup" that's added to the CollectionSet. How close is > that to > reality? > > If that's accurate, then I would propose the following > implementation for > the jmx collector: > > Create an AttributeGroup for each composite attribute defined, and > then add > the desired 'composite-attribute-members' to the group. Does this > sound > sensible to you? > > thanks, > steve. > > -------------------------------------------------- > From: "DJ Gregor" <[hidden email]> > Sent: Tuesday, July 28, 2009 7:51 PM > To: "OpenNMS Code Development and Bugs" > <[hidden email]> > Subject: Re: [opennms-devel] patch submission guidelines? > >> Steve, >> >> Look at the "store-by-group" feature that's available for SNMP >> collections. It was written to let you store all of the attributes >> specified in a single SNMP collection group in the same RRD file, >> named >> by the collection group. You might be able to do the same thing for >> JMX, but some of the "grouping" infrastructure might not be there >> that >> is there for SNMP. This is definitely the place to ask questions >> if you >> get stuck. >> >> >> - djg >> >> On Mon, 27 Jul 2009 18:04 -0400, "Steve Hillier" <[hidden email]> >> wrote: >>> I sent my patch to the dev list last week when it passed testing >>> in my >>> lab. >>> >>> I found a pooly named bug that describes the issue I'm trying to >>> address last night, and so I added my patch and spec doc as >>> attachments to it: BUG # 1444 >>> >>> I've run the code for a week in my lab - no errors. Next test >>> phase is >>> scaling it to 30 concurrent jvms undergoing collection which >>> requires >>> my work lab. This will be a linux test env, unlike my windows-based >>> lab env. >>> >>> Performance Problem: >>> >>> One enhancement I can't figure out how to do is to get multiple >>> datapoints stored in a single rrd. With my current patch, all the >>> composite attribute members go to individual rrds. I'm still >>> trying to >>> figure out how to aggregate multiple data points into a single rrd >>> (named for the attribute). Any tips? >>> >>> steve. >>> >>> On Mon, Jul 27, 2009 at 12:29 PM, Matt Brozowski<[hidden email]> >>> wrote: >>>> The other things to do is... When you have a patch... open an >>>> enhancement >>>> bug and attach the patch to it. Include in the enhancement bug >>>> details >>>> about what problem you are solving and why, and how your patch >>>> solves >>>> the >>>> problem. Also, include the revision and branch that your patch >>>> should >>>> be >>>> applied to. >>>> Matt Brozowski >>>> >>>> On Thu, Jul 16, 2009 at 1:27 AM, Steve Hillier <[hidden email]> >>>> wrote: >>>>> >>>>> Thanks. >>>>> >>>>> I'm still flushing out my prototype but so far, it's only required >>>>> changes >>>>> to 4 source files (although I'm sure that will change as I go). I >>>>> don't >>>>> expect my patch to be too huge - this is simply composite data >>>>> type >>>>> support >>>>> for the JMX collector. >>>>> >>>>> I'll request further guidance on tracking my changes in a branch >>>>> as >>>>> the >>>>> prototype develops. >>>>> >>>>> regards, >>>>> Steve. >>>>> From: David Hustace >>>>> Sent: Tuesday, July 14, 2009 11:58 PM >>>>> To: OpenNMS Code Development and Bugs >>>>> Subject: Re: [opennms-devel] patch submission guidelines? >>>>> >>>>> On Jul 1, 2009, at 10:08 AM, Steve Hillier wrote: >>>>> >>>>> Is there a current standard or guideline on patch development & >>>>> submission >>>>> for the project. Can anyone direct me? >>>>> >>>>> >>>>> Search for branch management in the wiki. We can create a feature >>>>> branch if it is something that does provide a considerable amount >>>>> changes to the code. This way you/we can track trunk in >>>>> the branch with svnmerge and make merging back to trunk more >>>>> feasible. >>>>> >>>>> David Hustace >>>>> President >>>>> The OpenNMS Group, Inc. >>>>> "Every program attempts to expand until it can read mail. Those >>>>> programs >>>>> which cannot so expand are replaced by ones which can." >>>>> http://www.jwz.org/ >>>>> >>>>> ________________________________ >>>>> >>>>> >>>>> --- >>>>> --- >>>>> --- >>>>> --- >>>>> ------------------------------------------------------------------ >>>>> Enter the BlackBerry Developer Challenge >>>>> This is your chance to win up to $100,000 in prizes! For a limited >>>>> time, >>>>> vendors submitting new applications to BlackBerry App World(TM) >>>>> will >>>>> have >>>>> the opportunity to enter the BlackBerry Developer Challenge. See >>>>> full >>>>> prize >>>>> details at: http://p.sf.net/sfu/Challenge >>>>> >>>>> ________________________________ >>>>> >>>>> _______________________________________________ >>>>> Please read the OpenNMS Mailing List FAQ: >>>>> http://www.opennms.org/index.php/Mailing_List_FAQ >>>>> >>>>> opennms-devel mailing list >>>>> >>>>> To *unsubscribe* or change your subscription options, see the >>>>> bottom >>>>> of >>>>> this page: >>>>> https://lists.sourceforge.net/lists/listinfo/opennms-devel >>>>> >>>>> >>>>> --- >>>>> --- >>>>> --- >>>>> --- >>>>> ------------------------------------------------------------------ >>>>> Enter the BlackBerry Developer Challenge >>>>> This is your chance to win up to $100,000 in prizes! For a limited >>>>> time, >>>>> vendors submitting new applications to BlackBerry App World(TM) >>>>> will >>>>> have >>>>> the opportunity to enter the BlackBerry Developer Challenge. See >>>>> full >>>>> prize >>>>> details at: http://p.sf.net/sfu/Challenge >>>>> _______________________________________________ >>>>> Please read the OpenNMS Mailing List FAQ: >>>>> http://www.opennms.org/index.php/Mailing_List_FAQ >>>>> >>>>> opennms-devel mailing list >>>>> >>>>> To *unsubscribe* or change your subscription options, see the >>>>> bottom >>>>> of >>>>> this page: >>>>> https://lists.sourceforge.net/lists/listinfo/opennms-devel >>>> >>>> >>>> --- >>>> --- >>>> --- >>>> --- >>>> ------------------------------------------------------------------ >>>> >>>> _______________________________________________ >>>> Please read the OpenNMS Mailing List FAQ: >>>> http://www.opennms.org/index.php/Mailing_List_FAQ >>>> >>>> opennms-devel mailing list >>>> >>>> To *unsubscribe* or change your subscription options, see the >>>> bottom of >>>> this >>>> page: >>>> https://lists.sourceforge.net/lists/listinfo/opennms-devel >>>> >>> >>> --- >>> --- >>> --- >>> --- >>> ------------------------------------------------------------------ >>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 >>> 30-Day >>> trial. Simplify your report design, integration and deployment - and >>> focus on >>> what you do best, core application coding. Discover what's new with >>> Crystal Reports now. http://p.sf.net/sfu/bobj-july >>> _______________________________________________ >>> Please read the OpenNMS Mailing List FAQ: >>> http://www.opennms.org/index.php/Mailing_List_FAQ >>> >>> opennms-devel mailing list >>> >>> To *unsubscribe* or change your subscription options, see the >>> bottom of >>> this page: >>> https://lists.sourceforge.net/lists/listinfo/opennms-devel >> >> --- >> --- >> --- >> --------------------------------------------------------------------- >> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 >> 30-Day >> trial. Simplify your report design, integration and deployment - >> and focus >> on >> what you do best, core application coding. Discover what's new with >> Crystal Reports now. http://p.sf.net/sfu/bobj-july >> _______________________________________________ >> Please read the OpenNMS Mailing List FAQ: >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> opennms-devel mailing list >> >> To *unsubscribe* or change your subscription options, see the >> bottom of >> this page: >> https://lists.sourceforge.net/lists/listinfo/opennms-devel >> > > --- > --- > --- > --------------------------------------------------------------------- > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Please read the OpenNMS Mailing List FAQ: > http://www.opennms.org/index.php/Mailing_List_FAQ > > opennms-devel mailing list > > To *unsubscribe* or change your subscription options, see the bottom > of this page: > https://lists.sourceforge.net/lists/listinfo/opennms-devel ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel |
||||||||||||||||
| Free Embeddable Forum Powered by Nabble | Help |
