patch: irritating seek bug

2 messages Options
Embed this post
Permalink
Ed Musgrove-2

patch: irritating seek bug

Reply Threaded More More options
Print post
Permalink
This bug presents on Mac and Windows. It would appear that at some time
someone tried to fix this problem. Code was added in the OnKeyDown function;
this code appears to function properly for Linux. If this code is removed
completely the same functionality is exhibited by Windows. At this time I
need someone to test on the Mac to see if this patch helps or hinders.


+#ifdef __WXMAC__
+   // I have no way of telling what code will work on the Mac but the
following code does not
+   // Ed Musgrove
+   // 28 October 2009
+   return;
+#endif
+
+#ifdef __WXMSW__
+   // Windows seems to have this built-in and does not need the following
code
+   // Ed Musgrove
+   // 28 October 2009
+   return;
+#endif


--Ed


Index: KeyConfigPrefs.cpp
===================================================================
RCS file: /cvsroot/audacity/audacity-src/src/prefs/KeyConfigPrefs.cpp,v
retrieving revision 1.87
diff -u -r1.87 KeyConfigPrefs.cpp
--- KeyConfigPrefs.cpp 18 Oct 2009 08:04:18 -0000 1.87
+++ KeyConfigPrefs.cpp 29 Oct 2009 03:07:02 -0000
@@ -395,6 +395,25 @@
 
 void KeyConfigPrefs::OnKeyDown(wxListEvent & e)
 {
+   // the code in this function allows the user to seek to the next command which begins with the letter that is pressed
+  
+#ifdef __WXMAC__
+   // I have no way of telling what code will work on the Mac but the following code does not
+   // Ed Musgrove
+   // 28 October 2009
+   return;
+#endif
+
+#ifdef __WXMSW__
+   // Windows seems to have this built-in and does not need the following code
+   // Ed Musgrove
+   // 28 October 2009
+   return;
+#endif
+
+   // The following code seems to work well on at least some versions of Linux
+   // Ed Musgrove
+   // 28 October 2009
    int keycode = e.GetKeyCode();
    int selected = mList->GetNextItem(-1, wxLIST_NEXT_ALL,  wxLIST_STATE_SELECTED);
    int cnt = mList->GetItemCount();                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Al Dimond

Re: patch: irritating seek bug

Reply Threaded More More options
Print post
Permalink
On Wednesday 28 October 2009 21:39:53 Ed Musgrove wrote:
> This bug presents on Mac and Windows. It would appear that at some
>  time someone tried to fix this problem. Code was added in the
>  OnKeyDown function; this code appears to function properly for
>  Linux. If this code is removed completely the same functionality
>  is exhibited by Windows. At this time I need someone to test on
>  the Mac to see if this patch helps or hinders.
>
>

On the Mac, without the patch when I press a letter key the control
scrolls down to the first command starting with that letter, but
doesn't change which element is actually selected.  With the patch
pressing letter keys does nothing.

> +#ifdef __WXMAC__
> +   // I have no way of telling what code will work on the Mac but
>  the following code does not
> +   // Ed Musgrove
> +   // 28 October 2009
> +   return;
> +#endif
> +
> +#ifdef __WXMSW__
> +   // Windows seems to have this built-in and does not need the
>  following code
> +   // Ed Musgrove
> +   // 28 October 2009
> +   return;
> +#endif
>
>
> --Ed
>

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel