[jira] Created: (CLK-535) Link control to be able to render both icon an text

Link control to be able to render both icon an text
---------------------------------------------------

                 Key: CLK-535
                 URL: https://issues.apache.org/jira/browse/CLK-535
             Project: Click
          Issue Type: Bug
          Components: core
            Reporter: Adrian A.


Link control should be able to render both the icon (if existing), and text too:
http://thread.gmane.org/gmane.comp.web.click.user/3017



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/CLK-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian A. updated CLK-535:
--------------------------

    Attachment: Link_renderBoth.diff

This patch (Link_renderBoth.diff) allows to render both icon and label for a link.

> Link control to be able to render both icon an text
> ---------------------------------------------------
>
>                 Key: CLK-535
>                 URL: https://issues.apache.org/jira/browse/CLK-535
>             Project: Click
>          Issue Type: Bug
>          Components: core
>            Reporter: Adrian A.
>         Attachments: Link_renderBoth.diff
>
>
> Link control should be able to render both the icon (if existing), and text too:
> http://thread.gmane.org/gmane.comp.web.click.user/3017

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/CLK-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian A. updated CLK-535:
--------------------------

    Attachment: LinkDemo_update.diff

This patch (LinkDemo_update.diff) improves the LinkDemo page with more link example usage (as well as the new possibility to render both icon and label for a link)

> Link control to be able to render both icon an text
> ---------------------------------------------------
>
>                 Key: CLK-535
>                 URL: https://issues.apache.org/jira/browse/CLK-535
>             Project: Click
>          Issue Type: Bug
>          Components: core
>            Reporter: Adrian A.
>         Attachments: Link_renderBoth.diff, LinkDemo_update.diff
>
>
> Link control should be able to render both the icon (if existing), and text too:
> http://thread.gmane.org/gmane.comp.web.click.user/3017

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/CLK-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian A. reassigned CLK-535:
-----------------------------

    Assignee: Adrian A.

> Link control to be able to render both icon an text
> ---------------------------------------------------
>
>                 Key: CLK-535
>                 URL: https://issues.apache.org/jira/browse/CLK-535
>             Project: Click
>          Issue Type: Bug
>          Components: core
>            Reporter: Adrian A.
>            Assignee: Adrian A.
>         Attachments: Link_renderBoth.diff, LinkDemo_update.diff
>
>
> Link control should be able to render both the icon (if existing), and text too:
> http://thread.gmane.org/gmane.comp.web.click.user/3017

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/CLK-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian A. resolved CLK-535.
---------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.0

Long standing patches were checked in.

> Link control to be able to render both icon an text
> ---------------------------------------------------
>
>                 Key: CLK-535
>                 URL: https://issues.apache.org/jira/browse/CLK-535
>             Project: Click
>          Issue Type: Bug
>          Components: core
>            Reporter: Adrian A.
>            Assignee: Adrian A.
>             Fix For: 2.1.0
>
>         Attachments: Link_renderBoth.diff, LinkDemo_update.diff
>
>
> Link control should be able to render both the icon (if existing), and text too:
> http://thread.gmane.org/gmane.comp.web.click.user/3017

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/CLK-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755801#action_12755801 ]

Bob Schellink commented on CLK-535:
-----------------------------------

Thanks for fixing this Adrian.

I don't think calling the property renderBoth is too user friendly though. How about renderLabelAndImage? We should also update the javadoc for setImageSrc and getImageSrc about the new option for rendering both text and images.

Its also worth updating the Changes & Roadmap html to communicate this fix to users.

> Link control to be able to render both icon an text
> ---------------------------------------------------
>
>                 Key: CLK-535
>                 URL: https://issues.apache.org/jira/browse/CLK-535
>             Project: Click
>          Issue Type: Bug
>          Components: core
>            Reporter: Adrian A.
>            Assignee: Adrian A.
>             Fix For: 2.1.0
>
>         Attachments: Link_renderBoth.diff, LinkDemo_update.diff
>
>
> Link control should be able to render both the icon (if existing), and text too:
> http://thread.gmane.org/gmane.comp.web.click.user/3017

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/CLK-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755958#action_12755958 ]

Adrian A. commented on CLK-535:
-------------------------------

> don't think calling the property renderBoth is too user friendly though. How about renderLabelAndImage?
Changed to 'renderLabelAndImage'.

> We should also update the javadoc for setImageSrc and getImageSrc about the new option for
> rendering both text and images.
Done.

> Its also worth updating the Changes & Roadmap html to communicate this fix to users.
Done.

> Link control to be able to render both icon an text
> ---------------------------------------------------
>
>                 Key: CLK-535
>                 URL: https://issues.apache.org/jira/browse/CLK-535
>             Project: Click
>          Issue Type: Bug
>          Components: core
>            Reporter: Adrian A.
>            Assignee: Adrian A.
>             Fix For: 2.1.0
>
>         Attachments: Link_renderBoth.diff, LinkDemo_update.diff
>
>
> Link control should be able to render both the icon (if existing), and text too:
> http://thread.gmane.org/gmane.comp.web.click.user/3017

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.