Audacity › audacity-devel

irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

28 messages

1 2

Ed Musgrove-2

irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

Recently Gale asked about this but I cannot find the original e-mail. I took
a quick look and I'm able to experience the problem.

------Quote------
Gale:
I've noted before there is a minor but nonetheless irritating bug in
Keyboard Preferences where seeking to the next command by hitting a keyboard
character jumps to the next but one item with that character, not the next
one.

Is this a Widgets problem or can you see a reason for this, Ed? :=) Gale

David:
Perhaps slightly larger than minor. If you're relying on the first character
to find an item and there are an even number of items beginning with that
character, you may never find it, David
------End Quote-------

It turns out to be pretty simple but a nightmare to figure out! If one
single-steps through the existing code the proper behavior is experienced.
Somewhere in the wxWidgets project is code which can only be viewed in
assembly. This code seems to be triggered before the KeyDown event is
declared processed. Somewhere in that code some timer trips and releases the
event unprocessed. Single-stepping through the disassembled code wastes
enough time to accomplish this.

Anyway, the long and short of it is that some base class to KeyConfigPrefs
is handling this event correctly but is not masked by OnKeyDown. Simply
commenting out ALL the code in KeyConfigPrefs::OnKeyDown() makes everything
work.

I'm am not going to admit how long it took me to figure this out!

--Ed

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

David Bailes-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

On Mon, Oct 12, 2009 at 8:43 AM, Ed Musgrove
<[hidden email]> wrote:

> Recently Gale asked about this but I cannot find the original e-mail. I took
> a quick look and I'm able to experience the problem.
>
>
> It turns out to be pretty simple but a nightmare to figure out! If one
> single-steps through the existing code the proper behavior is experienced.
> Somewhere in the wxWidgets project is code which can only be viewed in
> assembly. This code seems to be triggered before the KeyDown event is
> declared processed. Somewhere in that code some timer trips and releases the
> event unprocessed. Single-stepping through the disassembled code wastes
> enough time to accomplish this.
>
> Anyway, the long and short of it is that some base class to KeyConfigPrefs
> is handling this event correctly but is not masked by OnKeyDown. Simply
> commenting out ALL the code in KeyConfigPrefs::OnKeyDown() makes everything
> work.
>
> I'm am not going to admit how long it took me to figure this out!

thanks for looking into this and coming up with a fix,
David.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Michael Chinen

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

On Mon, Oct 12, 2009 at 10:26 AM, David Bailes <[hidden email]> wrote:

> On Mon, Oct 12, 2009 at 8:43 AM, Ed Musgrove
> <[hidden email]> wrote:
>> Recently Gale asked about this but I cannot find the original e-mail. I took
>> a quick look and I'm able to experience the problem.
>>
>>
>> It turns out to be pretty simple but a nightmare to figure out! If one
>> single-steps through the existing code the proper behavior is experienced.
>> Somewhere in the wxWidgets project is code which can only be viewed in
>> assembly. This code seems to be triggered before the KeyDown event is
>> declared processed. Somewhere in that code some timer trips and releases the
>> event unprocessed. Single-stepping through the disassembled code wastes
>> enough time to accomplish this.
>>
>> Anyway, the long and short of it is that some base class to KeyConfigPrefs
>> is handling this event correctly but is not masked by OnKeyDown. Simply
>> commenting out ALL the code in KeyConfigPrefs::OnKeyDown() makes everything
>> work.

When I comment out the contents of the function, keyboard input seems
not to work at all for selecting commands on Mac. With it not
commented out it works sometimes, but others not. For example
pressing the key does select Import Audio, but only sometimes -
other times there is a completely different string with no 'i' in it
selected, or no reaction, and I need to press another key before
pressing works. This might be due to the fact the computer I'm
on right now is still building audacity with wxMac 2.8.9, and not the
current 2.8.10, where they might have implemented some kind of
keyEvent filter into the wx list object.

I'm building 2.8.10 and will report back, but it will take a several hours.

Michael

>>
>> I'm am not going to admit how long it took me to figure this out!
>
> thanks for looking into this and coming up with a fix,
> David.
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

Could I impose upon someone running Audacity under Linux to run the below
listed test and report the results please?

--Ed

> -----Original Message-----
> From: Michael Chinen [mailto:[hidden email]]
>
> When I comment out the contents of the function, keyboard input seems
> not to work at all for selecting commands on Mac. With it not commented
> out it works sometimes, but others not

[Ed:]
The test:

> > To experience the bug:
> > *Start Audacity, open Preferences editor, navigate to Keyboard *With
> > the Key Bindings panel open, click on the word "Command"
> > *Press the <s> key; note that the list item "Save Project As...",
> > when the item immediately preceding it "Save Project" should have
> > been selected *Now try pressing the key; note that the list item
> > "Import Labels..." is selected when the "Import Audio..." should
> > have been selected
> >
> > Try commenting out the code in the function as noted above. Run the
> > above test again. All should be well -- it is on Vista.

void KeyConfigPrefs::OnKeyDown(wxListEvent & e) in file:
audacity/src/prefs/KeyConfigPrefs.cpp
at line # 396 (in the current CVS head which I just checked out a moment ago
-- 13 October 2009), eliminates the problem for me.

You need to comment ALL the code in the function out (removing the function
requires a bit more work--editing the EVENT_TABLE etc.--which I do for the
real repair) this leaves an empty function stub:
Function
{
//every
//line
/* or
Do
It this
Way*/
}

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Michael Chinen

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

In reply to this post by Michael Chinen

On Tue, Oct 13, 2009 at 2:09 PM, Michael Chinen <[hidden email]> wrote:

> On Mon, Oct 12, 2009 at 10:26 AM, David Bailes <[hidden email]> wrote:
>> On Mon, Oct 12, 2009 at 8:43 AM, Ed Musgrove
>> <[hidden email]> wrote:
>>> Recently Gale asked about this but I cannot find the original e-mail. I took
>>> a quick look and I'm able to experience the problem.
>>>
>>>
>>> It turns out to be pretty simple but a nightmare to figure out! If one
>>> single-steps through the existing code the proper behavior is experienced.
>>> Somewhere in the wxWidgets project is code which can only be viewed in
>>> assembly. This code seems to be triggered before the KeyDown event is
>>> declared processed. Somewhere in that code some timer trips and releases the
>>> event unprocessed. Single-stepping through the disassembled code wastes
>>> enough time to accomplish this.
>>>
>>> Anyway, the long and short of it is that some base class to KeyConfigPrefs
>>> is handling this event correctly but is not masked by OnKeyDown. Simply
>>> commenting out ALL the code in KeyConfigPrefs::OnKeyDown() makes everything
>>> work.
> When I comment out the contents of the function, keyboard input seems
> not to work at all for selecting commands on Mac. With it not
> commented out it works sometimes, but others not. For example
> pressing the key does select Import Audio, but only sometimes -
> other times there is a completely different string with no 'i' in it
> selected, or no reaction, and I need to press another key before
> pressing works. This might be due to the fact the computer I'm
> on right now is still building audacity with wxMac 2.8.9, and not the
> current 2.8.10, where they might have implemented some kind of
> keyEvent filter into the wx list object.
>
> I'm building 2.8.10 and will report back, but it will take a several hours.

I just built with 2.8.10, and the results are the same. Commenting
out the contents of the function breaks the keyboard input after you
click command - the keyboard input has no effect on selecting
commands.

This might be a case for an #ifdef, but it should require more
investigation. I understand the code being commented has something to
do with filtering the commands based on input, but I don't understand
exactly how, or why removing it fixes the problem on just win/linux.
Ed, did you see #ifdefs for mac while you were stepping around the
debugger?

Michael

>
> Michael
>>>
>>> I'm am not going to admit how long it took me to figure this out!
>>
>> thanks for looking into this and coming up with a fix,
>> David.
>>
>> ------------------------------------------------------------------------------
>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart your
>> developing skills, take BlackBerry mobile applications to market and stay
>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>> http://p.sf.net/sfu/devconference
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>

Ed Musgrove-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

Hi Michael!

It was a few days ago and is very early in the morning (late at night) when I was stepping through the code with the debugger. I think I vaguely recollect seeing #ifdef directives related to Mac. I am still hoping to hear from someone on Linux with a report as to the behavior there.

In general (vaguely) the keyboard preferences panel inherits from multiple classes who also handle keyboard input. It's been a long time since I've done any serious programming and multiple inheritance was in its infancy then. As I recall, there is a way to interrupt this chain and keep parent classes from getting the key event.

--Ed

> -----Original Message-----
> From: Michael Chinen [mailto:[hidden email]]
>
> > I'm building 2.8.10 and will report back, but it will take a several hours.
> I just built with 2.8.10, and the results are the same. Commenting out the
> contents of the function breaks the keyboard input after you click command
> - the keyboard input has no effect on selecting commands.
>
> This might be a case for an #ifdef, but it should require more investigation. I
> understand the code being commented has something to do with filtering
> the commands based on input, but I don't understand exactly how, or why
> removing it fixes the problem on just win/linux.
> Ed, did you see #ifdefs for mac while you were stepping around the
> debugger?

Al Dimond

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

On Tuesday 13 October 2009 10:28:46 Ed Musgrove wrote:
> Hi Michael!
>
> It was a few days ago and is very early in the morning (late at night) when
> I was stepping through the code with the debugger. I think I vaguely
> recollect seeing #ifdef directives related to Mac. I am still hoping to
> hear from someone on Linux with a report as to the behavior there.
>

Linux seems to act like Mac (Ed contacted me off-list and I went into a little
more detail there): the prefs dialog works correctly before the change, and
keyboard input has no effect after it (I am using wxGTK 2.8.10 on Linux).

A few weeks ago I got Audacity for Windows building with the mingw32 cross
compiler and running in Wine (using wxMSW 2.8.10 -- it's quite easy, because
the wxWidgets team maintains mingw32 compatibility). That version exhibits
the bug, and Ed's fix fixes it.

- Al

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

In reply to this post by Ed Musgrove-2

This appears to have fallen off the radar. My quick fix appears to work on Microsoft XP and Vista; the problem does not appear to be there in Linux. I need to know what the behavior is on the Mac. Do we have an active Mac developer on the list? On a somewhat separate track, do we have a list of active beta testers (non-developers) who are comfortable with checking out the nightly build, following explicit steps to test program changes and reporting?

To experience the bug:
*Start Audacity, open Preferences editor, navigate to Keyboard.
*(On Windows) With the Key Bindings panel open, click on the word "Command" (a column heading -- this moves focus from the preferences pages list to the key binding column without selecting an item).
(On Linux) With the Key Bindings panel open, click on the word "New" ( this moves focus from the preferences pages list to the key binding column but selects an item).
(On Mac) I have no idea, try both of the above.
*Press the <s> key; note that (on Windows) the list item "Save Project As..." is selected (takes focus and is highlighted), when the item immediately preceding it "Save Project" should have been selected.
*Now try pressing the key; note that (on Windows) the list item "Import Labels..." is selected when the "Import Audio..." should have been selected.

Simply commenting out all the code in the function:
void KeyConfigPrefs::OnKeyDown(wxListEvent & e) in file:
audacity/src/prefs/KeyConfigPrefs.cpp
at line # 396 (in the current CVS head which I just checked out a moment ago), eliminates the problem for me.

Try commenting out the code in the function as noted above. Run the
above test again.

You need to comment ALL the code in the function out (removing the function requires a bit more work--editing the EVENT_TABLE etc.--which I do for the real repair) this leaves an empty function stub:
Function
{
//every
//line
/* or
Do
It this
Way*/
}

Thanks!

--Ed

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Bill Wharrie

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

On 17-Oct-09, at 6:02 PM, Ed Musgrove wrote:

> This appears to have fallen off the radar. My quick fix appears to
> work on Microsoft XP and Vista; the problem does not appear to be
> there in Linux. I need to know what the behavior is on the Mac. Do
> we have an active Mac developer on the list? On a somewhat separate
> track, do we have a list of active beta testers (non-developers) who
> are comfortable with checking out the nightly build, following
> explicit steps to test program changes and reporting?

I would be one of the latter. As long as a G5 running 10.5.8 is useful.

>
> To experience the bug:
> *Start Audacity, open Preferences editor, navigate to Keyboard.
> *(On Windows) With the Key Bindings panel open, click on the word
> "Command" (a column heading -- this moves focus from the preferences
> pages list to the key binding column without selecting an item).
> (On Linux) With the Key Bindings panel open, click on the word
> "New" ( this moves focus from the preferences pages list to the key
> binding column but selects an item).
> (On Mac) I have no idea, try both of the above.

With the 1.3.10 Oct 16 build ...

On Mac (in my case a Dual G5 2 GHz PPC): click on the word "New" - the
line with "New Command+N" is highlighted, and "Command+N" is in the
text box.

> *Press the <s> key; note that (on Windows) the list item "Save
> Project As..." is selected (takes focus and is highlighted), when
> the item immediately preceding it "Save Project" should have been
> selected.

Pressing the <s> key, nothing appears to happen, except that "New" is
deselected. The contents of the text box do not change.

Pressing the <j> key scrolls the list so that "Join" is visible at the
bottom of the list, but it is not selected. The contents of the text
box do not change.

> *Now try pressing the key; note that (on Windows) the list item
> "Import Labels..." is selected when the "Import Audio..." should
> have been selected.

Pressing the key scrolls the list again so that "Import Audio..."
is visible at the top of the list, but again nothing is selected. The
contents of the text box do not change.

How is this meant to work if the list is not sorted alphabetically in
the first place?

--Bill Wharrie

>
> Simply commenting out all the code in the function:
> void KeyConfigPrefs::OnKeyDown(wxListEvent & e) in file:
> audacity/src/prefs/KeyConfigPrefs.cpp
> at line # 396 (in the current CVS head which I just checked out a
> moment ago), eliminates the problem for me.
>
> Try commenting out the code in the function as noted above. Run the
> above test again.
>
>
> You need to comment ALL the code in the function out (removing the
> function requires a bit more work--editing the EVENT_TABLE etc.--
> which I do for the real repair) this leaves an empty function stub:
> Function
> {
> //every
> //line
> /* or
> Do
> It this
> Way*/
> }
>
> Thanks!
>
> --Ed
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart
> your
> developing skills, take BlackBerry mobile applications to market and
> stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

Hi Bill!

One thing I need to know, is the report that you give a "before" or "after"
situation? In fact, if possible I need to know what happens before you
comment out the function code and what happens after you comment out the
function code.

This is exactly the information I needed. Unfortunately it is not good news.
What we have is three different behaviors -- Windows, Mac and Linux all
behave differently. I think the design behavior is this:
*change the focus from the left-hand panel (chooses which preference page is
displayed) to the right-hand panel:
(Windows) click the column heading (Command) to change focus without
selecting an item or select an item.
(Linux) click an item (clicking the column heading doesn't seem to
do anything).
(Mac) your report did not make it clear if clicking the column
header brought focus to that panel.
*press a key which is the first letter of any of the commands (obviously,
don't use the first letter of the active command as the result might be
confusing).
The list of commands should scroll and the next command whose label begins
with the letter pressed in step two above should be displayed and selected
(have focus).

This has nothing to do with whether the list is sorted or not . Sorting is
not (currently) allowed on this command list .

The actual results are this (before the function code is commented out):
On Windows, an item is selected, brought into focus and view, but it is one
item passed the proper item on the list (although it will have the same
first letter as the proper item).
On Linux, the proper item is selected brought into focus and scrolled into
view (this is the behavior that window users expect).
On Mac, whatever is happening is as yet unclear.

After the function code is commented out, Windows performs properly and
Linux performs like your report for the Mac. If the Mac code (before
commenting it out) works the way the Linux code does (before commenting out)
I can simply surround the code with #ifdef Windows.

--Ed

> -----Original Message-----
> From: Bill Wharrie [mailto:[hidden email]]
> Sent: Saturday, October 17, 2009 4:13 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] irritating bug in Keyboard Preferences when
> seeking to the next command by hitting a keyboard character
>
>
> On 17-Oct-09, at 6:02 PM, Ed Musgrove wrote:
>
> > This appears to have fallen off the radar. My quick fix appears to
> > work on Microsoft XP and Vista; the problem does not appear to be
> > there in Linux. I need to know what the behavior is on the Mac. Do we
> > have an active Mac developer on the list? On a somewhat separate
> > track, do we have a list of active beta testers (non-developers) who
> > are comfortable with checking out the nightly build, following
> > explicit steps to test program changes and reporting?
>
> I would be one of the latter. As long as a G5 running 10.5.8 is useful.
>
> >
> > To experience the bug:
> > *Start Audacity, open Preferences editor, navigate to Keyboard.
> > *(On Windows) With the Key Bindings panel open, click on the word
> > "Command" (a column heading -- this moves focus from the preferences
> > pages list to the key binding column without selecting an item).
> > (On Linux) With the Key Bindings panel open, click on the word "New"
> > ( this moves focus from the preferences pages list to the key binding
> > column but selects an item).
> > (On Mac) I have no idea, try both of the above.
>
> With the 1.3.10 Oct 16 build ...
>
> On Mac (in my case a Dual G5 2 GHz PPC): click on the word "New" - the
> line with "New Command+N" is highlighted, and "Command+N" is in the
> text box.
>
> > *Press the <s> key; note that (on Windows) the list item "Save Project
> > As..." is selected (takes focus and is highlighted), when the item
> > immediately preceding it "Save Project" should have been selected.
>
> Pressing the <s> key, nothing appears to happen, except that "New" is
> deselected. The contents of the text box do not change.
>
> Pressing the <j> key scrolls the list so that "Join" is visible at the

bottom of
> the list, but it is not selected. The contents of the text box do not
change.
>
> > *Now try pressing the key; note that (on Windows) the list item
> > "Import Labels..." is selected when the "Import Audio..." should
> > have been selected.
>
> Pressing the key scrolls the list again so that "Import Audio..."
> is visible at the top of the list, but again nothing is selected. The
contents of
> the text box do not change.
>
> How is this meant to work if the list is not sorted alphabetically in the
first

> place?
>
> --Bill Wharrie
>
> >
> > Simply commenting out all the code in the function:
> > void KeyConfigPrefs::OnKeyDown(wxListEvent & e) in file:
> > audacity/src/prefs/KeyConfigPrefs.cpp
> > at line # 396 (in the current CVS head which I just checked out a
> > moment ago), eliminates the problem for me.
> >
> > Try commenting out the code in the function as noted above. Run the
> > above test again.
> >
> >
> > You need to comment ALL the code in the function out (removing the
> > function requires a bit more work--editing the EVENT_TABLE etc.--
> > which I do for the real repair) this leaves an empty function stub:
> > Function
> > {
> > //every
> > //line
> > /* or
> > Do
> > It this
> > Way*/
> > }
> >
> > Thanks!
> >
> > --Ed
> >
> >
> >
> > ----------------------------------------------------------------------
> > -------- Come build with us! The BlackBerry(R) Developer Conference in
> > SF, CA is the only developer event you need to attend this year.
> > Jumpstart your developing skills, take BlackBerry mobile applications
> > to market and stay ahead of the curve. Join us from November 9 - 12,
> > 2009. Register now!
> > http://p.sf.net/sfu/devconference
> > _______________________________________________
> > audacity-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>

----------------------------------------------------------------------------
--
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Michael Chinen

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

Hi Ed,

I'm on a mac, and the report of the fix not working on mac I posted on
this thread should still be valid unless there is more new
directions/code on a different thread that I missed.

On Sun, Oct 18, 2009 at 1:55 AM, Ed Musgrove
<[hidden email]> wrote:
> Hi Bill!
>
> One thing I need to know, is the report that you give a "before" or "after"
> situation? In fact, if possible I need to know what happens before you
> comment out the function code and what happens after you comment out the
> function code.
The input not doing anything is what I get on mac after commenting out
the contents of the function.

>
> This is exactly the information I needed. Unfortunately it is not good news.
> What we have is three different behaviors -- Windows, Mac and Linux all
> behave differently.
Al said that the behavior was the same on linux as what I described
when I applied your directions on the mac - is there something more in
the off-list email that Al refers to?

> I think the design behavior is this:
> *change the focus from the left-hand panel (chooses which preference page is
> displayed) to the right-hand panel:
> (Windows) click the column heading (Command) to change focus without
> selecting an item or select an item.
> (Linux) click an item (clicking the column heading doesn't seem to
> do anything).
> (Mac) your report did not make it clear if clicking the column
> header brought focus to that panel.
> *press a key which is the first letter of any of the commands (obviously,
> don't use the first letter of the active command as the result might be
> confusing).
> The list of commands should scroll and the next command whose label begins
> with the letter pressed in step two above should be displayed and selected
> (have focus).
>
> This has nothing to do with whether the list is sorted or not . Sorting is
> not (currently) allowed on this command list .
>
> The actual results are this (before the function code is commented out):
> On Windows, an item is selected, brought into focus and view, but it is one
> item passed the proper item on the list (although it will have the same
> first letter as the proper item).
> On Linux, the proper item is selected brought into focus and scrolled into
> view (this is the behavior that window users expect).
> On Mac, whatever is happening is as yet unclear.
>
> After the function code is commented out, Windows performs properly and
> Linux performs like your report for the Mac. If the Mac code (before
> commenting it out) works the way the Linux code does (before commenting out)
> I can simply surround the code with #ifdef Windows.

This is a weird bug and I might ask wx-users about what they've done
to the list class in question and if they plan to add the key input
stuff to the mac/linux versions. If they do it will break again, and
we'll need to take out the ifdefs.

Michael

>
> --Ed
>
>
>> -----Original Message-----
>> From: Bill Wharrie [mailto:[hidden email]]
>> Sent: Saturday, October 17, 2009 4:13 PM
>> To: [hidden email]
>> Subject: Re: [Audacity-devel] irritating bug in Keyboard Preferences when
>> seeking to the next command by hitting a keyboard character
>>
>>
>> On 17-Oct-09, at 6:02 PM, Ed Musgrove wrote:
>>
>> > This appears to have fallen off the radar. My quick fix appears to
>> > work on Microsoft XP and Vista; the problem does not appear to be
>> > there in Linux. I need to know what the behavior is on the Mac. Do we
>> > have an active Mac developer on the list? On a somewhat separate
>> > track, do we have a list of active beta testers (non-developers) who
>> > are comfortable with checking out the nightly build, following
>> > explicit steps to test program changes and reporting?
>>
>> I would be one of the latter. As long as a G5 running 10.5.8 is useful.
>>
>> >
>> > To experience the bug:
>> > *Start Audacity, open Preferences editor, navigate to Keyboard.
>> > *(On Windows) With the Key Bindings panel open, click on the word
>> > "Command" (a column heading -- this moves focus from the preferences
>> > pages list to the key binding column without selecting an item).
>> > (On Linux) With the Key Bindings panel open, click on the word "New"
>> > ( this moves focus from the preferences pages list to the key binding
>> > column but selects an item).
>> > (On Mac) I have no idea, try both of the above.
>>
>> With the 1.3.10 Oct 16 build ...
>>
>> On Mac (in my case a Dual G5 2 GHz PPC): click on the word "New" - the
>> line with "New Command+N" is highlighted, and "Command+N" is in the
>> text box.
>>
>> > *Press the <s> key; note that (on Windows) the list item "Save Project
>> > As..." is selected (takes focus and is highlighted), when the item
>> > immediately preceding it "Save Project" should have been selected.
>>
>> Pressing the <s> key, nothing appears to happen, except that "New" is
>> deselected. The contents of the text box do not change.
>>
>> Pressing the <j> key scrolls the list so that "Join" is visible at the
> bottom of
>> the list, but it is not selected. The contents of the text box do not
> change.
>>
>> > *Now try pressing the key; note that (on Windows) the list item
>> > "Import Labels..." is selected when the "Import Audio..." should
>> > have been selected.
>>
>> Pressing the key scrolls the list again so that "Import Audio..."
>> is visible at the top of the list, but again nothing is selected. The
> contents of
>> the text box do not change.
>>
>> How is this meant to work if the list is not sorted alphabetically in the
> first
>> place?
>>
>> --Bill Wharrie
>>
>> >
>> > Simply commenting out all the code in the function:
>> > void KeyConfigPrefs::OnKeyDown(wxListEvent & e) in file:
>> > audacity/src/prefs/KeyConfigPrefs.cpp
>> > at line # 396 (in the current CVS head which I just checked out a
>> > moment ago), eliminates the problem for me.
>> >
>> > Try commenting out the code in the function as noted above. Run the
>> > above test again.
>> >
>> >
>> > You need to comment ALL the code in the function out (removing the
>> > function requires a bit more work--editing the EVENT_TABLE etc.--
>> > which I do for the real repair) this leaves an empty function stub:
>> > Function
>> > {
>> > //every
>> > //line
>> > /* or
>> > Do
>> > It this
>> > Way*/
>> > }
>> >
>> > Thanks!
>> >
>> > --Ed
>> >
>> >
>> >
>> > ----------------------------------------------------------------------
>> > -------- Come build with us! The BlackBerry(R) Developer Conference in
>> > SF, CA is the only developer event you need to attend this year.
>> > Jumpstart your developing skills, take BlackBerry mobile applications
>> > to market and stay ahead of the curve. Join us from November 9 - 12,
>> > 2009. Register now!
>> > http://p.sf.net/sfu/devconference
>> > _______________________________________________
>> > audacity-devel mailing list
>> > [hidden email]
>> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>>
>>
> ----------------------------------------------------------------------------
> --
>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart your
>> developing skills, take BlackBerry mobile applications to market and stay
>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>> http://p.sf.net/sfu/devconference
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Bill Wharrie

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

In reply to this post by Ed Musgrove-2

On 17-Oct-09, at 7:55 PM, Ed Musgrove wrote:

> Hi Bill!
>
> One thing I need to know, is the report that you give a "before" or
> "after"
> situation? In fact, if possible I need to know what happens before you
> comment out the function code and what happens after you comment out
> the
> function code.

I am a non-developer. So I can't comment out the code and do a before
and after. So this was done with the latest nightly build available to
me at the time.

>
> This is exactly the information I needed. Unfortunately it is not
> good news.
> What we have is three different behaviors -- Windows, Mac and Linux
> all
> behave differently. I think the design behavior is this:
> *change the focus from the left-hand panel (chooses which preference
> page is
> displayed) to the right-hand panel:
> (Windows) click the column heading (Command) to change focus without
> selecting an item or select an item.
> (Linux) click an item (clicking the column heading doesn't seem to
> do anything).
> (Mac) your report did not make it clear if clicking the column
> header brought focus to that panel.

The Command column header /apparently/ already has focus on Mac.
Clicking on it reverses the sort of the command list. However the
scroll list itself is not highlighted before clicking on the Command
header, so instead of clicking on the Command header (thus reversing
the list), I chose to click on "New", which apparently gives focus to
the list (it is now highlighted in blue).

-- Bill

> *press a key which is the first letter of any of the commands
> (obviously,
> don't use the first letter of the active command as the result might
> be
> confusing).
> The list of commands should scroll and the next command whose label
> begins
> with the letter pressed in step two above should be displayed and
> selected
> (have focus).
>
> This has nothing to do with whether the list is sorted or not .
> Sorting is
> not (currently) allowed on this command list .
>
> The actual results are this (before the function code is commented
> out):
> On Windows, an item is selected, brought into focus and view, but it
> is one
> item passed the proper item on the list (although it will have the
> same
> first letter as the proper item).
> On Linux, the proper item is selected brought into focus and
> scrolled into
> view (this is the behavior that window users expect).
> On Mac, whatever is happening is as yet unclear.
>
> After the function code is commented out, Windows performs properly
> and
> Linux performs like your report for the Mac. If the Mac code (before
> commenting it out) works the way the Linux code does (before
> commenting out)
> I can simply surround the code with #ifdef Windows.
>
> --Ed
>
>
>> -----Original Message-----
>> From: Bill Wharrie [mailto:[hidden email]]
>> Sent: Saturday, October 17, 2009 4:13 PM
>> To: [hidden email]
>> Subject: Re: [Audacity-devel] irritating bug in Keyboard
>> Preferences when
>> seeking to the next command by hitting a keyboard character
>>
>>
>> On 17-Oct-09, at 6:02 PM, Ed Musgrove wrote:
>>
>>> This appears to have fallen off the radar. My quick fix appears to
>>> work on Microsoft XP and Vista; the problem does not appear to be
>>> there in Linux. I need to know what the behavior is on the Mac. Do
>>> we
>>> have an active Mac developer on the list? On a somewhat separate
>>> track, do we have a list of active beta testers (non-developers) who
>>> are comfortable with checking out the nightly build, following
>>> explicit steps to test program changes and reporting?
>>
>> I would be one of the latter. As long as a G5 running 10.5.8 is
>> useful.
>>
>>>
>>> To experience the bug:
>>> *Start Audacity, open Preferences editor, navigate to Keyboard.
>>> *(On Windows) With the Key Bindings panel open, click on the word
>>> "Command" (a column heading -- this moves focus from the preferences
>>> pages list to the key binding column without selecting an item).
>>> (On Linux) With the Key Bindings panel open, click on the word
>>> "New"
>>> ( this moves focus from the preferences pages list to the key
>>> binding
>>> column but selects an item).
>>> (On Mac) I have no idea, try both of the above.
>>
>> With the 1.3.10 Oct 16 build ...
>>
>> On Mac (in my case a Dual G5 2 GHz PPC): click on the word "New" -
>> the
>> line with "New Command+N" is highlighted, and "Command+N" is in the
>> text box.
>>
>>> *Press the <s> key; note that (on Windows) the list item "Save
>>> Project
>>> As..." is selected (takes focus and is highlighted), when the item
>>> immediately preceding it "Save Project" should have been selected.
>>
>> Pressing the <s> key, nothing appears to happen, except that "New" is
>> deselected. The contents of the text box do not change.
>>
>> Pressing the <j> key scrolls the list so that "Join" is visible at
>> the
> bottom of
>> the list, but it is not selected. The contents of the text box do
>> not
> change.
>>
>>> *Now try pressing the key; note that (on Windows) the list item
>>> "Import Labels..." is selected when the "Import Audio..." should
>>> have been selected.
>>
>> Pressing the key scrolls the list again so that "Import Audio..."
>> is visible at the top of the list, but again nothing is selected.
>> The
> contents of
>> the text box do not change.
>>
>> How is this meant to work if the list is not sorted alphabetically
>> in the
> first
>> place?
>>
>> --Bill Wharrie
>>
>>>
>>> Simply commenting out all the code in the function:
>>> void KeyConfigPrefs::OnKeyDown(wxListEvent & e) in file:
>>> audacity/src/prefs/KeyConfigPrefs.cpp
>>> at line # 396 (in the current CVS head which I just checked out a
>>> moment ago), eliminates the problem for me.
>>>
>>> Try commenting out the code in the function as noted above. Run the
>>> above test again.
>>>
>>>
>>> You need to comment ALL the code in the function out (removing the
>>> function requires a bit more work--editing the EVENT_TABLE etc.--
>>> which I do for the real repair) this leaves an empty function stub:
>>> Function
>>> {
>>> //every
>>> //line
>>> /* or
>>> Do
>>> It this
>>> Way*/
>>> }
>>>
>>> Thanks!
>>>
>>> --Ed
>>>
>>>
>>>
>>> ----------------------------------------------------------------------
>>> -------- Come build with us! The BlackBerry(R) Developer
>>> Conference in
>>> SF, CA is the only developer event you need to attend this year.
>>> Jumpstart your developing skills, take BlackBerry mobile
>>> applications
>>> to market and stay ahead of the curve. Join us from November 9 - 12,
>>> 2009. Register now!
>>> http://p.sf.net/sfu/devconference
>>> _______________________________________________
>>> audacity-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>>
>>
> ----------------------------------------------------------------------------
> --
>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart
>> your
>> developing skills, take BlackBerry mobile applications to market
>> and stay
>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>> http://p.sf.net/sfu/devconference
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart
> your
> developing skills, take BlackBerry mobile applications to market and
> stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

Bill Wharrie

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

In reply to this post by Ed Musgrove-2

On 17-Oct-09, at 7:55 PM, Ed Musgrove wrote:

> Hi Bill!
>
> One thing I need to know, is the report that you give a "before" or
> "after"
> situation? In fact, if possible I need to know what happens before you
> comment out the function code and what happens after you comment out
> the
> function code.
>
> This is exactly the information I needed. Unfortunately it is not
> good news.
> What we have is three different behaviors -- Windows, Mac and Linux
> all
> behave differently. I think the design behavior is this:
> *change the focus from the left-hand panel (chooses which preference
> page is
> displayed) to the right-hand panel:
> (Windows) click the column heading (Command) to change focus without
> selecting an item or select an item.
> (Linux) click an item (clicking the column heading doesn't seem to
> do anything).
> (Mac) your report did not make it clear if clicking the column
> header brought focus to that panel.
> *press a key which is the first letter of any of the commands
> (obviously,
> don't use the first letter of the active command as the result might
> be
> confusing).
> The list of commands should scroll and the next command whose label
> begins
> with the letter pressed in step two above should be displayed and
> selected
> (have focus).
>
> This has nothing to do with whether the list is sorted or not .
> Sorting is
> not (currently) allowed on this command list .

My comment about sorting the list had to do with a scenario like this.
Suppose I'm looking for one of the Split commands, or one of the
Select commands. So I type <s> and get Save Project. Not very useful.
Even if I know that the Select commands are in the Edit category sub-
list, typing <s> takes me to the Split commands. So (naive user that I
am), I think "What if I type fast? Can I type the first few letters of
the command? Other programs can do this." Nope. Typing <se> (with
"All" selected in the Category popup) just takes me to the Export
command. OK, what if I type <s>, wait for the new selection to be
made, type <s> again to see if it will take me to the *next* command
that starts with "s". Nope, just keeps going back to "Save Project".
If this list was sorted alphabetically, at least I could jump to the
start of the S's, and scroll from there.

So I am led to ask "Why bother?" As a user, why bother using this
feature if it won't take me even close to what I'm looking for (in
this case, the Select commands). As a developer, why bother spending
time on this when it is really of so little use to the end user?

-- Bill

PS: My apologies if I am way off base with these comments. I'm new
here, after all.

>
> The actual results are this (before the function code is commented
> out):
> On Windows, an item is selected, brought into focus and view, but it
> is one
> item passed the proper item on the list (although it will have the
> same
> first letter as the proper item).
> On Linux, the proper item is selected brought into focus and
> scrolled into
> view (this is the behavior that window users expect).
> On Mac, whatever is happening is as yet unclear.
>
> After the function code is commented out, Windows performs properly
> and
> Linux performs like your report for the Mac. If the Mac code (before
> commenting it out) works the way the Linux code does (before
> commenting out)
> I can simply surround the code with #ifdef Windows.
>
> --Ed
>
>
>> -----Original Message-----
>> From: Bill Wharrie [mailto:[hidden email]]
>> Sent: Saturday, October 17, 2009 4:13 PM
>> To: [hidden email]
>> Subject: Re: [Audacity-devel] irritating bug in Keyboard
>> Preferences when
>> seeking to the next command by hitting a keyboard character
>>
>>
>> On 17-Oct-09, at 6:02 PM, Ed Musgrove wrote:
>>
>>> This appears to have fallen off the radar. My quick fix appears to
>>> work on Microsoft XP and Vista; the problem does not appear to be
>>> there in Linux. I need to know what the behavior is on the Mac. Do
>>> we
>>> have an active Mac developer on the list? On a somewhat separate
>>> track, do we have a list of active beta testers (non-developers) who
>>> are comfortable with checking out the nightly build, following
>>> explicit steps to test program changes and reporting?
>>
>> I would be one of the latter. As long as a G5 running 10.5.8 is
>> useful.
>>
>>>
>>> To experience the bug:
>>> *Start Audacity, open Preferences editor, navigate to Keyboard.
>>> *(On Windows) With the Key Bindings panel open, click on the word
>>> "Command" (a column heading -- this moves focus from the preferences
>>> pages list to the key binding column without selecting an item).
>>> (On Linux) With the Key Bindings panel open, click on the word
>>> "New"
>>> ( this moves focus from the preferences pages list to the key
>>> binding
>>> column but selects an item).
>>> (On Mac) I have no idea, try both of the above.
>>
>> With the 1.3.10 Oct 16 build ...
>>
>> On Mac (in my case a Dual G5 2 GHz PPC): click on the word "New" -
>> the
>> line with "New Command+N" is highlighted, and "Command+N" is in the
>> text box.
>>
>>> *Press the <s> key; note that (on Windows) the list item "Save
>>> Project
>>> As..." is selected (takes focus and is highlighted), when the item
>>> immediately preceding it "Save Project" should have been selected.
>>
>> Pressing the <s> key, nothing appears to happen, except that "New" is
>> deselected. The contents of the text box do not change.
>>
>> Pressing the <j> key scrolls the list so that "Join" is visible at
>> the
> bottom of
>> the list, but it is not selected. The contents of the text box do
>> not
> change.
>>
>>> *Now try pressing the key; note that (on Windows) the list item
>>> "Import Labels..." is selected when the "Import Audio..." should
>>> have been selected.
>>
>> Pressing the key scrolls the list again so that "Import Audio..."
>> is visible at the top of the list, but again nothing is selected.
>> The
> contents of
>> the text box do not change.
>>
>> How is this meant to work if the list is not sorted alphabetically
>> in the
> first
>> place?
>>
>> --Bill Wharrie
>>
>>>
>>> Simply commenting out all the code in the function:
>>> void KeyConfigPrefs::OnKeyDown(wxListEvent & e) in file:
>>> audacity/src/prefs/KeyConfigPrefs.cpp
>>> at line # 396 (in the current CVS head which I just checked out a
>>> moment ago), eliminates the problem for me.
>>>
>>> Try commenting out the code in the function as noted above. Run the
>>> above test again.
>>>
>>>
>>> You need to comment ALL the code in the function out (removing the
>>> function requires a bit more work--editing the EVENT_TABLE etc.--
>>> which I do for the real repair) this leaves an empty function stub:
>>> Function
>>> {
>>> //every
>>> //line
>>> /* or
>>> Do
>>> It this
>>> Way*/
>>> }
>>>
>>> Thanks!
>>>
>>> --Ed
>>>
>>>
>>>
>>> ----------------------------------------------------------------------
>>> -------- Come build with us! The BlackBerry(R) Developer
>>> Conference in
>>> SF, CA is the only developer event you need to attend this year.
>>> Jumpstart your developing skills, take BlackBerry mobile
>>> applications
>>> to market and stay ahead of the curve. Join us from November 9 - 12,
>>> 2009. Register now!
>>> http://p.sf.net/sfu/devconference
>>> _______________________________________________
>>> audacity-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>>
>>
> ----------------------------------------------------------------------------
> --
>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart
>> your
>> developing skills, take BlackBerry mobile applications to market
>> and stay
>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>> http://p.sf.net/sfu/devconference
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart
> your
> developing skills, take BlackBerry mobile applications to market and
> stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

In reply to this post by Bill Wharrie

Hi Bill!

Your reports are especially helpful to me (I am completely Mac illiterate).
I need one more piece of information; start Audacity and open the preference
panel -- don't click in it. Look at the list on the left side -- it lists
the various preference panels (Devices, Playback, Recording...); the last
time you visited Audacity preferences the state was saved so Audacity's
preferences opens on the same panel you last visited and its title should be
highlighted on that list. Now, having only opened the panel and not clicked
on it anywhere, press the first letter of a panel that is not currently
visible--if Key Bindings is visible, press the letter q . What happens now?
On Windows (and from what I understand, Linux) the Quality pane should open.

--Ed

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Bill Wharrie

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

On 17-Oct-09, at 8:56 PM, Ed Musgrove wrote:

> Hi Bill!
>
> Your reports are especially helpful to me (I am completely Mac
> illiterate).
> I need one more piece of information; start Audacity and open the
> preference
> panel -- don't click in it. Look at the list on the left side -- it
> lists
> the various preference panels (Devices, Playback, Recording...); the
> last
> time you visited Audacity preferences the state was saved so
> Audacity's
> preferences opens on the same panel you last visited and its title
> should be
> highlighted on that list. Now, having only opened the panel and not
> clicked
> on it anywhere, press the first letter of a panel that is not
> currently
> visible--if Key Bindings is visible, press the letter q . What
> happens now?
> On Windows (and from what I understand, Linux) the Quality pane
> should open.

And that is exactly what happen on Mac.

Also, if I press <d> it goes to Devices and if I press <d> again it
goes to Directories, press <d> again it goes back to Devices. I can
also navigate the list with the arrow keys (up, down, left (goes up),
right (goes down)).

-- Bill

>
> --Ed
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart
> your
> developing skills, take BlackBerry mobile applications to market and
> stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

In reply to this post by Bill Wharrie

Hi Bill!

No apologies needed! This is perfect (well, ugly too). The behavior you're
experiencing is radically different from the behavior on Windows.
Continually pressing the <s> key cycles sequentially through all the items
which start with that letter (on Linux -- on Windows it skips every other
one). The Linux behavior seems to be the design behavior.

As for sorting the list, that is a feature that I will not look into until I
get this bug squashed! There are comments in the code that lead me to
believe that someone has already tried to accomplish this. BTW, I'm new here
too!

--Ed

> -----Original Message-----
>
> My comment about sorting the list had to do with a scenario like this.
> Suppose I'm looking for one of the Split commands, or one of the Select
> commands. So I type <s> and get Save Project. Not very useful.
> Even if I know that the Select commands are in the Edit category sub-
list,
> typing <s> takes me to the Split commands. So (naive user that I am), I
think
> "What if I type fast? Can I type the first few letters of the command?
Other
> programs can do this." Nope. Typing <se> (with "All" selected in the
Category
> popup) just takes me to the Export command. OK, what if I type <s>, wait
for
> the new selection to be made, type <s> again to see if it will take me to
the
> *next* command that starts with "s". Nope, just keeps going back to "Save
> Project".
> If this list was sorted alphabetically, at least I could jump to the start
of the
> S's, and scroll from there.
>
> So I am led to ask "Why bother?" As a user, why bother using this feature
if it
> won't take me even close to what I'm looking for (in this case, the Select
> commands). As a developer, why bother spending time on this when it is
> really of so little use to the end user?
>
> -- Bill
>
> PS: My apologies if I am way off base with these comments. I'm new here,
> after all.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

In reply to this post by Bill Wharrie

The behavior you describe below is exactly the design behavior for the list
on the right.

--Ed

> -----Original Message-----
> From: Bill Wharrie [mailto:[hidden email]]
>
> Also, if I press <d> it goes to Devices and if I press <d> again it goes
to
> Directories, press <d> again it goes back to Devices. I can also navigate
the list
> with the arrow keys (up, down, left (goes up), right (goes down)).

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Bill Wharrie

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

In reply to this post by Ed Musgrove-2

Ed:
I should clarify that I never see the "Save Project" command
highlighted. I am assuming that something is happening when I press
<j> and the list jumps so that the "Join" command is in view. If the
"Save Project" command was actually highlighted (and the shortcut
transferred to the text box), then perhaps repeatedly typing <s> would
work as I expected.

I just tried this. I selected "Save Compressed Copy of
Project" (last of the first group of S's) in the list and then typed
<s>. The list jumped so that "Split Cut" was in view at the bottom of
the list, but it was still not selected. So it appears this is *half*
working.

I also, just by accident, found out that it is possible click and
drag in the list and have multiple lines selected. The last line in
the selection is the one that appears in the text box.

Here's another behaviour. Click on "New" in the list. Type <s>.
Nothing appears to be selected. Press down-arrow. "New" is selected.
Type <s>. Nothing happens - "New" remains selected. Press <s> -
nothing happens. Press <j>. The list scrolls so that "Join" is in view
at the bottom of the list.

Anything else you'd like me to try?

-- Bill

On 17-Oct-09, at 9:10 PM, Ed Musgrove wrote:

> Hi Bill!
>
> No apologies needed! This is perfect (well, ugly too). The behavior
> you're
> experiencing is radically different from the behavior on Windows.
> Continually pressing the <s> key cycles sequentially through all the
> items
> which start with that letter (on Linux -- on Windows it skips every
> other
> one). The Linux behavior seems to be the design behavior.
>
> As for sorting the list, that is a feature that I will not look into
> until I
> get this bug squashed! There are comments in the code that lead me to
> believe that someone has already tried to accomplish this. BTW, I'm
> new here
> too!
>
>
> --Ed
>
>
>> -----Original Message-----
>>
>> My comment about sorting the list had to do with a scenario like
>> this.
>> Suppose I'm looking for one of the Split commands, or one of the
>> Select
>> commands. So I type <s> and get Save Project. Not very useful.
>> Even if I know that the Select commands are in the Edit category sub-
> list,
>> typing <s> takes me to the Split commands. So (naive user that I
>> am), I
> think
>> "What if I type fast? Can I type the first few letters of the
>> command?
> Other
>> programs can do this." Nope. Typing <se> (with "All" selected in the
> Category
>> popup) just takes me to the Export command. OK, what if I type <s>,
>> wait
> for
>> the new selection to be made, type <s> again to see if it will take
>> me to
> the
>> *next* command that starts with "s". Nope, just keeps going back to
>> "Save
>> Project".
>> If this list was sorted alphabetically, at least I could jump to
>> the start
> of the
>> S's, and scroll from there.
>>
>> So I am led to ask "Why bother?" As a user, why bother using this
>> feature
> if it
>> won't take me even close to what I'm looking for (in this case, the
>> Select
>> commands). As a developer, why bother spending time on this when it
>> is
>> really of so little use to the end user?
>>
>> -- Bill
>>
>> PS: My apologies if I am way off base with these comments. I'm new
>> here,
>> after all.
>
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart
> your
> developing skills, take BlackBerry mobile applications to market and
> stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

Bill, thanks for all the details. They are perfect reports from a beta
tester -- clear, detailed and make no assumptions. Unfortunately, I think
this is not something that can be easily overcome in Audacity; the
underlying wxWidgets project's code is not as platform independent as
Audacity requires in this respect.

--Ed

> -----Original Message-----
> From: Bill Wharrie [mailto:[hidden email]]
> Sent: Saturday, October 17, 2009 6:29 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] irritating bug in Keyboard Preferences when
> seeking to the next command by hitting a keyboard character
>
> Ed:
> I should clarify that I never see the "Save Project" command
highlighted. I
> am assuming that something is happening when I press <j> and the list
jumps
> so that the "Join" command is in view. If the "Save Project" command was
> actually highlighted (and the shortcut transferred to the text box), then
> perhaps repeatedly typing <s> would work as I expected.
>
> I just tried this. I selected "Save Compressed Copy of Project" (last
of the
> first group of S's) in the list and then typed <s>. The list jumped so
that "Split
> Cut" was in view at the bottom of the list, but it was still not selected.
So it
> appears this is *half* working.
>
> I also, just by accident, found out that it is possible click and drag
in the list
> and have multiple lines selected. The last line in the selection is the
one that
> appears in the text box.
>
> Here's another behaviour. Click on "New" in the list. Type <s>.
> Nothing appears to be selected. Press down-arrow. "New" is selected.
> Type <s>. Nothing happens - "New" remains selected. Press <s> - nothing
> happens. Press <j>. The list scrolls so that "Join" is in view at the
bottom of

> the list.
>
> Anything else you'd like me to try?
>
> -- Bill
>
> On 17-Oct-09, at 9:10 PM, Ed Musgrove wrote:
>
> > Hi Bill!
> >
> > No apologies needed! This is perfect (well, ugly too). The behavior
> > you're experiencing is radically different from the behavior on
> > Windows.
> > Continually pressing the <s> key cycles sequentially through all the
> > items which start with that letter (on Linux -- on Windows it skips
> > every other one). The Linux behavior seems to be the design behavior.
> >
> > As for sorting the list, that is a feature that I will not look into
> > until I get this bug squashed! There are comments in the code that
> > lead me to believe that someone has already tried to accomplish this.
> > BTW, I'm new here too!
> >
> >
> > --Ed
> >
> >
> >> -----Original Message-----
> >>
> >> My comment about sorting the list had to do with a scenario like
> >> this.
> >> Suppose I'm looking for one of the Split commands, or one of the
> >> Select commands. So I type <s> and get Save Project. Not very useful.
> >> Even if I know that the Select commands are in the Edit category sub-
> > list,
> >> typing <s> takes me to the Split commands. So (naive user that I am),
> >> I
> > think
> >> "What if I type fast? Can I type the first few letters of the
> >> command?
> > Other
> >> programs can do this." Nope. Typing <se> (with "All" selected in the
> > Category
> >> popup) just takes me to the Export command. OK, what if I type <s>,
> >> wait
> > for
> >> the new selection to be made, type <s> again to see if it will take
> >> me to
> > the
> >> *next* command that starts with "s". Nope, just keeps going back to
> >> "Save Project".
> >> If this list was sorted alphabetically, at least I could jump to the
> >> start
> > of the
> >> S's, and scroll from there.
> >>
> >> So I am led to ask "Why bother?" As a user, why bother using this
> >> feature
> > if it
> >> won't take me even close to what I'm looking for (in this case, the
> >> Select commands). As a developer, why bother spending time on this
> >> when it is really of so little use to the end user?
> >>
> >> -- Bill
> >>
> >> PS: My apologies if I am way off base with these comments. I'm new
> >> here, after all.
> >
> >
> >
> >
> > ----------------------------------------------------------------------
> > -------- Come build with us! The BlackBerry(R) Developer Conference in
> > SF, CA is the only developer event you need to attend this year.
> > Jumpstart your developing skills, take BlackBerry mobile applications
> > to market and stay ahead of the curve. Join us from November 9 - 12,
> > 2009. Register now!
> > http://p.sf.net/sfu/devconference
> > _______________________________________________
> > audacity-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>

Ed Musgrove-2

Re: irritating bug in Keyboard Preferences when seeking to the next command by hitting a keyboard character

Reply Threaded

In reply to this post by Michael Chinen

Hi Michael!

Given that it works fine on Linux and commenting out the code makes it work
fine on Windows we can do something vaguely like:
void KeyConfigPrefs::OnKeyDown(wxListEvent & e)
{
#ifdef __WXMSW__
return;
#endif
#ifdef __WXMAC__
//insert code which works on Mac
return;
#endif
//Leave in all the code that is currently working well on Linux...
}

From: Michael Chinen <mchinen@gm...> - 2009-10-18 00:05

>I'm on a mac, and the report of the fix not working on mac I posted on
>this thread should still be valid

Are you a programmer? If so, could you take a quick look at the code?

--Ed

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

1 2