gdal capi branch feedback

[Tim Sutton]

Hi Frank

I made a build of your capi branch under MSVC today. For the most part
it seems fine but I did manage crash it when testing the graticule
creator.

src/plugins/grid_make/graticulecreator.cpp

 264     myWriter.addFeature(myFeature);
 265     mError = myWriter.hasError();   <-- crash


The above line is a call to qgsvectorfilewriter (in src/core).


I didnt have a lot of time to test so it will be good to have others
to test too. I'll be putting my test build online later for others to
test with - Ill send a follow up email when its available. I also want
to try to get the unit tests running under win since I have some tests
that put qgsvectorfilewriter through its paces so we might get better
diagnostics than from via a plugin.

Regards






--
Tim Sutton
QGIS Project Steering Committee Member - Release  Manager
Visit http://qgis.org for a great open source GIS
openModeller Desktop Developer
Visit http://openModeller.sf.net for a great open source ecological
niche modelling tool
Home Page: http://tim.linfiniti.com
Skype: timlinux
Irc: timlinux on #qgis at freenode.net
_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.qgis.org/cgi-bin/mailman/listinfo/qgis-developer

[Frank Warmerdam]

Tim Sutton wrote:

> Hi Frank
>
> I made a build of your capi branch under MSVC today. For the most part
> it seems fine but I did manage crash it when testing the graticule
> creator.
>
> src/plugins/grid_make/graticulecreator.cpp
>
>  264     myWriter.addFeature(myFeature);
>  265     mError = myWriter.hasError();   <-- crash
>
>
> The above line is a call to qgsvectorfilewriter (in src/core).

Tim,

I have identified a bug I introduced in the writer during the C API work.
I have corrected it now in SVN.

Thanks!
--
---------------------------------------+--------------------------------------
I set the clouds in motion - turn up   | Frank Warmerdam, [hidden email]
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush    | President OSGeo, http://osgeo.org

_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.qgis.org/cgi-bin/mailman/listinfo/qgis-developer

[Tim Sutton]

Hi

8<----------- snip --------

>  I have identified a bug I introduced in the writer during the C API work.
>  I have corrected it now in SVN.
>

Great!. I've uploaded the msvc build to here:

http://qgis.org/uploadfiles/testbuilds/qgis-gdalcapi-r8183.zip

The build was made before your fix so anyone testing bear in mind that
vector file writer related crashes can probably be ignored. Ill try to
make a fresh build tomorrow. Anyone who has a bit of time to test the
win build please go ahead and do so.


Regards



--
Tim Sutton
QGIS Project Steering Committee Member - Release  Manager
Visit http://qgis.org for a great open source GIS
openModeller Desktop Developer
Visit http://openModeller.sf.net for a great open source ecological
niche modelling tool
Home Page: http://tim.linfiniti.com
Skype: timlinux
Irc: timlinux on #qgis at freenode.net
_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.qgis.org/cgi-bin/mailman/listinfo/qgis-developer