final Disapearing Window patch

7 messages Options
Embed this post
Permalink
Ed Musgrove-2

final Disapearing Window patch

Reply Threaded More More options
Print post
Permalink
OK, this has every feature I can think of to positively eliminate the case
of the mysterious disappearing window!

Foremost, the only difference between this and the last patch is that this
positively checks to insure that every time Audacity launches, the resulting
new window (whether a blank project or an old project)  will be on an
attached monitor in such a position that the titlebar is accessible to the
user. This resolves the potential -32000x-32000 location bug that could have
been created by using registry or older preference settings.

The next step will be to add project window location information into the
project file itself so that when you double-click a project file icon to
launch Audacity with that file open, the project will be in the same size
and location as when it was last closed. That is certainly a minor feature
request and can wait until post-2.0.

--Ed




------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

finalDisapearingWindow.patch (25K) Download Attachment
Gale (Audacity Team)

Re: final Disapearing Window patch

Reply Threaded More More options
Print post
Permalink

| From "Ed Musgrove" <[hidden email]>
| Wed, 21 Oct 2009 03:15:18 -0700
| Subject: [Audacity-devel] final Disapearing Window patch
> OK, this has every feature I can think of to positively eliminate the case
> of the mysterious disappearing window!
>
> Foremost, the only difference between this and the last patch is that this
> positively checks to insure that every time Audacity launches, the resulting
> new window (whether a blank project or an old project)  will be on an
> attached monitor in such a position that the titlebar is accessible to the
> user. This resolves the potential -32000x-32000 location bug that could have
> been created by using registry or older preference settings.

Thanks, Ed. I did a few tests, pretty good except for 800x600. For
those who can't build but who want to try it on Windows:
http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.10-alpha.zip

On 1024x768, I found no problem with jumping to top when the first
window isn't at the top already, or with windows getting less tall.
Remembering the last normalised position worked fine.

Generally I like the tiling scheme, but wondered if when there is space
to go to the top of the screen, should it be used to give a vertical offset
on alternate windows, such as here:
http://www.gaclrecords.org.uk/windows1024.PNG

The first window there was the one under the Bookmarks menu in
xplorer2. I don't know if that alternate offset is useful, or worth the
effort, but it seems a little odd to me that we stick aggressively to
the same horizontal line when there is space above.

Similarly, should we use any space to left of the starting window when
we can go no further to right?

Of course, the user may have other windows above and to left of where
I have space, but we already cover any windows which may be to right of
the original Audacity screen estate.

Switching to 800x600 resolution (without restarting the computer)
created problems. Audacity started off-screen, and then every new
window was at the same horizontal position with progressive loss of
height:
http://www.gaclrecords.org.uk/windows800_1.PNG

then eventually the GUI started disappearing also:  
http://www.gaclrecords.org.uk/windows800_2.PNG

Note I haven't checked "second monitor issues" at all.  

As a side comment there is an issue with small window sizes or
screen resolutions where the menus jump above the interface
and block other menus, instead of gracefully scrolling downwards:
http://www.gaclrecords.org.uk/menus800.PNG

Other than that, what progress did you make Ed with the problem
when you reach the limit for the number of windows that Audacity
can handle?  

 
> The next step will be to add project window location information into the
> project file itself so that when you double-click a project file icon to
> launch Audacity with that file open, the project will be in the same size
> and location as when it was last closed. That is certainly a minor feature
> request and can wait until post-2.0.

I'm still not sure this is useful or practical. What happens when you
close the project with files A, B, C open and launch Audacity by
opening A? Or launch it by opening A and D, where D was last closed
in its own Audacity window?



Gale


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Ed Musgrove-2

Re: final Disapearing Window patch

Reply Threaded More More options
Print post
Permalink
I just got home for the day. Earlier I had made some "improvements" to the
code. I was sending that to the list as you were sending your test results.
I think I have addressed at least one of your issues in the "fixFinal"
patch. Look down in the nested replies for other comments...

> -----Original Message-----
> From: Gale Andrews [mailto:[hidden email]]
> Sent: Wednesday, October 21, 2009 8:18 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] final Disapearing Window patch
>
>
> | From "Ed Musgrove" <[hidden email]> Wed, 21 Oct 2009
> | 03:15:18 -0700
> | Subject: [Audacity-devel] final Disapearing Window patch
> > OK, this has every feature I can think of to positively eliminate the
> > case of the mysterious disappearing window!
> >
> > Foremost, the only difference between this and the last patch is that
> > this positively checks to insure that every time Audacity launches,
> > the resulting new window (whether a blank project or an old project)
> > will be on an attached monitor in such a position that the titlebar is
> > accessible to the user. This resolves the potential -32000x-32000
> > location bug that could have been created by using registry or older
> preference settings.
>
> Thanks, Ed. I did a few tests, pretty good except for 800x600. For those
who
> can't build but who want to try it on Windows:
> http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.10-alpha.zip

[Ed:]
My graphics card/monitor combo will not allow any resolution below
1680x1050. When I change to that resolution every icon on my desktop is
automatically relocated to a dense array in the top left corner of my
desktop. It takes quite a while to restore everything! I did it to test the
patch but will refrain from doing so again as the difference is so slight.


>
> On 1024x768, I found no problem with jumping to top when the first window
> isn't at the top already, or with windows getting less tall.
> Remembering the last normalised position worked fine.
>
> Generally I like the tiling scheme, but wondered if when there is space to
go
> to the top of the screen, should it be used to give a vertical offset on
> alternate windows, such as here:
> http://www.gaclrecords.org.uk/windows1024.PNG

[Ed:]
Could be done, but without a design committee to develop criteria at which I
may aim, I am spending a lot of time trying to hit a moving target <grin>.
Not that I am complaining, I am enjoying the challenge.

>
> The first window there was the one under the Bookmarks menu in xplorer2. I
> don't know if that alternate offset is useful, or worth the effort, but it
seems
> a little odd to me that we stick aggressively to the same horizontal line
when

> there is space above.
>
> Similarly, should we use any space to left of the starting window when we
> can go no further to right?
>
> Of course, the user may have other windows above and to left of where I
> have space, but we already cover any windows which may be to right of the
> original Audacity screen estate.
>
> Switching to 800x600 resolution (without restarting the computer) created
> problems. Audacity started off-screen, and then every new window was at
> the same horizontal position with progressive loss of
> height:
> http://www.gaclrecords.org.uk/windows800_1.PNG
>
> then eventually the GUI started disappearing also:
> http://www.gaclrecords.org.uk/windows800_2.PNG
>
[Ed:]
All of the above is addressed in the "fixFinal" patch

> Note I haven't checked "second monitor issues" at all.
>
[Ed:]
I only have two but exhaustively tested on those.

> As a side comment there is an issue with small window sizes or screen
> resolutions where the menus jump above the interface and block other
> menus, instead of gracefully scrolling downwards:
> http://www.gaclrecords.org.uk/menus800.PNG
>
[Ed:]
Known wxWidgets bug which was marked "patched" earlier this year.

> Other than that, what progress did you make Ed with the problem when you
> reach the limit for the number of windows that Audacity
> can handle?
>
>
> > The next step will be to add project window location information into
> > the project file itself so that when you double-click a project file
> > icon to launch Audacity with that file open, the project will be in
> > the same size and location as when it was last closed. That is
> > certainly a minor feature request and can wait until post-2.0.
>
> I'm still not sure this is useful or practical. What happens when you
close the
> project with files A, B, C open and launch Audacity by opening A? Or
launch it
> by opening A and D, where D was last closed in its own Audacity window?
>
[Ed:]
Each _project_ would maintain its own size and location. Each time one opens
a project (by any method) it would open at the same size and location as
when last closed; we are only talking about 4 integers (plus one more for
Maximize & Iconize if desired) to do this and 8 lines of code to read/write
it. My code is already able to do the rest. This is GUI 101--every major
commercial project I use (or have programmed for) which stored anything like
a project, had this minimum project memory. Most of the really biggies also
store much more state data--cursor location, scroll position etc.

>
>
> Gale
>
>
>
----------------------------------------------------------------------------
--
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

--Ed



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Ed Musgrove-2

Re: final Disapearing Window patch

Reply Threaded More More options
Print post
Permalink
In reply to this post by Gale (Audacity Team)
Since I am having a tough time getting anyone (other than you) on the list
to review my changes, would it be appropriate for me to post compiled
versions of my personal alphas on my web site and direct volunteer
beta-testers (even those who are not on the dev list) to them?

--Ed


> -----Original Message-----
> Thanks, Ed. I did a few tests, pretty good except for 800x600. For those
who
> can't build but who want to try it on Windows:
> http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.10-alpha.zip



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Ed Musgrove-2

Re: final Disapearing Window patch

Reply Threaded More More options
Print post
Permalink
In reply to this post by Ed Musgrove-2
I forgot about...

> -----Original Message-----
> >
> > Switching to 800x600 resolution (without restarting the computer)
created

> > problems. Audacity started off-screen, and then every new window was at
> > the same horizontal position with progressive loss of
> > height:
> > http://www.gaclrecords.org.uk/windows800_1.PNG
> >
> > then eventually the GUI started disappearing also:
> > http://www.gaclrecords.org.uk/windows800_2.PNG
> >
> [Ed:]
> All of the above is addressed in the "fixFinal" patch
[Ed:]

One of the problems with your 800x600 display is that your taskbar consumes
~60 pixels. The first project starts ~40 pixels from the screen top and is
~320 pixels tall. With 25 pixel steps you quickly run out of headroom. The
patch you tested shrank the height until the Audacity specified default
window size was reached 600x400 (plus a bit--OS dependent). I then used the
OS default to start back with. Now I use whatever your config value is.

--Ed



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Gale (Audacity Team)

Re: final Disapearing Window patch

Reply Threaded More More options
Print post
Permalink
In reply to this post by Ed Musgrove-2

| From "Ed Musgrove" <[hidden email]>
| Wed, 21 Oct 2009 21:03:35 -0700
| Subject: [Audacity-devel] final Disapearing Window patch
> Since I am having a tough time getting anyone (other than you) on the list
> to review my changes, would it be appropriate for me to post compiled
> versions of my personal alphas on my web site and direct volunteer
> beta-testers (even those who are not on the dev list) to them?

I'm already building on Windows, and I don't think you are on Mac,
which would be the only other useful binary.

I'll build from your "fixFinalDisapWindow.patch" in a few hours
time and post the link. Have you tested your patch on Linux?  

Generally, we're all very busy testing various patches and even
keeping up with reading all the e-mails, as you know. When
you think you have reached your final version, the patch should
ideally be reviewed by someone else for consistency/appropriateness
of code.




Gale


 

> > -----Original Message-----
> > Thanks, Ed. I did a few tests, pretty good except for 800x600. For those
> who
> > can't build but who want to try it on Windows:
> > http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.10-alpha.zip
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Ed Musgrove-2

Re: final Disapearing Window patch

Reply Threaded More More options
Print post
Permalink
> -----Original Message-----
> From: Gale Andrews [mailto:[hidden email]]
> Sent: Thursday, October 22, 2009 2:52 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] final Disapearing Window patch
>
>
> | From "Ed Musgrove" <[hidden email]> Wed, 21 Oct 2009
> | 21:03:35 -0700
> | Subject: [Audacity-devel] final Disapearing Window patch
> > Since I am having a tough time getting anyone (other than you) on the
> > list to review my changes, would it be appropriate for me to post
> > compiled versions of my personal alphas on my web site and direct
> > volunteer beta-testers (even those who are not on the dev list) to them?
>
> I'm already building on Windows, and I don't think you are on Mac, which
> would be the only other useful binary.
>
[Ed:]
I was thinking other Windows users, especially those with Vista, Windows 7
and multiple monitors.


> I'll build from your "fixFinalDisapWindow.patch" in a few hours
> time and post the link. Have you tested your patch on Linux?
>
[Ed:]
My guesses were playing catch up and by the time you read this you will have
read the results that Al gave me testing on Linux with two flavors of
Windows manager.


> Generally, we're all very busy testing various patches and even keeping up
> with reading all the e-mails, as you know. When you think you have reached
> your final version, the patch should ideally be reviewed by someone else
for
> consistency/appropriateness of code.
>
[Ed:]
I realize that everyone volunteers their time and skill; those with the
personality who volunteer and the skill to do this level of programming are
always busy! I also realize that everyone is pressing hard to meet a
deadline to release a stable version of Audacity.


>
> Gale
>
>
>
> > > -----Original Message-----
> > > Thanks, Ed. I did a few tests, pretty good except for 800x600. For
> > > those
> > who
> > > can't build but who want to try it on Windows:
> > > http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.10-alpha.zip
> >
> >
> >
> > ----------------------------------------------------------------------
> > -------- Come build with us! The BlackBerry(R) Developer Conference in
> > SF, CA is the only developer event you need to attend this year.
> > Jumpstart your developing skills, take BlackBerry mobile applications
> > to market and stay ahead of the curve. Join us from November 9 - 12,
> > 2009. Register now!
> > http://p.sf.net/sfu/devconference
> > _______________________________________________
> > audacity-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>
>
----------------------------------------------------------------------------
--
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA is
the
> only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

--Ed



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel