faster calc energy

2 messages Options
Embed this post
Permalink
Robert Hegemann

faster calc energy

Reply Threaded More More options
Print post
Permalink
>> faster calc_energy: don't loop if there is a single line within the band
 
How much difference in speed does this change make? Do you have
any profile logs showing the effect?
 
You know, it will make reading and understanding the code more difficult.
If there is almost no speed increase, then we shouldn't do such
optimizations.
 
If it has a huge effect and is worth the code change, we should consider a
similar optimization for the cases numlines[b] == 2 and 3 and 4 too.
 
 
 Ciao Robert


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Lame-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/lame-dev
Robert Hegemann

Re: faster calc energy

Reply Threaded More More options
Print post
Permalink
I did some profiling:

Am Montag, 19. Mai 2008 13:56 schrieb Robert Hegemann:
> >> faster calc_energy: don't loop if there is a single line within the band
>
> How much difference in speed does this change make? Do you have
> any profile logs showing the effect?

before the change, calc_energy took 1.9 percent of L3psycho_anal_vbr
after the change, calc_energy takes 2.1 percent of L3psycho_anal_vbr

> You know, it will make reading and understanding the code more difficult.
> If there is almost no speed increase, then we shouldn't do such
> optimizations.
>
> If it has a huge effect and is worth the code change, we should consider a
> similar optimization for the cases numlines[b] == 2 and 3 and 4 too.

Ciao Robert

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Lame-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/lame-dev