Audacity › audacity-devel

enable/disable Save menu--how?

26 messages

1 2

Ed Musgrove-2

enable/disable Save menu--how?

Reply Threaded

I am trying examine an extremely trivial bug (or possibly a feature request
<grin>). I need to know how to enable the File/Save menu item for a project.

--Ed
PS if inquiring minds want to know this is what I'm working on (but
if/when I bring it to the list I will create a new subject:

Changes in project state (i.e. zoom level), though stored in the save file,
do not "un-gray"/enable the File/Save menu item.

This bug is at best a P5 -- more like a P9 (a real bug but it probably only
affects the reporter, the reporter is a developer, the fix is trivial and
has no apparent side effects <grin>).

Currently saved state data (of which I'm aware):

xmlFile.WriteAttr(wxT("sel0"), mViewInfo.sel0, 10);
xmlFile.WriteAttr(wxT("sel1"), mViewInfo.sel1, 10);
xmlFile.WriteAttr(wxT("vpos"), mViewInfo.vpos);
xmlFile.WriteAttr(wxT("h"), mViewInfo.h, 10);
xmlFile.WriteAttr(wxT("zoom"), mViewInfo.zoom, 10);
xmlFile.WriteAttr(wxT("rate"), mRate);

Proposed solution:

As a test case, add to all "On... Zoom" functions code which enables the
File/Save menu item.

\audacity\src\Menus.cpp(4063):void AudacityProject::OnZoomIn()
\audacity\src\Menus.cpp(4128):void AudacityProject::OnZoomOut()
\audacity\src\Menus.cpp(4143):void AudacityProject::OnZoomToggle()
\audacity\src\Menus.cpp(4163):void AudacityProject::OnZoomNormal()
\audacity\src\Menus.cpp(4169):void AudacityProject::OnZoomFit()
\audacity\src\Menus.cpp(4221):void AudacityProject::OnZoomFitV()
\audacity\src\Menus.cpp(4230):void AudacityProject::OnZoomSel()

Add something like this:
Project_menubar->Enable(wxID_SAVE,true);
before any return except the "do-nothing" returned (if it is there)

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Al Dimond

Re: enable/disable Save menu--how?

Reply Threaded

On Thursday 22 October 2009 12:56:55 Ed Musgrove wrote:
> I am trying examine an extremely trivial bug (or possibly a feature
> request <grin>). I need to know how to enable the File/Save menu
> item for a project.
>

I just found this yesterday, actually. Look in src/Menus.cpp near the
top and you'll see the menus being built with calls to
CommandManager::BeginMenu() and CommandManager::AddItem(). Some of
the calls have two parameters at the end: flags and masks, and they're
always the same. Others don't, and fall back to the flags/masks set in
the last CommandManager::SetDefaultFlags() call. File->Save's looks
like this:

c->AddItem(wxT("Save"), _("&Save Project"),
FN(OnSave), wxT("Ctrl+S"),
AudioIONotBusyFlag | UnsavedChangesFlag,
AudioIONotBusyFlag | UnsavedChangesFlag);

The flags are defined in an enum in src/AudacityApp.h and set in
AudacityProject::GetUpdateFlags() in src/Menus.cpp. Whether it's
better to change the meaning of UnsavedChangesFlag or start a new
flag... and whether it's a good idea to change when File->Save is
enabled... those questions should be answered by someone with more
experience.

- Al

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Vaughan Johnson

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Ed Musgrove-2

Not a bug. We used to save every little thing on the undo stack, but
decided a while ago (and against my vote) that certain actions would not
mark the project dirty. I'm pleased with it now, generally.

Your proposed solution ignores the actual means by which File > Save is
enabled. It's not directly from command handler methods.

- V

Ed Musgrove wrote:

> I am trying examine an extremely trivial bug (or possibly a feature request
> <grin>). I need to know how to enable the File/Save menu item for a project.
>
> --Ed
> PS if inquiring minds want to know this is what I'm working on (but
> if/when I bring it to the list I will create a new subject:
>
> Changes in project state (i.e. zoom level), though stored in the save file,
> do not "un-gray"/enable the File/Save menu item.
>
> This bug is at best a P5 -- more like a P9 (a real bug but it probably only
> affects the reporter, the reporter is a developer, the fix is trivial and
> has no apparent side effects <grin>).
>
> Currently saved state data (of which I'm aware):
>
> xmlFile.WriteAttr(wxT("sel0"), mViewInfo.sel0, 10);
> xmlFile.WriteAttr(wxT("sel1"), mViewInfo.sel1, 10);
> xmlFile.WriteAttr(wxT("vpos"), mViewInfo.vpos);
> xmlFile.WriteAttr(wxT("h"), mViewInfo.h, 10);
> xmlFile.WriteAttr(wxT("zoom"), mViewInfo.zoom, 10);
> xmlFile.WriteAttr(wxT("rate"), mRate);
>
> Proposed solution:
>
> As a test case, add to all "On... Zoom" functions code which enables the
> File/Save menu item.
>
> \audacity\src\Menus.cpp(4063):void AudacityProject::OnZoomIn()
> \audacity\src\Menus.cpp(4128):void AudacityProject::OnZoomOut()
> \audacity\src\Menus.cpp(4143):void AudacityProject::OnZoomToggle()
> \audacity\src\Menus.cpp(4163):void AudacityProject::OnZoomNormal()
> \audacity\src\Menus.cpp(4169):void AudacityProject::OnZoomFit()
> \audacity\src\Menus.cpp(4221):void AudacityProject::OnZoomFitV()
> \audacity\src\Menus.cpp(4230):void AudacityProject::OnZoomSel()
>
> Add something like this:
> Project_menubar->Enable(wxID_SAVE,true);
> before any return except the "do-nothing" returned (if it is there)
>
>
>

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Vaughan Johnson

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Al Dimond

Al Dimond wrote:

> On Thursday 22 October 2009 12:56:55 Ed Musgrove wrote:
>> I am trying examine an extremely trivial bug (or possibly a feature
>> request <grin>). I need to know how to enable the File/Save menu
>> item for a project.
>>
>
> I just found this yesterday, actually. Look in src/Menus.cpp near the
> top and you'll see the menus being built with calls to
> CommandManager::BeginMenu() and CommandManager::AddItem(). Some of
> the calls have two parameters at the end: flags and masks, and they're
> always the same. Others don't, and fall back to the flags/masks set in
> the last CommandManager::SetDefaultFlags() call. File->Save's looks
> like this:
>
> c->AddItem(wxT("Save"), _("&Save Project"),
> FN(OnSave), wxT("Ctrl+S"),
> AudioIONotBusyFlag | UnsavedChangesFlag,
> AudioIONotBusyFlag | UnsavedChangesFlag);
>
> The flags are defined in an enum in src/AudacityApp.h and set in
> AudacityProject::GetUpdateFlags() in src/Menus.cpp. Whether it's
> better to change the meaning of UnsavedChangesFlag or start a new
> flag... and whether it's a good idea to change when File->Save is
> enabled... those questions should be answered by someone with more
> experience.
>

Exactly! It's all in the code. And not all actions set
UnsavedChangesFlag (via pushing onto the history/undo stack), by choice.

- V

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Martyn Shaw-2

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Ed Musgrove-2

Hi Ed

I see what you are up to (I think); enabling save so that any change
to 'state' can be made, and using this as an example? Presumably that
will include moving the window? Not a bad thing but I think we should
debate if we want it in 2.0, given time constraints.

I'm not seeing many P2s left on
http://wiki.audacityteam.org/index.php?title=Release_Checklist and
wouldn't want to see anything delay 2.0 release.

TTFN
Martyn

Ed Musgrove wrote:

Ed Musgrove-2

Re: enable/disable Save menu--how?

Reply Threaded

> -----Original Message-----
> From: Martyn Shaw [mailto:[hidden email]]
> Sent: Thursday, October 22, 2009 4:12 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] enable/disable Save menu--how?
>
> Hi Ed
>
> I see what you are up to (I think); enabling save so that any change to
'state'
> can be made, and using this as an example? Presumably that will include
> moving the window? Not a bad thing but I think we should debate if we
> want it in 2.0, given time constraints.
>
[Ed:]
This is exactly what I am up to. I want the user to at least have the option
of saving the project after it has been resized or relocated. I only chose
the OnZoom function because it was already being written to the file but was
being ignored as far as the menu state is concerned.

> I'm not seeing many P2s left on
> http://wiki.audacityteam.org/index.php?title=Release_Checklist and
> wouldn't want to see anything delay 2.0 release.
>
[Ed:]
That's what I am seeing as well; as far as I can tell almost every P2 is
being discussed and actively investigated on this list. There are no P1
items on the list. I am not proposing (initially) that we make a change to
the zoom state activate the File/Save menu item, just that section of the
code that I am currently dealing with the project window size and location.
Although once I learned how to deal with it in general I am guessing it
would be trivial to extend it to the zoom state. I am also not proposing
that this is urgent enough to warrant consideration before the release of
2.0.

I am deriving great enjoyment from learning that Audacity code project. If
there is any way I can be of active help to the developers who are working
on the P2 bugs, I would do that happily instead of hacking away at these
trivial items.

> TTFN
> Martyn
>
> Ed Musgrove wrote:
> > I am trying examine an extremely trivial bug (or possibly a feature
> > request <grin>). I need to know how to enable the File/Save menu item
for

> a project.
> >
> > --Ed
> > PS if inquiring minds want to know this is what I'm working on (but
> > if/when I bring it to the list I will create a new subject:
> >
> > Changes in project state (i.e. zoom level), though stored in the save
> > file, do not "un-gray"/enable the File/Save menu item.
> >
> > This bug is at best a P5 -- more like a P9 (a real bug but it probably
> > only affects the reporter, the reporter is a developer, the fix is
> > trivial and has no apparent side effects <grin>).
> >
> > Currently saved state data (of which I'm aware):
> >
> > xmlFile.WriteAttr(wxT("sel0"), mViewInfo.sel0, 10);
> > xmlFile.WriteAttr(wxT("sel1"), mViewInfo.sel1, 10);
> > xmlFile.WriteAttr(wxT("vpos"), mViewInfo.vpos);
> > xmlFile.WriteAttr(wxT("h"), mViewInfo.h, 10);
> > xmlFile.WriteAttr(wxT("zoom"), mViewInfo.zoom, 10);
> > xmlFile.WriteAttr(wxT("rate"), mRate);
> >
> > Proposed solution:
> >
> > As a test case, add to all "On... Zoom" functions code which enables
> > the File/Save menu item.
> >
> > \audacity\src\Menus.cpp(4063):void AudacityProject::OnZoomIn()
> > \audacity\src\Menus.cpp(4128):void AudacityProject::OnZoomOut()
> > \audacity\src\Menus.cpp(4143):void AudacityProject::OnZoomToggle()
> > \audacity\src\Menus.cpp(4163):void AudacityProject::OnZoomNormal()
> > \audacity\src\Menus.cpp(4169):void AudacityProject::OnZoomFit()
> > \audacity\src\Menus.cpp(4221):void AudacityProject::OnZoomFitV()
> > \audacity\src\Menus.cpp(4230):void AudacityProject::OnZoomSel()
> >
> > Add something like this:
> > Project_menubar->Enable(wxID_SAVE,true);
> > before any return except the "do-nothing" returned (if it is there)
> >
> >
> >
> > ----------------------------------------------------------------------
> > -------- Come build with us! The BlackBerry(R) Developer Conference in
> > SF, CA is the only developer event you need to attend this year.
> > Jumpstart your developing skills, take BlackBerry mobile applications
> > to market and stay ahead of the curve. Join us from November 9 - 12,
> > 2009. Register now!
> > http://p.sf.net/sfu/devconference
> > _______________________________________________
> > audacity-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >
>
>

----------------------------------------------------------------------------
--
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA is
the
> only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

--Ed

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Vaughan Johnson

> -----Original Message-----
> From: Vaughan Johnson [mailto:[hidden email]]
> Sent: Thursday, October 22, 2009 3:42 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] enable/disable Save menu--how?
>
>
>
> Al Dimond wrote:
> > On Thursday 22 October 2009 12:56:55 Ed Musgrove wrote:
> >> I am trying examine an extremely trivial bug (or possibly a feature
> >> request <grin>). I need to know how to enable the File/Save menu
> >> item for a project.
> >>
> >
> > I just found this yesterday, actually. Look in src/Menus.cpp near the
> > top and you'll see the menus being built with calls to
> > CommandManager::BeginMenu() and CommandManager::AddItem().
> Some of
> > the calls have two parameters at the end: flags and masks, and they're
> > always the same. Others don't, and fall back to the flags/masks set
> > in the last CommandManager::SetDefaultFlags() call. File->Save's
> > looks like this:
> >
> > c->AddItem(wxT("Save"), _("&Save Project"),
> > FN(OnSave), wxT("Ctrl+S"),
> > AudioIONotBusyFlag | UnsavedChangesFlag,
> > AudioIONotBusyFlag | UnsavedChangesFlag);
> >
> > The flags are defined in an enum in src/AudacityApp.h and set in
> > AudacityProject::GetUpdateFlags() in src/Menus.cpp. Whether it's
> > better to change the meaning of UnsavedChangesFlag or start a new
> > flag... and whether it's a good idea to change when File->Save is
> > enabled... those questions should be answered by someone with more
> > experience.
> >
>
> Exactly! It's all in the code. And not all actions set
> UnsavedChangesFlag (via pushing onto the history/undo stack), by choice.
>

[Ed:]
Unfortunately, my coding skills are rusty at best and definitely out of
date. I only wanted to make a simple change to demonstrate my proposed
suggestion about storing project window location and size with the project.
I spent a couple of hours examining the Audacity code trying on my own to
learn how to do this; I understand flags and masks but I am getting lost in
the confluence of Audacity and wxWidgets. I was hoping that some kind soul
would take pity on me and give me enough information to create my
demonstration. In reality, I suppose, if I really want to learn I should go
ahead and pay the price -- spend the time to figure it out myself. Thanks
anyway.

> - V
>
>
----------------------------------------------------------------------------
--
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

--Ed

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Vaughan Johnson

> -----Original Message-----
> From: Vaughan Johnson [mailto:[hidden email]]
> Sent: Thursday, October 22, 2009 3:39 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] enable/disable Save menu--how?
>
> Not a bug. We used to save every little thing on the undo stack, but
decided
> a while ago (and against my vote) that certain actions would not mark the
> project dirty. I'm pleased with it now, generally.
>
> Your proposed solution ignores the actual means by which File > Save is
> enabled. It's not directly from command handler methods.
>
[Ed:]
I beg to differ, it's a bug if we save it in the project file and after the
value has been changed by the user the user can't save the project file.

I tried my solution and found out that it didn't work.

> - V
>
>
> Ed Musgrove wrote:
> > I am trying examine an extremely trivial bug (or possibly a feature
> > request <grin>). I need to know how to enable the File/Save menu item
for

Vaughan Johnson

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Martyn Shaw-2

Sorry, Martyn, but I disagree. As I explained, we decided explicitly not
to save all changes (before even you joined the project, venerable
colleague!), like moving windows, etc. I really don't think Save
enabling should be dependent on window position. To save position in the
project file is reasonable, but then they can get out of sync if you
moved the window after finishing anything that sets. Gale, do you think
users would find that a big bug? Overall, I consider the idea low priority.

- V

Martyn Shaw wrote:

> Hi Ed
>
> I see what you are up to (I think); enabling save so that any change
> to 'state' can be made, and using this as an example? Presumably that
> will include moving the window? Not a bad thing but I think we should
> debate if we want it in 2.0, given time constraints.
>
> I'm not seeing many P2s left on
> http://wiki.audacityteam.org/index.php?title=Release_Checklist and
> wouldn't want to see anything delay 2.0 release.
>
> TTFN
> Martyn
>
> Ed Musgrove wrote:
>> I am trying examine an extremely trivial bug (or possibly a feature request
>> <grin>). I need to know how to enable the File/Save menu item for a project.
>>
>> --Ed
>> PS if inquiring minds want to know this is what I'm working on (but
>> if/when I bring it to the list I will create a new subject:
>>
>> Changes in project state (i.e. zoom level), though stored in the save file,
>> do not "un-gray"/enable the File/Save menu item.
>>
>> This bug is at best a P5 -- more like a P9 (a real bug but it probably only
>> affects the reporter, the reporter is a developer, the fix is trivial and
>> has no apparent side effects <grin>).
>>
>> Currently saved state data (of which I'm aware):
>>
>> xmlFile.WriteAttr(wxT("sel0"), mViewInfo.sel0, 10);
>> xmlFile.WriteAttr(wxT("sel1"), mViewInfo.sel1, 10);
>> xmlFile.WriteAttr(wxT("vpos"), mViewInfo.vpos);
>> xmlFile.WriteAttr(wxT("h"), mViewInfo.h, 10);
>> xmlFile.WriteAttr(wxT("zoom"), mViewInfo.zoom, 10);
>> xmlFile.WriteAttr(wxT("rate"), mRate);
>>
>> Proposed solution:
>>
>> As a test case, add to all "On... Zoom" functions code which enables the
>> File/Save menu item.
>>
>> \audacity\src\Menus.cpp(4063):void AudacityProject::OnZoomIn()
>> \audacity\src\Menus.cpp(4128):void AudacityProject::OnZoomOut()
>> \audacity\src\Menus.cpp(4143):void AudacityProject::OnZoomToggle()
>> \audacity\src\Menus.cpp(4163):void AudacityProject::OnZoomNormal()
>> \audacity\src\Menus.cpp(4169):void AudacityProject::OnZoomFit()
>> \audacity\src\Menus.cpp(4221):void AudacityProject::OnZoomFitV()
>> \audacity\src\Menus.cpp(4230):void AudacityProject::OnZoomSel()
>>
>> Add something like this:
>> Project_menubar->Enable(wxID_SAVE,true);
>> before any return except the "do-nothing" returned (if it is there)
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart your
>> developing skills, take BlackBerry mobile applications to market and stay
>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>> http://p.sf.net/sfu/devconference
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Vaughan Johnson

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Ed Musgrove-2

Ed Musgrove wrote:
>> --...
>>
> In reality, I suppose, if I really want to learn I should go
> ahead and pay the price -- spend the time to figure it out myself. Thanks
> anyway.
>
>

Ed, I truly do appreciate your enthusiasm, but we're all very pressed
for time these days. So yes, it may take you time to get up to speed,
but we all did, mostly with very little hand-holding. We're willing to
help, but clearly, you hadn't put in the effort to understand the
mechanisms well enough to make a reasonable suggestion about the proper
way to do it (or first asked whether it was a good idea). It takes time
to read your wordy messages and figure out what you don't understand,
and when it's apparent you didn't put in the effort to understand what
you were suggesting, well that's frustrating to me.

To me, it would have been far better if you'd just asked why Save isn't
enabled (i.e., why the project isn't marked dirty) when you move a
window. Would have taken far less time to answer.

Thanks for trying to adapt to the constraints of working with an
all-volunteer development team doing this in our spare time.

- Vaughan

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Gale (Audacity Team)

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Ed Musgrove-2

| From "Ed Musgrove" <[hidden email]>
| Thu, 22 Oct 2009 22:25:31 -0700
| Subject: [Audacity-devel] enable/disable Save menu--how?

> > -----Original Message-----
> > From: Vaughan Johnson [mailto:[hidden email]]
> > Sent: Thursday, October 22, 2009 3:39 PM
> > To: [hidden email]
> > Subject: Re: [Audacity-devel] enable/disable Save menu--how?
> >
> > Not a bug. We used to save every little thing on the undo stack, but
> decided
> > a while ago (and against my vote) that certain actions would not mark the
> > project dirty. I'm pleased with it now, generally.
> >
> > Your proposed solution ignores the actual means by which File > Save is
> > enabled. It's not directly from command handler methods.
> >
> [Ed:]
> I beg to differ, it's a bug if we save it in the project file and after the
> value has been changed by the user the user can't save the project file.

Definitely an "enhancement" rather than a bug. It isn't something
"not working as intended".

Users would appreciate cursor position/track selection state/zoom
state etc. being available when they reopen the project, irrespective of
when they last changed those states. But they don't want Undo menu
and Undo History items for changing those states as the price for doing
that.

Gale

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Vaughan Johnson

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Vaughan Johnson

Ed, I just want to reiterate the appreciation part of this. Thanks for
wanting to help and spending so much time working on it.

I'm just expressing how I think you could be more effective in the
group. Sorry if it's too abrasive. Let me know.

- V

Vaughan Johnson wrote:

> Ed Musgrove wrote:
>>> --...
>>>
>> In reality, I suppose, if I really want to learn I should go
>> ahead and pay the price -- spend the time to figure it out myself. Thanks
>> anyway.
>>
>>
>
> Ed, I truly do appreciate your enthusiasm, but we're all very pressed
> for time these days. So yes, it may take you time to get up to speed,
> but we all did, mostly with very little hand-holding. We're willing to
> help, but clearly, you hadn't put in the effort to understand the
> mechanisms well enough to make a reasonable suggestion about the proper
> way to do it (or first asked whether it was a good idea). It takes time
> to read your wordy messages and figure out what you don't understand,
> and when it's apparent you didn't put in the effort to understand what
> you were suggesting, well that's frustrating to me.
>
> To me, it would have been far better if you'd just asked why Save isn't
> enabled (i.e., why the project isn't marked dirty) when you move a
> window. Would have taken far less time to answer.
>
> Thanks for trying to adapt to the constraints of working with an
> all-volunteer development team doing this in our spare time.
>
> - Vaughan
>
>

Ed Musgrove-2

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Vaughan Johnson

Understood.

--Ed

> -----Original Message-----
> From: Vaughan Johnson [mailto:[hidden email]]
> Sent: Friday, October 23, 2009 11:34 AM
> To: [hidden email]
> Subject: Re: [Audacity-devel] enable/disable Save menu--how?
>
> Ed Musgrove wrote:
> >> --...
> >>
> > In reality, I suppose, if I really want to learn I should go ahead
> > and pay the price -- spend the time to figure it out myself. Thanks
> > anyway.
> >
> >
>
> Ed, I truly do appreciate your enthusiasm, but we're all very pressed for

time
> these days. So yes, it may take you time to get up to speed, but we all
did,
> mostly with very little hand-holding. We're willing to help, but clearly,
you
> hadn't put in the effort to understand the mechanisms well enough to make
> a reasonable suggestion about the proper way to do it (or first asked
> whether it was a good idea). It takes time to read your wordy messages and
> figure out what you don't understand, and when it's apparent you didn't
put
> in the effort to understand what you were suggesting, well that's
frustrating
> to me.
>
> To me, it would have been far better if you'd just asked why Save isn't
> enabled (i.e., why the project isn't marked dirty) when you move a window.
> Would have taken far less time to answer.
>
> Thanks for trying to adapt to the constraints of working with an
all-volunteer
> development team doing this in our spare time.
>
> - Vaughan
>
>
>
----------------------------------------------------------------------------
--
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA is
the
> only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Gale (Audacity Team)

Defeat accepted.

--Ed

> -----Original Message-----
> From: Gale Andrews [mailto:[hidden email]]
> Sent: Friday, October 23, 2009 1:08 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] enable/disable Save menu--how?
>
>
> | From "Ed Musgrove" <[hidden email]> Thu, 22 Oct 2009
> | 22:25:31 -0700
> | Subject: [Audacity-devel] enable/disable Save menu--how?
> > > -----Original Message-----
> > > From: Vaughan Johnson [mailto:[hidden email]]
> > > Sent: Thursday, October 22, 2009 3:39 PM
> > > To: [hidden email]
> > > Subject: Re: [Audacity-devel] enable/disable Save menu--how?
> > >
> > > Not a bug. We used to save every little thing on the undo stack, but
> > decided
> > > a while ago (and against my vote) that certain actions would not
> > > mark the project dirty. I'm pleased with it now, generally.
> > >
> > > Your proposed solution ignores the actual means by which File > Save
> > > is enabled. It's not directly from command handler methods.
> > >
> > [Ed:]
> > I beg to differ, it's a bug if we save it in the project file and
> > after the value has been changed by the user the user can't save the
> project file.
>
> Definitely an "enhancement" rather than a bug. It isn't something "not
> working as intended".
>
> Users would appreciate cursor position/track selection state/zoom state

etc.
> being available when they reopen the project, irrespective of when they
last
> changed those states. But they don't want Undo menu and Undo History
> items for changing those states as the price for doing that.
>
>
>
> Gale
>
>
>
----------------------------------------------------------------------------
--
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA is
the
> only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Vaughan Johnson

I would not mind abrasive if I thought it were so. In fact I did not. I do
appreciate your replies even when we disagree. Being a "team member" implies
playing by team rules -- abiding by team decisions. I have no problem doing
so as long as the team is willing to consider my position and arguments.

--Ed

> -----Original Message-----
> From: Vaughan Johnson [mailto:[hidden email]]
> Sent: Friday, October 23, 2009 3:18 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] enable/disable Save menu--how?
>
> Ed, I just want to reiterate the appreciation part of this. Thanks for
wanting to

> help and spending so much time working on it.
>
> I'm just expressing how I think you could be more effective in the group.
> Sorry if it's too abrasive. Let me know.
>
> - V
>
>
> Vaughan Johnson wrote:
> > Ed Musgrove wrote:
> >>> --...
> >>>
> >> In reality, I suppose, if I really want to learn I should go ahead
> >> and pay the price -- spend the time to figure it out myself. Thanks
> >> anyway.
> >>
> >>
> >
> > Ed, I truly do appreciate your enthusiasm, but we're all very pressed
> > for time these days. So yes, it may take you time to get up to speed,
> > but we all did, mostly with very little hand-holding. We're willing to
> > help, but clearly, you hadn't put in the effort to understand the
> > mechanisms well enough to make a reasonable suggestion about the
> > proper way to do it (or first asked whether it was a good idea). It
> > takes time to read your wordy messages and figure out what you don't
> > understand, and when it's apparent you didn't put in the effort to
> > understand what you were suggesting, well that's frustrating to me.
> >
> > To me, it would have been far better if you'd just asked why Save
> > isn't enabled (i.e., why the project isn't marked dirty) when you move
> > a window. Would have taken far less time to answer.
> >
> > Thanks for trying to adapt to the constraints of working with an
> > all-volunteer development team doing this in our spare time.
> >
> > - Vaughan
> >
> >
>
>
>

----------------------------------------------------------------------------
--
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA is
the
> only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Gale (Audacity Team)

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Ed Musgrove-2

| From "Ed Musgrove" <[hidden email]>
| Fri, 23 Oct 2009 16:51:46 -0700
| Subject: [Audacity-devel] enable/disable Save menu--how?
> Defeat accepted.
>
> --Ed

How do the other programs you mentioned store this type of information?
Can it be done with some type of additional .cfg file created on exit e.g.
"when "blah.aup" is opened, set "h" to "0", "zoom" to "60.9591440811",
"selected track" to "4" etc?

I'm not saying it isn't wanted, because users do ask for it. But they
back off when I tell them that would currently require all such changes
to be in the Undo stack.

Gale

> > -----Original Message-----
> > From: Gale Andrews [mailto:[hidden email]]
> > Sent: Friday, October 23, 2009 1:08 PM
> > To: [hidden email]
> > Subject: Re: [Audacity-devel] enable/disable Save menu--how?
> >
> >
> > | From "Ed Musgrove" <[hidden email]> Thu, 22 Oct 2009
> > | 22:25:31 -0700
> > | Subject: [Audacity-devel] enable/disable Save menu--how?
> > > > -----Original Message-----
> > > > From: Vaughan Johnson [mailto:[hidden email]]
> > > > Sent: Thursday, October 22, 2009 3:39 PM
> > > > To: [hidden email]
> > > > Subject: Re: [Audacity-devel] enable/disable Save menu--how?
> > > >
> > > > Not a bug. We used to save every little thing on the undo stack, but
> > > decided
> > > > a while ago (and against my vote) that certain actions would not
> > > > mark the project dirty. I'm pleased with it now, generally.
> > > >
> > > > Your proposed solution ignores the actual means by which File > Save
> > > > is enabled. It's not directly from command handler methods.
> > > >
> > > [Ed:]
> > > I beg to differ, it's a bug if we save it in the project file and
> > > after the value has been changed by the user the user can't save the
> > project file.
> >
> > Definitely an "enhancement" rather than a bug. It isn't something "not
> > working as intended".
> >
> > Users would appreciate cursor position/track selection state/zoom state
> etc.
> > being available when they reopen the project, irrespective of when they
> last
> > changed those states. But they don't want Undo menu and Undo History
> > items for changing those states as the price for doing that.
> >
> >
> >
> > Gale
> >
> >
> >
> ----------------------------------------------------------------------------
> --
> > Come build with us! The BlackBerry(R) Developer Conference in SF, CA is
> the
> > only developer event you need to attend this year. Jumpstart your
> > developing skills, take BlackBerry mobile applications to market and stay
> > ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> > http://p.sf.net/sfu/devconference
> > _______________________________________________
> > audacity-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

Ed Musgrove-2

Re: enable/disable Save menu--how?

Reply Threaded

I am not sure if the below was on-list or off-list to Martyn...
----------------------begin paste--------------------
My understanding is that the saved project file is paired data: label/value
and is not position dependent. I cannot imagine how it could possibly
endanger compatibility. As for trying to complete this for a 2.0 release, my
only desire was to add project size and location information -- four
integers and to booleans. In dealing with the "Disappearing Windows" bug and
modifying the GUI for project windows this became a reasonable adjunct.

These functions currently exists in my patch:
AudacityProject::wxRect GetNormalizedWindowState() const { return
mNormalizedWindowState; }
void SetNormalizedWindowState(wxRect & pSizeAndLocation) {
mNormalizedWindowState = pSizeAndLocation; }

WxRect windowRectangle = project->GetNormalizedWindowState (); wxRect
defaultWindowRectangle = GetDefaultWindowRectangle ();
xmlFile.WriteAttr(wxT("windowX"), windowRectangle .GetX (),
defaultWindowRectangle .GetX ());
[... Etc.]
xmlFile.ReadAttr(wxT("windowX"), windowRectangle .SetX (),
defaultWindowRectangle .GetX ());
[... Etc.]
Project->SetNormalizedWindowState(SetNormalizedWindowState);
------------------end paste----------------------------

The [... Etc.] above means that the y, width, height, Maximized and
(potentially useful) Iconized values are also WriteAttr/ReadAttr (i.e. at
most 10 more lines of code) and it is all done. This would add 5 (or 6 with
iconize) lines to the project data file and would be ignored by any version
which did not want the data.

As for the other values (zoom, etc.) I cannot say and get the impression
that this whole topic of adding to the project data file is causing a bit of
tension. As for storing and retrieving the info it is trivial--simply write
it and read it; older version will ignore it, future versions may ignore it.
What can be done within the code as far as using those other values is a
mystery to me.

--Ed

> -----Original Message-----
> From: Gale Andrews [mailto:[hidden email]]
> Sent: Saturday, October 24, 2009 12:53 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] enable/disable Save menu--how?
>
>
> | From "Ed Musgrove" <[hidden email]> Fri, 23 Oct 2009
> | 16:51:46 -0700
> | Subject: [Audacity-devel] enable/disable Save menu--how?
> > Defeat accepted.
> >
> > --Ed
>
> How do the other programs you mentioned store this type of information?
> Can it be done with some type of additional .cfg file created on exit e.g.
> "when "blah.aup" is opened, set "h" to "0", "zoom" to "60.9591440811",
> "selected track" to "4" etc?
>
> I'm not saying it isn't wanted, because users do ask for it. But they back

off
> when I tell them that would currently require all such changes to be in
the

> Undo stack.
>
>
>
> Gale
>
>
>
> > > -----Original Message-----
> > > From: Gale Andrews [mailto:[hidden email]]
> > > Sent: Friday, October 23, 2009 1:08 PM
> > > To: [hidden email]
> > > Subject: Re: [Audacity-devel] enable/disable Save menu--how?
> > >
> > >
> > > | From "Ed Musgrove" <[hidden email]> Thu, 22 Oct
> 2009
> > > | 22:25:31 -0700
> > > | Subject: [Audacity-devel] enable/disable Save menu--how?
> > > > > -----Original Message-----
> > > > > From: Vaughan Johnson [mailto:[hidden email]]
> > > > > Sent: Thursday, October 22, 2009 3:39 PM
> > > > > To: [hidden email]
> > > > > Subject: Re: [Audacity-devel] enable/disable Save menu--how?
> > > > >
> > > > > Not a bug. We used to save every little thing on the undo stack,
> > > > > but
> > > > decided
> > > > > a while ago (and against my vote) that certain actions would not
> > > > > mark the project dirty. I'm pleased with it now, generally.
> > > > >
> > > > > Your proposed solution ignores the actual means by which File >
> > > > > Save is enabled. It's not directly from command handler methods.
> > > > >
> > > > [Ed:]
> > > > I beg to differ, it's a bug if we save it in the project file and
> > > > after the value has been changed by the user the user can't save
> > > > the
> > > project file.
> > >
> > > Definitely an "enhancement" rather than a bug. It isn't something
> > > "not working as intended".
> > >
> > > Users would appreciate cursor position/track selection state/zoom
> > > state
> > etc.
> > > being available when they reopen the project, irrespective of when
> > > they
> > last
> > > changed those states. But they don't want Undo menu and Undo History
> > > items for changing those states as the price for doing that.
> > >
> > >
> > >
> > > Gale
> > >
> > >
> > >
> > ----------------------------------------------------------------------
> > ------
> > --
> > > Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> > > is
> > the
> > > only developer event you need to attend this year. Jumpstart your
> > > developing skills, take BlackBerry mobile applications to market and
> > > stay ahead of the curve. Join us from November 9 - 12, 2009. Register
> now!
> > > http://p.sf.net/sfu/devconference
> > > _______________________________________________
> > > audacity-devel mailing list
> > > [hidden email]
> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >
> >
> >
> > ----------------------------------------------------------------------
> > -------- Come build with us! The BlackBerry(R) Developer Conference in
> > SF, CA is the only developer event you need to attend this year.
> > Jumpstart your developing skills, take BlackBerry mobile applications
> > to market and stay ahead of the curve. Join us from November 9 - 12,
> > 2009. Register now!
> > http://p.sf.net/sfu/devconference
> > _______________________________________________
> > audacity-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>
>

----------------------------------------------------------------------------
--
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA is
the
> only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Vaughan Johnson

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Ed Musgrove-2

Thanks, Ed!! Great perspective.

But if I do offend, do call me on it.

(Sorry for the delay. At the GSoC Mentor Summit, most of the time I was
reading email on the phone, and I couldn't send from my audacityteam.org
address from my phone, so couldn't post to the list.)

- V

Ed Musgrove wrote:

> I would not mind abrasive if I thought it were so. In fact I did not. I do
> appreciate your replies even when we disagree. Being a "team member" implies
> playing by team rules -- abiding by team decisions. I have no problem doing
> so as long as the team is willing to consider my position and arguments.
>
> --Ed
>
>
>> -----Original Message-----
>> From: Vaughan Johnson [mailto:[hidden email]]
>> Sent: Friday, October 23, 2009 3:18 PM
>> To: [hidden email]
>> Subject: Re: [Audacity-devel] enable/disable Save menu--how?
>>
>> Ed, I just want to reiterate the appreciation part of this. Thanks for
> wanting to
>> help and spending so much time working on it.
>>
>> I'm just expressing how I think you could be more effective in the group.
>> Sorry if it's too abrasive. Let me know.
>>
>> - V
>>
>>...

Ed Musgrove-2

Re: enable/disable Save menu--how?

Reply Threaded

<grin>

--Ed

> -----Original Message-----
> From: Vaughan Johnson [mailto:[hidden email]]
> Sent: Tuesday, October 27, 2009 3:28 PM
> To: [hidden email]
> Subject: Re: [Audacity-devel] enable/disable Save menu--how?
>
> Thanks, Ed!! Great perspective.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Martyn Shaw-2

Re: enable/disable Save menu--how?

Reply Threaded

In reply to this post by Vaughan Johnson

No problem, I see the arguments, having skimmed this thread. Clearly
low priority.

It would appear from this thread that enabling 'save' and an entry on
the history list are synonymous. Maybe that's what we need to address
for some cases, post release. A 'feature request' to enable 'save' if
state is changed (other than things that go on the history list).

TTFN
Martyn
(who has still got 142 unread emails in his inbox)

Vaughan Johnson wrote:

> Sorry, Martyn, but I disagree. As I explained, we decided explicitly not
> to save all changes (before even you joined the project, venerable
> colleague!), like moving windows, etc. I really don't think Save
> enabling should be dependent on window position. To save position in the
> project file is reasonable, but then they can get out of sync if you
> moved the window after finishing anything that sets. Gale, do you think
> users would find that a big bug? Overall, I consider the idea low priority.
>
> - V
>
>
> Martyn Shaw wrote:
>> Hi Ed
>>
>> I see what you are up to (I think); enabling save so that any change
>> to 'state' can be made, and using this as an example? Presumably that
>> will include moving the window? Not a bad thing but I think we should
>> debate if we want it in 2.0, given time constraints.
>>
>> I'm not seeing many P2s left on
>> http://wiki.audacityteam.org/index.php?title=Release_Checklist and
>> wouldn't want to see anything delay 2.0 release.
>>
>> TTFN
>> Martyn
>>
>> Ed Musgrove wrote:
>>> I am trying examine an extremely trivial bug (or possibly a feature
>>> request
>>> <grin>). I need to know how to enable the File/Save menu item for a
>>> project.
>>>
>>> --Ed
>>> PS if inquiring minds want to know this is what I'm working on (but
>>> if/when I bring it to the list I will create a new subject:
>>>
>>> Changes in project state (i.e. zoom level), though stored in the save
>>> file,
>>> do not "un-gray"/enable the File/Save menu item.
>>>
>>> This bug is at best a P5 -- more like a P9 (a real bug but it
>>> probably only
>>> affects the reporter, the reporter is a developer, the fix is trivial
>>> and
>>> has no apparent side effects <grin>).
>>>
>>> Currently saved state data (of which I'm aware):
>>>
>>> xmlFile.WriteAttr(wxT("sel0"), mViewInfo.sel0, 10);
>>> xmlFile.WriteAttr(wxT("sel1"), mViewInfo.sel1, 10);
>>> xmlFile.WriteAttr(wxT("vpos"), mViewInfo.vpos);
>>> xmlFile.WriteAttr(wxT("h"), mViewInfo.h, 10);
>>> xmlFile.WriteAttr(wxT("zoom"), mViewInfo.zoom, 10);
>>> xmlFile.WriteAttr(wxT("rate"), mRate);
>>>
>>> Proposed solution:
>>>
>>> As a test case, add to all "On... Zoom" functions code which enables the
>>> File/Save menu item.
>>>
>>> \audacity\src\Menus.cpp(4063):void AudacityProject::OnZoomIn()
>>> \audacity\src\Menus.cpp(4128):void AudacityProject::OnZoomOut()
>>> \audacity\src\Menus.cpp(4143):void AudacityProject::OnZoomToggle()
>>> \audacity\src\Menus.cpp(4163):void AudacityProject::OnZoomNormal()
>>> \audacity\src\Menus.cpp(4169):void AudacityProject::OnZoomFit()
>>> \audacity\src\Menus.cpp(4221):void AudacityProject::OnZoomFitV()
>>> \audacity\src\Menus.cpp(4230):void AudacityProject::OnZoomSel()
>>>
>>> Add something like this:
>>> Project_menubar->Enable(wxID_SAVE,true);
>>> before any return except the "do-nothing" returned (if it is there)
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>>
>>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>>> is the only developer event you need to attend this year. Jumpstart your
>>> developing skills, take BlackBerry mobile applications to market and
>>> stay ahead of the curve. Join us from November 9 - 12, 2009. Register
>>> now!
>>> http://p.sf.net/sfu/devconference
>>> _______________________________________________
>>> audacity-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>>
>> ------------------------------------------------------------------------------
>>
>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart your
>> developing skills, take BlackBerry mobile applications to market and
>> stay ahead of the curve. Join us from November 9 - 12, 2009. Register
>> now!
>> http://p.sf.net/sfu/devconference
>> _______________________________________________
>> audacity-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>
>

1 2