defaultMessageModifier does not work?

6 messages Options
Embed this post
Permalink
ddia

defaultMessageModifier does not work?

Reply Threaded More More options
Print post
Permalink
Hi everybody!
Great app you have here!
As you might guess I do have a question. I've tried playing around with the platform and currently I am trying to customize the logon message.
On logon I have to send the FIX fields 50 and 95. I've modified the message-modifiers.xml and added two entries into the headerFields as follows:
<bean id="defaultMessageModifier" class="org.marketcetera.quickfix.DefaultMessageModifier">
<property name="headerFields">
<map>
<entry key="50(A)" value="AIM00"/>
<entry key="95(A)" value="49"/>

Well, it does not work, I mean the logon messags is not modified.

Am I missing something?

Thanks,
Dan
ddia

Re: defaultMessageModifier does not work?

Reply Threaded More More options
Print post
Permalink
Hi again,

I've already took a look at http://www.nabble.com/Creating-custom-order-modifiers-and-custom-FIX-data-dictionary-tf4282711.html and I am not able to modify the logon message...

Any idea?

Thanks,
Dan
ddia wrote:
Hi everybody!
Great app you have here!
As you might guess I do have a question. I've tried playing around with the platform and currently I am trying to customize the logon message.
On logon I have to send the FIX fields 50 and 95. I've modified the message-modifiers.xml and added two entries into the headerFields as follows:
<bean id="defaultMessageModifier" class="org.marketcetera.quickfix.DefaultMessageModifier">
<property name="headerFields">
<map>
<entry key="50(A)" value="AIM00"/>
<entry key="95(A)" value="49"/>

Well, it does not work, I mean the logon messags is not modified.

Am I missing something?

Thanks,
Dan
toli

Re: defaultMessageModifier does not work?

Reply Threaded More More options
Print post
Permalink
Dan,

Looks like you found a bug. Sorry about that:
http://trac.marketcetera.org/trac.fcgi/ticket/442

The message modifiers are currently only applied to the outgoing
application messages (such as orders/cancels/replaces), and not to
Login messages.

I'll try to fix this bug in the next couple days.

Let me know if you are running the OMS from code, in which case i'll
give you directions on how to do it sooner.

thanks!

On 10/10/07, ddia <[hidden email]> wrote:

>
> Hi again,
>
> I've already took a look at
> http://www.nabble.com/Creating-custom-order-modifiers-and-custom-FIX-data-dictionary-tf4282711.html
> and I am not able to modify the logon message...
>
> Any idea?
>
> Thanks,
> Dan
>
> ddia wrote:
> >
> > Hi everybody!
> > Great app you have here!
> > As you might guess I do have a question. I've tried playing around with
> > the platform and currently I am trying to customize the logon message.
> > On logon I have to send the FIX fields 50 and 95. I've modified the
> > message-modifiers.xml and added two entries into the headerFields as
> > follows:
> > <bean id="defaultMessageModifier"
> > class="org.marketcetera.quickfix.DefaultMessageModifier">
> > <property name="headerFields">
> > <map>
> > <entry key="50(A)" value="AIM00"/>
> > <entry key="95(A)" value="49"/>
> >
> > Well, it does not work, I mean the logon messags is not modified.
> >
> > Am I missing something?
> >
> > Thanks,
> > Dan
> >
> >
>
> --
> View this message in context: http://www.nabble.com/defaultMessageModifier-does-not-work--tf4602448.html#a13141290
> Sent from the m-etc-users mailing list archive at Nabble.com.
>
> _______________________________________________
> m-etc-users mailing list
> [hidden email]
> http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
>


--
Toli Kuznets
http://www.marketcetera.com: Open-Source Trading Platform
download.run.trade.
_______________________________________________
m-etc-users mailing list
[hidden email]
http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
ddia

Re: defaultMessageModifier does not work?

Reply Threaded More More options
Print post
Permalink
Hi Toli,

Great to be of any help... I mean discovering the bug.
Once it is fixed, let me know and I will grab the latest sources and do a snapshot build.
Or you can let me know what file(s) where modified and I can grab only those ones.

Thanks,
Dan

toli wrote:
Dan,

Looks like you found a bug. Sorry about that:
http://trac.marketcetera.org/trac.fcgi/ticket/442

The message modifiers are currently only applied to the outgoing
application messages (such as orders/cancels/replaces), and not to
Login messages.

I'll try to fix this bug in the next couple days.

Let me know if you are running the OMS from code, in which case i'll
give you directions on how to do it sooner.

thanks!

On 10/10/07, ddia <ddia@hotmail.com> wrote:
>
> Hi again,
>
> I've already took a look at
> http://www.nabble.com/Creating-custom-order-modifiers-and-custom-FIX-data-dictionary-tf4282711.html
> and I am not able to modify the logon message...
>
> Any idea?
>
> Thanks,
> Dan
>
> ddia wrote:
> >
> > Hi everybody!
> > Great app you have here!
> > As you might guess I do have a question. I've tried playing around with
> > the platform and currently I am trying to customize the logon message.
> > On logon I have to send the FIX fields 50 and 95. I've modified the
> > message-modifiers.xml and added two entries into the headerFields as
> > follows:
> > <bean id="defaultMessageModifier"
> > class="org.marketcetera.quickfix.DefaultMessageModifier">
> > <property name="headerFields">
> > <map>
> > <entry key="50(A)" value="AIM00"/>
> > <entry key="95(A)" value="49"/>
> >
> > Well, it does not work, I mean the logon messags is not modified.
> >
> > Am I missing something?
> >
> > Thanks,
> > Dan
> >
> >
>
> --
> View this message in context: http://www.nabble.com/defaultMessageModifier-does-not-work--tf4602448.html#a13141290
> Sent from the m-etc-users mailing list archive at Nabble.com.
>
> _______________________________________________
> m-etc-users mailing list
> m-etc-users@lists.marketcetera.org
> http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
>


--
Toli Kuznets
http://www.marketcetera.com: Open-Source Trading Platform
download.run.trade.
_______________________________________________
m-etc-users mailing list
m-etc-users@lists.marketcetera.org
http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
toli

Re: defaultMessageModifier does not work?

Reply Threaded More More options
Print post
Permalink
Dan,

I fixed it in this changeset:
http://trac.marketcetera.org/trac.fcgi/changeset/1557

Read the bug or the changeset for details. I ended up slightly
modifying the oms-shared.xml file so you'll need to modify yours
accordingly - it now creates a MessageModifierManager class and passes
that in, instead of passing the list of modifiers into
OutgoingMessageHandler directly.

One note - in your example you had both fields in the header section.
That works for 50, but since field 95 is a message field you'll need
to have that in the appropriate section:


    <bean id="defaultMessageModifier"
class="org.marketcetera.quickfix.DefaultMessageModifier">
        <property name="headerFields">
            <map>
                <entry key="50(A)" value="AIM00"/>
            </map>
        </property>
        <property name="msgFields">
            <map>
                <entry key="95(A)" value="49"/>
            </map>
        </property>
        <property name="trailerFields">
            <map>
            </map>
        </property>
    </bean>

let me know if you have any questions or issues with this.

On 10/11/07, ddia <[hidden email]> wrote:

>
> Hi Toli,
>
> Great to be of any help... I mean discovering the bug.
> Once it is fixed, let me know and I will grab the latest sources and do a
> snapshot build.
> Or you can let me know what file(s) where modified and I can grab only those
> ones.
>
> Thanks,
> Dan
>
>
> toli wrote:
> >
> > Dan,
> >
> > Looks like you found a bug. Sorry about that:
> > http://trac.marketcetera.org/trac.fcgi/ticket/442
> >
> > The message modifiers are currently only applied to the outgoing
> > application messages (such as orders/cancels/replaces), and not to
> > Login messages.
> >
> > I'll try to fix this bug in the next couple days.
> >
> > Let me know if you are running the OMS from code, in which case i'll
> > give you directions on how to do it sooner.
> >
> > thanks!
> >
> > On 10/10/07, ddia <[hidden email]> wrote:
> >>
> >> Hi again,
> >>
> >> I've already took a look at
> >> http://www.nabble.com/Creating-custom-order-modifiers-and-custom-FIX-data-dictionary-tf4282711.html
> >> and I am not able to modify the logon message...
> >>
> >> Any idea?
> >>
> >> Thanks,
> >> Dan
> >>
> >> ddia wrote:
> >> >
> >> > Hi everybody!
> >> > Great app you have here!
> >> > As you might guess I do have a question. I've tried playing around with
> >> > the platform and currently I am trying to customize the logon message.
> >> > On logon I have to send the FIX fields 50 and 95. I've modified the
> >> > message-modifiers.xml and added two entries into the headerFields as
> >> > follows:
> >> > <bean id="defaultMessageModifier"
> >> > class="org.marketcetera.quickfix.DefaultMessageModifier">
> >> > <property name="headerFields">
> >> > <map>
> >> > <entry key="50(A)" value="AIM00"/>
> >> > <entry key="95(A)" value="49"/>
> >> >
> >> > Well, it does not work, I mean the logon messags is not modified.
> >> >
> >> > Am I missing something?
> >> >
> >> > Thanks,
> >> > Dan
> >> >
> >> >
> >>
> >> --
> >> View this message in context:
> >> http://www.nabble.com/defaultMessageModifier-does-not-work--tf4602448.html#a13141290
> >> Sent from the m-etc-users mailing list archive at Nabble.com.
> >>
> >> _______________________________________________
> >> m-etc-users mailing list
> >> [hidden email]
> >> http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
> >>
> >
> >
> > --
> > Toli Kuznets
> > http://www.marketcetera.com: Open-Source Trading Platform
> > download.run.trade.
> > _______________________________________________
> > m-etc-users mailing list
> > [hidden email]
> > http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
> >
> >
>
> --
> View this message in context: http://www.nabble.com/defaultMessageModifier-does-not-work--tf4602448.html#a13156186
> Sent from the m-etc-users mailing list archive at Nabble.com.
>
> _______________________________________________
> m-etc-users mailing list
> [hidden email]
> http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
>


--
Toli Kuznets
http://www.marketcetera.com: Open-Source Trading Platform
download.run.trade.
_______________________________________________
m-etc-users mailing list
[hidden email]
http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
ddia

Re: defaultMessageModifier does not work?

Reply Threaded More More options
Print post
Permalink
Hi Toli,

Great to hear back from you so quick.
I took the latest change set and run a quick test, looks like it is working.
Thanks a bunch.

I might have another question but let leave it for later.

Thanks,
Dan

toli wrote:
Dan,

I fixed it in this changeset:
http://trac.marketcetera.org/trac.fcgi/changeset/1557

Read the bug or the changeset for details. I ended up slightly
modifying the oms-shared.xml file so you'll need to modify yours
accordingly - it now creates a MessageModifierManager class and passes
that in, instead of passing the list of modifiers into
OutgoingMessageHandler directly.

One note - in your example you had both fields in the header section.
That works for 50, but since field 95 is a message field you'll need
to have that in the appropriate section:


    <bean id="defaultMessageModifier"
class="org.marketcetera.quickfix.DefaultMessageModifier">
        <property name="headerFields">
            <map>
                <entry key="50(A)" value="AIM00"/>
            </map>
        </property>
        <property name="msgFields">
            <map>
                <entry key="95(A)" value="49"/>
            </map>
        </property>
        <property name="trailerFields">
            <map>
            </map>
        </property>
    </bean>

let me know if you have any questions or issues with this.

On 10/11/07, ddia <ddia@hotmail.com> wrote:
>
> Hi Toli,
>
> Great to be of any help... I mean discovering the bug.
> Once it is fixed, let me know and I will grab the latest sources and do a
> snapshot build.
> Or you can let me know what file(s) where modified and I can grab only those
> ones.
>
> Thanks,
> Dan
>
>
> toli wrote:
> >
> > Dan,
> >
> > Looks like you found a bug. Sorry about that:
> > http://trac.marketcetera.org/trac.fcgi/ticket/442
> >
> > The message modifiers are currently only applied to the outgoing
> > application messages (such as orders/cancels/replaces), and not to
> > Login messages.
> >
> > I'll try to fix this bug in the next couple days.
> >
> > Let me know if you are running the OMS from code, in which case i'll
> > give you directions on how to do it sooner.
> >
> > thanks!
> >
> > On 10/10/07, ddia <ddia@hotmail.com> wrote:
> >>
> >> Hi again,
> >>
> >> I've already took a look at
> >> http://www.nabble.com/Creating-custom-order-modifiers-and-custom-FIX-data-dictionary-tf4282711.html
> >> and I am not able to modify the logon message...
> >>
> >> Any idea?
> >>
> >> Thanks,
> >> Dan
> >>
> >> ddia wrote:
> >> >
> >> > Hi everybody!
> >> > Great app you have here!
> >> > As you might guess I do have a question. I've tried playing around with
> >> > the platform and currently I am trying to customize the logon message.
> >> > On logon I have to send the FIX fields 50 and 95. I've modified the
> >> > message-modifiers.xml and added two entries into the headerFields as
> >> > follows:
> >> > <bean id="defaultMessageModifier"
> >> > class="org.marketcetera.quickfix.DefaultMessageModifier">
> >> > <property name="headerFields">
> >> > <map>
> >> > <entry key="50(A)" value="AIM00"/>
> >> > <entry key="95(A)" value="49"/>
> >> >
> >> > Well, it does not work, I mean the logon messags is not modified.
> >> >
> >> > Am I missing something?
> >> >
> >> > Thanks,
> >> > Dan
> >> >
> >> >
> >>
> >> --
> >> View this message in context:
> >> http://www.nabble.com/defaultMessageModifier-does-not-work--tf4602448.html#a13141290
> >> Sent from the m-etc-users mailing list archive at Nabble.com.
> >>
> >> _______________________________________________
> >> m-etc-users mailing list
> >> m-etc-users@lists.marketcetera.org
> >> http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
> >>
> >
> >
> > --
> > Toli Kuznets
> > http://www.marketcetera.com: Open-Source Trading Platform
> > download.run.trade.
> > _______________________________________________
> > m-etc-users mailing list
> > m-etc-users@lists.marketcetera.org
> > http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
> >
> >
>
> --
> View this message in context: http://www.nabble.com/defaultMessageModifier-does-not-work--tf4602448.html#a13156186
> Sent from the m-etc-users mailing list archive at Nabble.com.
>
> _______________________________________________
> m-etc-users mailing list
> m-etc-users@lists.marketcetera.org
> http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users
>


--
Toli Kuznets
http://www.marketcetera.com: Open-Source Trading Platform
download.run.trade.
_______________________________________________
m-etc-users mailing list
m-etc-users@lists.marketcetera.org
http://lists.marketcetera.org/cgi-bin/mailman/listinfo/m-etc-users