collective.plone3bugfixes

28 messages Options
Embed this post
Permalink
1 2
Martin Aspeli

collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
Andreas pointed this out on twitter:

   http://pypi.python.org/pypi/collective.plone3bugfixes/0.9

It's a bit sad to see people do this. It'd be good to get these into
Plone proper.

It'd also be nice if the people behind that product could fill in a
contributor agreement and just make the fixes in Plone svn. I understand
that it can be frustrating to wait for people to have time to action
your own bug reports, but *surely* it'd have been less work to fix this
in Plone than to release a product like this.

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Jon Stahl

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink


> -----Original Message-----
> From: Martin Aspeli [mailto:[hidden email]]
> Sent: Tuesday, June 30, 2009 7:27 AM
> To: [hidden email]
> Subject: [Plone-developers] collective.plone3bugfixes
>
> Andreas pointed this out on twitter:
>
>    http://pypi.python.org/pypi/collective.plone3bugfixes/0.9
>
> It's a bit sad to see people do this. It'd be good to get these into
> Plone proper.
>
> It'd also be nice if the people behind that product could fill in a
> contributor agreement and just make the fixes in Plone svn. I
> understand
> that it can be frustrating to wait for people to have time to action
> your own bug reports, but *surely* it'd have been less work to fix
this
> in Plone than to release a product like this.

I wonder if this doesn't also signify a missing process for handling
submitted patches from non-core devs in an efficient, trackable manner?


:jon

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
-----
Jon Stahl, Director of Web Solutions
ONE/Northwest - Online Networking for the Environment
http://www.onenw.org
Jim Nelson

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
Jon Stahl wrote:

>
>> -----Original Message-----
>> From: Martin Aspeli [mailto:[hidden email]]
>> Sent: Tuesday, June 30, 2009 7:27 AM
>> To: [hidden email]
>> Subject: [Plone-developers] collective.plone3bugfixes
>>
>> Andreas pointed this out on twitter:
>>
>>    http://pypi.python.org/pypi/collective.plone3bugfixes/0.9
>>
>> It's a bit sad to see people do this. It'd be good to get these into
>> Plone proper.
>>
>> It'd also be nice if the people behind that product could fill in a
>> contributor agreement and just make the fixes in Plone svn. I
>> understand
>> that it can be frustrating to wait for people to have time to action
>> your own bug reports, but *surely* it'd have been less work to fix
> this
>> in Plone than to release a product like this.
>
> I wonder if this doesn't also signify a missing process for handling
> submitted patches from non-core devs in an efficient, trackable manner?
>
>

+1

As someone who primarily does bug fixes, it's really, really hard to get the
attention of a core developer to push a one-line patch into Plone core.  There
are several QA'd and ready to apply patches from the last tune-up that haven't
been cleared yet - and that has been the problem for some time.

> :jon
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Plone-developers mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/plone-developers
>


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Hanno Schlichting-4

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
In reply to this post by Jon Stahl
On Tue, Jun 30, 2009 at 5:34 PM, Jon Stahl<[hidden email]> wrote:
> I wonder if this doesn't also signify a missing process for handling
> submitted patches from non-core devs in an efficient, trackable manner?

The process we have today is called Tune-Up days. From what I can tell
they work way better than what we had before them (essentially
nothing).

But given that we have over 600 open bug tickets targeted at Plone
3.x, I'd say we don't have enough contributers to the Tune-Up days
compared to the amount of input we are getting.

I don't know how to fix or approach this problem. Personally my
impression is that many developers today only fix bugs in Plone
itself, if they hit them in a customer site and are payed for fixing
them. The amount of purely love-based contributions we see have
decreased quite a bit over the last years.

The obvious and very hard and controversial approach to this, is to
introduce money into the process in some form as a motivating factor.
I don't think the Plone Foundation is anywhere near a position to make
that happen based on its current budget though. And it creates quite a
bit of a challenge and controversy about the process. My bug report
might be another ones "invalid - out of scope" or "wrong approach".
Judging what constitutes a real bug report and when it can be
considered to be fixed for real with a satisfactory quality level is
no simple task in itself.

Hanno

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Martin Aspeli

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
In reply to this post by Jon Stahl
Jon Stahl wrote:

>
>> -----Original Message-----
>> From: Martin Aspeli [mailto:[hidden email]]
>> Sent: Tuesday, June 30, 2009 7:27 AM
>> To: [hidden email]
>> Subject: [Plone-developers] collective.plone3bugfixes
>>
>> Andreas pointed this out on twitter:
>>
>>    http://pypi.python.org/pypi/collective.plone3bugfixes/0.9
>>
>> It's a bit sad to see people do this. It'd be good to get these into
>> Plone proper.
>>
>> It'd also be nice if the people behind that product could fill in a
>> contributor agreement and just make the fixes in Plone svn. I
>> understand
>> that it can be frustrating to wait for people to have time to action
>> your own bug reports, but *surely* it'd have been less work to fix
> this
>> in Plone than to release a product like this.
>
> I wonder if this doesn't also signify a missing process for handling
> submitted patches from non-core devs in an efficient, trackable manner?

Yes it does. :)

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Jon Stahl

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
In reply to this post by Hanno Schlichting-4


> -----Original Message-----
> From: Hanno Schlichting [mailto:[hidden email]]
> Sent: Tuesday, June 30, 2009 8:54 AM
> To: Jon Stahl
> Cc: Martin Aspeli; [hidden email]
> Subject: Re: [Plone-developers] collective.plone3bugfixes
>
> On Tue, Jun 30, 2009 at 5:34 PM, Jon Stahl<[hidden email]> wrote:
> > I wonder if this doesn't also signify a missing process for handling
> > submitted patches from non-core devs in an efficient, trackable
> manner?
>
> The process we have today is called Tune-Up days. From what I can tell
> they work way better than what we had before them (essentially
> nothing).
>
> But given that we have over 600 open bug tickets targeted at Plone
> 3.x, I'd say we don't have enough contributers to the Tune-Up days
> compared to the amount of input we are getting.

Hanno-

Just to clear, I'm not talking about fixing bugs (Tune-up Days rock, and we can always use more hands on deck), I'm talking about a missing process for reviewing and committing real *patches* from non-core devs.

In other projects, that seems to be an important step before becoming a core committer.

:jon

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
-----
Jon Stahl, Director of Web Solutions
ONE/Northwest - Online Networking for the Environment
http://www.onenw.org
Hanno Schlichting-4

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
On Tue, Jun 30, 2009 at 6:01 PM, Jon Stahl<[hidden email]> wrote:
> Just to clear, I'm not talking about fixing bugs (Tune-up Days rock, and we can always use more hands on deck), I'm talking about a missing process for reviewing and committing real *patches* from non-core devs.
>
> In other projects, that seems to be an important step before becoming a core committer.

Well, we don't have a separate "contribute patch" process at all and
never had. We always treated that as a form of bug+patch contribution.

One of the reasons other projects do special-case this, is to build up
some form of "merit" that is required to get contributer access in the
first place.

We on the other hand just rely on the hurdle of motivation (I want to
be a contributer) and process knowledge (how the hell does this work -
ah I need to sent a fax/letter to Toby with that signed document) to
restrict contributions to Plone itself. That process has so far served
us well, as far as I can tell. The number of times we had to revert
changes made by someone in any of the repositories is very low. The
success of the collective as the "default place" to put your code and
share is a huge success from my point of view.

So I wouldn't want to change this part of the process. This means that
we do lack a distinct "mentoring / feedback" mechanism for aspiring
contributers though and put that as an extra burden onto the Tune-Up
days.

Hanno

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Jon Stahl

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink


> -----Original Message-----
> From: Hanno Schlichting [mailto:[hidden email]]
> Sent: Tuesday, June 30, 2009 9:24 AM
> To: Jon Stahl
> Cc: Martin Aspeli; [hidden email]
> Subject: Re: [Plone-developers] collective.plone3bugfixes
>
> On Tue, Jun 30, 2009 at 6:01 PM, Jon Stahl<[hidden email]> wrote:
> > Just to clear, I'm not talking about fixing bugs (Tune-up Days rock,
> and we can always use more hands on deck), I'm talking about a missing
> process for reviewing and committing real *patches* from non-core devs.
> >
> > In other projects, that seems to be an important step before becoming
> a core committer.
>
> Well, we don't have a separate "contribute patch" process at all and
> never had. We always treated that as a form of bug+patch contribution.
>
> One of the reasons other projects do special-case this, is to build up
> some form of "merit" that is required to get contributer access in the
> first place.
>
> We on the other hand just rely on the hurdle of motivation (I want to
> be a contributer) and process knowledge (how the hell does this work -
> ah I need to sent a fax/letter to Toby with that signed document) to
> restrict contributions to Plone itself. That process has so far served
> us well, as far as I can tell. The number of times we had to revert
> changes made by someone in any of the repositories is very low. The
> success of the collective as the "default place" to put your code and
> share is a huge success from my point of view.
>
> So I wouldn't want to change this part of the process. This means that
> we do lack a distinct "mentoring / feedback" mechanism for aspiring
> contributers though and put that as an extra burden onto the Tune-Up
> days.

I agree: I like our "high trust/broad inclusion" process that makes it easy for people to gain core committer privs. (As opposed to many other opensource projects where only a few people actually make the checkins from a larger stream of submitted patches.)

I think what's happening is that as our community grows, we're not becoming more aggressive at encouraging people to sign the contributor form.   And because there is a little bit of a lag between signing the agreement and getting permission (due to the mails), that makes it hard for new people to jump in via Tune-Up Days.

So, I'm wondering if perhaps we don't need to do some combination of:

1) Work with the Tune-Up team to get people processed as committers more aggressively/rapidly.

2) Have a few core committers volunteer to checkin Tune-Up patches in a timely manner.

I'm definitely not arguing for wholesale change, but I think we are seeing evidence (see Jim's email above) that a few tweaks are in order.

:jon
------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
-----
Jon Stahl, Director of Web Solutions
ONE/Northwest - Online Networking for the Environment
http://www.onenw.org
Alec Mitchell

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
On Tue, Jun 30, 2009 at 9:58 AM, Jon Stahl<[hidden email]> wrote:

>
>
>> -----Original Message-----
>> From: Hanno Schlichting [mailto:[hidden email]]
>> Sent: Tuesday, June 30, 2009 9:24 AM
>> To: Jon Stahl
>> Cc: Martin Aspeli; [hidden email]
>> Subject: Re: [Plone-developers] collective.plone3bugfixes
>>
>> On Tue, Jun 30, 2009 at 6:01 PM, Jon Stahl<[hidden email]> wrote:
>> > Just to clear, I'm not talking about fixing bugs (Tune-up Days rock,
>> and we can always use more hands on deck), I'm talking about a missing
>> process for reviewing and committing real *patches* from non-core devs.
>> >
>> > In other projects, that seems to be an important step before becoming
>> a core committer.
>>
>> Well, we don't have a separate "contribute patch" process at all and
>> never had. We always treated that as a form of bug+patch contribution.
>>
>> One of the reasons other projects do special-case this, is to build up
>> some form of "merit" that is required to get contributer access in the
>> first place.
>>
>> We on the other hand just rely on the hurdle of motivation (I want to
>> be a contributer) and process knowledge (how the hell does this work -
>> ah I need to sent a fax/letter to Toby with that signed document) to
>> restrict contributions to Plone itself. That process has so far served
>> us well, as far as I can tell. The number of times we had to revert
>> changes made by someone in any of the repositories is very low. The
>> success of the collective as the "default place" to put your code and
>> share is a huge success from my point of view.
>>
>> So I wouldn't want to change this part of the process. This means that
>> we do lack a distinct "mentoring / feedback" mechanism for aspiring
>> contributers though and put that as an extra burden onto the Tune-Up
>> days.
>
> I agree: I like our "high trust/broad inclusion" process that makes it easy for people to gain core committer privs. (As opposed to many other opensource projects where only a few people actually make the checkins from a larger stream of submitted patches.)
>
> I think what's happening is that as our community grows, we're not becoming more aggressive at encouraging people to sign the contributor form.   And because there is a little bit of a lag between signing the agreement and getting permission (due to the mails), that makes it hard for new people to jump in via Tune-Up Days.
>
> So, I'm wondering if perhaps we don't need to do some combination of:
>
> 1) Work with the Tune-Up team to get people processed as committers more aggressively/rapidly.
>
> 2) Have a few core committers volunteer to checkin Tune-Up patches in a timely manner.
>
> I'm definitely not arguing for wholesale change, but I think we are seeing evidence (see Jim's email above) that a few tweaks are in order.

We also need to keep in mind that patches submitted in Trac only very
rarely also include tests (or even updates to fix tests that might be
broken by those patches).  So applying the fixes is often not a
trivial process.  When there's a complete patch with tests in Trac, I
can't imagine it's all that hard to get it applied/accepted.  Simply
having someone going through tickets and assigning those with quality
patches to appropriate people (or even the TuneUp team), would
probably have some major benefits.

Alec

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
AnthonyG

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
Alec Mitchell wrote:

>
> We also need to keep in mind that patches submitted in Trac only very
> rarely also include tests (or even updates to fix tests that might be
> broken by those patches).  So applying the fixes is often not a
> trivial process.  When there's a complete patch with tests in Trac, I
> can't imagine it's all that hard to get it applied/accepted.  Simply
> having someone going through tickets and assigning those with quality
> patches to appropriate people (or even the TuneUp team), would
> probably have some major benefits.
>
> Alec
>

As an experienced developer who's new to Plone I do feel we're missing a trick with getting quick wins committed.  e.g. I submitted a one character change (with tests) 7 weeks ago.  

https://dev.plone.org/plone/ticket/9122

I think reviewing this issue and committing shouldn't take more than a couple of minutes (I'll blush if there's something wrong with it now) and there may be many more examples in Trac just waiting for someone to do just that.

Why not have a new status in Trac something like "Patch submitted" that all logged in users can action to?  Committers can report on this status and review and if the patch isn't up to scratch the reviewer doesn't need to fix it: they just put it back to new with reasons and cc the person who submitted.  This has the benefit of providing potential future committers with some feedback.

Anthony

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Wichert Akkerman

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
On 6/30/09 10:32 PM, Anthony Gerrard wrote:

> Alec Mitchell wrote:
>> We also need to keep in mind that patches submitted in Trac only very
>> rarely also include tests (or even updates to fix tests that might be
>> broken by those patches).  So applying the fixes is often not a
>> trivial process.  When there's a complete patch with tests in Trac, I
>> can't imagine it's all that hard to get it applied/accepted.  Simply
>> having someone going through tickets and assigning those with quality
>> patches to appropriate people (or even the TuneUp team), would
>> probably have some major benefits.
>>
>> Alec
>>
>
> As an experienced developer who's new to Plone I do feel we're missing a trick with getting quick wins committed.  e.g. I submitted a one character change (with tests) 7 weeks ago.

I'm not sure if we have any process for managing tickets. I know that I
at least only look at tickets if they are explicitly assigned to me and
I get an email for them, and I suspect that holds for many others as well.


Wichert.

--
Wichert Akkerman <[hidden email]>   It is simple to make things.
http://www.wiggy.net/                  It is hard to make things simple.

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Hanno Schlichting-4

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
On Tue, Jun 30, 2009 at 10:58 PM, Wichert Akkerman<[hidden email]> wrote:
> I'm not sure if we have any process for managing tickets. I know that I
> at least only look at tickets if they are explicitly assigned to me and
> I get an email for them, and I suspect that holds for many others as well.

We don't really have a process anymore. Me and Alexander used to watch
the incoming tickets and provide some initial filtering and assign to
people / components that would fit. Neither of us has done that on a
regular basis anymore for a while, so essentially anything that goes
into the tracker is not looked at at all.

Only once Gabrielle tries to find tickets suitable for a Tune-Up day,
someone will actually look at tickets. I doubt she has the time to do
much to any classification or actual feedback at that point, though.

So if people currently rely on mails to get sent to them, that will
actually never happen.

I know that I'm personally not able to follow-up on all the tickets in
the tracker anymore and am a bit tired of the "squash-300-bugs" in a
weekend approach, I used to do once in a while. It's not a very
entertaining and certainly not sustainable approach.

So ideas on reorganizing the bug trackers are welcome as usual ;)

Hanno

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Tim Knapp

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
In reply to this post by Alec Mitchell
On Tue, 2009-06-30 at 10:18 -0700, Alec Mitchell wrote:

<snip />

>
> We also need to keep in mind that patches submitted in Trac only very
> rarely also include tests (or even updates to fix tests that might be
> broken by those patches).  So applying the fixes is often not a
> trivial process.  When there's a complete patch with tests in Trac, I
> can't imagine it's all that hard to get it applied/accepted.  Simply
> having someone going through tickets and assigning those with quality
> patches to appropriate people (or even the TuneUp team), would
> probably have some major benefits.

I can imagine that this could also be related to the issue at hand with
this pypi package as its related to CSS updates (according to the pypi
page) and this would involve someone actually applying the fixes to
their site and then manually testing it in all the supported browsers.
So a bit of a time sink in terms of wanting to commit these changes.

-Tim

>
> Alec
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Plone-developers mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/plone-developers


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Darryl Dixon - Winterhouse Consulting-2

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
In reply to this post by Martin Aspeli
> Andreas pointed this out on twitter:
>
>    http://pypi.python.org/pypi/collective.plone3bugfixes/0.9
>
> It's a bit sad to see people do this. It'd be good to get these into
> Plone proper.
>
> It'd also be nice if the people behind that product could fill in a
> contributor agreement and just make the fixes in Plone svn. I understand
> that it can be frustrating to wait for people to have time to action
> your own bug reports, but *surely* it'd have been less work to fix this
> in Plone than to release a product like this.

I'm going to stick my neck out here and opine that, in fact, sometimes it
just *is* easier to create a product like this. I understand completely
the frustrations that may have led the authors to create and release this
product.

I'd like to sketch out a few 'user' scenarios:
1) Total Plone neophyte, just knows how to install and use it; they find a
bug. They don't know what to do, so they leave it and hope that the next
Plone version fixes it. I bet a lot of people fall into this category

2) Almost Plone neophyte, has installed Plone, figured out how to google
when they run in to trouble, and, amazingly, are motivated enough to sign
up for an account and submit a semi-sensible ticket into the bug tracker.
They have no idea how to fix things, but are able to describe a problem
OK. I bet there are not all that many people in this category. I suspect
mainly people end up here when the pain factor of the bug is high enough
to turn type (1) people into type (2) people.

3) Plone tinkerer, integrator, customiser. This person hits a bug, pokes
around in the guts of Plone's core code, and maybe gets lucky and figures
out just enough to see what is wrong and hack up a fix that Works For
Them. 3a) If the Plone *community* is lucky, these people file a bug
report, include a snippet describing what *they* did to fix the problem
for themselves, and maybe even, if they're really savvy, attach a patch.
Possibly there's more people only in (3) than in (3a).

4) Experienced Plone developer, integrator, etc. These people probably
code in or with Plone and Zope for money, but they either lack the time,
resources, motivation, legal advice, or whatever to fill out the
contributor form and become a core developer. Hopefully most of these
people, when they find a bug, will file a bugreport, and probably, because
they're doing it for money, they will attach a patch. But once again, I'd
say the odds of getting a patch that also updates/creates tests is about
50/50 here - the barrier to entry for understanding and using the many
facets of Plone's test infrastructure is quite high. Hint:
http://plone.org/search?SearchableText=create+test+case

5) Plone core dev. 'nuff said.

Personally, most of the time I'm in between (3a) and (4), but the odds of
me ever filling out the contributor agreement are very low, for a variety
of reasons, including both time and the hurdle of getting legal advice. I
have submitted bugreports on their own, submitted bugreports with patches,
and submitted bugreports with patches and tests, but almost universally
these bugreports have languished. Eventually, most of them have been
closed, but I still have some open for a long time, including even ones
that I submitted a patch for (no tests on this one) and then even
*reworked* the patches on (https://dev.plone.org/plone/ticket/8466).

There are some situations where just releasing a hotfix/monkeypatch
product to fix a pain point is Just Going To Be Easier (and I don't
necessarily think of this as a bad thing). For example, bug
http://dev.plone.org/plone/ticket/5665 - This bug has been open and
relevant for more than *three years*. I have a patch and can hotfix this
relatively trivially, but in order to fix it 'properly', not only do I
have to supply a patch + tests for some core Zope functionality, but I
then have to supply a patch + tests for some core Plone functionality. Or,
I could just release a hotfix product. *Or* I could just not bother and
simply Fix It For Me. In fact, what I have done is bugreport/feature
request it in Zope + patch (it's languishing - needs tests
https://bugs.launchpad.net/zope2/+bug/193122), and comment on the Plone
bugreport (+ patch!).

The comment on the PyPI page for the plone3bugfixes product says: "The
reason why we don't write bugreports is that nobody seems to care about
them. Yes, we tried before."

I sympathise with that.

If the question is 'how do we turn (3a) and (4) into core contributors?'
then the first suggestion I would offer is simply that the mere existence
of bugreports + patch attempts, no matter how poor, are the signal that
someone is *ready* to *potentially* become a core contributor, and
therefore that these efforts should be *actively sought out* and
*encouraged* so that they will develop further. I took the liberty of
searching for tickets created by one of the authors of the plone3bugfixes
product. It seems he submitted a bugreport/feature request along with a
tentative patch some 18 months ago. It is languishing, because his patch
wasn't a "working patch" so that ball was punted back into his court to
action. I guess if it Worked For Him, then at that point flat-out
rejection was enough to kill that nascent motivation dead.

Anyhow, just my 2c.


regards,
Darryl Dixon
Winterhouse Consulting Ltd
http://www.winterhouseconsulting.com


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Martin Aspeli

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
Meh... reply-to-all failure. :(

And for the record - I'm not trying to chastise Darryl here, who's
been a valuable contributor in many other ways for a long time. I'm
trying to make a more general, but very important point.

2009/7/1 Darryl Dixon - Winterhouse Consulting
<[hidden email]>:

>
> Personally, most of the time I'm in between (3a) and (4), but the odds of
> me ever filling out the contributor agreement are very low, for a variety
> of reasons, including both time and the hurdle of getting legal advice.


The time it takes is about 5 minutes. Maybe 10 if you have to find a
scanner or fax machine. It's a very short and clear form.

I can't really understand why you'd see the need to seek legal advice
over this, though of course I don't know your exact circumstances. I
suspect that virtually no-one has, except perhaps a few large
organisations with in-house lawyers. The agreement is very short and
clear and places very few obligations on the contributor.

The contributor agreement is there to protect you, as a user of Plone,
more than anything. It helps ensure that Plone remains free and open
for you to use in your business. If you really do have bugs to
contribute and you know how, then I think it's a really big shame that
you won't invest the time and trust to send in an agreement and make a
positive impact on the project. After all, you're benefiting from
everyone else who've done this already and are working to make the
core product better.

I do get rather fired up about this "us and them" attitude that
sometimes prevails, no matter which side of the
contributor-agreement-signing divide it comes from. There is nothing
special about being a core Plone contributor. If you know how to use
svn and you have the ability to fix a bug (ideally, with a test), and
you have a reason - pragmatic or emotional - to fix that bug, then you
should be a Plone contributor. The core contributors shouldn't foster
the idea that they are somewhow "different". And those who are not,
but have the ability to be, shouldn't hide behind that excuse either.

I fully agree that we should be better at both attacking bugs and
following up on patches. It's a difficult problem, and one that rears
its head every few months. But the only thing that's going to make an
impact is having more contributors, and that means more people signing
the agreement.

Martin

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Darryl Dixon - Winterhouse Consulting-2

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
> Meh... reply-to-all failure. :(

;)

> And for the record - I'm not trying to chastise Darryl here, who's
> been a valuable contributor in many other ways for a long time. I'm
> trying to make a more general, but very important point.

Thanks. I'm not trying to be difficult either, just wanting to express a
point of view that I'm pretty sure a number of others may also have but
might not otherwise be heard :)

I was motivated by your mail to look again at the Contributor Agreement in
order to revalidate my recollections about it - perhaps it wasn't as big a
deal as I may have thought at the time... I'll comment on my findings
below.

> 2009/7/1 Darryl Dixon - Winterhouse Consulting
> <[hidden email]>:
>
>>
>> Personally, most of the time I'm in between (3a) and (4), but the odds
>> of
>> me ever filling out the contributor agreement are very low, for a
>> variety
>> of reasons, including both time and the hurdle of getting legal advice.
>
>
> The time it takes is about 5 minutes. Maybe 10 if you have to find a
> scanner or fax machine. It's a very short and clear form.

It is clear, but requires physical mailing - scanners and faxes are
redundant except perhaps to keep a copy for myself. That alone raises the
bar at least a little, but I don't think that's a bad thing ;)

> > I can't really understand why you'd see the need to seek legal advice
> over this, though of course I don't know your exact circumstances. I
> suspect that virtually no-one has, except perhaps a few large
> organisations with in-house lawyers. The agreement is very short and
> clear and places very few obligations on the contributor.

One of the first reasons I need to seek advice is that I am a contractor
who implements Plone-based solutions for my clients. When I write a
feature/code for them that touches Plone or integrates deeply with it, I
need to know that I am the "sole copyright holder for the Work" before I
can contribute any part of that feature back to the Plone foundation. And
I need to be darn certain, because I will have warranted such by signing
the Contributor Agreement (I'd need to be certain anyway, but the
Contributor Agreement puts me on the hook to all parties, client and PF
and maybe even
random-3rd-party-who-uses-Plone-who-now-has-to-deal-with-copyright-infringement-suit-from-my-client).
This can be a tricky landscape (which is why the Plone Foundation needs
the agreement in the first place) - is what I have done a 'work for hire'?
This probably depends on the wording of my current contract and the local
laws where I work, and may vary from case-to-case. Either way, legal
advice is required. Call me paranoid if you will, but if the Plone
Foundation needs a Contributor Agreement, then by the same measure I (any
Plone contractor) need legal advice before I sign it.

If I was a full-time employee, I'd need a letter from my C-level executive
releasing any claim on any Plone work done by me. I'm pretty sure that
anything at that level is guaranteed to need a legal rep to sign off on
it, and in some places I've worked historically it would have been a
show-stopper straight away.

> The contributor agreement is there to protect you, as a user of Plone,
> more than anything. It helps ensure that Plone remains free and open
> for you to use in your business. If you really do have bugs to
> contribute and you know how, then I think it's a really big shame that
> you won't invest the time and trust to send in an agreement and make a
> positive impact on the project. After all, you're benefiting from
> everyone else who've done this already and are working to make the
> core product better.

Of course. The ideal situation would be to do more than simply contribute
bugreports and trivial patches.

> I do get rather fired up about this "us and them" attitude that
> sometimes prevails, no matter which side of the
> contributor-agreement-signing divide it comes from. There is nothing
> special about being a core Plone contributor. If you know how to use
> svn and you have the ability to fix a bug (ideally, with a test), and
> you have a reason - pragmatic or emotional - to fix that bug, then you
> should be a Plone contributor. The core contributors shouldn't foster
> the idea that they are somewhow "different". And those who are not,
> but have the ability to be, shouldn't hide behind that excuse either.

Agree.

> I fully agree that we should be better at both attacking bugs and
> following up on patches. It's a difficult problem, and one that rears
> its head every few months. But the only thing that's going to make an
> impact is having more contributors, and that means more people signing
> the agreement.
>
> Martin

All true. Chicken-meets-egg ;) Anyhow, I guess I really mean to say I
don't necessarily think that there isn't room out there for third-party
'hotfixes' of Plone in lieu of core code contribution. It's probably not
ideal, but better than perhaps nothing.

regards,
Darryl Dixon
Winterhouse Consulting Ltd
http://www.winterhouseconsulting.com


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Martin Aspeli

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
Hi Daryl,

> Thanks. I'm not trying to be difficult either, just wanting to express a
> point of view that I'm pretty sure a number of others may also have but
> might not otherwise be heard :)

Yes, and it is much appreciated.

> I was motivated by your mail to look again at the Contributor Agreement in
> order to revalidate my recollections about it - perhaps it wasn't as big a
> deal as I may have thought at the time... I'll comment on my findings
> below.

Excellent. :)

>> The time it takes is about 5 minutes. Maybe 10 if you have to find a
>> scanner or fax machine. It's a very short and clear form.
>
> It is clear, but requires physical mailing - scanners and faxes are
> redundant except perhaps to keep a copy for myself. That alone raises the
> bar at least a little, but I don't think that's a bad thing ;)

I don't think it's too much to ask. I'm sure you do plenty of
paperwork in your day job. ;)

> One of the first reasons I need to seek advice is that I am a contractor
> who implements Plone-based solutions for my clients.

I suspect you're not alone in that. ;-)

> When I write a
> feature/code for them that touches Plone or integrates deeply with it, I
> need to know that I am the "sole copyright holder for the Work" before I
> can contribute any part of that feature back to the Plone foundation. And
> I need to be darn certain, because I will have warranted such by signing
> the Contributor Agreement (I'd need to be certain anyway, but the
> Contributor Agreement puts me on the hook to all parties, client and PF
> and maybe even
> random-3rd-party-who-uses-Plone-who-now-has-to-deal-with-copyright-infringement-suit-from-my-client).
> This can be a tricky landscape (which is why the Plone Foundation needs
> the agreement in the first place) - is what I have done a 'work for hire'?

If you're concerned about this, I suggest you email the board mailing
list and ask for clarification. The agreement has a number of
clarifying points already, but if you feel it's not covered, better
ask.

That said, I think everyone else is in the same boat, so if it was a
big problem, it probably would've been sorted out by now. More likely,
the discussion needs to be between you and the client, if they are
comfortable with you spending some of the time they pay for to make
fixes in the core product.

> If I was a full-time employee, I'd need a letter from my C-level executive
> releasing any claim on any Plone work done by me. I'm pretty sure that
> anything at that level is guaranteed to need a legal rep to sign off on
> it, and in some places I've worked historically it would have been a
> show-stopper straight away.

I guess it depends on what kind of a company you work for. :)

I do see how it can be a problem in some cases, of course, which is
unfortunate. But then the issue under discussion here is kind of moot:
you can't submit a patch and ask someone else to commit it either. :)

> All true. Chicken-meets-egg ;) Anyhow, I guess I really mean to say I
> don't necessarily think that there isn't room out there for third-party
> 'hotfixes' of Plone in lieu of core code contribution. It's probably not
> ideal, but better than perhaps nothing.

The problem is that those things tend to create problems in the long
run. They probably won't be maintained and tested with future Plone
releases. So they may work today, but break tomorrow, and no-one has
any idea why or how.

Martin

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Dylan Jay

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
In reply to this post by Martin Aspeli
In defence of Darryl I think his gist was that many integrators get  
used to creating products to do their work (including patches to plone  
needed to solve immediate client issues) and now with pypi and  
collective.releaser is very very easy to make that public.

I agree martin that there isn't logically a them and us and it is just  
a perception that becoming a core developer is difficult... but I  
think it is a perception that does exist for better or worse. I'm not  
sure why that perception exists.



On 01/07/2009, at 12:07 PM, Martin Aspeli wrote:

> Meh... reply-to-all failure. :(
>
> And for the record - I'm not trying to chastise Darryl here, who's
> been a valuable contributor in many other ways for a long time. I'm
> trying to make a more general, but very important point.
>
> 2009/7/1 Darryl Dixon - Winterhouse Consulting
> <[hidden email]>:
>
>>
>> Personally, most of the time I'm in between (3a) and (4), but the  
>> odds of
>> me ever filling out the contributor agreement are very low, for a  
>> variety
>> of reasons, including both time and the hurdle of getting legal  
>> advice.
>
>
> The time it takes is about 5 minutes. Maybe 10 if you have to find a
> scanner or fax machine. It's a very short and clear form.
>
> I can't really understand why you'd see the need to seek legal advice
> over this, though of course I don't know your exact circumstances. I
> suspect that virtually no-one has, except perhaps a few large
> organisations with in-house lawyers. The agreement is very short and
> clear and places very few obligations on the contributor.
>
> The contributor agreement is there to protect you, as a user of Plone,
> more than anything. It helps ensure that Plone remains free and open
> for you to use in your business. If you really do have bugs to
> contribute and you know how, then I think it's a really big shame that
> you won't invest the time and trust to send in an agreement and make a
> positive impact on the project. After all, you're benefiting from
> everyone else who've done this already and are working to make the
> core product better.
>
> I do get rather fired up about this "us and them" attitude that
> sometimes prevails, no matter which side of the
> contributor-agreement-signing divide it comes from. There is nothing
> special about being a core Plone contributor. If you know how to use
> svn and you have the ability to fix a bug (ideally, with a test), and
> you have a reason - pragmatic or emotional - to fix that bug, then you
> should be a Plone contributor. The core contributors shouldn't foster
> the idea that they are somewhow "different". And those who are not,
> but have the ability to be, shouldn't hide behind that excuse either.
>
> I fully agree that we should be better at both attacking bugs and
> following up on patches. It's a difficult problem, and one that rears
> its head every few months. But the only thing that's going to make an
> impact is having more contributors, and that means more people signing
> the agreement.
>
> Martin
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Plone-developers mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/plone-developers


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Jim Nelson

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
In reply to this post by Martin Aspeli
>> When I write a
>> feature/code for them that touches Plone or integrates deeply with it, I
>> need to know that I am the "sole copyright holder for the Work" before I
>> can contribute any part of that feature back to the Plone foundation. And
>> I need to be darn certain, because I will have warranted such by signing
>> the Contributor Agreement (I'd need to be certain anyway, but the
>> Contributor Agreement puts me on the hook to all parties, client and PF
>> and maybe even
>> random-3rd-party-who-uses-Plone-who-now-has-to-deal-with-copyright-infringement-suit-from-my-client).
>> This can be a tricky landscape (which is why the Plone Foundation needs
>> the agreement in the first place) - is what I have done a 'work for hire'?
>
> If you're concerned about this, I suggest you email the board mailing
> list and ask for clarification. The agreement has a number of
> clarifying points already, but if you feel it's not covered, better
> ask.
>
> That said, I think everyone else is in the same boat, so if it was a
> big problem, it probably would've been sorted out by now. More likely,
> the discussion needs to be between you and the client, if they are
> comfortable with you spending some of the time they pay for to make
> fixes in the core product.
>

I know we've had customers pay for having features fixed in Plone before -
monkey-patched it, and submitted the fixes for application later. We were
upfront about it, and they have been pretty cool about it.  Half the time, I
don't even think they understood what we were talking about...


>> If I was a full-time employee, I'd need a letter from my C-level executive
>> releasing any claim on any Plone work done by me. I'm pretty sure that
>> anything at that level is guaranteed to need a legal rep to sign off on
>> it, and in some places I've worked historically it would have been a
>> show-stopper straight away.
>
> I guess it depends on what kind of a company you work for. :)
>
> I do see how it can be a problem in some cases, of course, which is
> unfortunate. But then the issue under discussion here is kind of moot:
> you can't submit a patch and ask someone else to commit it either. :)
>

Doesn't that invalidate the work done in the tune-up days? If only core
contributors can commit, and cannot commit work from anyone else, then there are
a whole raft of problems that simply cannot be fixed, unless we get a lot of
core developers with time on their hands who can clean-room reimplement the
patch submitted by someone who doesn't have that same agreement.

That seems a rather high bar.

Maybe there should be an exception for patches of five lines or less? Some kind
of streamlined "I fixed this typo - don't put a pile of process in front of me"
system?

Speaking as someone who spends some time doing Plone coding, but also does
enough other things that taking the implied commitment of signing a contributor
agreement just to fix a few quick bugs in my spare time just doesn't feel... right.

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
Martin Aspeli

Re: collective.plone3bugfixes

Reply Threaded More More options
Print post
Permalink
In reply to this post by Jim Nelson
Jim Nelson wrote:

> As someone who primarily does bug fixes, it's really, really hard to get the
> attention of a core developer to push a one-line patch into Plone core.  There
> are several QA'd and ready to apply patches from the last tune-up that haven't
> been cleared yet - and that has been the problem for some time.

In general, we should never be waiting for anyone to "approve" bug
fixes. Get the contributor agreement signed, and commit the fix. People
*do* watch the checkin list and will revert anything that's obviously
bad. 9 times out of 10, the fix won't be bad and having it in will be
way better than waiting.

Don't let other people become a bottleneck. And don't fall into the trap
of dropping responsibility on no-one in particular. As wiggy once said
"You assigned the body to the 'somebody' user. He tends not to do too much".

I've got a patch sitting in my inbox that I know is safe to commit, and
I've left it there for two days now. Yes, it's a simple thing to do, but
my Plone to-do list is basically endless and prioritising is sometimes hard.

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers
1 2