about the bug 'Automatic Crash Recovery: disregards track zoom level and position'

[sam lewis-2]

Hi all,

I am interested in helping fix the bug, ' P3 Automatic Crash Recovery: disregards track zoom level and position.' , which is listed on the bug list given by Martyn.

I have reproduced that on my computer and started reading related code.

Is there anyone already working on this or anyone who have more details about this problem?  Your instructions will be greatly appreciated.

BTW, I am not sure if it is proper to post email like this. Please point out if it is not proper.


Thanks
Sam

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Martyn Shaw-2]

Hi Sam

It's fine to post here.

A good starting point would be to make a recovered project fit to the
window - not a full recovery of state but better than we have now (?).

The >--< button in the Edit Toolbar does that and has the ToolTip 'Fit
Project'.  I would search for 'Fit Project' and find out what makes
that work, so then you know what to call.  Then find out when to call
it.  When is the recovery code done?  Perhaps you could put the call
in there, at the end...

HTH
Martyn

sam lewis wrote:

> Hi all,
>
> I am interested in helping fix the bug, ' *P3* *Automatic Crash
> Recovery: disregards track zoom level and position.*' , which is listed
> on the bug list given by Martyn.
>
> I have reproduced that on my computer and started reading related code.
>
> Is there anyone already working on this or anyone who have more details
> about this problem?  Your instructions will be greatly appreciated.
>
> BTW, I am not sure if it is proper to post email like this. Please point
> out if it is not proper.
>
>
> Thanks
> Sam

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[sam lewis-2]

Hi Martyn,

I think the 'fit project' feature is implemented in the function
AudacityProject::OnZoomFit. And this function can be called after a

project is recovered in function RecoverAllProjects. I append a patch
implementing this simple method. This one works fine on my

own computer. I hope this one would be helpful.

Thanks.

Sam

On Sat, Sep 19, 2009 at 7:01 AM, Martyn Shaw
<[hidden email]> wrote:

>
> Hi Sam
>
> It's fine to post here.
>
> A good starting point would be to make a recovered project fit to the window - not a full recovery of state but better than we have now (?).
>
> The >--< button in the Edit Toolbar does that and has the ToolTip 'Fit Project'.  I would search for 'Fit Project' and find out what makes that work, so then you know what to call.  Then find out when to call it.  When is the recovery code done?  Perhaps you could put the call in there, at the end...
>
> HTH
> Martyn
>
> sam lewis wrote:
>>
>> Hi all,
>>
>> I am interested in helping fix the bug, ' *P3* *Automatic Crash Recovery: disregards track zoom level and position.*' , which is listed on the bug list given by Martyn.
>>
>> I have reproduced that on my computer and started reading related code.
>>
>> Is there anyone already working on this or anyone who have more details about this problem?  Your instructions will be greatly appreciated.
>>
>> BTW, I am not sure if it is proper to post email like this. Please point out if it is not proper.
>>
>>
>> Thanks
>> Sam

[autorecovery.patch]

---

diff -r -u audacity/src/AutoRecovery.cpp audacity-patched/src/AutoRecovery.cpp
--- audacity/src/AutoRecovery.cpp 2009-09-21 11:16:15.551246000 +0800
+++ audacity-patched/src/AutoRecovery.cpp 2009-09-21 11:10:56.632830500 +0800
@@ -210,6 +210,9 @@
       // the opened auto-save file is automatically deleted and a new one
       // is created.
       proj->OpenFile(files[i], false);
+
+  //fit proj after recovery
+  proj->OnZoomFit();
    }
   
    return true;

---

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[sam lewis-2]

Hi,

Now, afer a project is recovered, the zoom level and position is discarded and the project is fitted. I would like to continue working on this issue to make the recovered project keep its zoom level and position.

Any suggestions, please?

Thanks
Sam

On Tue, Sep 22, 2009 at 6:14 AM, Martyn Shaw <[hidden email]> wrote:

Hi Sam

Nice one!  Thanks for your efforts.  Works here, and I have a lot of recoveries since I often stop Audacity from the debugger, so it will be useful.  I have committed it and noted on the wiki.

I future, it's 3 spaces instead of a tab ;-).

So what's next?  Please start a new thread for that.

TTFN

Martyn

sam lewis wrote:

Hi Martyn,

I think the 'fit project' feature is implemented in the function
AudacityProject::OnZoomFit. And this function can be called after a

project is recovered in function RecoverAllProjects. I append a patch
implementing this simple method. This one works fine on my

own computer. I hope this one would be helpful.

Thanks.

Sam

On Sat, Sep 19, 2009 at 7:01 AM, Martyn Shaw
<[hidden email]> wrote:

Hi Sam

It's fine to post here.

A good starting point would be to make a recovered project fit to the window - not a full recovery of state but better than we have now (?).

The >--< button in the Edit Toolbar does that and has the ToolTip 'Fit Project'.  I would search for 'Fit Project' and find out what makes that work, so then you know what to call.  Then find out when to call it.  When is the recovery code done?  Perhaps you could put the call in there, at the end...

HTH
Martyn

sam lewis wrote:

Hi all,

I am interested in helping fix the bug, ' *P3* *Automatic Crash Recovery: disregards track zoom level and position.*' , which is listed on the bug list given by Martyn.

I have reproduced that on my computer and started reading related code.

Is there anyone already working on this or anyone who have more details about this problem?  Your instructions will be greatly appreciated.

BTW, I am not sure if it is proper to post email like this. Please point out if it is not proper.


Thanks
Sam

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel