ZipCache.java: an attempt to speed up loading

[Erik Huelsmann]

Attached is a patch which implements a ZipCache class: an attempt to
speed up our loading.

In one of the profiles that I ran over the past days,
File.lastModified() consumed up an awful lot of time. With this patch,
it's now off the list of hot spots. However: does it really matter, I
mean, is loading really faster?

Could you try it and tell me your findings? If there's no speed up,
there's no reason for the added complexity.

Bye,

Erik.


------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
armedbear-j-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/armedbear-j-devel

[Alessio Stalla]

On Sat, Jun 6, 2009 at 4:00 PM, Erik Huelsmann<[hidden email]> wrote:

> Attached is a patch which implements a ZipCache class: an attempt to
> speed up our loading.
>
> In one of the profiles that I ran over the past days,
> File.lastModified() consumed up an awful lot of time. With this patch,
> it's now off the list of hot spots. However: does it really matter, I
> mean, is loading really faster?
>
> Could you try it and tell me your findings? If there's no speed up,
> there's no reason for the added complexity.

I haven't tried it. However, I noted that in your patch you have
changed an if test in Stream.java to avoid using indexOf(); the new
test does not consider the case firstChar == '.' that the original
code took into account. Is it intended to be like that?

Cheers,
Alessio

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
armedbear-j-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/armedbear-j-devel

[Erik Huelsmann]

On Sat, Jun 6, 2009 at 9:03 PM, Alessio Stalla <[hidden email]> wrote:

> On Sat, Jun 6, 2009 at 4:00 PM, Erik Huelsmann<[hidden email]> wrote:
>> Attached is a patch which implements a ZipCache class: an attempt to
>> speed up our loading.
>>
>> In one of the profiles that I ran over the past days,
>> File.lastModified() consumed up an awful lot of time. With this patch,
>> it's now off the list of hot spots. However: does it really matter, I
>> mean, is loading really faster?
>>
>> Could you try it and tell me your findings? If there's no speed up,
>> there's no reason for the added complexity.
>
> I haven't tried it. However, I noted that in your patch you have
> changed an if test in Stream.java to avoid using indexOf(); the new
> test does not consider the case firstChar == '.' that the original
> code took into account. Is it intended to be like that?

Ah. Thanks for the review; no, it's an error: that change wasn't
supposed to be part of the patch at all.

Since 0.16 is roughly 2 months away, I decided to commit the change
(without the Stream changes); we'll see before 0.16 to pull it or not.


Bye,

Erik.

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
armedbear-j-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/armedbear-j-devel