Where should feature requests go?

4 messages Options
Embed this post
Permalink
Russell McOrmond

Where should feature requests go?

Reply Threaded More More options
Print post
Permalink

   I have a feature request that is likely easy to add.  I would send a
patch, but suspect it is quicker for one of the already trusted developers
to do things.

Request: In TileCache/Service.py there is a look-up of
options["TileCacheConfig"] , and then the use of this configuration file.
I am wondering if something similar can be added to TileCache/Client.py as
an additional parser.add_option() such as "-c","--config".


Reason:

   We have set up a number of different tilecache configurations
corresponding to different WMS groupings.  We have each of these in the
Apache configuration, using "PythonOption TileCacheConfig
/path/to/config.cfg"  to point to the right config.  It would be easier if
we could specify the configuration file on the command line for
tilecache_seed.py as well, rather than having to hack around this (copy
specific config to different name before running, etc).

   If there is a better place to file this request (a Bugzilla), then
please let me know.

Thanks!


--
  Russell McOrmond, Internet Consultant: <http://www.flora.ca/>
  Please help us tell the Canadian Parliament to protect our property
  rights as owners of Information Technology. Sign the petition!
  http://digital-copyright.ca/petition/ict/     http://KillBillC61.ca

  "The government, lobbied by legacy copyright holders and hardware
   manufacturers, can pry control over my camcorder, computer,
   home theatre, or portable media player from my cold dead hands!"
_______________________________________________
Tilecache mailing list
[hidden email]
http://openlayers.org/mailman/listinfo/tilecache
Christopher Schmidt-2

Re: Where should feature requests go?

Reply Threaded More More options
Print post
Permalink
On Fri, Aug 14, 2009 at 08:28:27AM -0400, Russell McOrmond wrote:
>
>    I have a feature request that is likely easy to add.  I would send a
> patch, but suspect it is quicker for one of the already trusted developers
> to do things.

Feel free to make requests to the mailing list; if someone impements
it, I will apply the patch.

-- Chris

> Request: In TileCache/Service.py there is a look-up of
> options["TileCacheConfig"] , and then the use of this configuration file.
> I am wondering if something similar can be added to TileCache/Client.py as
> an additional parser.add_option() such as "-c","--config".
>
>
> Reason:
>
>    We have set up a number of different tilecache configurations
> corresponding to different WMS groupings.  We have each of these in the
> Apache configuration, using "PythonOption TileCacheConfig
> /path/to/config.cfg"  to point to the right config.  It would be easier if
> we could specify the configuration file on the command line for
> tilecache_seed.py as well, rather than having to hack around this (copy
> specific config to different name before running, etc).
>
>    If there is a better place to file this request (a Bugzilla), then
> please let me know.

Nope, just the mailing list.

Regards,
--
Christopher Schmidt
MetaCarta
_______________________________________________
Tilecache mailing list
[hidden email]
http://openlayers.org/mailman/listinfo/tilecache
Russell McOrmond

Re: Where should feature requests go?

Reply Threaded More More options
Print post
Permalink
On Fri, 14 Aug 2009, Christopher Schmidt wrote:

> On Fri, Aug 14, 2009 at 08:28:27AM -0400, Russell McOrmond wrote:
>>
>>    I have a feature request that is likely easy to add.  I would send a
>> patch, but suspect it is quicker for one of the already trusted developers
>> to do things.
>
> Feel free to make requests to the mailing list; if someone impements
> it, I will apply the patch.


   I don't know python or TileCache well, but the following appears to do
what I need:


--- Client.py-orig 2009-01-18 22:01:24.000000000 -0500
+++ Client.py 2009-08-14 14:09:29.000000000 -0400
@@ -133,7 +133,10 @@

      parser.add_option("-b","--bbox",action="store", type="string", dest="bbox", default = None,
                        help="restrict to specified bounding box")
-
+
+    parser.add_option("-c","--config",action="store", type="string", dest="tilecacheconfig", default = None,
+                      help="path to configuration file")
+
      parser.add_option("-p","--padding",action="store", type="int", dest="padding", default = 0,
                        help="extra margin tiles to seed around target area. Defaults to 0 "+
                        "(some edge tiles might be missing).      A value of 1 ensures all tiles "+
@@ -149,7 +152,14 @@

      from Service import Service, cfgfiles
      from Layer import Layer
-    svc = Service.load(*cfgfiles)
+
+    cfgs = cfgfiles
+    if options.tilecacheconfig:
+        configFile = options.tilecacheconfig
+        print "Config file set to %s" % (configFile)
+        cfgs = cfgs + (configFile,)
+
+    svc = Service.load(*cfgs)
      layer = svc.layers[args[0]]

      if options.bbox:



--
  Russell McOrmond, Internet Consultant: <http://www.flora.ca/>
  Please help us tell the Canadian Parliament to protect our property
  rights as owners of Information Technology. Sign the petition!
  http://digital-copyright.ca/petition/ict/     http://KillBillC61.ca

  "The government, lobbied by legacy copyright holders and hardware
   manufacturers, can pry control over my camcorder, computer,
   home theatre, or portable media player from my cold dead hands!"
_______________________________________________
Tilecache mailing list
[hidden email]
http://openlayers.org/mailman/listinfo/tilecache
Christopher Schmidt-2

Re: Where should feature requests go?

Reply Threaded More More options
Print post
Permalink
On Fri, Aug 14, 2009 at 02:17:17PM -0400, Russell McOrmond wrote:

> On Fri, 14 Aug 2009, Christopher Schmidt wrote:
>
>> On Fri, Aug 14, 2009 at 08:28:27AM -0400, Russell McOrmond wrote:
>>>
>>>    I have a feature request that is likely easy to add.  I would send a
>>> patch, but suspect it is quicker for one of the already trusted developers
>>> to do things.
>>
>> Feel free to make requests to the mailing list; if someone impements
>> it, I will apply the patch.
>
>
>   I don't know python or TileCache well, but the following appears to do  
> what I need:

Committed as r395.

>
> --- Client.py-orig 2009-01-18 22:01:24.000000000 -0500
> +++ Client.py 2009-08-14 14:09:29.000000000 -0400
> @@ -133,7 +133,10 @@
>
>      parser.add_option("-b","--bbox",action="store", type="string", dest="bbox", default = None,
>                        help="restrict to specified bounding box")
> - + +    parser.add_option("-c","--config",action="store", type="string",
> dest="tilecacheconfig", default = None,
> +                      help="path to configuration file")
> +
>      parser.add_option("-p","--padding",action="store", type="int", dest="padding", default = 0,
>                        help="extra margin tiles to seed around target area. Defaults to 0 "+
>                        "(some edge tiles might be missing).      A value of 1 ensures all tiles "+
> @@ -149,7 +152,14 @@
>
>      from Service import Service, cfgfiles
>      from Layer import Layer
> -    svc = Service.load(*cfgfiles)
> +
> +    cfgs = cfgfiles
> +    if options.tilecacheconfig:
> +        configFile = options.tilecacheconfig
> +        print "Config file set to %s" % (configFile)
> +        cfgs = cfgs + (configFile,)
> + +    svc = Service.load(*cfgs)
>      layer = svc.layers[args[0]]
>
>      if options.bbox:
>
>
>
> --
>  Russell McOrmond, Internet Consultant: <http://www.flora.ca/>
>  Please help us tell the Canadian Parliament to protect our property
>  rights as owners of Information Technology. Sign the petition!
>  http://digital-copyright.ca/petition/ict/     http://KillBillC61.ca
>
>  "The government, lobbied by legacy copyright holders and hardware
>   manufacturers, can pry control over my camcorder, computer,
>   home theatre, or portable media player from my cold dead hands!"

--
Christopher Schmidt
MetaCarta
_______________________________________________
Tilecache mailing list
[hidden email]
http://openlayers.org/mailman/listinfo/tilecache