Track group definition

2 messages Options
Embed this post
Permalink
Al Dimond

Track group definition

Reply Threaded More More options
Print post
Permalink
In an off-list discussion with Gale A. and Bill W., Bill mentioned that
the manual defines a track group as any positive number of wave tracks
followed by any positive number of label tracks.  Gale said that this
is the definition agreed to by all developers when track groups and
linking were introduced.  However, currently in the code this
definition is never used, as far as I can tell.  It's always any number
of wave tracks followed by exactly one label track.  Any further wave
tracks are on their own.

For the most part, we could move to the definition stated in the manual
by changing TrackGroupIterator and TrackAndGroupIterator.  I know of
at least a few other areas that would need attention: just about all
the Clear, Cut, and Paste functions would at least need a look, and
the Repeat effect would need minor changes.  I'm sure I'm missing a few
things.  On the other hand, we could leave the code how it is and
change the manual.  I'd rather change the manual at this point, but,
you know, I'm just this guy that drops a lot of patches on your heads.

Does anyone have thoughts or opinions on this?

 - Al

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
James Crook

Re: Track group definition

Reply Threaded More More options
Print post
Permalink
I would regard the current way as being a P4 bug, rather than changing
the manual only to have to change it back later when we do things right.

If our code is designed right it should be just exactly as you say, a
change in the iterators.  If it's not, then it suggests we're being too
special case in our coding, so it's a (mild) design smell and worth
sorting out (as a P4).

--James.


Al Dimond wrote:

> In an off-list discussion with Gale A. and Bill W., Bill mentioned that
> the manual defines a track group as any positive number of wave tracks
> followed by any positive number of label tracks.  Gale said that this
> is the definition agreed to by all developers when track groups and
> linking were introduced.  However, currently in the code this
> definition is never used, as far as I can tell.  It's always any number
> of wave tracks followed by exactly one label track.  Any further wave
> tracks are on their own.
>
> For the most part, we could move to the definition stated in the manual
> by changing TrackGroupIterator and TrackAndGroupIterator.  I know of
> at least a few other areas that would need attention: just about all
> the Clear, Cut, and Paste functions would at least need a look, and
> the Repeat effect would need minor changes.  I'm sure I'm missing a few
> things.  On the other hand, we could leave the code how it is and
> change the manual.  I'd rather change the manual at this point, but,
> you know, I'm just this guy that drops a lot of patches on your heads.
>
> Does anyone have thoughts or opinions on this?
>
>  - Al


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel