Still 4 blockers for Plone 3.3

[Wichert Akkerman]

Since my last message two days ago little progress has been made:
Alexander closed two tickets (one of which has already fixed), but the
other four blocker bugs have not seen any activity.

To refresh your memory: these are the open bugs that have to be fixed
before we can move forward with the Plone 3.3 release:


9141 - http://dev.plone.org/old/plone/ticket/9141
3 month old bug in ResourceRegistries migration, which breaks CSS for
sites when upgrading.

9240 - http://dev.plone.org/old/plone/ticket/9240
4 week old bug: Kupu no longer works with AJAX. Might be fixed in
subversion already, but needs some positive test feedback and a new release.

9266 - http://dev.plone.org/old/plone/ticket/9266
Captioning no longer works in Kupu. Has not gotten any attention since
it was reported three weeks ago.

7794 - http://dev.plone.org/old/plone/ticket/7794
Content based language negotation does not work with virtual hosting.
Release critical since the feature is new to Plone 3.3. A record holding
blocker bug: it was reported 17 months ago.


9240 and 9266 can be fixed by downgrading kupu to the previous release.
This will mean a significant loss of translations, but I am willing to
make that sacrifice if needed.

Wichert.

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Martin Aspeli]

Wichert Akkerman wrote:

> 9141 - http://dev.plone.org/old/plone/ticket/9141
> 3 month old bug in ResourceRegistries migration, which breaks CSS for
> sites when upgrading.

Can we follow Hanno's suggestion and just re-bake the content on migration?

> 9240 - http://dev.plone.org/old/plone/ticket/9240
> 4 week old bug: Kupu no longer works with AJAX. Might be fixed in
> subversion already, but needs some positive test feedback and a new release.

I tested this when Laurence made the fix, and it worked.

> 9266 - http://dev.plone.org/old/plone/ticket/9266
> Captioning no longer works in Kupu. Has not gotten any attention since
> it was reported three weeks ago.

:-/

> 7794 - http://dev.plone.org/old/plone/ticket/7794
> Content based language negotation does not work with virtual hosting.
> Release critical since the feature is new to Plone 3.3. A record holding
> blocker bug: it was reported 17 months ago.

Who owns this? I see i18n and I think Hanno, but... :p

> 9240 and 9266 can be fixed by downgrading kupu to the previous release.
> This will mean a significant loss of translations, but I am willing to
> make that sacrifice if needed.

9240 is fixed as far as I know. 9266 needs someone to look at it urgently.

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Wichert Akkerman]

On 7/1/09 4:23 PM, Martin Aspeli wrote:
> Wichert Akkerman wrote:
>
>> 9141 - http://dev.plone.org/old/plone/ticket/9141
>> 3 month old bug in ResourceRegistries migration, which breaks CSS for
>> sites when upgrading.
>
> Can we follow Hanno's suggestion and just re-bake the content on migration?

Probably, but someone needs to write the failing test, implement the fix
and ask one of the bug reports to test it.

>> 9240 - http://dev.plone.org/old/plone/ticket/9240
>> 4 week old bug: Kupu no longer works with AJAX. Might be fixed in
>> subversion already, but needs some positive test feedback and a new release.
>
> I tested this when Laurence made the fix, and it worked.

That's excellent news!

>> 9266 - http://dev.plone.org/old/plone/ticket/9266
>> Captioning no longer works in Kupu. Has not gotten any attention since
>> it was reported three weeks ago.
>
> :-/
>
>> 7794 - http://dev.plone.org/old/plone/ticket/7794
>> Content based language negotation does not work with virtual hosting.
>> Release critical since the feature is new to Plone 3.3. A record holding
>> blocker bug: it was reported 17 months ago.
>
> Who owns this? I see i18n and I think Hanno, but... :p

I don't think anyone owns this at the moment. I tried to talk Hanno into
looking at this yesterday, but he said that it was not his feature and
he was just applying patches from others.

Wichert.

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Tom Gross]

Hi Wichert,

Wichert Akkerman <wichert@...> writes:

>
> On 7/1/09 4:23 PM, Martin Aspeli wrote:
> > Wichert Akkerman wrote:
> >
> >> 9141 - http://dev.plone.org/old/plone/ticket/9141
> >> 3 month old bug in ResourceRegistries migration, which breaks CSS for
> >> sites when upgrading.
> >
> > Can we follow Hanno's suggestion and just re-bake the content on migration?
>

I couldn't have to see this tragedy so I fixed this one. I don't have commit
access to the Plone repository and therefore I uploaded a patch to trac.

https://dev.plone.org/plone/attachment/ticket/9141/fix9141.patch

...

I don't know much JavaScript and kupu. I can not help you with the others. sorry.

> Wichert.
>
-Tom



------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Martin Aspeli]

Tom wrote:

> Hi Wichert,
>
> Wichert Akkerman <wichert@...> writes:
>
>> On 7/1/09 4:23 PM, Martin Aspeli wrote:
>>> Wichert Akkerman wrote:
>>>
>>>> 9141 - http://dev.plone.org/old/plone/ticket/9141
>>>> 3 month old bug in ResourceRegistries migration, which breaks CSS for
>>>> sites when upgrading.
>>> Can we follow Hanno's suggestion and just re-bake the content on migration?
>
> I couldn't have to see this tragedy so I fixed this one. I don't have commit
> access to the Plone repository and therefore I uploaded a patch to trac.

Awesome!

By the way, you should get commit access. Can you fill in a contributor
agreement?

> https://dev.plone.org/plone/attachment/ticket/9141/fix9141.patch

Your patch looks good to me. Does test_bug9141() fail if you remove
cookCSSRegistries(portal) from the migration code?

Did you manage to test TTW?

Cheers,
Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Martin Aspeli]

Hi Wichert,

> 9240 - http://dev.plone.org/old/plone/ticket/9240
> 4 week old bug: Kupu no longer works with AJAX. Might be fixed in
> subversion already, but needs some positive test feedback and a new release.
>
> 9266 - http://dev.plone.org/old/plone/ticket/9266
> Captioning no longer works in Kupu. Has not gotten any attention since
> it was reported three weeks ago.

Laurence suggested 9266 may have been fixed on kupu trunk as well.

I don't have the ability to test right now, but it'd be a good thing for
someone to test.

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[David Glick-2]

On Jul 1, 2009, at 5:50 PM, Martin Aspeli wrote:
> Laurence suggested 9266 may have been fixed on kupu trunk as well.
>
> I don't have the ability to test right now, but it'd be a good thing  
> for
> someone to test.
>
> Martin


I checked; it's definitely a real problem.  I added a patch to the  
ticket a couple hours ago, but I don't have commit access, and it  
could use a critical eye anyway.


David Glick
Web Developer
ONE/Northwest

New tools and strategies for engaging people in protecting the  
environment

http://www.onenw.org
[hidden email]
work: [phone] x32
mobile: [phone]

Subscribe to ONEList, our email newsletter!
Practical advice for effective online engagement
http://www.onenw.org/full_signup





------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Maurits van Rees-3]

Tom, on 2009-07-01:
>> > Can we follow Hanno's suggestion and just re-bake the content on migration?
>>
>
> I couldn't have to see this tragedy so I fixed this one. I don't have commit
> access to the Plone repository and therefore I uploaded a patch to trac.
>
> https://dev.plone.org/plone/attachment/ticket/9141/fix9141.patch

Looks good.  Tests pass.  Works for me in real life.  Fix committed.
Thanks, Tom!

--
Maurits van Rees | http://maurits.vanrees.org/
            Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Alexander Limi]

On Fri, 03 Jul 2009 16:33:52 -0700, Maurits van Rees  
<[hidden email]> wrote:

> Tom, on 2009-07-01:
>>> > Can we follow Hanno's suggestion and just re-bake the content on  
>>> migration?
>>>
>>
>> I couldn't have to see this tragedy so I fixed this one. I don't have  
>> commit
>> access to the Plone repository and therefore I uploaded a patch to trac.
>>
>> https://dev.plone.org/plone/attachment/ticket/9141/fix9141.patch
>
> Looks good.  Tests pass.  Works for me in real life.  Fix committed.
> Thanks, Tom!

Awesome. Thanks Tom, and Maurits!


--
Alexander Limi · http://limi.net


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Maurits van Rees-3]

Martin Aspeli, on 2009-07-02:
>> https://dev.plone.org/plone/attachment/ticket/9141/fix9141.patch
>
> Your patch looks good to me. Does test_bug9141() fail if you remove
> cookCSSRegistries(portal) from the migration code?

Yes.

> Did you manage to test TTW?

Yes.

Fix committed by me (reported somewhere else in this thread).

--
Maurits van Rees | http://maurits.vanrees.org/
            Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers