Audacity

›

audacity-devel

Saving for OD checked in

10 Messages

Michael Chinen

Reply Threaded

I just checked in the ability to save projects with OD. Also, as more blocks are summarized, every now and then a new 'needs save' flag gets reset. For a description of how project gets the "needs save" flag,

Also, the orphaned blockfile issue should be gone now.

Several thread-unsafe bugs were fixed. FYI wxFFile is not threadsafe because it uses wxLog sometimes.

There may be a thread-safety issue that I haven't seen for a while, but maybe I haven't tested it enough. If you get a crash in ODPCMAliasBlockFile::WriteSummary()=>sf_open or something similar please let me know.

Michael

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Gale Andrews

Re: Saving for OD checked in

Reply Threaded

| From "Michael Chinen" <mchinen@...>
| Sat, 9 Aug 2008 22:47:36 -0400
| Subject: [Audacity-devel] Saving for OD checked in
> I just checked in the ability to save projects with OD. Also, as more blocks are
> summarized, every now and then a new 'needs save' flag gets reset.

Hi Michael

* The delay after saving before "Save Project" in the File menu
reactivates seems to be about 10 seconds on my machine - is it too
long?

* Saving a project during OD summarising (choosing "Do not copy any
audio") does not cancel the project save - the project is created.
However this problem too was there before OD (e.g. in 1.3.5 release),
so maybe not your remit.

* If you exit when OD is still in progress and there are unsaved changes,
then choose to save the project, Audacity either freezes re-opening
the project, or freezes when trying to click in it (summarising does not
recommence). I replicated this several times and it makes no difference
whether the "save on exit" is the first save or not.

* For me the stripey background is too much like what we had before.
My 2p would be go back to a simple dummy animated waveform like you
were working on, but use the stripey colours. The point of the blue
colours would be to suggest more than the grey did that the
unsummarised region is clickable.

* Thanks for replying again to the user on the Forum who has OD kicking
in when it shouldn't - I was just about to remind you:
http://audacityteam.org/forum/viewtopic.php?f=17&t=5459

I suggested the user try the next nightly build:
http://www.audacity.homerow.net/index.php?dir=mac%2F

This might get you some more feedback before the freeze.

> Also, the orphaned blockfile issue should be gone now.

Seems to be fine if the project is completely summarised when saved.

Thanks

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Michael Chinen

Re: Saving for OD checked in

Reply Threaded

On Sun, Aug 10, 2008 at 5:37 PM, Gale Andrews <gale@...> wrote:

| From "Michael Chinen" <mchinen@...>
| Sat, 9 Aug 2008 22:47:36 -0400
| Subject: [Audacity-devel] Saving for OD checked in

> I just checked in the ability to save projects with OD. Also, as more blocks are
> summarized, every now and then a new 'needs save' flag gets reset.

Hi Michael

* The delay after saving before "Save Project" in the File menu
reactivates seems to be about 10 seconds on my machine - is it too
long?

Not sure. Maybe it is too long. Right now it is set to a minimum of 5% of the wav file.
Perhaps I should make it a constant number of blockfiles?

* Saving a project during OD summarising (choosing "Do not copy any
audio") does not cancel the project save - the project is created.
However this problem too was there before OD (e.g. in 1.3.5 release),
so maybe not your remit.

Yeah, we discussed this and the optimal fix was too much work to do now. The fix doesn't involve OD.

* If you exit when OD is still in progress and there are unsaved changes,
then choose to save the project, Audacity either freezes re-opening
the project, or freezes when trying to click in it (summarising does not
recommence). I replicated this several times and it makes no difference
whether the "save on exit" is the first save or not.

This hasn't happened for me. It seems like a serious bug.
This is what I did, and I wasn't able to recreate it. Can you tell me if you are doing anything besides these steps?:
1.Launch Audacity
2.Open a 2hr wave
3.Wait for 5-10% to load
4.Quit and then select save when it asks about unsaved changes.

5.Relaunch Audacity
6.Open Project.

* For me the stripey background is too much like what we had before.
My 2p would be go back to a simple dummy animated waveform like you
were working on, but use the stripey colours. The point of the blue
colours would be to suggest more than the grey did that the
unsummarised region is clickable.

I'll try to give it some click-appeal, then.

* Thanks for replying again to the user on the Forum who has OD kicking
in when it shouldn't - I was just about to remind you:
http://audacityteam.org/forum/viewtopic.php?f=17&t=5459

I suggested the user try the next nightly build:
http://www.audacity.homerow.net/index.php?dir=mac%2F

This might get you some more feedback before the freeze.

> Also, the orphaned blockfile issue should be gone now.

Seems to be fine if the project is completely summarised when saved.

Should be fine with a save at any time. The problem before was for saves before the summary completes.

Thanks for taking a look at this so quickly!

Michael

Gale Andrews

Re: Saving for OD checked in

Reply Threaded

| From "Michael Chinen" <mchinen@...>
| Sun, 10 Aug 2008 18:17:45 -0400
| Subject: [Audacity-devel] Saving for OD checked in
> On Sun, Aug 10, 2008 at 5:37 PM, Gale Andrews <gale@...> wrote:
> > * The delay after saving before "Save Project" in the File menu
> > reactivates seems to be about 10 seconds on my machine - is it too
> > long?
> >
> Not sure. Maybe it is too long. Right now it is set to a minimum of 5% of
> the wav file. Perhaps I should make it a constant number of blockfiles?

Maybe so. I just tried a 1.5 GB WAV file and I'm waiting 20 seconds
before I can save again.

> > * If you exit when OD is still in progress and there are unsaved changes,
> > then choose to save the project, Audacity either freezes re-opening
> > the project, or freezes when trying to click in it (summarising does not
> > recommence). I replicated this several times and it makes no difference
> > whether the "save on exit" is the first save or not.
>
> This hasn't happened for me. It seems like a serious bug.
> This is what I did, and I wasn't able to recreate it. Can you tell me if
> you are doing anything besides these steps?:
> 1.Launch Audacity
> 2.Open a 2hr wave
> 3.Wait for 5-10% to load
> 4.Quit and then select save when it asks about unsaved changes.
> 5.Relaunch Audacity
> 6.Open Project.

Maddeningly inconclusive. Yesterday the PC had been on some 48 hours
and I could recreate the issue at will with any file. Today on a fresh boot
(using above steps) I am having problems with certain WAVs but not
others, but it is not exactly the same problem.

What is happening replicably today is that if I follow the above steps
1- 6 with file1.WAV, observing the recommenced summarising working
fine, then:

* quit without saving changes
* relaunch and OD import file1.WAV

I get 100% CPU and have to force quit. Relaunch again and repeat OD
import with the same file and the same problem.

If I repeat with file2.WAV, I don't have a problem. If I repeat with file3.WAV,
I do.

So are file1.WAV and file3.WAV corrupt? I don't think so. I never had a
problem with them before, have not edited them for a long time, and they
OD-import perfectly into a 1.3.6a5 ansi debug build from three days ago
straight after failing in current CVS HEAD.

So is the next step to send one of these files that's failing? Smallest
is 748 MB.

> > * For me the stripey background is too much like what we had before.
> > My 2p would be go back to a simple dummy animated waveform like you
> > were working on, but use the stripey colours. The point of the blue
> > colours would be to suggest more than the grey did that the
> > unsummarised region is clickable.
>
> I'll try to give it some click-appeal, then.

Thanks.

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Richard Ash (audacity-help)

Re: Saving for OD checked in

Reply Threaded

On Mon, 2008-08-11 at 19:21 +0100, Gale Andrews wrote:

> | From "Michael Chinen" <mchinen@...>
> | Sun, 10 Aug 2008 18:17:45 -0400
> | Subject: [Audacity-devel] Saving for OD checked in
> > On Sun, Aug 10, 2008 at 5:37 PM, Gale Andrews <gale@...> wrote:
> > > * The delay after saving before "Save Project" in the File menu
> > > reactivates seems to be about 10 seconds on my machine - is it too
> > > long?
> > Not sure. Maybe it is too long. Right now it is set to a minimum of 5% of
> > the wav file. Perhaps I should make it a constant number of blockfiles?
>
> Maybe so. I just tried a 1.5 GB WAV file and I'm waiting 20 seconds
> before I can save again.

I think a fixed number of block files is a good compromise - it's still
to some extent speed controlled because on a slow machine they
blockfiles will go by slower, but it still means that as soon as there
is a worthwhile amount of stuff to save then it becomes save-able.

Richard

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Michael Chinen

Re: Saving for OD checked in

Reply Threaded

In reply to this post by Gale Andrews

On Mon, Aug 11, 2008 at 2:21 PM, Gale Andrews <gale@...> wrote:

| From "Michael Chinen" <mchinen@...>

| Sun, 10 Aug 2008 18:17:45 -0400

| Subject: [Audacity-devel] Saving for OD checked in

> On Sun, Aug 10, 2008 at 5:37 PM, Gale Andrews <gale@...> wrote:

> > * The delay after saving before "Save Project" in the File menu
> > reactivates seems to be about 10 seconds on my machine - is it too
> > long?
> >
> Not sure. Maybe it is too long. Right now it is set to a minimum of 5% of
> the wav file. Perhaps I should make it a constant number of blockfiles?

Maybe so. I just tried a 1.5 GB WAV file and I'm waiting 20 seconds
before I can save again.

> > * If you exit when OD is still in progress and there are unsaved changes,
> > then choose to save the project, Audacity either freezes re-opening
> > the project, or freezes when trying to click in it (summarising does not
> > recommence). I replicated this several times and it makes no difference
> > whether the "save on exit" is the first save or not.
>
> This hasn't happened for me. It seems like a serious bug.
> This is what I did, and I wasn't able to recreate it. Can you tell me if
> you are doing anything besides these steps?:
> 1.Launch Audacity
> 2.Open a 2hr wave
> 3.Wait for 5-10% to load
> 4.Quit and then select save when it asks about unsaved changes.
> 5.Relaunch Audacity
> 6.Open Project.

Maddeningly inconclusive. Yesterday the PC had been on some 48 hours
and I could recreate the issue at will with any file. Today on a fresh boot
(using above steps) I am having problems with certain WAVs but not
others, but it is not exactly the same problem.

What is happening replicably today is that if I follow the above steps
1- 6 with file1.WAV, observing the recommenced summarising working
fine, then:

* quit without saving changes
* relaunch and OD import file1.WAV

I get 100% CPU and have to force quit. Relaunch again and repeat OD
import with the same file and the same problem.

If I repeat with file2.WAV, I don't have a problem. If I repeat with file3.WAV,
I do.

So are file1.WAV and file3.WAV corrupt? I don't think so. I never had a
problem with them before, have not edited them for a long time, and they
OD-import perfectly into a 1.3.6a5 ansi debug build from three days ago
straight after failing in current CVS HEAD.

So is the next step to send one of these files that's failing? Smallest
is 748 MB.

Let me try several of my local waves first - I've only been testing on two files lately.

Michael Chinen

Re: Saving for OD checked in

Reply Threaded

On Mon, Aug 11, 2008 at 3:12 PM, Michael Chinen <mchinen@...> wrote:

On Mon, Aug 11, 2008 at 2:21 PM, Gale Andrews <gale@...> wrote:

| From "Michael Chinen" <mchinen@...>

| Sun, 10 Aug 2008 18:17:45 -0400

| Subject: [Audacity-devel] Saving for OD checked in

> On Sun, Aug 10, 2008 at 5:37 PM, Gale Andrews <gale@...> wrote:

> > * The delay after saving before "Save Project" in the File menu
> > reactivates seems to be about 10 seconds on my machine - is it too
> > long?
> >
> Not sure. Maybe it is too long. Right now it is set to a minimum of 5% of
> the wav file. Perhaps I should make it a constant number of blockfiles?

Maybe so. I just tried a 1.5 GB WAV file and I'm waiting 20 seconds
before I can save again.

> > * If you exit when OD is still in progress and there are unsaved changes,
> > then choose to save the project, Audacity either freezes re-opening
> > the project, or freezes when trying to click in it (summarising does not
> > recommence). I replicated this several times and it makes no difference
> > whether the "save on exit" is the first save or not.
>

Along with Richard's suggestion I made it an arbitrary 18 blockfiles or about a little more than 3 minutes of audio. Of course, if it is stereo, than 18 blockfiles means 1.5 minutes, but the same amount of CPU time. Right now if anyone wants to change it, its in ODComputeSummaryTask.cpp #defined as kNumBlocksPerDoSome

> This hasn't happened for me. It seems like a serious bug.
> This is what I did, and I wasn't able to recreate it. Can you tell me if
> you are doing anything besides these steps?:
> 1.Launch Audacity
> 2.Open a 2hr wave
> 3.Wait for 5-10% to load
> 4.Quit and then select save when it asks about unsaved changes.
> 5.Relaunch Audacity
> 6.Open Project.

Maddeningly inconclusive. Yesterday the PC had been on some 48 hours
and I could recreate the issue at will with any file. Today on a fresh boot
(using above steps) I am having problems with certain WAVs but not
others, but it is not exactly the same problem.

What is happening replicably today is that if I follow the above steps
1- 6 with file1.WAV, observing the recommenced summarising working
fine, then:

* quit without saving changes
* relaunch and OD import file1.WAV

I get 100% CPU and have to force quit. Relaunch again and repeat OD
import with the same file and the same problem.

If I repeat with file2.WAV, I don't have a problem. If I repeat with file3.WAV,
I do.

So are file1.WAV and file3.WAV corrupt? I don't think so. I never had a
problem with them before, have not edited them for a long time, and they
OD-import perfectly into a 1.3.6a5 ansi debug build from three days ago
straight after failing in current CVS HEAD.

So is the next step to send one of these files that's failing? Smallest
is 748 MB.

Let me try several of my local waves first - I've only been testing on two files lately.

Also Gale, you might want to try rebuilding after a clean after I checkin. I moved some virtual functions up and down the hierarchy and xcode couldn't handle it. I just fixed some really weird bugs that made no sense just by doing this. Quiting firefox also gave me a 500% speed increase (not just for Audacity).

On a less related note, I was debugging and I found that we autosave from the very first second. Is this the expected behavior? I'd expect otherwise - it seems wasteful. mLastAutoSaveTime is inited at 0.

I'll be checking this in along with the waveform in a bit.

Gale Andrews

Re: Saving for OD checked in

Reply Threaded

| From "Michael Chinen" <mchinen@...>
| Mon, 11 Aug 2008 16:40:41 -0400
| Subject: [Audacity-devel] Saving for OD checked in

> > On Mon, Aug 11, 2008 at 2:21 PM, Gale Andrews <gale@...>wrote:
> >> > This hasn't happened for me. It seems like a serious bug.
> >> > This is what I did, and I wasn't able to recreate it. Can you tell me
> >> if
> >> > you are doing anything besides these steps?:
> >> > 1.Launch Audacity
> >> > 2.Open a 2hr wave
> >> > 3.Wait for 5-10% to load
> >> > 4.Quit and then select save when it asks about unsaved changes.
> >> > 5.Relaunch Audacity
> >> > 6.Open Project.
> >>
> >> Maddeningly inconclusive. Yesterday the PC had been on some 48 hours
> >> and I could recreate the issue at will with any file. Today on a fresh
> >> boot
> >> (using above steps) I am having problems with certain WAVs but not
> >> others, but it is not exactly the same problem.
> >>
> >> What is happening replicably today is that if I follow the above steps
> >> 1- 6 with file1.WAV, observing the recommenced summarising working
> >> fine, then:
> >>
> >> * quit without saving changes
> >> * relaunch and OD import file1.WAV
> >>
> >> I get 100% CPU and have to force quit. Relaunch again and repeat OD
> >> import with the same file and the same problem.
> >>
> >> If I repeat with file2.WAV, I don't have a problem. If I repeat with
> >> file3.WAV,
> >> I do.
> >>
> >> So are file1.WAV and file3.WAV corrupt? I don't think so. I never had a
> >> problem with them before, have not edited them for a long time, and they
> >> OD-import perfectly into a 1.3.6a5 ansi debug build from three days ago
> >> straight after failing in current CVS HEAD.
> >>
> >> So is the next step to send one of these files that's failing? Smallest
> >> is 748 MB.
> >>
> >
> > Let me try several of my local waves first - I've only been testing on two
> > files lately.
>
> Also Gale, you might want to try rebuilding after a clean after I checkin.
> I moved some virtual functions up and down the hierarchy and xcode couldn't
> handle it. I just fixed some really weird bugs that made no sense just by
> doing this. Quiting firefox also gave me a 500% speed increase (not just
> for Audacity).

After updating I always clean the solution before rebuild.

Firefox brings me down from 400 MB available RAM to 250 MB (but at least
it does not leak like it used to). I did close it and (at the moment) I can now
reopen projects saved during summarising that are aliased to the files that
were suspect, and can OD import those files into Audacity after quitting
and re-launching. I also had "audio cache" enabled in Preferences in error,
but that only uses about 20 MB of RAM for an aliased file.

I get no sense of the files that were OD importing OK when Firefox was
running importing much quicker now that it isn't. And I still don't really
understand when FF was running why a given WAV would fail replicably
in CVS when one of a similar size didn't, and why the file failing in CVS
gave no problem in a slightly less recent build. If I was keeping the CVS
build running I could understand it more, but I was quitting and
re-launching every time.

So I guess no saving bug remaining at the moment that we can quantify,
but can anyone else play with this on Windows? (build here if needed)
http://www.gaclrecords.org.uk/audacity-latest-cvs-ansi.zip

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Gale Andrews

Re: Saving for OD checked in

Reply Threaded

Hi Michael

Apologies if I am getting confused here, but I see on your Wiki progress
page (11 August) items for reinstating the dummy animated waveform on
top of the stripey blocks, plus new files to support FLAC on demand. You
say these are held up because Mac build was broken, but relevant check-ins
were made on the 12th and 14th.

However I'm not seeing the animated waveform unless it's too subtle for
me? This is what I see:
http://www.gaclrecords.org.uk/od.png

I can see a couple of blue (not grey) thin lines slanting between the
stripes (e.g. between 15 and 30 seconds) but they are not animating for
me. Yes I have rebooted.

Do I presume other things are needed before OD is visible for FLAC?

The chap who was getting 100% CPU with the OD Status Bar messages still
has this problem (with an AIFF in a nightly build from 16 August):
http://audacityteam.org/forum/viewtopic.php?f=17&t=5459&st=0&sk=t&sd=a&start=18

I'm not clear if he has the Preference set to read directly or not so I asked
him.

Thanks

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Michael Chinen

Re: Saving for OD checked in

Reply Threaded

Gale,

Yes, FLAC support is not there yet. Only wav support. I thought it a
bad idea to rush it at the last minute. The animated waveform is
really nothing much - it's just that blue line you see moving across
the screen. It's supposed to be a triangle wave, and I thought I
fixed that. It does need some touching up for the long run. The blue
line doesn't move at all for you? I'll take another look.

I don't know about the AIFF/mp3 problem, but could it be a bad file
that audacity handles incorrectly by giving it to the ImportPCM class?
If so we need to fix the error higher up in the chain. OD should
only be for ImportPCM - which I thought was only for 'wavs'. In any
case it needs fixing and I'll try it out.

Michael

On 8/16/08, Gale Andrews <gale@...> wrote:

>
> Hi Michael
>
> Apologies if I am getting confused here, but I see on your Wiki progress
> page (11 August) items for reinstating the dummy animated waveform on
> top of the stripey blocks, plus new files to support FLAC on demand. You
> say these are held up because Mac build was broken, but relevant check-ins
> were made on the 12th and 14th.
>
> However I'm not seeing the animated waveform unless it's too subtle for
> me? This is what I see:
> http://www.gaclrecords.org.uk/od.png
>
> I can see a couple of blue (not grey) thin lines slanting between the
> stripes (e.g. between 15 and 30 seconds) but they are not animating for
> me. Yes I have rebooted.
>
> Do I presume other things are needed before OD is visible for FLAC?
>
> The chap who was getting 100% CPU with the OD Status Bar messages still
> has this problem (with an AIFF in a nightly build from 16 August):
> http://audacityteam.org/forum/viewtopic.php?f=17&t=5459&st=0&sk=t&sd=a&start=18
>
> I'm not clear if he has the Preference set to read directly or not so I
> asked
> him.
>
>
> Thanks
>
> Gale
>
>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> audacity-devel mailing list
> audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>