Resized About Dialog WAS: Re: Beta_Feedback

3 messages Options
Embed this post
Permalink
Gale (Audacity Team)

Resized About Dialog WAS: Re: Beta_Feedback

Reply Threaded More More options
Print post
Permalink

| From "Ed Musgrove" <[hidden email]>
| Sun, 25 Oct 2009 23:37:05 -0700
| Subject: [Audacity-devel] Beta_Feedback
> ... Vaguely related, I gave Gale working code which makes the
> Help/About... panel user resizable. (it is a trivial one line change). BTW,
> is there a problem or reason why that was never committed (patch attached)?

I was going to write about this but had not had time yet. I'm fine with
the change, and it works for me on Windows XP and Linux. Have you
asked someone to test it on Mac, or does that standard Widgets code
always work OK there?

I'd agree it's trivial, but I thought I'd better err on the side of caution
just in case anyone feels strongly against. Can't imagine why they
would, as all the other similar dialogues (Welcome, Show Log, Benchmark,
Audio Device) are resizable. Have I missed any that are not resizable?


Code in line below.  



Gale


Index: AboutDialog.cpp
===================================================================
RCS file: /cvsroot/audacity/audacity-src/src/AboutDialog.cpp,v
retrieving revision 1.73
diff -u -r1.73 AboutDialog.cpp
--- AboutDialog.cpp 20 Oct 2009 23:08:26 -0000 1.73
+++ AboutDialog.cpp 26 Oct 2009 06:32:10 -0000
@@ -157,7 +157,8 @@
 
 AboutDialog::AboutDialog(wxWindow * parent)
    :  wxDialog(parent, -1, _("About Audacity..."),
-               wxDefaultPosition, wxDefaultSize)
+               wxDefaultPosition, wxDefaultSize,
+               wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER)
 {
    this->SetBackgroundColour(theTheme.Colour( clrAboutBoxBackground ));
    icon = NULL;

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Al Dimond

Re: Resized About Dialog WAS: Re: Beta_Feedback

Reply Threaded More More options
Print post
Permalink
On Monday 26 October 2009 15:15:22 Gale Andrews wrote:

> | From "Ed Musgrove" <[hidden email]>
> | Sun, 25 Oct 2009 23:37:05 -0700
> | Subject: [Audacity-devel] Beta_Feedback
> |
> > ... Vaguely related, I gave Gale working code which makes the
> > Help/About... panel user resizable. (it is a trivial one line
> > change). BTW, is there a problem or reason why that was never
> > committed (patch attached)?
>
> I was going to write about this but had not had time yet. I'm fine
>  with the change, and it works for me on Windows XP and Linux. Have
>  you asked someone to test it on Mac, or does that standard Widgets
>  code always work OK there?
>

I tried it on Mac and it looks fine.

 - Al

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Ed Musgrove-2

Re: Resized About Dialog WAS: Re: Beta_Feedback

Reply Threaded More More options
Print post
Permalink
In reply to this post by Gale (Audacity Team)
Al replied and tested on Mac. I cannot imagine a problem.

-----Original Message-----
From: Gale Andrews [mailto:[hidden email]]
Sent: Monday, October 26, 2009 2:15 PM
To: [hidden email]
Subject: [Audacity-devel] Resized About Dialog WAS: Re: Beta_Feedback


| From "Ed Musgrove" <[hidden email]> Sun, 25 Oct 2009
| 23:37:05 -0700
| Subject: [Audacity-devel] Beta_Feedback
> ... Vaguely related, I gave Gale working code which makes the
> Help/About... panel user resizable. (it is a trivial one line change).
> BTW, is there a problem or reason why that was never committed (patch
attached)?

I was going to write about this but had not had time yet. I'm fine with the
change, and it works for me on Windows XP and Linux. Have you asked someone
to test it on Mac, or does that standard Widgets code always work OK there?

I'd agree it's trivial, but I thought I'd better err on the side of caution
just in case anyone feels strongly against. Can't imagine why they would, as
all the other similar dialogues (Welcome, Show Log, Benchmark, Audio Device)
are resizable. Have I missed any that are not resizable?


Code in line below.  



Gale


Index: AboutDialog.cpp
===================================================================
RCS file: /cvsroot/audacity/audacity-src/src/AboutDialog.cpp,v
retrieving revision 1.73
diff -u -r1.73 AboutDialog.cpp
--- AboutDialog.cpp 20 Oct 2009 23:08:26 -0000 1.73
+++ AboutDialog.cpp 26 Oct 2009 06:32:10 -0000
@@ -157,7 +157,8 @@
 
 AboutDialog::AboutDialog(wxWindow * parent)
    :  wxDialog(parent, -1, _("About Audacity..."),
-               wxDefaultPosition, wxDefaultSize)
+               wxDefaultPosition, wxDefaultSize,
+               wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER)
 {
    this->SetBackgroundColour(theTheme.Colour( clrAboutBoxBackground ));
    icon = NULL;

----------------------------------------------------------------------------
--
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel