{READABLE_STRING_nn}.is_real

4 messages Options
Embed this post
Permalink
Colin Paul Adams

{READABLE_STRING_nn}.is_real

Reply Threaded More More options
Print post
Permalink
Why does this just call is_double? It gives false positives.
--
Colin Adams
Preston Lancashire

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
freeelks-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freeelks-devel
Emmanuel Stapf

Re: {READABLE_STRING_nn}.is_real

Reply Threaded More More options
Print post
Permalink
> Why does this just call is_double? It gives false positives.

Most likely because the old code used to call `is_double' since it could not do
bounce checking. So the new code preserve the same behavior. Using `is_real' might
break some existing code though, if you can verify that it works fine for your
code base and for others, maybe we can switch without causing any trouble.

Regards,
Manu


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
freeelks-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freeelks-devel
------------------------------------------------------------------------  
Eiffel Software
805-685-1006
http://www.eiffel.com       
Customer support: http://support.eiffel.com       
User group: http://groups.eiffel.com/join       
------------------------------------------------------------------------  
Emmanuel Stapf

Re: {READABLE_STRING_nn}.is_real

Reply Threaded More More options
Print post
Permalink
For clarification, I meant overflow/underflow issue.

Manu

> -----Original Message-----
> From: Emmanuel Stapf [ES] [mailto:[hidden email]]
> Sent: Wednesday, September 24, 2008 11:44 AM
> To: 'Colin Paul Adams'; [hidden email]
> Subject: Re: [freeelks-devel] {READABLE_STRING_nn}.is_real
>
> > Why does this just call is_double? It gives false positives.
>
> Most likely because the old code used to call `is_double' since it could
> not do
> bounce checking. So the new code preserve the same behavior. Using
> `is_real' might
> break some existing code though, if you can verify that it works fine for
> your
> code base and for others, maybe we can switch without causing any
> trouble.
>
> Regards,
> Manu
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the
> world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> freeelks-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/freeelks-devel


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
freeelks-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freeelks-devel
------------------------------------------------------------------------  
Eiffel Software
805-685-1006
http://www.eiffel.com       
Customer support: http://support.eiffel.com       
User group: http://groups.eiffel.com/join       
------------------------------------------------------------------------  
Emmanuel Stapf

Re: {READABLE_STRING_nn}.is_real

Reply Threaded More More options
Print post
Permalink
Actually after careful reading of the code, I thought the convertor did
overflow/underflow checking for reals but currently does not. Therefore `is_real'
and `is_double' can only have the same implementation which means that you may not
get what you want. If one wants to have a look at STRING_TO_REAL_CONVERTOR to
perform the check that would be great.

Regards,
Manu

> -----Original Message-----
> From: Emmanuel Stapf [ES] [mailto:[hidden email]]
> Sent: Wednesday, September 24, 2008 1:48 PM
> To: [hidden email]; 'Colin Paul Adams'; freeelks-
> [hidden email]
> Subject: RE: [freeelks-devel] {READABLE_STRING_nn}.is_real
>
> For clarification, I meant overflow/underflow issue.
>
> Manu
>
> > -----Original Message-----
> > From: Emmanuel Stapf [ES] [mailto:[hidden email]]
> > Sent: Wednesday, September 24, 2008 11:44 AM
> > To: 'Colin Paul Adams'; [hidden email]
> > Subject: Re: [freeelks-devel] {READABLE_STRING_nn}.is_real
> >
> > > Why does this just call is_double? It gives false positives.
> >
> > Most likely because the old code used to call `is_double' since it
> could
> > not do
> > bounce checking. So the new code preserve the same behavior. Using
> > `is_real' might
> > break some existing code though, if you can verify that it works fine
> for
> > your
> > code base and for others, maybe we can switch without causing any
> > trouble.
> >
> > Regards,
> > Manu
> >
> >
> > -----------------------------------------------------------------------
> --
> > This SF.Net email is sponsored by the Moblin Your Move Developer's
> > challenge
> > Build the coolest Linux based applications with Moblin SDK & win great
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the
> > world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > freeelks-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/freeelks-devel



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
freeelks-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freeelks-devel
------------------------------------------------------------------------  
Eiffel Software
805-685-1006
http://www.eiffel.com       
Customer support: http://support.eiffel.com       
User group: http://groups.eiffel.com/join       
------------------------------------------------------------------------