Product install regression?
|
| 1 2 |
|
|
||||||||
|
|
|
||||||||
|
|
||||||||
|
In reply to this post
by Alexander Limi
|
||||||||
|
On Dec 5, 2007, at 10:36 AM, Wichert Akkerman wrote:
> Previously Alexander Limi wrote: >> What's interesting is that this product works on an existing >> instance of >> Plone 3.0.2 hosted on a different server. So it's either a) a >> regression, >> b) my instance is screwed up. > > Or c) what used to result in a silent but nasty problem now results > in a > proper exception. And looking at that error message you are indeed > trying to set the context to "", which is obviously invalid. apply the current state (or maybe the latest snapshot?), which did help when populating a test layer with some content (to avoid creating that content for every single test). for example the linkintegrity test layer contains the following code: # apply plone profile to register local utilities etc setup_tool = portal.portal_setup setup_tool.setImportContext('') # pass empty id to re- apply current state (snapshot) setup_tool.runAllImportSteps() without it some registrations are missing making the tests fail, which is also the case now that the call to `setImportContext` produces an exception... :) so my question is, what is the best practice here to still be able to use a layer? or do i need to drop the layer again and move things back to `afterSetup`, effectively making the tests run twice as slow? cheers, andi -- zeidler it consulting - http://zitc.de/ - [hidden email] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.3 released! -- http://plone.org/products/plone ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ Plone-developers mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/plone-developers |
||||||||
PGP.sig (193 bytes) |
|
|
||||||||
|
|
On Dec 5, 2007, at 12:17 PM, Wichert Akkerman wrote:
> Previously Andreas Zeidler wrote: >> # apply plone profile to register local utilities etc >> setup_tool = portal.portal_setup >> setup_tool.setImportContext('') # pass empty id to re- >> apply current state (snapshot) >> setup_tool.runAllImportSteps() > > That killed the base profile in all versions of Plone 3. It has never > been a valid thing to do. yes, it sure looked nasty, but i ran into that code when looking into ways of moving the creation of sample content onto the layer, and it worked... :) > I'm not sure what 're-apply the current state' > would even do. and I feel I know GS reasonably well by now :) well, this is why i'm asking you, isn't it? :) anyway, it did the trick — without it stuff from the portal was missing at that stage, i.e. utilities etc. > I don't know what your exact needs are. i'd like to create some sample content to test linkintegrity with, and i don't want to put that into `afterSetUp`, since this would repeat it for every single test making things much slower. a quick look at http://dev.plone.org/plone/browser/plone.app.linkintegrity/tags/1.0.2/plone/app/linkintegrity/tests/layer.py should give you the basic idea. i thought that was one of the original motivations for using layers, but maybe i got that wrong. i completely agree that needing this hack to make it work is indeed nasty, and i'd also like to do this in a saner way, but how? what's the best practice of using a layer to create sample content for your tests? > If you want to make sure your > steps are registered you can use applyContext(context_id). If you want > to import steps from a profile you use runAllImportStepsFromProfile. neither seems to do the same — i've spent the last 1.5 hours trying various things like that, but no luck. :) andi -- zeidler it consulting - http://zitc.de/ - [hidden email] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.3 released! -- http://plone.org/products/plone ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ Plone-developers mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/plone-developers |
||||||||
|
|
||||||||
|
|
On Dec 5, 2007, at 1:11 PM, Raphael Ritz wrote:
>> neither seems to do the same — i've spent the last 1.5 hours trying >> various things like that, but no luck. :) > > keep us updated on any progress or feedback you get on this. > I for sure would be interested in an answer to this as well. so it turns out the test failures i was getting weren't due to the now unsupported hack to re-apply the current profile, but due to alec's changes in r18239. in fact, the test layer works nicely without the hack, and consequently it's gone now (see r18303). however, with CMFPlone newer than r18238 linkintegrity tests still fail, but i kinda feel it's not really my responsibility to fix that, is it? :) cheers, andi -- zeidler it consulting - http://zitc.de/ - [hidden email] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.3 released! -- http://plone.org/products/plone ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ Plone-developers mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/plone-developers |
||||||||
|
|
On Dec 5, 2007, at 2:16 PM, Andreas Zeidler wrote:
> however, with CMFPlone newer than r18238 linkintegrity tests still > fail, but i kinda feel it's not really my responsibility to fix > that, is it? :) ah well, fixed in r18304 :) > cheers, > > > andi ps: i guess since the linkintegrity package is part of plone now it's okay to import from it, right? -- zeidler it consulting - http://zitc.de/ - [hidden email] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.3 released! -- http://plone.org/products/plone ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ Plone-developers mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/plone-developers |
||||||||
|
|
|
||||||||
|
|
On Dec 5, 2007, at 2:45 PM, Wichert Akkerman wrote:
> Andreas Zeidler wrote: >> ps: i guess since the linkintegrity package is part of plone now >> it's okay to import from it, right? > > For plone.app that is fine. For Plone 4 you'll have to add a > dependency on Products.CMFPlone if you do that. it's already in the `install_requires` of `Products.CMFPlone`, but do you think we should start adding minimal versions there? andi -- zeidler it consulting - http://zitc.de/ - [hidden email] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.3 released! -- http://plone.org/products/plone ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ Plone-developers mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/plone-developers |
||||||||
|
|
|
||||||||
|
|
On Dec 5, 2007, at 3:10 PM, Wichert Akkerman wrote:
> Yes. No exact pinning, but minimum versions if they are indeed > required > should be there. +1 and fixed in r18306. andi -- zeidler it consulting - http://zitc.de/ - [hidden email] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.3 released! -- http://plone.org/products/plone ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ Plone-developers mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/plone-developers |
||||||||
|
|
In reply to this post
by Wichert Akkerman
|
||||||||
|
|
On Dec 5, 2007, at 6:07 PM, Alexander Limi wrote:
> As an end-user, this is a regression from earlier 3.0.x versions, > and at > least needs a recommended way to fix it. It's not obvious what to do > at > this point. the following patch fixes the problem in alex' case: ---------- snip ---------- diff -rU5 Downloads/ConceptCards/Extensions/Install.py products/ ConceptCards/Extensions/Install.py --- Downloads/ConceptCards/Extensions/Install.py 2007-11-20 23:13:59.000000000 +0100 +++ products/ConceptCards/Extensions/Install.py 2007-12-05 21:04:50.000000000 +0100 @@ -132,14 +132,11 @@ else: print >>out,'no output' else: print >>out,'no custom install' setup_tool = getToolByName(portal, 'portal_setup') - old_context = setup_tool.getImportContextID() - setup_tool.setImportContext('profile-ConceptCards:default') - setup_tool.runAllImportSteps() - setup_tool.setImportContext(old_context) + setup_tool.runAllImportStepsFromProfile('profile- ConceptCards:default') print >> out, "Ran all GS import steps." return out.getvalue() def uninstall(self, reinstall=False): ---------- snip ---------- > Can it be fixed in AGX, or is the error elsewhere? agx should probably be updated, since most of the removed function calls are now deprecated. > Even if it can be fixed > in AGX, it's a bit scary that products that were working earlier stop > working in a minor release, no matter how "correct" it is. that's true. imho, GS should gracefully handle an empty context id for a little longer, even though the deprecation warnings have probably been around a while... andi -- zeidler it consulting - http://zitc.de/ - [hidden email] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.3 released! -- http://plone.org/products/plone ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ Plone-developers mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/plone-developers |
||||||||
|
|
In reply to this post
by Alexander Limi
|
||||||||
|
|
|
||||||||
|
|
In reply to this post
by Alec Mitchell
|
||||||||
|
In reply to this post
by Raphael Ritz
|
||||||||
| Free Embeddable Forum Powered by Nabble | Help |
