Plone 3.3 status

[Wichert Akkerman]

I am very happy to see that almost all blocked bugs for Plone 3.3 have
been fixes. Hopefully Duncan will be able to make a new Kupu release
this week, after which only two blocker bugs will remain:

7794 - http://dev.plone.org/old/plone/ticket/7794
Content based language negotation does not work with virtual hosting.
Release critical since the feature is new to Plone 3.3. Since this is
turning out to be a complex problem I have asked Hanno to remove the
content negotiation feature again. Unless someone comes up with a fix
this weekend of course!

9348 - http://dev.plone.org/old/plone/ticket/9348
A new bug for the Windows installer. Since I do not use Windows myself I
need some help triaging this bug, and someone needs to fix it. Since
Sidnei is very busy on other tasks lately I am hoping someone else will
step in to help with the Windows installer.

Wichert.

--
Wichert Akkerman <[hidden email]>   It is simple to make things.
http://www.wiggy.net/                  It is hard to make things simple.

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Daniel Kraft-5]

Hi Wichert,

> 7794 - http://dev.plone.org/old/plone/ticket/7794
> Content based language negotation does not work with virtual hosting.
> Release critical since the feature is new to Plone 3.3. Since this is
> turning out to be a complex problem I have asked Hanno to remove the
> content negotiation feature again. Unless someone comes up with a fix
> this weekend of course!

375             rootpath =
self.REQUEST.physicalPathFromURL(self.REQUEST.get("URL",""))
376             contentpath = self.REQUEST.get('PATH_TRANSLATED').split("/")
377             try:
378                 i1 = contentpath.index("VirtualHostBase")
379                 i2 = contentpath.index("VirtualHostRoot")
380                 del(contentpath[i1:i2+1])
381             except ValueError:
382                 pass
383             contentpath = "%s%s" % ("/".join(rootpath),
"/".join(contentpath))


I see that this fix isn't very beautiful, and maybe the path logic
should be moved into the VHM itslef. But I think, better use that and
comment # XXX: SHOULD BE BAUTIFIED! instead of removing this wonderful
feature.

This fix was successfully tested in several live environments - with and
without VHM.

Daniel


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Mikel Larreategi]

Daniel Kraft(e)k dio:

> Hi Wichert,
>
>> 7794 - http://dev.plone.org/old/plone/ticket/7794
>> Content based language negotation does not work with virtual hosting.
>> Release critical since the feature is new to Plone 3.3. Since this is
>> turning out to be a complex problem I have asked Hanno to remove the
>> content negotiation feature again. Unless someone comes up with a fix
>> this weekend of course!
>
> 375             rootpath =
> self.REQUEST.physicalPathFromURL(self.REQUEST.get("URL",""))
> 376             contentpath = self.REQUEST.get('PATH_TRANSLATED').split("/")
> 377             try:
> 378                 i1 = contentpath.index("VirtualHostBase")
> 379                 i2 = contentpath.index("VirtualHostRoot")
> 380                 del(contentpath[i1:i2+1])
> 381             except ValueError:
> 382                 pass
> 383             contentpath = "%s%s" % ("/".join(rootpath),
> "/".join(contentpath))
>
>
> I see that this fix isn't very beautiful, and maybe the path logic
> should be moved into the VHM itslef. But I think, better use that and
> comment # XXX: SHOULD BE BAUTIFIED! instead of removing this wonderful
> feature.
>
> This fix was successfully tested in several live environments - with and
> without VHM.
>

Hi:


The point is that it doesn't work when you have folder with
INavigationRoot set and using VirtualHosting to point a domain to that
folder.


Mikel

--
Mikel Larreategi
[hidden email]

CodeSyntax
Azitaingo Industrialdea 3 K
E-20600 Eibar
Tel: [phone]


------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers

[Hanno Schlichting-4]

On Sat, Jul 4, 2009 at 1:24 PM, Wichert Akkerman<[hidden email]> wrote:
> 7794 - http://dev.plone.org/old/plone/ticket/7794
> Content based language negotation does not work with virtual hosting.
> Release critical since the feature is new to Plone 3.3. Since this is
> turning out to be a complex problem I have asked Hanno to remove the
> content negotiation feature again. Unless someone comes up with a fix
> this weekend of course!

As of http://dev.plone.org/plone/ticket/7794#comment:17 I noted this
as a known incompatibility and added tests for the situations where
this feature works and where it doesn't.

I couldn't decipher the patch Daniel sent as it lacked any sort of
context and certainly wasn't against trunk. At least in the testing
environment I couldn't find any way to make this feature work in
situations where the virtual host base is not the Plone site root. If
someone is able to find a non-hackish way to make things work
*including* tests to show this, I'm happy to revert the note.

Given that exposing the Plone site root is still the most common
situation, I think it is fine to let the feature stay in and point out
the incompatibility. This is released as PLT 3.0.2 now to PyPi and
updated in plonenext/3.3.

Hanno

------------------------------------------------------------------------------
_______________________________________________
Plone-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/plone-developers