Please review new RFC 22 - Enhance expression engine CONCAT function

[Orest Halustchak]

Some javascript/style in this post has been disabled (why?)

Hi,

 

The CONCAT function in the FDO expression language is difficult to use in many cases because it supports only two parameters. If you need to concatenate a set of more than two strings, you have to use nested calls which is not convenient and error prone.

 

RFC 22, drafted by Dan Stoica, proposes to support a variable set of parameters for this function to make it easier to use.

 

http://trac.osgeo.org/fdo/wiki/FDORfc22

 

Have a look at the RFC and provide your comments.

 

Thanks,

Orest.

 

_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

[Jason Birch]

Some javascript/style in this post has been disabled (why?)

No opinion on the implementation, but +900 on the idea :)

---

From: [hidden email] <[hidden email]>
To: FDO Internals Mail List <[hidden email]>
Sent: Tue Jul 14 11:15:55 2009
Subject: [fdo-internals] Please review new RFC 22 - Enhance expression engine CONCAT function

Hi,

 

The CONCAT function in the FDO expression language is difficult to use in many cases because it supports only two parameters. If you need to concatenate a set of more than two strings, you have to use nested calls which is not convenient and error prone.

 

RFC 22, drafted by Dan Stoica, proposes to support a variable set of parameters for this function to make it easier to use.

 

http://trac.osgeo.org/fdo/wiki/FDORfc22

 

Have a look at the RFC and provide your comments.

 

Thanks,

Orest.

 

_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

[Jackie Ng]

Would there be any noticeable difference in performance between the current CONCAT and the proposed CONCAT?

- Jackie

Orest Halustchak wrote:

Hi,

The CONCAT function in the FDO expression language is difficult to use in many cases because it supports only two parameters. If you need to concatenate a set of more than two strings, you have to use nested calls which is not convenient and error prone.

RFC 22, drafted by Dan Stoica, proposes to support a variable set of parameters for this function to make it easier to use.

http://trac.osgeo.org/fdo/wiki/FDORfc22

Have a look at the RFC and provide your comments.

Thanks,
Orest.


_______________________________________________
fdo-internals mailing list
[e-mail]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

[Dan Stoica]

Definitely the performance will be better because significant overhead will be skipped. Now, how noticeable this boost will be I don't know, until you vote +901 :-)

Dan.

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Tuesday, July 14, 2009 8:37 PM
To: [hidden email]
Subject: Re: [fdo-internals] Please review new RFC 22 - Enhance expression engine CONCAT function


Would there be any noticeable difference in performance between the current
CONCAT and the proposed CONCAT?

- Jackie


Orest Halustchak wrote:

>
> Hi,
>
> The CONCAT function in the FDO expression language is difficult to use in
> many cases because it supports only two parameters. If you need to
> concatenate a set of more than two strings, you have to use nested calls
> which is not convenient and error prone.
>
> RFC 22, drafted by Dan Stoica, proposes to support a variable set of
> parameters for this function to make it easier to use.
>
> http://trac.osgeo.org/fdo/wiki/FDORfc22
>
> Have a look at the RFC and provide your comments.
>
> Thanks,
> Orest.
>
>
> _______________________________________________
> fdo-internals mailing list
> [hidden email]
> http://lists.osgeo.org/mailman/listinfo/fdo-internals
>
>

--
View this message in context: http://n2.nabble.com/Please-review-new-RFC-22---Enhance-expression-engine-CONCAT-function-tp3258502p3260184.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

[Jackie Ng]

Going to slightly deviate from the discussion here:

Do you foresee new expression functions in the future that would look like this:

MyVariableArgumentFunction(arg1, arg2, ...)

where there are actual defined arguments, followed by a variable argument list?

It would seem that the proposed FdoFunctionDefinition wouldn't handle such a scenario should it arise in the future.

- Jackie

Orest Halustchak wrote:

Hi,

The CONCAT function in the FDO expression language is difficult to use in many cases because it supports only two parameters. If you need to concatenate a set of more than two strings, you have to use nested calls which is not convenient and error prone.

RFC 22, drafted by Dan Stoica, proposes to support a variable set of parameters for this function to make it easier to use.

http://trac.osgeo.org/fdo/wiki/FDORfc22

Have a look at the RFC and provide your comments.

Thanks,
Orest.


_______________________________________________
fdo-internals mailing list
[e-mail]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

[Orest Halustchak]

Hi Jackie,

The change to FdoFunctionDefinition allows the last parameter to repeat a variable number of times.

Thanks,
Orest.

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Tuesday, July 14, 2009 11:57 PM
To: [hidden email]
Subject: Re: [fdo-internals] Please review new RFC 22 - Enhance expression engine CONCAT function


Going to slightly deviate from the discussion here:

Do you foresee new expression functions in the future that would look like
this:

MyVariableArgumentFunction(arg1, arg2, ...)

where there are actual defined arguments, followed by a variable argument
list?

It would seem that the proposed FdoFunctionDefinition wouldn't handle such a
scenario should it arise in the future.

- Jackie


Orest Halustchak wrote:

>
> Hi,
>
> The CONCAT function in the FDO expression language is difficult to use in
> many cases because it supports only two parameters. If you need to
> concatenate a set of more than two strings, you have to use nested calls
> which is not convenient and error prone.
>
> RFC 22, drafted by Dan Stoica, proposes to support a variable set of
> parameters for this function to make it easier to use.
>
> http://trac.osgeo.org/fdo/wiki/FDORfc22
>
> Have a look at the RFC and provide your comments.
>
> Thanks,
> Orest.
>
>
> _______________________________________________
> fdo-internals mailing list
> [hidden email]
> http://lists.osgeo.org/mailman/listinfo/fdo-internals
>
>

--
View this message in context: http://n2.nabble.com/Please-review-new-RFC-22---Enhance-expression-engine-CONCAT-function-tp3258502p3260997.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals