[Patch]correct the launch order of scim x11 frontend and socket server.

2 messages Options
Embed this post
Permalink
Peng Wu

[Patch]correct the launch order of scim x11 frontend and socket server.

Reply Threaded More More options
Print post
Permalink
Hi Ryo,
  Previously I made a patch for scim-bridge to launch the x11 frontend
of scim. But that time I just add the code, and it works fine.
  But this is a bug in the previous patch, the scim x11 frontend is
launched before the scim socket server. So another bug appears, the x11
frontend can't connect to scim socket server. X11 frontend can't provide
im engines for X11 applications like OpenOffice.
  We got this bug
report(https://bugzilla.novell.com/show_bug.cgi?id=465111). So I change
the patch to launch scim socket server first, then x11 frontend, solved
the new bug.
  The patch is contained in attachment.
Best Wishes,
  Peng Wu


Index: scim-bridge-0.4.15/agent/scim-bridge-agent.cpp
===================================================================
--- scim-bridge-0.4.15.orig/agent/scim-bridge-agent.cpp
+++ scim-bridge-0.4.15/agent/scim-bridge-agent.cpp
@@ -455,12 +455,6 @@ retval_t ScimBridgeAgentImpl::initialize
         return RETVAL_FAILED;
     }
     
-    {
-     scim_bridge_pdebugln (8, "Launching a SCIM daemon with x11 FrontEnd...");
-     char *new_argv [] = {"--no-stay","-d", NULL};
-     scim_launch (true, "socket", "socket", "x11", new_argv);
-    }
-
     // If there is no socket frontend running, launch one.
     if (!is_socket_frontend_ready ()) {
         scim_bridge_pdebugln (8, "Launching a SCIM daemon with Socket FrontEnd...");
@@ -480,7 +474,13 @@ retval_t ScimBridgeAgentImpl::initialize
             }
         }
     }
-    
+
+    {
+        scim_bridge_pdebugln (8, "Launching a SCIM daemon with x11 FrontEnd...");
+        char *new_argv [] = {"--no-stay","-d", NULL};
+        scim_launch (true, "socket", "socket", "x11", new_argv);
+    }
+
     // load config module
     scim_bridge_pdebugln (2, "Loading Config module...: socket");
     scim_config_module = new ConfigModule ("socket");

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Scim-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/scim-devel
Ryo Dairiki-2

Re: [Patch]correct the launch order of scim x11 frontend and socket server.

Reply Threaded More More options
Print post
Permalink
Now this patch has been applied on svn latest.

Ryo

Peng Wu wrote:

> Hi Ryo,
>   Previously I made a patch for scim-bridge to launch the x11 frontend
> of scim. But that time I just add the code, and it works fine.
>   But this is a bug in the previous patch, the scim x11 frontend is
> launched before the scim socket server. So another bug appears, the x11
> frontend can't connect to scim socket server. X11 frontend can't provide
> im engines for X11 applications like OpenOffice.
>   We got this bug
> report(https://bugzilla.novell.com/show_bug.cgi?id=465111). So I change
> the patch to launch scim socket server first, then x11 frontend, solved
> the new bug.
>   The patch is contained in attachment.
> Best Wishes,
>   Peng Wu
>
>  
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by:
> SourcForge Community
> SourceForge wants to tell your story.
> http://p.sf.net/sfu/sf-spreadtheword
> ------------------------------------------------------------------------
>
> _______________________________________________
> Scim-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/scim-devel


------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Scim-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/scim-devel