Patch: Issue 549 - UniqueIdentifier Fields not working in SQL Server Spatial
|
| 1 2 |
|
Some javascript/style in this post has been disabled (why?)
Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||
FDO-Issue549-SqlSpatialUniqueIdentifierFields.patch (904 bytes)
|
Some javascript/style in this post has been disabled (why?)
Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID : a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||
|
|
Some javascript/style in this post has been disabled (why?)
Ok, I must have missed that, I
think I must have been looking at something equivalent to the release of 3.4. Is there a patched/released
version of 3.4 with this in it? (3.4.1?) Or do I need to compile separately. We need to build a version of
3.4 with both of these changes in it, and I see all sorts of changes committed
to the 3.4 branch – where was the release version of 3.4 built from? All of
the stuff that has been committed to the branch – has that been re-compiled and
re-released? Is this what 3.4.1 is?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email] [mailto:[hidden email]]
On Behalf Of Chris Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||
|
Some javascript/style in this post has been disabled (why?)
Today, FDO 3.4.1 was uploaded
to: http://fdo.osgeo.org/content/fdo-341-downloads Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Ok, I must have missed that, I
think I must have been looking at something equivalent to the release of 3.4. Is there a patched/released
version of 3.4 with this in it? (3.4.1?) Or do I need to compile separately. We need to build a version of
3.4 with both of these changes in it, and I see all sorts of changes committed
to the 3.4 branch – where was the release version of 3.4 built from? All
of the stuff that has been committed to the branch – has that been re-compiled
and re-released? Is this what 3.4.1 is?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||
|
|
Some javascript/style in this post has been disabled (why?)
This upload can be considered Release
Candidate 1. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Today, FDO 3.4.1 was uploaded
to: http://fdo.osgeo.org/content/fdo-341-downloads Greg From:
[hidden email] [mailto:[hidden email]]
On Behalf Of Chris Erickson Ok, I must have missed that, I
think I must have been looking at something equivalent to the release of 3.4. Is there a patched/released
version of 3.4 with this in it? (3.4.1?) Or do I need to compile separately. We need to build a version of
3.4 with both of these changes in it, and I see all sorts of changes committed
to the 3.4 branch – where was the release version of 3.4 built from? All
of the stuff that has been committed to the branch – has that been re-compiled
and re-released? Is this what 3.4.1 is?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||
|
|
Some javascript/style in this post has been disabled (why?)
There was a fix done to support
uniqueidentifier columns on Mar. 24 but it was only applied to the trunk and was
not backported to 3.4. At the moment, you’d have to do a separate compile
to get it into a 3.4 provider. I’m not sure if the fix could
still be backported to 3.4. Greg would have a better idea. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone This upload can be considered
Release Candidate 1. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Today, FDO 3.4.1 was uploaded
to: http://fdo.osgeo.org/content/fdo-341-downloads Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Ok, I must have missed that, I
think I must have been looking at something equivalent to the release of 3.4. Is there a patched/released
version of 3.4 with this in it? (3.4.1?) Or do I need to compile separately. We need to build a version of
3.4 with both of these changes in it, and I see all sorts of changes committed
to the 3.4 branch – where was the release version of 3.4 built
from? All of the stuff that has been committed to the branch – has
that been re-compiled and re-released? Is this what 3.4.1 is?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From: [hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to
work. Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||
|
|
In reply to this post
by Greg Boone
Some javascript/style in this post has been disabled (why?)
Greg, Where is this from in SRC? Is
it the top of the 3.4 branch?
From: [hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone This upload can be considered
Release Candidate 1. From: [hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Today, FDO 3.4.1 was uploaded
to: http://fdo.osgeo.org/content/fdo-341-downloads Greg From:
[hidden email] [mailto:[hidden email]]
On Behalf Of Chris Erickson Ok, I must have missed that, I think
I must have been looking at something equivalent to the release of 3.4. Is there a patched/released
version of 3.4 with this in it? (3.4.1?) Or do I need to compile separately. We need to build a version of
3.4 with both of these changes in it, and I see all sorts of changes committed
to the 3.4 branch – where was the release version of 3.4 built from? All
of the stuff that has been committed to the branch – has that been re-compiled
and re-released? Is this what 3.4.1 is?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file (line
187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||||
|
|
In reply to this post
by Brent Robinson
Some javascript/style in this post has been disabled (why?)
Ahh, So, I guess my request is to
backport that to this 3.4.1 version so it would be in the release…along with
the other patch I submitted. Is that possible?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson There was a fix done to support
uniqueidentifier columns on Mar. 24 but it was only applied to the trunk and
was not backported to 3.4. At the moment, you’d have to do a separate compile
to get it into a 3.4 provider. I’m not sure if the fix could still
be backported to 3.4. Greg would have a better idea. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone This upload can be considered
Release Candidate 1. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Today, FDO 3.4.1 was uploaded
to: http://fdo.osgeo.org/content/fdo-341-downloads Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Ok, I must have missed that, I
think I must have been looking at something equivalent to the release of 3.4. Is there a patched/released version
of 3.4 with this in it? (3.4.1?) Or do I need to compile separately. We need to build a version of
3.4 with both of these changes in it, and I see all sorts of changes committed
to the 3.4 branch – where was the release version of 3.4 built from? All
of the stuff that has been committed to the branch – has that been re-compiled
and re-released? Is this what 3.4.1 is?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file (line
187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||||
|
|
In reply to this post
by Chris Erickson-2
Some javascript/style in this post has been disabled (why?)
Yes, which is label G054. Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Greg, Where is this from in SRC?
Is it the top of the 3.4 branch?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone This upload can be considered
Release Candidate 1. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Today, FDO 3.4.1 was uploaded
to: http://fdo.osgeo.org/content/fdo-341-downloads Greg From:
[hidden email] [mailto:[hidden email]]
On Behalf Of Chris Erickson Ok, I must have missed that, I
think I must have been looking at something equivalent to the release of 3.4. Is there a patched/released
version of 3.4 with this in it? (3.4.1?) Or do I need to compile separately. We need to build a version of
3.4 with both of these changes in it, and I see all sorts of changes committed
to the 3.4 branch – where was the release version of 3.4 built from? All
of the stuff that has been committed to the branch – has that been re-compiled
and re-released? Is this what 3.4.1 is?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||||
|
|
In reply to this post
by Chris Erickson-2
Some javascript/style in this post has been disabled (why?)
We can try… Brent, can I get a list of the revisions
you submitted that are candidates for porting? Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Ahh, So, I guess my request is to
backport that to this 3.4.1 version so it would be in the release…along with
the other patch I submitted. Is that possible?
From: [hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson There was a fix done to support
uniqueidentifier columns on Mar. 24 but it was only applied to the trunk and
was not backported to 3.4. At the moment, you’d have to do a separate compile
to get it into a 3.4 provider. I’m not sure if the fix could
still be backported to 3.4. Greg would have a better idea. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone This upload can be considered
Release Candidate 1. From:
[hidden email] [mailto:[hidden email]]
On Behalf Of Greg Boone Today, FDO 3.4.1 was uploaded
to: http://fdo.osgeo.org/content/fdo-341-downloads Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Ok, I must have missed that, I
think I must have been looking at something equivalent to the release of 3.4. Is there a patched/released
version of 3.4 with this in it? (3.4.1?) Or do I need to compile separately. We need to build a version of
3.4 with both of these changes in it, and I see all sorts of changes committed
to the 3.4 branch – where was the release version of 3.4 built from? All
of the stuff that has been committed to the branch – has that been re-compiled
and re-released? Is this what 3.4.1 is?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From: [hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||||
|
|
Some javascript/style in this post has been disabled (why?)
Greg, The revision for
uniqueIdentifier support is 4474. Brent. From:
[hidden email] [mailto:[hidden email]]
On Behalf Of Greg Boone We can try… Brent, can I get a list of the
revisions you submitted that are candidates for porting? Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Ahh, So, I guess my request is to
backport that to this 3.4.1 version so it would be in the release…along with
the other patch I submitted. Is that possible?
From: [hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson There was a fix done to support
uniqueidentifier columns on Mar. 24 but it was only applied to the trunk and
was not backported to 3.4. At the moment, you’d have to do a separate compile
to get it into a 3.4 provider. I’m not sure if the fix could
still be backported to 3.4. Greg would have a better idea. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone This upload can be considered
Release Candidate 1. From:
[hidden email] [mailto:[hidden email]]
On Behalf Of Greg Boone Today, FDO 3.4.1 was uploaded
to: http://fdo.osgeo.org/content/fdo-341-downloads Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Ok, I must have missed that, I
think I must have been looking at something equivalent to the release of 3.4. Is there a patched/released
version of 3.4 with this in it? (3.4.1?) Or do I need to compile separately. We need to build a version of
3.4 with both of these changes in it, and I see all sorts of changes committed
to the 3.4 branch – where was the release version of 3.4 built from? All
of the stuff that has been committed to the branch – has that been re-compiled
and re-released? Is this what 3.4.1 is?
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||||
|
|
In reply to this post
by Chris Erickson-2
Some javascript/style in this post has been disabled (why?)
Not sure if this didn’t get
picked up because I didn’t caps PATCH. I’d like to include this in
3.4.1, as well as trunk.
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||
|
|
In reply to this post
by Brent Robinson
Some javascript/style in this post has been disabled (why?)
Brent, Can you review Chris’ proposal
(patch) ? Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||
|
|
Some javascript/style in this post has been disabled (why?)
NOTE that I will be porting
submission 4474 to 3.4 from Trunk. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Brent, Can you review Chris’ proposal
(patch) ? Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||
|
|
Some javascript/style in this post has been disabled (why?)
Awesome. When both of these are in, can you
fire off a new RC? We’re trying to move to RC stage here as well and have a dependency
on FDO, and these defects. We need to test that all is working for a few of these
providers. If not, I can build it here, but would prefer to get something ‘more
official’…
From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone NOTE that I will be porting
submission 4474 to 3.4 from Trunk. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Brent, Can you review Chris’ proposal
(patch) ? Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||||
|
|
In reply to this post
by Greg Boone
Some javascript/style in this post has been disabled (why?)
Hi Greg, The patch looks fine. It’s
in a different spot but is equivalent to the fix that was done in 3.5. However,
fixing by backporting the 3.5 fix would keep 3.5 more in line with 3.4.1. It’s
not a big deal but having a different fix in each version might introduce some
confusion. Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Brent, Can you review Chris’
proposal (patch) ? Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From: [hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to
work. Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||
|
|
Some javascript/style in this post has been disabled (why?)
The patch contains code in
addition to the change made in 4474. These additional changes are ok? From: [hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Greg, The patch looks fine. It’s in a
different spot but is equivalent to the fix that was done in 3.5. However,
fixing by backporting the 3.5 fix would keep 3.5 more in line with 3.4.1. It’s
not a big deal but having a different fix in each version might introduce some
confusion. Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Brent, Can you review Chris’ proposal
(patch) ? Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||
|
|
Some javascript/style in this post has been disabled (why?)
Please disregard. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone The patch contains code in
addition to the change made in 4474. These additional changes are ok? From: [hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Greg, The patch looks fine. It’s in a
different spot but is equivalent to the fix that was done in 3.5. However,
fixing by backporting the 3.5 fix would keep 3.5 more in line with 3.4.1. It’s
not a big deal but having a different fix in each version might introduce some
confusion. Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Greg Boone Brent, Can you review Chris’ proposal
(patch) ? Greg From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Brent
Robinson Hi Chris, I had a look but the trunk
desc_selct.c already has a: case SQL_GUID
: a bit further up in the file
(line 187). Brent. From:
[hidden email]
[mailto:[hidden email]] On Behalf Of Chris
Erickson Hello, I’ve tested the attached patch, and it seems to work.
Can anyone verify it? I’d like to commit it to trunk.
_______________________________________________ fdo-internals mailing list [hidden email] http://lists.osgeo.org/mailman/listinfo/fdo-internals |
||||||||||
|
In reply to this post
by Greg Boone
|
||||||||
|
|
|
||||||||
| Free Embeddable Forum Powered by Nabble | Help |
