I still have some questions about Unicode on the Windows build. I asked
some of this before, but maybe that email got lost, and I think some are
relevant to Linux.
1) string literals. Many places in the code, there are implicit
concatenations, where for readability, a string is split across multiple
lines, e.g.:
wxMessageBox(_("CleanSpeech only allows recording mono track.\n"
"Recording not possible when more than one
window open."),
_("Recording not permitted"),
wxOK | wxICON_INFORMATION,
this);
This compiles fine in MSVC for Debug or Release build, but not Unicode:
audacity\src\ControlToolBar.cpp(882) : error C2308: concatenating
mismatched wide strings
In some places the offending code can be replaced with wxT("xxx") +
wxT("yyy"), but in args to _(), I think it must all be one string:
wxMessageBox(_("CleanSpeech only allows recording mono
track.\nRecording not possible when more than one window open."),
_("Recording not permitted"),
wxOK | wxICON_INFORMATION,
this);
Is there a better way to do it?
2) This, line 51 in PlatformCompatibility.cpp:
HANDLE findHandle = FindFirstFile((const char*)pathToFind,
&findData);
generates this error:
audacity\src\PlatformCompatibility.cpp(51) :
error C2440: 'type cast' : cannot convert from 'wxString' to
'const char *'
Should that be (const char*)(pathToFind.mb_str())?
3) Calls to one-byte fns, e.g.,
wxFFile file(fopen(FILENAME(mFileName.GetFullPath()).fn_str(), "wb"));
generate
audacity\src\blockfile\SimpleBlockFile.cpp(56) : error C2664: 'fopen' :
cannot convert parameter 1 from 'const wxChar *' to 'const char *'
It seems to me GCC should have the same error. I think the right fix is:
#ifdef _UNICODE
wxFFile file(_wfopen(FILENAME(mFileName.GetFullPath()).fn_str(),
L"wb"));
#else // ANSI
wxFFile file(fopen(FILENAME(mFileName.GetFullPath()).fn_str(), "wb"));
#endif // Unicode/ANSI
Right?
4) That being the case, what about calls to lib fns that don't have a
wide-char version, e.g.,
SNDFILE *sf=sf_open(FILENAME(mFileName.GetFullPath()).fn_str(),
SFM_READ, &info);
which generates
audacity\src\blockfile\SimpleBlockFile.cpp(196) :
error C2664: 'sf_open' : cannot convert parameter 1 from 'const
wxChar *' to 'const char *'
Do we need to write wide versions and call them based on #ifdef
_UNICODE, or will this work?
wxString filenameStr = FILENAME(mFileName.GetFullPath()).fn_str();
SNDFILE *sf=sf_open(filenameStr.mb_str(), SFM_READ, &info);
I think these file-handling things must be fixed for it to actually work
with Unicode on Linux, right?
And I understand that Unicode is not essential for Windows, but I did
read that modern versions of Windows are based on Unicode, and that the
code should run faster in Unicode, because the OS won't have to keep
translating between Unicode and ANSI. Of course, we don't do that much
string-handling...
-Vaughan
Markus Meyer wrote:
> ...Unicode: Audacity now compiles on GTK2 Unicode again. Note that
> there may still be runtime problems with Unicode (e.g. with message
> boxes and file names in the new clean speech code, GCC warnings give
> hints about that)
>
>
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast.
http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
