Measure tool should not use GetResourceContent to check if resource exists

[Bruno Scott]

Please review this patch

http://trac.osgeo.org/mapguide/ticket/1045

Bruno Scott

[zspitzer]

btw: is there a bug filed for that memory leak?

On Thu, Jul 23, 2009 at 12:14 AM, Bruno Scott<[hidden email]> wrote:

>
>
> Please review this patch
>
> http://trac.osgeo.org/mapguide/ticket/1045
> http://trac.osgeo.org/mapguide/ticket/1045
>
> Bruno Scott
> --
> View this message in context: http://n2.nabble.com/Measure-tool-should-not-use-GetResourceContent-to-check-if-resource-exists-tp3303377p3303377.html
> Sent from the MapGuide Internals mailing list archive at Nabble.com.
> _______________________________________________
> mapguide-internals mailing list
> [hidden email]
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
>

--
Zac Spitzer -
http://zacster.blogspot.com
[phone]
_______________________________________________
mapguide-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals

[Jackie Ng]

Poor java, does get any love. So I've put in a equivalent patch for the java viewer :-)

Other than that, looks fine. Could there possibly be more areas in the map viewer code where GetResourceContent() is (mis)used in this fashion?

- Jackie

Bruno Scott wrote:

Please review this patch

http://trac.osgeo.org/mapguide/ticket/1045

Bruno Scott

[Bruno Scott]

Thanks for the java patch Jackie
I made a global search, and i only found one other
  devguide/digitizing_features/draw_line.php
But i don't know where the sources are

Bruno

Jackie Ng wrote:

Poor java, does get any love. So I've put in a equivalent patch for the java viewer :-)

Other than that, looks fine. Could there possibly be more areas in the map viewer code where GetResourceContent() is (mis)used in this fashion?

- Jackie

Bruno Scott wrote:

Please review this patch

http://trac.osgeo.org/mapguide/ticket/1045

Bruno Scott

[Bruno Scott]

There is this one
http://trac.osgeo.org/mapguide/ticket/971
Maybe this defect should be part of it?

I'll put a comment on it

Bruno

zspitzer wrote:

btw: is there a bug filed for that memory leak?

On Thu, Jul 23, 2009 at 12:14 AM, Bruno Scott<[e-mail]> wrote:
>
>
> Please review this patch
>
> http://trac.osgeo.org/mapguide/ticket/1045
> http://trac.osgeo.org/mapguide/ticket/1045
>
> Bruno Scott
> --
> View this message in context: http://n2.nabble.com/Measure-tool-should-not-use-GetResourceContent-to-check-if-resource-exists-tp3303377p3303377.html
> Sent from the MapGuide Internals mailing list archive at Nabble.com.
> _______________________________________________
> mapguide-internals mailing list
> [e-mail]
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
>



--
Zac Spitzer -
http://zacster.blogspot.com
[phone]
_______________________________________________
mapguide-internals mailing list
[e-mail]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals

[Jackie Ng]

That would be here:

MgDev/Doc/samples/phpsamples/digitizing_features/draw_line.php

- Jackie

Bruno Scott wrote:

Thanks for the java patch Jackie
I made a global search, and i only found one other
  devguide/digitizing_features/draw_line.php
But i don't know where the sources are

Bruno

Jackie Ng wrote:

Poor java, does get any love. So I've put in a equivalent patch for the java viewer :-)

Other than that, looks fine. Could there possibly be more areas in the map viewer code where GetResourceContent() is (mis)used in this fashion?

- Jackie

Bruno Scott wrote:

Please review this patch

http://trac.osgeo.org/mapguide/ticket/1045

Bruno Scott