[MERGE/PATCH/REVIEW] nice device type and version helpers

[Benjamin Kampmann]

Hi.

As we found out working on the fritz.box during guadec some devices
may not provide a fully correct device-type-string (5 strings
seperated by a ':') all the time. That made the fritzbox media server
not appear in our side. Very stupid. At that certain point we added a
fix by splitting the name in a different way and came accross that we
actually rely on the split-method in a lot of cases. In most cases it
is just for logging/debugging purpose but it could still traceback in
case the device-type-string is slightly missformed. So we came up with
the idea of centralizing the correct lookup code in
core.upnp.device:Device as some more helper methods.

That is what this Review/Merge request is about. I added three more
methods to the DeviceClass and added code for Parsing the data
properly. I also added some of them to the dbus API and did some minor
refactoring and cleanups while replacing the old copy-pasted-code with
the new helper functions. Now only the new helpers are used inside
coherence (also fixed mirabeau).

You can either use the git-branch "nice_device_type" on my github
mirror or you apply these three patches in order of their names (or
use git-am in case you use git).

Thanks for reviewing
Benjamin




_______________________________________________
coherence-dev mailing list
[hidden email]
http://lists.beebits.net/cgi-bin/mailman/listinfo/coherence-dev

[Frank Scholz]

Hi Benjamin,

patch is fine with me, pls go ahead.

Regards,
Frank
_______________________________________________
coherence-dev mailing list
[hidden email]
http://lists.beebits.net/cgi-bin/mailman/listinfo/coherence-dev