Large commit coming -- VS project will need updating

[Al Dimond]

I'm about to commit a lot of stuff that I've been working on, regarding
mostly the labeled regions commands, and copying and pasting labels.  
This follows several discussions on this list and some off-list
discussions with Gale and Bill.  Important parts of this include:

 - When you copy tracks to the clipboard, the system clipboard is set
to represent the labels selected.  Any label fully overlapped by the
selection is added, with labels separated by tabs and label tracks
separated by newlines.
 - It's much easier to copy from/paste to label tracks -- the system
clipboard text is only used if it's changed since the last copy,
otherwise you get the label track as copied.
 - With linking enabled when you select the whole length of a track
the selection extends to the length of the longest group track.
 - A lot of bug fixes in Labeled Regions commands
 - Edit->Labeled Regions->Cut/Delete are disabled when linking is
enabled.

There was a CaptureEvents class defined in LabelTrack.cpp to work
around a wxGTK/wxClipboard bug.  As the clipboard is now used in a
couple more places I split that workaround out into its own files,
src/CaptureEvents.cpp and src/CaptureEvents.h.  src/Makefile.in has
been updated, and I'm pretty sure I got the XCode project updated
correctly, but the Visual Studio project will still need them to be
added.

If there are any other problems with these changes let me know.

 - Al

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Gale (Audacity Team)]

| From Al Dimond <[hidden email]>
| Sat, 31 Oct 2009 09:20:30 -0600
| Subject: [Audacity-devel] Large commit coming -- VS project will need updating

> I'm about to commit a lot of stuff that I've been working on, regarding
> mostly the labeled regions commands, and copying and pasting labels.  
> This follows several discussions on this list and some off-list
> discussions with Gale and Bill.  Important parts of this include:
>
>  - When you copy tracks to the clipboard, the system clipboard is set
> to represent the labels selected.  Any label fully overlapped by the
> selection is added, with labels separated by tabs and label tracks
> separated by newlines.
>  - It's much easier to copy from/paste to label tracks -- the system
> clipboard text is only used if it's changed since the last copy,
> otherwise you get the label track as copied.
>  - With linking enabled when you select the whole length of a track
> the selection extends to the length of the longest group track.
>  - A lot of bug fixes in Labeled Regions commands
>  - Edit->Labeled Regions->Cut/Delete are disabled when linking is
> enabled.
>
> There was a CaptureEvents class defined in LabelTrack.cpp to work
> around a wxGTK/wxClipboard bug.  As the clipboard is now used in a
> couple more places I split that workaround out into its own files,
> src/CaptureEvents.cpp and src/CaptureEvents.h.  src/Makefile.in has
> been updated, and I'm pretty sure I got the XCode project updated
> correctly, but the Visual Studio project will still need them to be
> added.
>
> If there are any other problems with these changes let me know.

Hi Al

I added src/CaptureEvents.cpp and src/CaptureEvents.h locally to
audacity/win/Projects/Audacity/Audacity.vcproj (not committed yet)  
but in Menus.cpp I get this when compiling:

Menus.cpp
..\..\..\src\Menus.cpp(3725) : error C2660: 'AudacityProject::EditByLabel' : function does not take 1 arguments
..\..\..\src\Menus.cpp(3737) : error C2660: 'AudacityProject::EditByLabel' : function does not take 1 arguments
..\..\..\src\Menus.cpp(3749) : error C2660: 'AudacityProject::EditByLabel' : function does not take 1 arguments
..\..\..\src\Menus.cpp(3761) : error C2660: 'AudacityProject::EditByLabel' : function does not take 1 arguments
..\..\..\src\Menus.cpp(3773) : error C2660: 'AudacityProject::EditByLabel' : function does not take 1 arguments
..\..\..\src\Menus.cpp(3785) : error C2660: 'AudacityProject::EditByLabel' : function does not take 1 arguments




Gale


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Al Dimond]

On Saturday 31 October 2009 13:54:22 Gale Andrews wrote:

> | From Al Dimond <[hidden email]>
> | Sat, 31 Oct 2009 09:20:30 -0600
> | Subject: [Audacity-devel] Large commit coming -- VS project will
> | need updating
> |
> > I'm about to commit a lot of stuff that I've been working on,
> > regarding mostly the labeled regions commands, and copying and
> > pasting labels. This follows several discussions on this list and
> > some off-list discussions with Gale and Bill.  Important parts of
> > this include:
> >
> >  - When you copy tracks to the clipboard, the system clipboard is
> > set to represent the labels selected.  Any label fully overlapped
> > by the selection is added, with labels separated by tabs and
> > label tracks separated by newlines.
> >  - It's much easier to copy from/paste to label tracks -- the
> > system clipboard text is only used if it's changed since the last
> > copy, otherwise you get the label track as copied.
> >  - With linking enabled when you select the whole length of a
> > track the selection extends to the length of the longest group
> > track. - A lot of bug fixes in Labeled Regions commands
> >  - Edit->Labeled Regions->Cut/Delete are disabled when linking is
> > enabled.
> >
> > There was a CaptureEvents class defined in LabelTrack.cpp to work
> > around a wxGTK/wxClipboard bug.  As the clipboard is now used in
> > a couple more places I split that workaround out into its own
> > files, src/CaptureEvents.cpp and src/CaptureEvents.h.
> > src/Makefile.in has been updated, and I'm pretty sure I got the
> > XCode project updated correctly, but the Visual Studio project
> > will still need them to be added.
> >
> > If there are any other problems with these changes let me know.
>
> Hi Al
>
> I added src/CaptureEvents.cpp and src/CaptureEvents.h locally to
> audacity/win/Projects/Audacity/Audacity.vcproj (not committed yet)
> but in Menus.cpp I get this when compiling:
>
> Menus.cpp
> ..\..\..\src\Menus.cpp(3725) : error C2660:
>  'AudacityProject::EditByLabel' : function does not take 1
>  arguments ..\..\..\src\Menus.cpp(3737) : error C2660:
>  'AudacityProject::EditByLabel' : function does not take 1
>  arguments ..\..\..\src\Menus.cpp(3749) : error C2660:
>  'AudacityProject::EditByLabel' : function does not take 1
>  arguments ..\..\..\src\Menus.cpp(3761) : error C2660:
>  'AudacityProject::EditByLabel' : function does not take 1
>  arguments ..\..\..\src\Menus.cpp(3773) : error C2660:
>  'AudacityProject::EditByLabel' : function does not take 1
>  arguments ..\..\..\src\Menus.cpp(3785) : error C2660:
>  'AudacityProject::EditByLabel' : function does not take 1
>  arguments
>
>

What do you have on those lines?  You may have had a merge conflict or
something that prevented changes from being applied (this could
especially be true if you had one of my earlier patches applied when
you updated).  In the version I committed the calls have all been
changed to use two arguments.

>
>
> Gale

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Gale (Audacity Team)]

| From Al Dimond <[hidden email]>
| Sat, 31 Oct 2009 14:03:43 -0600
| Subject: [Audacity-devel] Large commit coming -- VS project will need updating
|  > On Saturday 31 October 2009 13:54:22 Gale Andrews wrote:

> > | From Al Dimond <[hidden email]>
> > | Sat, 31 Oct 2009 09:20:30 -0600
> > | Subject: [Audacity-devel] Large commit coming -- VS project will
> > | need updating
> > |
> > > I'm about to commit a lot of stuff that I've been working on,
> > > regarding mostly the labeled regions commands, and copying and
> > > pasting labels. This follows several discussions on this list and
> > > some off-list discussions with Gale and Bill.  Important parts of
> > > this include:
> > >
> > >  - When you copy tracks to the clipboard, the system clipboard is
> > > set to represent the labels selected.  Any label fully overlapped
> > > by the selection is added, with labels separated by tabs and
> > > label tracks separated by newlines.
> > >  - It's much easier to copy from/paste to label tracks -- the
> > > system clipboard text is only used if it's changed since the last
> > > copy, otherwise you get the label track as copied.
> > >  - With linking enabled when you select the whole length of a
> > > track the selection extends to the length of the longest group
> > > track. - A lot of bug fixes in Labeled Regions commands
> > >  - Edit->Labeled Regions->Cut/Delete are disabled when linking is
> > > enabled.
> > >
> > > There was a CaptureEvents class defined in LabelTrack.cpp to work
> > > around a wxGTK/wxClipboard bug.  As the clipboard is now used in
> > > a couple more places I split that workaround out into its own
> > > files, src/CaptureEvents.cpp and src/CaptureEvents.h.
> > > src/Makefile.in has been updated, and I'm pretty sure I got the
> > > XCode project updated correctly, but the Visual Studio project
> > > will still need them to be added.
> > >
> > > If there are any other problems with these changes let me know.
> >
> > Hi Al
> >
> > I added src/CaptureEvents.cpp and src/CaptureEvents.h locally to
> > audacity/win/Projects/Audacity/Audacity.vcproj (not committed yet)
> > but in Menus.cpp I get this when compiling:
> >
> > Menus.cpp
> > ..\..\..\src\Menus.cpp(3725) : error C2660:
> >  'AudacityProject::EditByLabel' : function does not take 1
> >  arguments ..\..\..\src\Menus.cpp(3737) : error C2660:
> >  'AudacityProject::EditByLabel' : function does not take 1
> >  arguments ..\..\..\src\Menus.cpp(3749) : error C2660:
> >  'AudacityProject::EditByLabel' : function does not take 1
> >  arguments ..\..\..\src\Menus.cpp(3761) : error C2660:
> >  'AudacityProject::EditByLabel' : function does not take 1
> >  arguments ..\..\..\src\Menus.cpp(3773) : error C2660:
> >  'AudacityProject::EditByLabel' : function does not take 1
> >  arguments ..\..\..\src\Menus.cpp(3785) : error C2660:
> >  'AudacityProject::EditByLabel' : function does not take 1
> >  arguments
> >
> >
>
> What do you have on those lines?  You may have had a merge conflict or
> something that prevented changes from being applied (this could
> especially be true if you had one of my earlier patches applied when
> you updated).  In the version I committed the calls have all been
> changed to use two arguments.

On 3725 for example:

EditByLabel( &WaveTrack::Clear );

The whole tree is exactly as per CVS HEAD, and I'm building into an
empty folder. But "do a new checkout", I guess.




Gale


 

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Al Dimond]

On Saturday 31 October 2009 14:57:54 Gale Andrews wrote:

> | From Al Dimond <[hidden email]>
> | Sat, 31 Oct 2009 14:03:43 -0600
> | Subject: [Audacity-devel] Large commit coming -- VS project will
> | need updating
> |
> |  > On Saturday 31 October 2009 13:54:22 Gale Andrews wrote:
> > > | From Al Dimond <[hidden email]>
> > > | Sat, 31 Oct 2009 09:20:30 -0600
> > > | Subject: [Audacity-devel] Large commit coming -- VS project
> > > | will need updating
> > > |
> > > > I'm about to commit a lot of stuff that I've been working on,
> > > > regarding mostly the labeled regions commands, and copying
> > > > and pasting labels. This follows several discussions on this
> > > > list and some off-list discussions with Gale and Bill.
> > > > Important parts of this include:
> > > >
> > > >  - When you copy tracks to the clipboard, the system
> > > > clipboard is set to represent the labels selected.  Any label
> > > > fully overlapped by the selection is added, with labels
> > > > separated by tabs and label tracks separated by newlines.
> > > >  - It's much easier to copy from/paste to label tracks -- the
> > > > system clipboard text is only used if it's changed since the
> > > > last copy, otherwise you get the label track as copied.
> > > >  - With linking enabled when you select the whole length of a
> > > > track the selection extends to the length of the longest
> > > > group track. - A lot of bug fixes in Labeled Regions commands
> > > > - Edit->Labeled Regions->Cut/Delete are disabled when linking
> > > > is enabled.
> > > >
> > > > There was a CaptureEvents class defined in LabelTrack.cpp to
> > > > work around a wxGTK/wxClipboard bug.  As the clipboard is now
> > > > used in a couple more places I split that workaround out into
> > > > its own files, src/CaptureEvents.cpp and src/CaptureEvents.h.
> > > > src/Makefile.in has been updated, and I'm pretty sure I got
> > > > the XCode project updated correctly, but the Visual Studio
> > > > project will still need them to be added.
> > > >
> > > > If there are any other problems with these changes let me
> > > > know.
> > >
> > > Hi Al
> > >
> > > I added src/CaptureEvents.cpp and src/CaptureEvents.h locally
> > > to audacity/win/Projects/Audacity/Audacity.vcproj (not
> > > committed yet) but in Menus.cpp I get this when compiling:
> > >
> > > Menus.cpp
> > > ..\..\..\src\Menus.cpp(3725) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3737) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3749) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3761) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3773) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3785) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments
> >
> > What do you have on those lines?  You may have had a merge
> > conflict or something that prevented changes from being applied
> > (this could especially be true if you had one of my earlier
> > patches applied when you updated).  In the version I committed
> > the calls have all been changed to use two arguments.
>
> On 3725 for example:
>
> EditByLabel( &WaveTrack::Clear );
>
> The whole tree is exactly as per CVS HEAD, and I'm building into an
> empty folder. But "do a new checkout", I guess.
>
>

Odd.  'cvs diff src/Menus.cpp' shows no differences for me, and the
lines look like:

EditByLabel( &WaveTrack::Clear, true );

Based on the spacing of EditByLabel() calls, these appear to be the
last 6 of them, which are between lines 3812 and 3871 for me.

>
>
> Gale
>
>
>
>
> -------------------------------------------------------------------
> ----------- Come build with us! The BlackBerry(R) Developer
>  Conference in SF, CA is the only developer event you need to
>  attend this year. Jumpstart your developing skills, take
>  BlackBerry mobile applications to market and stay ahead of the
>  curve. Join us from November 9 - 12, 2009. Register now!
>  http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Richard Ash (audacity-help)]

On Sat, 2009-10-31 at 20:57 +0000, Gale Andrews wrote:

> > > I added src/CaptureEvents.cpp and src/CaptureEvents.h locally to
> > > audacity/win/Projects/Audacity/Audacity.vcproj (not committed yet)
> > > but in Menus.cpp I get this when compiling:
> > >
> > > Menus.cpp
> > > ..\..\..\src\Menus.cpp(3725) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3737) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3749) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3761) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3773) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments ..\..\..\src\Menus.cpp(3785) : error C2660:
> > >  'AudacityProject::EditByLabel' : function does not take 1
> > >  arguments
> > What do you have on those lines?  You may have had a merge conflict or
> > something that prevented changes from being applied (this could
> > especially be true if you had one of my earlier patches applied when
> > you updated).  In the version I committed the calls have all been
> > changed to use two arguments.
>
> On 3725 for example:
>
> EditByLabel( &WaveTrack::Clear );
>
> The whole tree is exactly as per CVS HEAD, and I'm building into an
> empty folder. But "do a new checkout", I guess.

What version does your copy of src/Menus.cpp claim to be? When I run cvs
status on that file I get

File: Menus.cpp         Status: Up-to-date

   Working revision:    1.532
   Repository revision:
1.532   /cvsroot/audacity/audacity-src/src/Menus.cpp,v
   Sticky Tag:          (none)
   Sticky Date:         (none)
   Sticky Options:      (none)

This version compiles correctly. The very fact that you have a call to
EditByLabel() on line 3725 indicates that your file is not an up-to-date
copy of src/Menus.cpp.

For reference the line numbers where EditByLabel() is called in version
1.532 of src/Menus.cpp are:

3759:     EditByLabel( &WaveTrack::ClearAndAddCutLine, true );
3761:     EditByLabel( &WaveTrack::Clear, true );
3812:  EditByLabel( &WaveTrack::Clear, true );
3826:  EditByLabel( &WaveTrack::SplitDelete, false );
3838:  EditByLabel( &WaveTrack::Silence, false );
3847:  EditByLabel( &WaveTrack::Split, false );
3859:  EditByLabel( &WaveTrack::Join, false );
3871:  EditByLabel( &WaveTrack::Disjoin, false );

This is one area where CVS is not a helpful tool, because it's very hard
to get it to tell you which files in your source tree are out of sync
with the repository (you can see it in the output of a CVS update),
where as subversion provides a status command that lists only the
out-of-sync files in your working copy.

Richard


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Gale (Audacity Team)]

Thanks Richard and Al.  In TortoiseCVS you get a green icon which
is supposed to tell you when the file is in sync. with CVS. I had the
green icon for Menus.cpp and the TortoiseCVS "Revision Graph"
context menu item was showing Menus.cpp as 1.532 (correct). But
when I double-clicked the file to open it in VS it was as you
demonstrate clearly showing me (and I presume using) the wrong
contents, maybe some cache from a previous open?  

All compiles fine now from a fresh tree, anyway.
 
NB I have found with Tortoise that if you use its "Update Special"
command to get an out-of-date version of a file for some reason,
subsequently delete the file and refetch it, it can give you the old
version again (and still give you the same green icon). This wasn't
the case here, but that has caught me out before.



Gale



| From Richard Ash <[hidden email]>
| Sat, 31 Oct 2009 21:30:10 +0000
| Subject: [Audacity-devel] Large commit coming -- VS project will need updating

> On Sat, 2009-10-31 at 20:57 +0000, Gale Andrews wrote:
> > > > I added src/CaptureEvents.cpp and src/CaptureEvents.h locally to
> > > > audacity/win/Projects/Audacity/Audacity.vcproj (not committed yet)
> > > > but in Menus.cpp I get this when compiling:
> > > >
> > > > Menus.cpp
> > > > ..\..\..\src\Menus.cpp(3725) : error C2660:
> > > >  'AudacityProject::EditByLabel' : function does not take 1
> > > >  arguments ..\..\..\src\Menus.cpp(3737) : error C2660:
> > > >  'AudacityProject::EditByLabel' : function does not take 1
> > > >  arguments ..\..\..\src\Menus.cpp(3749) : error C2660:
> > > >  'AudacityProject::EditByLabel' : function does not take 1
> > > >  arguments ..\..\..\src\Menus.cpp(3761) : error C2660:
> > > >  'AudacityProject::EditByLabel' : function does not take 1
> > > >  arguments ..\..\..\src\Menus.cpp(3773) : error C2660:
> > > >  'AudacityProject::EditByLabel' : function does not take 1
> > > >  arguments ..\..\..\src\Menus.cpp(3785) : error C2660:
> > > >  'AudacityProject::EditByLabel' : function does not take 1
> > > >  arguments
> > > What do you have on those lines?  You may have had a merge conflict or
> > > something that prevented changes from being applied (this could
> > > especially be true if you had one of my earlier patches applied when
> > > you updated).  In the version I committed the calls have all been
> > > changed to use two arguments.
> >
> > On 3725 for example:
> >
> > EditByLabel( &WaveTrack::Clear );
> >
> > The whole tree is exactly as per CVS HEAD, and I'm building into an
> > empty folder. But "do a new checkout", I guess.
>
> What version does your copy of src/Menus.cpp claim to be? When I run cvs
> status on that file I get
>
> File: Menus.cpp         Status: Up-to-date
>
>    Working revision:    1.532
>    Repository revision:
> 1.532   /cvsroot/audacity/audacity-src/src/Menus.cpp,v
>    Sticky Tag:          (none)
>    Sticky Date:         (none)
>    Sticky Options:      (none)
>
> This version compiles correctly. The very fact that you have a call to
> EditByLabel() on line 3725 indicates that your file is not an up-to-date
> copy of src/Menus.cpp.
>
> For reference the line numbers where EditByLabel() is called in version
> 1.532 of src/Menus.cpp are:
>
> 3759:     EditByLabel( &WaveTrack::ClearAndAddCutLine, true );
> 3761:     EditByLabel( &WaveTrack::Clear, true );
> 3812:  EditByLabel( &WaveTrack::Clear, true );
> 3826:  EditByLabel( &WaveTrack::SplitDelete, false );
> 3838:  EditByLabel( &WaveTrack::Silence, false );
> 3847:  EditByLabel( &WaveTrack::Split, false );
> 3859:  EditByLabel( &WaveTrack::Join, false );
> 3871:  EditByLabel( &WaveTrack::Disjoin, false );
>
> This is one area where CVS is not a helpful tool, because it's very hard
> to get it to tell you which files in your source tree are out of sync
> with the repository (you can see it in the output of a CVS update),
> where as subversion provides a status command that lists only the
> out-of-sync files in your working copy.
>
> Richard
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Richard Ash (audacity-help)]

On Sat, 2009-10-31 at 23:00 +0000, Gale Andrews wrote:
> NB I have found with Tortoise that if you use its "Update Special"
> command to get an out-of-date version of a file for some reason,
> subsequently delete the file and refetch it, it can give you the old
> version again (and still give you the same green icon). This wasn't
> the case here, but that has caught me out before.

That's the "correct" CVS behaviour, but I agree it is brain-dead.
Something else that I prefer about subversion.

Richard


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Bill Wharrie]

On 31-Oct-09, at 11:20 AM, Al Dimond wrote:

> I'm about to commit a lot of stuff that I've been working on,  
> regarding
> mostly the labeled regions commands, and copying and pasting labels.
> This follows several discussions on this list and some off-list
> discussions with Gale and Bill.

I have tested this with the Nov 2 2009 Mac nightly build. It appears  
that every bug we identified has been squashed.

-- Bill


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Martyn Shaw-2]

Do we still need to turn off linking for the 2.0 release on 1st
December then?

Martyn

Bill Wharrie wrote:

> On 31-Oct-09, at 11:20 AM, Al Dimond wrote:
>
>> I'm about to commit a lot of stuff that I've been working on,  
>> regarding
>> mostly the labeled regions commands, and copying and pasting labels.
>> This follows several discussions on this list and some off-list
>> discussions with Gale and Bill.
>
> I have tested this with the Nov 2 2009 Mac nightly build. It appears  
> that every bug we identified has been squashed.
>
> -- Bill
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Bill Wharrie]

On 2-Nov-09, at 7:55 PM, Martyn Shaw wrote:

> Do we still need to turn off linking for the 2.0 release on 1st
> December then?

Perhaps I was a little too broad in my wording. Al's patches solve all  
the issues we *identified* having to do with the interaction of  
labeled regions commands and linked tracks. One of those fixes was to  
simply disable Labeled Regions > Cut and Labeled Regions > Delete for  
linked tracks because (as I understand it) there was no agreement on  
what the correct behaviour was. Another issue addressed in this patch  
was copy/paste with both audio and labels on the clipboard, which did  
not depend on linking being on or off.

This doesn't mean there aren't other issues remaining. Such as the  
fact that the specification for linked tracks says there can be  
multiple label tracks in a group but the code assumes there's only one.

-- Bill

>
> Martyn
>
> Bill Wharrie wrote:
>> On 31-Oct-09, at 11:20 AM, Al Dimond wrote:
>>
>>> I'm about to commit a lot of stuff that I've been working on,
>>> regarding
>>> mostly the labeled regions commands, and copying and pasting labels.
>>> This follows several discussions on this list and some off-list
>>> discussions with Gale and Bill.
>>
>> I have tested this with the Nov 2 2009 Mac nightly build. It appears
>> that every bug we identified has been squashed.
>>
>> -- Bill
>>

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Al Dimond]

On Monday 02 November 2009 18:21:57 Bill Wharrie wrote:

> On 2-Nov-09, at 7:55 PM, Martyn Shaw wrote:
> > Do we still need to turn off linking for the 2.0 release on 1st
> > December then?
>
> Perhaps I was a little too broad in my wording. Al's patches solve
>  all the issues we *identified* having to do with the interaction
>  of labeled regions commands and linked tracks. One of those fixes
>  was to simply disable Labeled Regions > Cut and Labeled Regions >
>  Delete for linked tracks because (as I understand it) there was no
>  agreement on what the correct behaviour was.

Some of this stuff was discussed on-list, and much of it was off-list
with just Bill, Gale, and myself.  So when Bill says, "All the
issues," there really were a lot of issues just with the Labeled
Regions commands.

>  Another issue
>  addressed in this patch was copy/paste with both audio and labels
>  on the clipboard, which did not depend on linking being on or off.
>
> This doesn't mean there aren't other issues remaining. Such as the
> fact that the specification for linked tracks says there can be
> multiple label tracks in a group but the code assumes there's only
>  one.
>

Yeah... this and the fact that linking just flat-out confuses people
right now.  When you add the first label track to your project many of
the commands do totally different things and there's no visual
indication of this.  I've talked a bit about how I'd like to improve
visual indications, and I'm willing to create mock-ups and work on
them, but I'm no GUI expert. I could certainly get something done
before 2.0, but it really feels like a new feature that would benefit
from some time spent in beta.  On the other hand, it's the kind of big
visible change that feels more 2.0 than 2.2.

> -- Bill
>


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Gale (Audacity Team)]

| From Bill Wharrie <[hidden email]>
| Mon, 2 Nov 2009 20:21:57 -0500
| Subject: [Audacity-devel] Large commit coming -- VS project will need updating

>
> On 2-Nov-09, at 7:55 PM, Martyn Shaw wrote:
>
> > Do we still need to turn off linking for the 2.0 release on 1st
> > December then?
>
> Perhaps I was a little too broad in my wording. Al's patches solve all  
> the issues we *identified* having to do with the interaction of  
> labeled regions commands and linked tracks. One of those fixes was to  
> simply disable Labeled Regions > Cut and Labeled Regions > Delete for  
> linked tracks because (as I understand it) there was no agreement on  
> what the correct behaviour was. Another issue addressed in this patch  
> was copy/paste with both audio and labels on the clipboard, which did  
> not depend on linking being on or off.
>
> This doesn't mean there aren't other issues remaining. Such as the  
> fact that the specification for linked tracks says there can be  
> multiple label tracks in a group but the code assumes there's only one.

I think that's a P3, not a P4 (if we don't change the Manual).  

I haven't re-tested against the commit, but will do so. But IMO, linking
remains "off" for 2.0.

*Lots* of issues I think remain unresolved about what "should" happen
when selecting only one audio track of a multi-track group. There won't
be time for a rational discussion of this until after 2.0.
 
* SBSMS, Change Speed, Change Tempo and Truncate Silence do not keep
labels/audio in sync. (these are P3s). TimeTrack stops linking working
(maybe it should anyway, but is a P3 for now).

I don't get the impression linking is "ready" for Stable. I've got a lot
of issues in my "bugs clipboard" to do with linking and I've checked a
few which seem to have been fixed, but I doubt they are all fixed.
Some may be minor/obvious individually, but if people keep coming
across different ones here and there, they "add up" (IMO).

For example in CVS now, create a 10s variable amplitude Chirp,
duplicate it and in the upper track, add a point label at 3s. Click
in the upper track at 1s and generate DTMF (built-in) or Pluck
(Nyquist) of 1s duration. No effect on audio or label track when
linking is on. Now include the cursor in both the audio tracks and
the label track and generate. Label does not move.

Fairly easy to fix?  Delay desynchronises groups too.


Al said:
> Yeah... this and the fact that linking just flat-out confuses people
> right now.  When you add the first label track to your project many of
> the commands do totally different things and there's no visual
> indication of this.  I've talked a bit about how I'd like to improve
> visual indications, and I'm willing to create mock-ups and work on
> them, but I'm no GUI expert. I could certainly get something done
> before 2.0, but it really feels like a new feature that would benefit
> from some time spent in beta.  On the other hand, it's the kind of big
> visible change that feels more 2.0 than 2.2.

It the linked tracks had a huge chain through them, there would still be
people who didn't understand. I've no objection to a visual indication
but it was discussed before and there was insufficient consensus to add
visual indications of linking. When we decided to enable linking not on
the track panel but by label track placement, the idea of "indications"
was dropped.

Assuming we agree that linking is off by default (when it is re-enabled
in 2.1.0), I see indications as a modest improvement, but no more. We
must make sure they do not conflict too much with the yellow focus
indication, obviously.  




Gale  



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Gale (Audacity Team)]

Hi Al, some concerns over the new clipboard behaviour and
Labeled Regions items especially pasting...


| From Bill Wharrie <[hidden email]>
| Mon, 2 Nov 2009 11:46:53 -0500
| Subject: [Audacity-devel] Large commit coming -- VS project will need updating
>
> On 31-Oct-09, at 11:20 AM, Al Dimond wrote:
>  - When you copy tracks to the clipboard, the system clipboard is set
> to represent the labels selected.  Any label fully overlapped by the
> selection is added, with labels separated by tabs and label tracks
> separated by newlines.

Isn't the Audacity clipboard able to capture the label text as well as
the audio, then? This is quite a liability for people who use clipboard
managers which store every clip.

And I note it's using the system clipboard even for audio only, so
knocking current text off the clipboard. Supposing I didn't have a
clipboard manager and that was a clip I was just about to paste into a
document? Would I have expected Audacity to erase that clip
permanently when copying audio?


>  - It's much easier to copy from/paste to label tracks -- the system
> clipboard text is only used if it's changed since the last copy,
> otherwise you get the label track as copied.

That indeed seems to be true from what I see, but it comes rather
expensively (for me). We could capture labels and their text (including
multiple labels) OK when selecting over the labels. But we could
not seem to get the audio as well (at least, without the clipboard
contents). I'll admit I haven't followed all the clipboard discussions
closely.


>  - With linking enabled when you select the whole length of a track
> the selection extends to the length of the longest group track.
>  - A lot of bug fixes in Labeled Regions commands
>  - Edit->Labeled Regions->Cut/Delete are disabled when linking is
> enabled.

For the Labeled Regions items that aren't disabled when linking is
on, I did some tests and noticed a few things that look odd to me.

I have one audio and one label track. I have two labelled clips,
both three-seconds long and the label the same length as the clip,
separated by a 1 second of whitespace.

* I select over the two labels and Edit > Labeled Regions > Copy.
   If I paste into the white space of the audio track further to right,
   the two clips run together with the white space removed. If I
   drag the cursor down into the label track, or just paste into the
   label track, I paste one point-label only which has the text of
   both clips. I get no audio.  

* Identical comment for Split Cut then Paste as above.

* Edit > Labeled Regions > Join doesn't join my two clips.

* Edit > Labeled Regions > Silence works but should be  
   called "Silence Audio" to match with the Edit menu

* If I have two audio tracks and do the Labeled Regions >
   Copy or Split Cut by selecting only over the labels, or by
   selecting over the labels *and* both audio tracks, there
   is no way to paste the contents of the lower audio track
   on its own. If I paste into upper track only, I get the upper
   track (OK apart from them being joined together); if I paste
   into the lower track, I get the upper track. I see if I extend
   the selection into one audio track only, I get that track pasted,
   but I'm not sure what happens with no or both audio tracks
   selected  is correct.

* Maybe we should verify behaviour generally when pasting
   different numbers of audio tracks into different selected
   tracks, in case the above behaviour isn't confined to
   labeled regions.  

* All the above seems to be the same if linking is off, so perhaps
   this isn't all new.



Thanks


Gale





 

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[James Crook]

Gale Andrews wrote:
> I haven't re-tested against the commit, but will do so. But IMO, linking
> remains "off" for 2.0.
>  
+1.

And Al, thank you very much for this patch.  As above we will disable
linking for 2.0, but what you've done should mean that we have something
good for betas thereafter, and a good start at it getting to release
grade.  And of course the label fixes that will be visible in 2.0 are
really good.

I've done some quick checks on audio clip and label cutting and pasting
for the aspects that will be enabled in 2.0 and see a vast improvement
over what we had before - and didn't see regressions.   Gale has pointed
to a number of remaining problems.  I couldn't reproduce the issue
(labels being run together, audio join not being done).  Can you (Al)
try Gale's steps and see if you get that result?  From what I saw either
there is some detail to the instructions missing, like exactly what to
select, or I can't follow instructions, or there is still not exactly
CVS code in Gale's build.

On issues around cutting from 3 tracks and pasting into 2 and such -
it's another case where we need some policy decision.  It's more
relevant with grouping/linking on, where we have to choose a policy of
either pasting only some or of adding new tracks.  Post 2.0 I'd go with
a preference here, including option of prompt-for "add-new-tracks" - but
we're not going to argue that through now with all else that is on our
plate.  Maybe we release note or add to the manual that 'pasting
multiple tracks into a different number of tracks currently loses
additional tracks or pastes into the first few' (if that is what we do
with linking off).

With regard to GUI to show linking....  Linking in groups is actually a
special case of hierarchical projects, where the tracks are in a tree.  
A list is a degenerate kind of tree.  We will eventually design and code
a proper way of displaying tree structure to the tracks...  Definitely
post 2.0!
> *Lots* of issues I think remain unresolved about what "should" happen
> when selecting only one audio track of a multi-track group. There won't
> be time for a rational discussion of this until after 2.0.
>  
+1.

> If the linked tracks had a huge chain through them, there would still be
> people who didn't understand. I've no objection to a visual indication
> but it was discussed before and there was insufficient consensus to add
> visual indications of linking. When we decided to enable linking not on
> the track panel but by label track placement, the idea of "indications"
> was dropped.
>
> Assuming we agree that linking is off by default (when it is re-enabled
> in 2.1.0), I see indications as a modest improvement, but no more. We
> must make sure they do not conflict too much with the yellow focus
> indication, obviously.  
>  

I have an idea for how linking 'brackets' could look.  My main concern
is that it takes up some space on the left.  Yes there will be people
who do not understand it anyway!  I'd be looking for some 'space savers'
to work well with it to regain the lost space.  Not a quick fix.  If I
don't respond to threads on how it could look it is because there are
more pressing concerns.  Part of the point of disabling linking in 2.0
is to give us some breathing room for addressing the P2s.

--James.


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Bill Wharrie]

On 3-Nov-09, at 6:00 AM, Gale Andrews wrote:

>
> Hi Al, some concerns over the new clipboard behaviour and
> Labeled Regions items especially pasting...
>
>
> | From Bill Wharrie <[hidden email]>
> | Mon, 2 Nov 2009 11:46:53 -0500
> | Subject: [Audacity-devel] Large commit coming -- VS project will  
> need updating
>>
>> On 31-Oct-09, at 11:20 AM, Al Dimond wrote:
>> - When you copy tracks to the clipboard, the system clipboard is set
>> to represent the labels selected.  Any label fully overlapped by the
>> selection is added, with labels separated by tabs and label tracks
>> separated by newlines.
>
> Isn't the Audacity clipboard able to capture the label text as well as
> the audio, then? This is quite a liability for people who use  
> clipboard
> managers which store every clip.
>
> And I note it's using the system clipboard even for audio only, so
> knocking current text off the clipboard. Supposing I didn't have a
> clipboard manager and that was a clip I was just about to paste into a
> document? Would I have expected Audacity to erase that clip
> permanently when copying audio?

Confirmed. I don't know about clipboard managers, but I don't think  
I'd copy text from a WP document, then copy audio from an Audacity  
project, then try to paste into another WP document and expect the  
original WP contents to be there.

>
>
>> - It's much easier to copy from/paste to label tracks -- the system
>> clipboard text is only used if it's changed since the last copy,
>> otherwise you get the label track as copied.
>
> That indeed seems to be true from what I see, but it comes rather
> expensively (for me). We could capture labels and their text  
> (including
> multiple labels) OK when selecting over the labels. But we could
> not seem to get the audio as well (at least, without the clipboard
> contents). I'll admit I haven't followed all the clipboard discussions
> closely.
>
>
>> - With linking enabled when you select the whole length of a track
>> the selection extends to the length of the longest group track.
>> - A lot of bug fixes in Labeled Regions commands
>> - Edit->Labeled Regions->Cut/Delete are disabled when linking is
>> enabled.
>
> For the Labeled Regions items that aren't disabled when linking is
> on, I did some tests and noticed a few things that look odd to me.
>
> I have one audio and one label track. I have two labelled clips,
> both three-seconds long and the label the same length as the clip,
> separated by a 1 second of whitespace.
>
> * I select over the two labels and Edit > Labeled Regions > Copy.
>   If I paste into the white space of the audio track further to right,
>   the two clips run together with the white space removed. If I
>   drag the cursor down into the label track, or just paste into the
>   label track, I paste one point-label only which has the text of
>   both clips. I get no audio.

Confirmed. Also for linking off when dragging over audio and label  
track to make selection.

With standard Edit > Copy followed by Paste the behaviour is correct -  
the clips are pasted without being joined and two labels are pasted,  
in sync with the clips.

In both cases when pasting into a WP doc the label text pastes properly.

However ....
With two label tracks, selecting both label tracks then Labeled  
Regions > Copy, then select two other label tracks and do Edit >  
Paste, the labels from both tracks are all joined into one point label  
which is pasted to both label tracks.

>
> * Identical comment for Split Cut then Paste as above.

Confirmed. I assume you meant Labeled Regions > Split Cut. Also for  
linking off when dragging over audio and label track to make selection.

With standard Edit > Split Cut followed by Paste the behaviour is  
correct - the clips are pasted without being joined and two labels are  
pasted, in sync with the clips.

>
> * Edit > Labeled Regions > Join doesn't join my two clips.

Confirmed.  Also for linking off when dragging over audio and label  
track to make selection.

>
> * Edit > Labeled Regions > Silence works but should be
>   called "Silence Audio" to match with the Edit menu

Yes.

>
> * If I have two audio tracks and do the Labeled Regions >
>   Copy or Split Cut by selecting only over the labels, or by
>   selecting over the labels *and* both audio tracks, there
>   is no way to paste the contents of the lower audio track
>   on its own. If I paste into upper track only, I get the upper
>   track (OK apart from them being joined together); if I paste
>   into the lower track, I get the upper track. I see if I extend
>   the selection into one audio track only, I get that track pasted,
>   but I'm not sure what happens with no or both audio tracks
>   selected  is correct.

How can Audacity know which is the "upper" track and which is the  
"lower" when pasting? The same behaviour occurs with a standard Edit >  
Copy followed by a Paste into a different number of tracks.

>
> * Maybe we should verify behaviour generally when pasting
>   different numbers of audio tracks into different selected
>   tracks, in case the above behaviour isn't confined to
>   labeled regions.
>
> * All the above seems to be the same if linking is off, so perhaps
>   this isn't all new.

Yes, all the same with linking off.
>

To summarize:

1) Starting with labeled regions Copy, Cut or Split Cut, on subsequent  
Paste:

a) Clips are joined (spacing is not preserved). This applies whether  
the copied audio is separate clips or discontiguous bits defined by  
the labeled regions.

b) If a label track is included in the selection for the paste, only  
the label track is pasted to and not the audio track(s).

c) Multiple region labels are joined into one point label.

2) Labeled Regions > Join doesn't work at all.

3) Copying audio only, knocks previous content off the system clipboard.

4) Labeled Regions > Silence should be Labeled Regions > Silence Audio.

5) In general, copying multiple audio tracks then pasting to a  
different number of audio tracks, the current behaviour may not be  
correct.

That's enough for this morning. I'll bang on this some more later  
today and see if I can find anything else we should make note of.  
There are just soooo many permutations....

-- Bill


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[James Crook]

Bill Wharrie wrote:
> With standard Edit > Copy followed by Paste the behaviour is correct -  
> the clips are pasted without being joined and two labels are pasted,  
> in sync with the clips.  [..snip..] However .... With two label tracks, selecting both label tracks then Labeled  Regions > Copy, then select two other label tracks and do Edit >  Paste, the labels from both tracks are all joined into one point label which is pasted to both label tracks.
>  
Ah, got it now.

But now that normal copy/paste works fine with labels, do we actually
have any need for the "Labelled Regions" sub menu?  Put another way, is
there anything one can't do easily with normal, cut, copy, split, paste
join??  If not, can we fix the problem by hiding the sub menu?  [I
suspect we will not need it even with linking available].

> That's enough for this morning. I'll bang on this some more later  
> today and see if I can find anything else we should make note of.  
> There are just soooo many permutations....
>  
Thanks Bill.  If it is the case that we can remove labelled region
submenu, then that cuts out a lot of the cases to test!

--James.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Bill Wharrie]

Some javascript/style in this post has been disabled (why?)

On 3-Nov-09, at 12:21 PM, James Crook wrote:

[snip]

But now that normal copy/paste works fine with labels, do we actually
have any need for the "Labelled Regions" sub menu?  Put another way, is
there anything one can't do easily with normal, cut, copy, split, paste
join??  If not, can we fix the problem by hiding the sub menu?  [I
suspect we will not need it even with linking available].

The power of the labeled regions commands is the ability to select and operate on discontiguous regions of audio, regardless of whether linking is on or off. As well, the labeled regions commands leave the labels alone (either don't remove them or don't move them), while the standard commands affect the labels.

Linking off, before:

After Labeled Regions > Split Cut:

Or, after Labeled Regions > Delete:

Someone else will have to answer the question: are these features useful?

-- Bill

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Al Dimond]

On a note not directly related to this message, the problem with
generators not respecting group behavior is confirmed.  Every generator
I've tried acts this way.  That's odd; I haven't looked at any
generator code, but based on how their behavior changed with my
earlier repeat/paste fixes patch I assumed they were pasting into the
target track and letting group behavior take its course.  I'll have a
look at that.

On Tuesday 03 November 2009 04:00:45 Gale Andrews wrote:

> Hi Al, some concerns over the new clipboard behaviour and
> Labeled Regions items especially pasting...
>
> | From Bill Wharrie <[hidden email]>
> | Mon, 2 Nov 2009 11:46:53 -0500
> | Subject: [Audacity-devel] Large commit coming -- VS project will
> | need updating
> |
> > On 31-Oct-09, at 11:20 AM, Al Dimond wrote:
> >  - When you copy tracks to the clipboard, the system clipboard is
> > set to represent the labels selected.  Any label fully overlapped
> > by the selection is added, with labels separated by tabs and
> > label tracks separated by newlines.
>
> Isn't the Audacity clipboard able to capture the label text as well
>  as the audio, then? This is quite a liability for people who use
>  clipboard managers which store every clip.
>

As it stands Audacity's clipboard, where copied tracks are stored, is
completely separate from the system clipboard.  We could add a
separate Audacity text clipboard but that wouldn't help us get the
desired behavior.

 - If you've just copied something from a text document, we want a new
label created with that text.
 - If you've just copied part of a label track from Audacity we want
that new part copied in.

What we want is to honor the most recent thing copied to the
clipboard, whether it was Audacity data or text.  Without writing to
the system clipboard we can't do that (some platforms' clipboards have
timestamps, and some platforms let you listen for clipboard events --
if either approach was supported by wxWidgets we could use those
instead, but it doesn't sound like either is universal enough to be
usable by wx).  We have to write to the system clipboard on a copy and
then, on a paste, check whether some other program overwrote what we
wrote there.  Even if there isn't any label text to write.

One problem with this is that it's impossible to distinguish
Audacity's text from a user copying the exact same text from another
program.  There is no perfect way around this using this scheme...
maybe we could prefix the string we copy with "Audacity:".  The problem
would still exist, but as users would be unlikely to copy that prefix
with the intention of pasting it into a new label, it would be less
likely to occur in practice.

> And I note it's using the system clipboard even for audio only, so
> knocking current text off the clipboard. Supposing I didn't have a
> clipboard manager and that was a clip I was just about to paste
>  into a document? Would I have expected Audacity to erase that clip
>  permanently when copying audio?
>

Most programs operate on the system clipboard when you use Edit->Copy.  
Some programs (i.e. vim) have separate cut buffers, but you explicitly
control when you use them.  I wouldn't expect Audacity to act any
differently.

> >  - It's much easier to copy from/paste to label tracks -- the
> > system clipboard text is only used if it's changed since the last
> > copy, otherwise you get the label track as copied.
>
> That indeed seems to be true from what I see, but it comes rather
> expensively (for me). We could capture labels and their text
>  (including multiple labels) OK when selecting over the labels. But
>  we could not seem to get the audio as well (at least, without the
>  clipboard contents). I'll admit I haven't followed all the
>  clipboard discussions closely.
>

I'm not sure exactly what you're doing here.  If you select audio
audio will be copied.  To get it to paste you have to paste it either
(a) with an audio track selected or (b) with no tracks selected, in
which case a new track will be created to hold it.  But this has
always been the case.  It's possible you're trying something here that
I haven't and that it's not working correctly (OnPaste() is still
pretty crazy).

> >  - With linking enabled when you select the whole length of a
> > track the selection extends to the length of the longest group
> > track. - A lot of bug fixes in Labeled Regions commands
> >  - Edit->Labeled Regions->Cut/Delete are disabled when linking is
> > enabled.
>
> For the Labeled Regions items that aren't disabled when linking is
> on, I did some tests and noticed a few things that look odd to me.
>
> I have one audio and one label track. I have two labelled clips,
> both three-seconds long and the label the same length as the clip,
> separated by a 1 second of whitespace.
>
> * I select over the two labels and Edit > Labeled Regions > Copy.
>    If I paste into the white space of the audio track further to
>  right, the two clips run together with the white space removed.

This was an existing behavior in
AudacityProject::EditClipboardByLabel().  I will probably change it,
although... based on the semantics of the command (it works as if
there are multiple selections existing only where there are selected
labels) I'm a bit conflicted as to whether it should change.  If people
don't like the new way it's easy to change back.

>  If
>  I drag the cursor down into the label track, or just paste into
>  the label track, I paste one point-label only which has the text
>  of both clips. I get no audio.
>

Oops, that was a mistake.  I'll have a fix checked in shortly.

> * Identical comment for Split Cut then Paste as above.
>
> * Edit > Labeled Regions > Join doesn't join my two clips.
>

L.R.->Join seems to work OK for me.  Is the split line covered by a
label?

> * Edit > Labeled Regions > Silence works but should be
>    called "Silence Audio" to match with the Edit menu
>

Will be changed shortly.  Based on other menu items, it looks like the
policy for choosing a selector letter is something like: prefer first
letters of words, then prefer last letters, then prefer first letters
of syllables, so I used "Silence &Audio".  If this is wrong or will
screw up translations let me know.

> * If I have two audio tracks and do the Labeled Regions >
>    Copy or Split Cut by selecting only over the labels, or by
>    selecting over the labels *and* both audio tracks, there
>    is no way to paste the contents of the lower audio track
>    on its own. If I paste into upper track only, I get the upper
>    track (OK apart from them being joined together); if I paste
>    into the lower track, I get the upper track. I see if I extend
>    the selection into one audio track only, I get that track
>  pasted, but I'm not sure what happens with no or both audio tracks
>  selected  is correct.
>

Paste is mostly separate from Copy.  If you paste a group of tracks
into a group of tracks that's too small it always takes the first ones.  
It might be cool, since the clipboard is totally internal to Audacity,
to keep track of the origin of clipboard tracks... or it might be
incredibly confusing.

> * Maybe we should verify behaviour generally when pasting
>    different numbers of audio tracks into different selected
>    tracks, in case the above behaviour isn't confined to
>    labeled regions.
>

I'm looking at a couple things in OnPaste() right now; there is at
least one hang bug, noted in the code, that I have fixed locally (the
fix includes correcting some iterator stuff, mostly stuff nobody was
using anyway because it was broken -- TrackListIteratorOfKind::Last(),
for example... anyway, I've been testing with it for a few days and
making sure nothing unexpected happens, so I think I'll check it in
soon).

> * All the above seems to be the same if linking is off, so perhaps
>    this isn't all new.
>

A number of the issues raised here aren't really new, but are things
that people are more likely to run into now that label pasting works
(the hang bug, for example).

 - Al

>
>
> Thanks
>
>
> Gale

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Todd Baker]

Dear All:

Relatively new to Visual Studio and compiling Audacity, and thought I
had everything set up (no pun intended) correctly.
I have been running into a compile problem and after reading a lot of
different things and trying adding include directories I keep running
into a error message with setup.h.  Maybe someone know what is wrong
when I get this error.....

------------------------------------------------------- Error Output
--------------------------------------
4>------ Build started: Project: mod-script-pipe, Configuration: Unicode
Debug Win32 ------
4>Compiling...
1>cl : Command line warning D9035 : option 'Wp64' has been deprecated
and will be removed in a future release
1>FileDialog.cpp
4>cl : Command line warning D9035 : option 'Wp64' has been deprecated
and will be removed in a future release
4>ScripterCallback.cpp
1>c:\wxwidgets-2.8.9\include\wx\setup.h(20) : fatal error C1083: Cannot
open include file: '../../../lib/vc_dll/mswud/wx/setup.h': No such file
or directory
1>FileDialogPrivate.cpp
4>c:\wxwidgets-2.8.9\include\wx\setup.h(20) : fatal error C1083: Cannot
open include file: '../../../lib/vc_dll/mswud/wx/setup.h': No such file
or directory
4>Build log was saved at "file://c:\Documents and
Settings\bakert\Desktop\audacity\win\Projects\mod-script-pipe\Unicode
Debug\BuildLog.htm"
4>mod-script-pipe - 1 error(s), 1 warning(s)
------------------------------------------------------------------------
---------------------------------


Any information that someone may have would be greatly appreciated.

Best Regards,

Todd Baker
Technical Operations

Radio Free Asia
2025 M Street, NW
Washington DC, 20036
[phone]


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel