KSS Kupu and problem saving edits

[Steven McDonald]

Hi

    I have noticed a problem with Kupu and I believe its interaction
with KSS.
   
 I am using plone 3.0.6 with the default install of Kupu 1.4.8. There is
very little other customizations, it is pretty much a default plone
site. If I am logged in as a user with edit privileges on a page if I
click in the content part of the page the kupu editor starts up
automatically, but when I try to save something it does not work, i.e
nothing appears to happen when I click the "save button"

It is okay when I edit the title of the page, only when I try to edit
the body contents and the KUPU edit starts.

If I click the edit tab of the same page to edit it, it opens up the
edit form for the page loads kupu for the content body and any edits I
do CAN be saved okay.

The problem only appears when KUPU is launched via KSS.

Does anyone understand my problem and can offer an explanation for this
behaviour.

 It would also be nice to be able to TURN KSS off on a per page basis,
is this possible? If you are logged in with edit priv on a page it is
impossible to use the table sort feature, as each time you try to click
on the table header to sort the column it launches you into the KUPU
editor ;-(. Maybe a little tab in the user preference bar. I used to use
something similar that would toggle on/off the green edit border.


Thanks
Steve

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Plone-Users mailing list
Plone-Users@...
https://lists.sourceforge.net/lists/listinfo/plone-users

[Derek Broughton-3]

Steven McDonald wrote:

> Hi
>
>     I have noticed a problem with Kupu and I believe its interaction
> with KSS.
>    
>  I am using plone 3.0.6 with the default install of Kupu 1.4.8. There is
> very little other customizations, it is pretty much a default plone
> site. If I am logged in as a user with edit privileges on a page if I
> click in the content part of the page the kupu editor starts up
> automatically, but when I try to save something it does not work, i.e
> nothing appears to happen when I click the "save button"
>
> It is okay when I edit the title of the page, only when I try to edit
> the body contents and the KUPU edit starts.
>
> If I click the edit tab of the same page to edit it, it opens up the
> edit form for the page loads kupu for the content body and any edits I
> do CAN be saved okay.
>
> The problem only appears when KUPU is launched via KSS.
>
> Does anyone understand my problem and can offer an explanation for this
> behaviour.

I don't understand it and can't offer an explanation - but I do have exactly
the same problem with the same version of Plone.  I'd file an issue if I
had a clue what was happening.
--
derek


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Plone-Users mailing list
Plone-Users@...
https://lists.sourceforge.net/lists/listinfo/plone-users

[Martin Aspeli-2]

Derek Broughton wrote:

> Steven McDonald wrote:
>
>> Hi
>>
>>     I have noticed a problem with Kupu and I believe its interaction
>> with KSS.
>>    
>>  I am using plone 3.0.6 with the default install of Kupu 1.4.8. There is
>> very little other customizations, it is pretty much a default plone
>> site. If I am logged in as a user with edit privileges on a page if I
>> click in the content part of the page the kupu editor starts up
>> automatically, but when I try to save something it does not work, i.e
>> nothing appears to happen when I click the "save button"
>>
>> It is okay when I edit the title of the page, only when I try to edit
>> the body contents and the KUPU edit starts.
>>
>> If I click the edit tab of the same page to edit it, it opens up the
>> edit form for the page loads kupu for the content body and any edits I
>> do CAN be saved okay.
>>
>> The problem only appears when KUPU is launched via KSS.
>>
>> Does anyone understand my problem and can offer an explanation for this
>> behaviour.
>
> I don't understand it and can't offer an explanation - but I do have exactly
> the same problem with the same version of Plone.  I'd file an issue if I
> had a clue what was happening.

I think it's this bug: http://dev.plone.org/plone/ticket/7893

We may be able to work around it by upgrading Kupu and/or KSS. I'm
looking into it now.

Martin


--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Plone-Users mailing list
Plone-Users@...
https://lists.sourceforge.net/lists/listinfo/plone-users

[Duncan Booth]

Martin Aspeli <optilude@...> wrote:

> I think it's this bug: http://dev.plone.org/plone/ticket/7893
>
> We may be able to work around it by upgrading Kupu and/or KSS. I'm
> looking into it now.
>

The simplest thing may be to just apply the following patch to kupu:

Index: kupuploneinit.js
===================================================================
--- kupuploneinit.js (revision 52479)
+++ kupuploneinit.js (revision 52480)
@@ -201,6 +201,7 @@
             opt.selected = opt.defaultSelected = (opt.value=='text/html');
         }
         pulldown.disabled = true;
+        pulldown.removeAttribute('name');
         var hidden = document.createElement('input');
         hidden.type = 'hidden';
         hidden.name = fmtname;


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Plone-Users mailing list
Plone-Users@...
https://lists.sourceforge.net/lists/listinfo/plone-users

[Martin Aspeli-2]

Duncan Booth wrote:

> Martin Aspeli <optilude@...> wrote:
>
>> I think it's this bug: http://dev.plone.org/plone/ticket/7893
>>
>> We may be able to work around it by upgrading Kupu and/or KSS. I'm
>> looking into it now.
>>
>
> The simplest thing may be to just apply the following patch to kupu:
>
> Index: kupuploneinit.js
> ===================================================================
> --- kupuploneinit.js (revision 52479)
> +++ kupuploneinit.js (revision 52480)
> @@ -201,6 +201,7 @@
>              opt.selected = opt.defaultSelected = (opt.value=='text/html');
>          }
>          pulldown.disabled = true;
> +        pulldown.removeAttribute('name');
>          var hidden = document.createElement('input');
>          hidden.type = 'hidden';
>          hidden.name = fmtname;

This should also be fixed in Plone 3.1

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Plone-Users mailing list
Plone-Users@...
https://lists.sourceforge.net/lists/listinfo/plone-users

[Duncan Booth]

Martin Aspeli <optilude@...> wrote:

> Duncan Booth wrote:
>> Martin Aspeli <optilude@...> wrote:
>>
>>> I think it's this bug: http://dev.plone.org/plone/ticket/7893
>>>
>>> We may be able to work around it by upgrading Kupu and/or KSS. I'm
>>> looking into it now.
>>>
>>
>> The simplest thing may be to just apply the following patch to kupu:
>>
>> Index: kupuploneinit.js
>> ===================================================================
>> --- kupuploneinit.js     (revision 52479)
>> +++ kupuploneinit.js     (revision 52480)
>> @@ -201,6 +201,7 @@
>>              opt.selected = opt.defaultSelected =
>>              (opt.value=='text/html');
>>          }
>>          pulldown.disabled = true;
>> +        pulldown.removeAttribute('name');
>>          var hidden = document.createElement('input');
>>          hidden.type = 'hidden';
>>          hidden.name = fmtname;
>
> This should also be fixed in Plone 3.1
>

The current Plone 3.1 beta has both the above workround in kupu and the
fixed version of KSS. For earlier versions you can upgrade KSS, upgrade
kupu, or just apply the above one-line patch.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Plone-Users mailing list
Plone-Users@...
https://lists.sourceforge.net/lists/listinfo/plone-users

[Brian W. Bramlett]

Steven McDonald wrote:

It would also be nice to be able to TURN KSS off on a per page basis,
is this possible? If you are logged in with edit priv on a page it is
impossible to use the table sort feature, as each time you try to click
on the table header to sort the column it launches you into the KUPU
editor ;-(. Maybe a little tab in the user preference bar. I used to use
something similar that would toggle on/off the green edit border.

Beyond the ticket/patch resolution on another branch of this thread (thanks!), I'm trying to get to the bottom of this one as well, and haven't been able to locate a solution or other discussion.  The issue here is definitely one of usability--"View" is only viewing in a look-but-don't-touch sense, and this has been confusing to people using our sites.  I've also seen cases where clicking on content in View has unintentionally added a editor's lock, which disrupts the development of content.

If this looks like something that isn't known to be filed already, I'd be happy to write it up, but it seemed like the sort of thing that would have already generated some attention.

[Duncan Booth]

"Brian W. Bramlett"
<brian.bramlett@...> wrote:

> Beyond the ticket/patch resolution on another branch of this thread
> (thanks!), I'm trying to get to the bottom of this one as well, and
> haven't been able to locate a solution or other discussion.  The issue
> here is definitely one of usability--"View" is only viewing in a
> look-but-don't-touch sense, and this has been confusing to people
> using our sites.  I've also seen cases where clicking on content in
> View has unintentionally added a editor's lock, which disrupts the
> development of content.

Tell me about it: I just dropped a youtube video into a page, but as
someone with edit rights on the page there is no way (so far as I can tell)
to get the video to play without switching into edit mode.



-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Plone-Users mailing list
Plone-Users@...
https://lists.sourceforge.net/lists/listinfo/plone-users

[Brian W. Bramlett]

Duncan Booth wrote:

"Brian W. Bramlett"
<[e-mail]> wrote:

> Beyond the ticket/patch resolution on another branch of this thread
> (thanks!), I'm trying to get to the bottom of this one as well, and
> haven't been able to locate a solution or other discussion.  The issue
> here is definitely one of usability--"View" is only viewing in a
> look-but-don't-touch sense, and this has been confusing to people
> using our sites.  I've also seen cases where clicking on content in
> View has unintentionally added a editor's lock, which disrupts the
> development of content.

Tell me about it: I just dropped a youtube video into a page, but as
someone with edit rights on the page there is no way (so far as I can tell)
to get the video to play without switching into edit mode.

Finally got around to searching again, and located this how-to:

http://plone.org/documentation/how-to/how-to-setup-and-use-kss-on-plone-3.0/

Item 1.5 (How to disable in-line editing globally?) seems to address the issue, and the comments on this page describe a couple of implementation options.  I used Alan O'Neill's comment as reference, and it worked fine on a 3.0.6 install, as far as I can tell so far.  I haven't looked at a 3.1 distro to see if anything changed for a default installation, but in my opinion, in-line editing (i.e., edit during view) shouldn't be enabled by default for usability reasons.

Cheers,

-- Brian