IMPORTANT: Losing Regression Tests

4 messages Options
Embed this post
Permalink
Paul Ramsey

IMPORTANT: Losing Regression Tests

Reply Threaded More More options
Print post
Permalink
Due to http://trac.osgeo.org/geos/ticket/281 we are about to lose our
regression test harness.

Consider this an impassioned plea for someone w/ enough C++ chops to
rescue the xmltester before I remove this code from the repo.

P.

On Fri, Jul 24, 2009 at 7:59 AM, GEOS <[hidden email]> wrote:

> #281: License issue
> ----------------------+-----------------------------------------------------
>  Reporter:  frankie   |        Owner:  pramsey
>     Type:  defect    |       Status:  new
>  Priority:  blocker   |    Milestone:  3.1.2
> Component:  Default   |      Version:  3.1.1
>  Severity:  Critical  |   Resolution:
>  Keywords:            |
> ----------------------+-----------------------------------------------------
> Changes (by pramsey):
>
>  * owner:  [hidden email] => pramsey
>
> Comment:
>
>  This is a bona fide problem, the "Use in commercial applications requires
>  written permission" clause is certainly not GPL compatible, so this code
>  absolutely must go. As a side note, this also indicates the OSGeo
>  incubation code review process is probably too trusting, one person can't
>  catch everything, and I did not catch this one in my review -- having more
>  than one person perform a review of the code seems a good idea.
>
>  We can't release 3.2 until this is stripped, and I think to incentivize us
>  I am going to remove these files and take XMLTester out of the build.
>
> --
> Ticket URL: <http://trac.osgeo.org/geos/ticket/281#comment:1>
> GEOS <http://geos.refractions.net/>
> GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).
_______________________________________________
geos-devel mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/geos-devel
Mateusz Loskot

Re: IMPORTANT: Losing Regression Tests

Reply Threaded More More options
Print post
Permalink
Paul Ramsey wrote:
> Due to http://trac.osgeo.org/geos/ticket/281 we are about to lose our
> regression test harness.
>
> Consider this an impassioned plea for someone w/ enough C++ chops to

I've made a quick scan through the test source code and I think it
should be possible to replace CMarkupSTL [1] class with TinyXML.
It is used by XMLTester class [1] only.

[1]
http://trac.osgeo.org/geos/browser/trunk/tests/xmltester/markup/MarkupSTL.h
[2] http://trac.osgeo.org/geos/browser/trunk/tests/xmltester/XMLTester.h#L57


Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net
Charter Member of OSGeo, http://osgeo.org
_______________________________________________
geos-devel mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/geos-devel
--
Mateusz Loskot
http://mateusz.loskot.net
strk

Re: IMPORTANT: Losing Regression Tests

Reply Threaded More More options
Print post
Permalink
On Sat, Sep 12, 2009 at 02:43:25PM +0100, Mateusz Loskot wrote:
> Paul Ramsey wrote:
> > Due to http://trac.osgeo.org/geos/ticket/281 we are about to lose our
> > regression test harness.
> >
> > Consider this an impassioned plea for someone w/ enough C++ chops to
>
> I've made a quick scan through the test source code and I think it
> should be possible to replace CMarkupSTL [1] class with TinyXML.
> It is used by XMLTester class [1] only.

Committed in r2634. Thanks for the tip.
God save the testsuite!

--strk;

 Free GIS & Flash consultant/developer      ()  ASCII Ribbon Campaign
 http://foo.keybit.net/~strk/services.html  /\  Keep it simple!
_______________________________________________
geos-devel mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/geos-devel
Mateusz Loskot

Re: IMPORTANT: Losing Regression Tests

Reply Threaded More More options
Print post
Permalink
strk wrote:

> On Sat, Sep 12, 2009 at 02:43:25PM +0100, Mateusz Loskot wrote:
>> Paul Ramsey wrote:
>>> Due to http://trac.osgeo.org/geos/ticket/281 we are about to lose our
>>> regression test harness.
>>>
>>> Consider this an impassioned plea for someone w/ enough C++ chops to
>> I've made a quick scan through the test source code and I think it
>> should be possible to replace CMarkupSTL [1] class with TinyXML.
>> It is used by XMLTester class [1] only.
>
> Committed in r2634. Thanks for the tip.

Sandro, thanks for that! I should apply DIY principle, I know.

> God save the testsuite!

and the Queen too!

Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net
_______________________________________________
geos-devel mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/geos-devel
--
Mateusz Loskot
http://mateusz.loskot.net