[Fwd: Re: [xwiki-notifications] r21750 - in sandbox/gsoc/widgets/src/main: . XWikiFox XWikiFox/chrome XWikiFox/chrome/XWikiFox XWikiFox/chrome/XWikiFox/content XWikiFox/chrome/XWikiFox/content/images XWikiFox/chrome/XWikiFox/locale XWikiFox/chrome/XWikiFox/locale/en-US]

1 message

lucaa

[Fwd: Re: [xwiki-notifications] r21750 - in sandbox/gsoc/widgets/src/main: . XWikiFox XWikiFox/chrome XWikiFox/chrome/XWikiFox XWikiFox/chrome/XWikiFox/content XWikiFox/chrome/XWikiFox/content/images XWikiFox/chrome/XWikiFox/locale XWikiFox/chrome/XWikiFox/locale/en-US]

Reply Threaded

-------- Original Message --------
Subject: Re: [xwiki-notifications] r21750 - in sandbox/gsoc/widgets/src/main: .
XWikiFox XWikiFox/chrome XWikiFox/chrome/XWikiFox
XWikiFox/chrome/XWikiFox/content XWikiFox/chrome/XWikiFox/content/images
XWikiFox/chrome/XWikiFox/locale XWikiFox/chrome/XWikiFox/locale/en-US
Date: Thu, 02 Jul 2009 12:17:37 +0300
From: Anca Paula Luca <[hidden email]>
Reply-To: XWiki Notifications <[hidden email]>
To: XWiki Notifications <[hidden email]>
References: <[hidden email]>

alexmaru (SVN) wrote:
> Author: alexmaru
> Date: 2009-07-01 18:16:45 +0200 (Wed, 01 Jul 2009)
> New Revision: 21750
>
> Added:
> sandbox/gsoc/widgets/src/main/XWikiFox/
> sandbox/gsoc/widgets/src/main/XWikiFox/XWikiFox.xpi

This is not needed. Redundant is bad because it takes up unneeded space, brings
unneeded complexity to the sources tree, and it can cause unsynchronized sources
with packed versions. You should have a maven build create this pack for you.

> sandbox/gsoc/widgets/src/main/XWikiFox/chrome.manifest
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox.jar

Neither is this, same, you can have a maven build create it for you. Or, for the
start, use just the sources, it's not mandatory to pack them in a .jar.

> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/images/
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/images/icon.png
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/images/xwiki.png
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.css
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.js
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.xul
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/locale/
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/locale/en-US/
> sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/locale/en-US/xwikifox.dtd
> sandbox/gsoc/widgets/src/main/XWikiFox/install.rdf
> Log:
> Added a first version of XWikiFox
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/XWikiFox.xpi
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: sandbox/gsoc/widgets/src/main/XWikiFox/XWikiFox.xpi
> ___________________________________________________________________
> Name: svn:mime-type
> + application/octet-stream
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/images/icon.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/images/icon.png
> ___________________________________________________________________
> Name: svn:mime-type
> + application/octet-stream
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/images/xwiki.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/images/xwiki.png
> ___________________________________________________________________
> Name: svn:mime-type
> + application/octet-stream
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.css
> ===================================================================
> --- sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.css (rev 0)
> +++ sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.css 2009-07-01 16:16:45 UTC (rev 21750)
> @@ -0,0 +1,5 @@
> +
> +#xwikifox-statusbar {
> +
> +
> +}

I would have rather went for an empty file, if you needed it in the setup but
still had no content to put inside.

> \ No newline at end of file
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.js
> ===================================================================
> --- sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.js (rev 0)
> +++ sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.js 2009-07-01 16:16:45 UTC (rev 21750)
> @@ -0,0 +1,8 @@
> +
> +function test(){
> +alert("test");
> +}

Avoid to commit this, even if you need it locally.

Happy coding,
Anca

> +
> +function openUrl(url){
> + var tab = gBrowser.loadOneTab(url);
> +}
> \ No newline at end of file
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.xul
> ===================================================================
> --- sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.xul (rev 0)
> +++ sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/content/xwikifox.xul 2009-07-01 16:16:45 UTC (rev 21750)
> @@ -0,0 +1,35 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +
> +<?xml-stylesheet href="chrome://xwikifox/content/xwikifox.css" type="text/css"?>
> +
> +<!DOCTYPE overlay SYSTEM "chrome://xwikifox/locale/xwikifox.dtd">
> +<overlay id="xwikifox-overlay"
> + xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
> +
> +
> + <statusbar id="status-bar">
> + <statusbarpanel id="xwikifox-statusbar"
> + image="chrome://xwikifox/content/images/xwiki.png"
> + class="statusbarpanel-menu-iconic"
> + context="xwikifox-main-menupopup"
> + ondblclick="openUrl('http://xwiki.org/')"
> + onclick=""
> + tooltiptext="XWikiFox - relevant info from your wikis">
> +
> +
> + <label id="xwikifox-statusbar-text" style="margin: 1px"/>
> + </statusbarpanel>
> +
> +<menupopup id="xwikifox-main-menupopup">
> +<menuitem id="xwikifox-menuitem-update" label="&xwikifox.update;" oncommand="" />
> + <menu id="xwikifox-menuitem-wiki" label="&xwikifox.wikis;">
> + <menupopup id="xwikifox-wiki" sortDirection="ascending" onpopupshowing=""/>
> + </menu>
> + <menuitem id="xwikifox-menuitem-preference" label="&xwikifox.preference;" oncommand="" />
> +</menupopup>
> +
> + </statusbar>
> +
> + 
> + <script src="xwikifox.js"/>
> +</overlay>
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/locale/en-US/xwikifox.dtd
> ===================================================================
> --- sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/locale/en-US/xwikifox.dtd (rev 0)
> +++ sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox/locale/en-US/xwikifox.dtd 2009-07-01 16:16:45 UTC (rev 21750)
> @@ -0,0 +1,3 @@
> +<!ENTITY xwikifox.update "Update information now">
> +<!ENTITY xwikifox.wikis "Change wiki">
> +<!ENTITY xwikifox.preference "Preferences...">
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox.jar
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: sandbox/gsoc/widgets/src/main/XWikiFox/chrome/XWikiFox.jar
> ___________________________________________________________________
> Name: svn:mime-type
> + application/octet-stream
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/chrome.manifest
> ===================================================================
> --- sandbox/gsoc/widgets/src/main/XWikiFox/chrome.manifest (rev 0)
> +++ sandbox/gsoc/widgets/src/main/XWikiFox/chrome.manifest 2009-07-01 16:16:45 UTC (rev 21750)
> @@ -0,0 +1,3 @@
> +content xwikifox jar:chrome/XWikiFox.jar!/content/
> +overlay chrome://browser/content/browser.xul chrome://xwikifox/content/xwikifox.xul
> +locale xwikifox en-US jar:chrome/XWikiFox.jar!/locale/en-US/
>
> Added: sandbox/gsoc/widgets/src/main/XWikiFox/install.rdf
> ===================================================================
> --- sandbox/gsoc/widgets/src/main/XWikiFox/install.rdf (rev 0)
> +++ sandbox/gsoc/widgets/src/main/XWikiFox/install.rdf 2009-07-01 16:16:45 UTC (rev 21750)
> @@ -0,0 +1,21 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
> + xmlns:em="http://www.mozilla.org/2004/em-rdf#">
> + <Description about="urn:mozilla:install-manifest">
> + <em:id>[hidden email]</em:id>
> + <em:name>XWikiFox</em:name>
> + <em:version>0.5</em:version>
> + <em:creator>Alexandru Cismaru</em:creator>
> + <em:description>Relevant information from your wiki into Firefox extension.</em:description>
> + <em:homepageURL>http://gsoc.myxwiki.org/xwiki/bin/view/XWiki+Widget+and+Firefox+extension/</em:homepageURL>
> + <em:iconURL>chrome://xwikifox/content/images/icon.png</em:iconURL>
> +
> + <em:targetApplication>
> + <Description>
> + <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id> 
> + <em:minVersion>3.0</em:minVersion>
> + <em:maxVersion>3.5.*</em:maxVersion>
> + </Description>
> + </em:targetApplication>
> + </Description>
> +</RDF>
>
> _______________________________________________
> notifications mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/notifications

_______________________________________________
notifications mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/notifications
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs