Found (and fixed?) new Paste bug and fixed Change Speed
|
|
André Pinto
|
Hi
Trying to fix "P2 - Crash applying non-zero Speed, Tempo, Pitch or Sliding Time Scale effects if label and time tracks present.", I've found another new bug: 1 - Create two tracks with tones of 30 sec. 2 - Select 1 second of one track and Edit -> Copy. 3 - Select a wider selection of audio in both tracks and Edit -> Paste. Result: The first track has its duration reduced as expected, but the second track keeps the initial 30 secs. This bug is present in 1.3.7 too. I think I have fixed it including unique calls to ClearAndPaste instead of individual calls to Clear and Paste. As multiple clipboard is also implemented I tried to find a solution where I could keep that functionality and fix the bug with paste from individual sources to multiple targets. Then I worked on Change Speed bug, and after some changes (one of them being the comment of HandleGroupChangeSpeed, it is used by two other functionalities that I'll fix after this) I think it is working as intended. Like always the "bug reporters" confirmation would be appreciated. Obviously I'll take a look at Tempo, Pitch and Sliding bugs. I've committed the Change Speed fix now because I wanted to know if you think this is the right approach to the time stretching problems before changing all the related functions. Thanks, André. ------------------------------------------------------------------------------ _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
||||||||||||||||
|
André Pinto
|
Hi,
I've implemented the same changes to the other bugs. "P2 - Crash applying non-zero Speed, Tempo, Pitch or Sliding Time Scale effects if label and time tracks present." should now be fixed. As always, if possible, I would appreciate some testing to help confirming the fix. Thanks, André. On Sat, Jul 4, 2009 at 8:01 PM, André Pinto <[hidden email]> wrote: Hi ------------------------------------------------------------------------------ _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
||||||||||||||||
Martyn Shaw-2
|
Hi André
I am seeing some improvements here in the way that labels are handled (I think), but I never saw the original 'crash' so can't say if that has been fixed. In principle what you have done looks OK to me, but I haven't studied the code in detail. For what we do with the labels when we change speed etc, I am not at all sure that we are doing the right thing. For example a track of length 30s with a label from 10s to 16s and you change speed by 100%. The track decreases in length to 15s but the label does not keep in step, it's now at 10-15s but shouldn't it be at 5-8s to keep in time with the thing you labelled? I'm sure this must have been discussed before. Timeline changing effects would not normally be applied to just some of the tracks in a group, surely. So not modifying the labels to keep in step does not seem right. Also, I have seen ASSERT messages twice whilst playing with this for the last few minutes. The second of these was in LabelTrack.h at WX_DEFINE_ARRAY(LabelStruct *, LabelArray); (I think). Nothing reproducible unfortunately, but worrying. TTFN Martyn André Pinto wrote: > Hi, > > I've implemented the same changes to the other bugs. > > "P2 - Crash applying non-zero Speed, Tempo, Pitch or Sliding Time Scale > effects if label and time tracks present." should now be fixed. > > As always, if possible, I would appreciate some testing to help > confirming the fix. > > Thanks, > André. > > On Sat, Jul 4, 2009 at 8:01 PM, André Pinto <[hidden email] > <mailto:[hidden email]>> wrote: > > Hi > > Trying to fix "P2 - Crash applying non-zero Speed, Tempo, Pitch or > Sliding Time Scale effects if label and time tracks present.", I've > found another new bug: > > 1 - Create two tracks with tones of 30 sec. > 2 - Select 1 second of one track and Edit -> Copy. > 3 - Select a wider selection of audio in both tracks and Edit -> Paste. > > Result: The first track has its duration reduced as expected, but > the second track keeps the initial 30 secs. > > This bug is present in 1.3.7 too. > > I think I have fixed it including unique calls to ClearAndPaste > instead of individual calls to Clear and Paste. As multiple > clipboard is also implemented I tried to find a solution where I > could keep that functionality and fix the bug with paste from > individual sources to multiple targets. > > Then I worked on Change Speed bug, and after some changes (one of > them being the comment of HandleGroupChangeSpeed, it is used by two > other functionalities that I'll fix after this) I think it is > working as intended. Like always the "bug reporters" confirmation > would be appreciated. > > Obviously I'll take a look at Tempo, Pitch and Sliding bugs. I've > committed the Change Speed fix now because I wanted to know if you > think this is the right approach to the time stretching problems > before changing all the related functions. > > Thanks, > André. > > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > > > ------------------------------------------------------------------------ > > _______________________________________________ > audacity-devel mailing list > [hidden email] > https://lists.sourceforge.net/lists/listinfo/audacity-devel ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/blackberry _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
||||||||||||||||
|
André Pinto
|
Hi Martyn,
First of all, sorry for the delay with the reply but unfortunately I had an uncle who past away on Monday and yesterday I was in his funeral with my cousins and aunt. thanks a lot for reporting that problem with the labels. It should now be fixed. Regarding the crashes and bugs that you didn't see, you can still check them on 1.3.7 if you have it. Thanks, André. On Tue, Jul 7, 2009 at 12:30 AM, Martyn Shaw <[hidden email]> wrote: Hi André ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
||||||||||||||||
|
Martyn Shaw-2
|
Hi André
I'm sorry to hear about your uncle. Labels now move how I would expect with timeline changing effects. The Repeat effect also now seems to behave properly. I think you referred to 'the usual problem' at some point recently (but can't find the reference right now). It seems to me that you have a good framework in place to easily handle and fix problems with linked tracks. I just wonder how many other problems there are with Clear and Paste that you could easily fix. Any idea how to search for them? Maybe there are none left! Thanks for your good work, especially under difficult circumstances! Martyn André Pinto wrote: > Hi Martyn, > > First of all, sorry for the delay with the reply but unfortunately I had > an uncle who past away on Monday and yesterday I was in his funeral with > my cousins and aunt. > > thanks a lot for reporting that problem with the labels. It should now > be fixed. > > Regarding the crashes and bugs that you didn't see, you can still check > them on 1.3.7 if you have it. > > Thanks, > André. > > On Tue, Jul 7, 2009 at 12:30 AM, Martyn Shaw > <[hidden email] <mailto:[hidden email]>> wrote: > > Hi André > > I am seeing some improvements here in the way that labels are handled > (I think), but I never saw the original 'crash' so can't say if that > has been fixed. In principle what you have done looks OK to me, but I > haven't studied the code in detail. > > For what we do with the labels when we change speed etc, I am not at > all sure that we are doing the right thing. For example a track of > length 30s with a label from 10s to 16s and you change speed by 100%. > The track decreases in length to 15s but the label does not keep in > step, it's now at 10-15s but shouldn't it be at 5-8s to keep in time > with the thing you labelled? > > I'm sure this must have been discussed before. Timeline changing > effects would not normally be applied to just some of the tracks in a > group, surely. So not modifying the labels to keep in step does not > seem right. > > Also, I have seen ASSERT messages twice whilst playing with this for > the last few minutes. The second of these was in LabelTrack.h at > WX_DEFINE_ARRAY(LabelStruct *, LabelArray); > (I think). Nothing reproducible unfortunately, but worrying. > > TTFN > Martyn > > André Pinto wrote: > > Hi, > > > > I've implemented the same changes to the other bugs. > > > > "P2 - Crash applying non-zero Speed, Tempo, Pitch or Sliding Time > Scale > > effects if label and time tracks present." should now be fixed. > > > > As always, if possible, I would appreciate some testing to help > > confirming the fix. > > > > Thanks, > > André. > > > > On Sat, Jul 4, 2009 at 8:01 PM, André Pinto > <[hidden email] <mailto:[hidden email]> > > <mailto:[hidden email] <mailto:[hidden email]>>> wrote: > > > > Hi > > > > Trying to fix "P2 - Crash applying non-zero Speed, Tempo, > Pitch or > > Sliding Time Scale effects if label and time tracks > present.", I've > > found another new bug: > > > > 1 - Create two tracks with tones of 30 sec. > > 2 - Select 1 second of one track and Edit -> Copy. > > 3 - Select a wider selection of audio in both tracks and Edit > -> Paste. > > > > Result: The first track has its duration reduced as expected, but > > the second track keeps the initial 30 secs. > > > > This bug is present in 1.3.7 too. > > > > I think I have fixed it including unique calls to ClearAndPaste > > instead of individual calls to Clear and Paste. As multiple > > clipboard is also implemented I tried to find a solution where I > > could keep that functionality and fix the bug with paste from > > individual sources to multiple targets. > > > > Then I worked on Change Speed bug, and after some changes (one of > > them being the comment of HandleGroupChangeSpeed, it is used > by two > > other functionalities that I'll fix after this) I think it is > > working as intended. Like always the "bug reporters" confirmation > > would be appreciated. > > > > Obviously I'll take a look at Tempo, Pitch and Sliding bugs. I've > > committed the Change Speed fix now because I wanted to know > if you > > think this is the right approach to the time stretching problems > > before changing all the related functions. > > > > Thanks, > > André. > > > > > > > > > ------------------------------------------------------------------------ > > > > > ------------------------------------------------------------------------------ > > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > audacity-devel mailing list > > [hidden email] > <mailto:[hidden email]> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > ------------------------------------------------------------------------------ > Enter the BlackBerry Developer Challenge > This is your chance to win up to $100,000 in prizes! For a limited time, > vendors submitting new applications to BlackBerry App World(TM) will > have > the opportunity to enter the BlackBerry Developer Challenge. See > full prize > details at: http://p.sf.net/sfu/blackberry > _______________________________________________ > audacity-devel mailing list > [hidden email] > <mailto:[hidden email]> > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
||||||||||||||||
|
André Pinto
|
Hi,
I only saw this now. Thanks Martyn. Regarding the usual problem, I did a quick search for calls to Clear and Paste that doesn't considerate the functions as group functions but I was only able to find the Truncate Silence issue (that is pending till a final decision about what should it do). It's possible that other functions have the "usual problem" but to identify them a deep read of their code might be needed. I'll keep experimenting with these functionalities and surely any help testing paste and clear is welcome. André. On Wed, Jul 8, 2009 at 11:43 PM, Martyn Shaw <[hidden email]> wrote: Hi André ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ audacity-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/audacity-devel |
||||||||||||||||
| Free Embeddable Forum Powered by Nabble | Help |
