Focus "and on top" issues on Windows

14 messages Options
Embed this post
Permalink
Gale (Audacity Team)

Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink

Leland,

Yesterday I removed P1 "new window does not come up on top" and P2
"clearing to new empty project loses focus" from the Checklist as they
had gone from my ANSI Release build on Windows. I assumed (although
there was no such comment accompanying it), that this commit had solved
it:

   07 07 2009
   Update of /cvsroot/audacity/audacity-src/src
   In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv32158

   Modified Files:
   Project.cpp Project.h
   Log Message:
   Finally found the scenario where the focus would be lost upon Project
   windows
   receiving an activate event. Back in July 2006, I'd added a SetFocus()
   to force focus back to the trackpanel. Unfortunately, this was a bit
   forceful, so in Jun 2009, I'd removed it because users would expect
   the control that had focus to still have focus up return to the
   project.

   However, there are case where the window frame gets focus when it
   receives an activate event. Since that's just not very useful, I've
   re-added the focus handling, but made it a bit less forceful this time
   round.

However in the Unicode Release I built today, both problems are still
there. The P1 problem makes working with more than one project
impossible on XP, unless you happen to know the trick of clicking on
the correct task bar icon. I assume these to be Windows only problems
as I have never seen them on Linux. Any ideas?



Thanks


Gale
 


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Leland (Audacity Team)

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
Funny...This was on my list to do for the evening.  Update and try it
again.  Let me know how it goes.

Leland

[hidden email] wrote:

> Leland,
>
> Yesterday I removed P1 "new window does not come up on top" and P2
> "clearing to new empty project loses focus" from the Checklist as they
> had gone from my ANSI Release build on Windows. I assumed (although
> there was no such comment accompanying it), that this commit had solved
> it:
>
>    07 07 2009
>    Update of /cvsroot/audacity/audacity-src/src
>    In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv32158
>
>    Modified Files:
>    Project.cpp Project.h
>    Log Message:
>    Finally found the scenario where the focus would be lost upon Project
>    windows
>    receiving an activate event. Back in July 2006, I'd added a SetFocus()
>    to force focus back to the trackpanel. Unfortunately, this was a bit
>    forceful, so in Jun 2009, I'd removed it because users would expect
>    the control that had focus to still have focus up return to the
>    project.
>
>    However, there are case where the window frame gets focus when it
>    receives an activate event. Since that's just not very useful, I've
>    re-added the focus handling, but made it a bit less forceful this time
>    round.
>
> However in the Unicode Release I built today, both problems are still
> there. The P1 problem makes working with more than one project
> impossible on XP, unless you happen to know the trick of clicking on
> the correct task bar icon. I assume these to be Windows only problems
> as I have never seen them on Linux. Any ideas?
>
>
>
> Thanks
>
>
> Gale
>  
>
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge  
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize  
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Gale (Audacity Team)

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink

| From Leland <[hidden email]>
| Thu, 09 Jul 2009 02:38:28 -0500
| Subject: [Audacity-devel] Focus "and on top" issues on Windows
> Funny...This was on my list to do for the evening.  Update and try it
> again.  Let me know how it goes.
>
> Leland

Unicode Release just built after updating now doesn't have either
of the below issues.


Thanks


Gale


 

> [hidden email] wrote:
> > Leland,
> >
> > Yesterday I removed P1 "new window does not come up on top" and P2
> > "clearing to new empty project loses focus" from the Checklist as they
> > had gone from my ANSI Release build on Windows. I assumed (although
> > there was no such comment accompanying it), that this commit had solved
> > it:
> >
> >    07 07 2009
> >    Update of /cvsroot/audacity/audacity-src/src
> >    In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv32158
> >
> >    Modified Files:
> >    Project.cpp Project.h
> >    Log Message:
> >    Finally found the scenario where the focus would be lost upon Project
> >    windows
> >    receiving an activate event. Back in July 2006, I'd added a SetFocus()
> >    to force focus back to the trackpanel. Unfortunately, this was a bit
> >    forceful, so in Jun 2009, I'd removed it because users would expect
> >    the control that had focus to still have focus up return to the
> >    project.
> >
> >    However, there are case where the window frame gets focus when it
> >    receives an activate event. Since that's just not very useful, I've
> >    re-added the focus handling, but made it a bit less forceful this time
> >    round.
> >
> > However in the Unicode Release I built today, both problems are still
> > there. The P1 problem makes working with more than one project
> > impossible on XP, unless you happen to know the trick of clicking on
> > the correct task bar icon. I assume these to be Windows only problems
> > as I have never seen them on Linux. Any ideas?
> >
> >
> >
> > Thanks
> >
> >
> > Gale


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Dan Horgan

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
In reply to this post by Leland (Audacity Team)
On Linux, (with a 'focus-follows-mouse' window manager) I think this causes a
crash for me:
1) Open Audacity
2) Create another project
3) Close one of the projects

Program received signal SIGSEGV, Segmentation fault.
#0  0x00000000 in ?? ()
#1  0x0822d5da in AudacityProject::OnActivate (this=0xa65f7f0, event=@0xbf8eb4c8) at Project.cpp:1675
#2  0xb76ecb0f in wxAppConsole::HandleEvent (this=0xa438e60, handler=0xa65f7f0, func=0x822d552 <AudacityProject::OnActivate(wxActivateEvent&)>, event=@0xbf8eb4c8)
    at ./src/common/appbase.cpp:322
[...]

I'm fairly sure this didn't happen before and it definitely doesn't happen
in 1.3.7.
Then again, if it only takes effect when focus-follows-mouse is enabled
it might not affect many people.

Dan

On Thu, Jul 09, 2009 at 02:38:28AM -0500, Leland wrote:

> Funny...This was on my list to do for the evening.  Update and try it
> again.  Let me know how it goes.
>
> Leland
>
> [hidden email] wrote:
> > Leland,
> >
> > Yesterday I removed P1 "new window does not come up on top" and P2
> > "clearing to new empty project loses focus" from the Checklist as they
> > had gone from my ANSI Release build on Windows. I assumed (although
> > there was no such comment accompanying it), that this commit had solved
> > it:
> >
> >    07 07 2009
> >    Update of /cvsroot/audacity/audacity-src/src
> >    In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv32158
> >
> >    Modified Files:
> >    Project.cpp Project.h
> >    Log Message:
> >    Finally found the scenario where the focus would be lost upon Project
> >    windows
> >    receiving an activate event. Back in July 2006, I'd added a SetFocus()
> >    to force focus back to the trackpanel. Unfortunately, this was a bit
> >    forceful, so in Jun 2009, I'd removed it because users would expect
> >    the control that had focus to still have focus up return to the
> >    project.
> >
> >    However, there are case where the window frame gets focus when it
> >    receives an activate event. Since that's just not very useful, I've
> >    re-added the focus handling, but made it a bit less forceful this time
> >    round.
> >
> > However in the Unicode Release I built today, both problems are still
> > there. The P1 problem makes working with more than one project
> > impossible on XP, unless you happen to know the trick of clicking on
> > the correct task bar icon. I assume these to be Windows only problems
> > as I have never seen them on Linux. Any ideas?
> >
> >
> >
> > Thanks
> >
> >
> > Gale
> >  
> >
> >
> > ------------------------------------------------------------------------------
> > Enter the BlackBerry Developer Challenge  
> > This is your chance to win up to $100,000 in prizes! For a limited time,
> > vendors submitting new applications to BlackBerry App World(TM) will have
> > the opportunity to enter the BlackBerry Developer Challenge. See full prize  
> > details at: http://p.sf.net/sfu/Challenge
> > _______________________________________________
> > audacity-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >
>
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge  
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize  
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Richard Ash (audacity-help)

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
On Fri, 2009-07-10 at 19:38 +0100, Dan Horgan wrote:

> On Linux, (with a 'focus-follows-mouse' window manager) I think this causes a
> crash for me:
> 1) Open Audacity
> 2) Create another project
> 3) Close one of the projects
>
> Program received signal SIGSEGV, Segmentation fault.
> #0  0x00000000 in ?? ()
> #1  0x0822d5da in AudacityProject::OnActivate (this=0xa65f7f0, event=@0xbf8eb4c8) at Project.cpp:1675
> #2  0xb76ecb0f in wxAppConsole::HandleEvent (this=0xa438e60, handler=0xa65f7f0, func=0x822d552 <AudacityProject::OnActivate(wxActivateEvent&)>, event=@0xbf8eb4c8)
>     at ./src/common/appbase.cpp:322
> [...]
>
> I'm fairly sure this didn't happen before and it definitely doesn't happen
> in 1.3.7.
> Then again, if it only takes effect when focus-follows-mouse is enabled
> it might not affect many people.

Ack, this is now crashing for me as well (I am using
focus-follows-mouse, with Fluxbox as it happens). My back-trace looks
very similar, I think we have something that needs fixing here.

#1  0x08225471 in AudacityProject::OnActivate (this=0x8d8f258,
    event=@0xbf8b426c) at Project.cpp:1673
#2  0xb75e68dd in wxAppConsole::HandleEvent (this=0x8b4b9e8,
    handler=0x8d8f258,
    func=0x82253e0 <AudacityProject::OnActivate(wxActivateEvent&)>,
    event=@0xbf8b426c) at ../src/common/appbase.cpp:322
#3  0xb76a1e50 in wxEvtHandler::ProcessEventIfMatches
(entry=@0x8815ef0,
    handler=0x8d8f258, event=@0xbf8b426c)
at ../src/common/event.cpp:1231
#4  0xb76a3cce in wxEventHashTable::HandleEvent (this=0x8815d1c,
    event=@0xbf8b426c, self=0x8d8f258) at ../src/common/event.cpp:906
#5  0xb76a3e31 in wxEvtHandler::ProcessEvent (this=0x8d8f258,
    event=@0xbf8b426c) at ../src/common/event.cpp:1293
#6  0xb790fa29 in gtk_frame_focus_in_callback (widget=0x8b7aa30,
win=0x8d8f258)
    at ../src/gtk/toplevel.cpp:165

In a CVS build from 24th June or so it doesn't happen, so it's a recent
change. I updated to a week ago (3rd July), and that build doesn't crash
either, so it's a recent change causing this.

Richard


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Richard Ash (audacity-help)

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
On Fri, 2009-07-10 at 23:15 +0100, Richard Ash wrote:
> In a CVS build from 24th June or so it doesn't happen, so it's a recent
> change. I updated to a week ago (3rd July), and that build doesn't crash
> either, so it's a recent change causing this.
Was OK at 6th July as well.

Richard


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Leland (Audacity Team)

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
In reply to this post by Dan Horgan
Dan Horgan wrote:

> On Linux, (with a 'focus-follows-mouse' window manager) I think this causes a
> crash for me:
> 1) Open Audacity
> 2) Create another project
> 3) Close one of the projects
>
> Program received signal SIGSEGV, Segmentation fault.
> #0  0x00000000 in ?? ()
> #1  0x0822d5da in AudacityProject::OnActivate (this=0xa65f7f0, event=@0xbf8eb4c8) at Project.cpp:1675
> #2  0xb76ecb0f in wxAppConsole::HandleEvent (this=0xa438e60, handler=0xa65f7f0, func=0x822d552 <AudacityProject::OnActivate(wxActivateEvent&)>, event=@0xbf8eb4c8)
>     at ./src/common/appbase.cpp:322
> [...]
>
> I'm fairly sure this didn't happen before and it definitely doesn't happen
> in 1.3.7.
> Then again, if it only takes effect when focus-follows-mouse is enabled
> it might not affect many people.
>
This is my fault and I'll fix it after dinner.

Leland

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Leland (Audacity Team)

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
This should now be fixed.

When the "focus follows mouse" option is enabled, a subwindow of a different project can be returned by FindFocus(), but that is typically within the project that is being deleted.  When the remaining project window gets the activate event, it was trying to set the focus to the already deleted subwindow.

Leland

Leland wrote:

> Dan Horgan wrote:
>> On Linux, (with a 'focus-follows-mouse' window manager) I think this causes a
>> crash for me:
>> 1) Open Audacity
>> 2) Create another project
>> 3) Close one of the projects
>>
>> Program received signal SIGSEGV, Segmentation fault.
>> #0  0x00000000 in ?? ()
>> #1  0x0822d5da in AudacityProject::OnActivate (this=0xa65f7f0, event=@0xbf8eb4c8) at Project.cpp:1675
>> #2  0xb76ecb0f in wxAppConsole::HandleEvent (this=0xa438e60, handler=0xa65f7f0, func=0x822d552 <AudacityProject::OnActivate(wxActivateEvent&)>, event=@0xbf8eb4c8)
>>     at ./src/common/appbase.cpp:322
>> [...]
>>
>> I'm fairly sure this didn't happen before and it definitely doesn't happen
>> in 1.3.7.
>> Then again, if it only takes effect when focus-follows-mouse is enabled
>> it might not affect many people.
>>
> This is my fault and I'll fix it after dinner.
>
> Leland
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge  
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize  
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> audacity-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Dan Horgan

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
On Fri, Jul 10, 2009 at 11:54:56PM -0500, Leland wrote:
> This should now be fixed.
>
> When the "focus follows mouse" option is enabled, a subwindow of a different project can be returned by FindFocus(), but that is typically within the project that is being deleted.  When the remaining project window gets the activate event, it was trying to set the focus to the already deleted subwindow.
>
> Leland

Thanks, that fixes it for me in the case I mentioned before. However,
the same thing still happens when I press OK on the preferences window
(pretty much the same backtrace). I think in general the window can be
sent the deactivate event after the other one has been activated, so it
still gets the wrong focus.

Dan

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Leland (Audacity Team)

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
Dan Horgan wrote:

> On Fri, Jul 10, 2009 at 11:54:56PM -0500, Leland wrote:
>> This should now be fixed.
>>
>> When the "focus follows mouse" option is enabled, a subwindow of a different project can be returned by FindFocus(), but that is typically within the project that is being deleted.  When the remaining project window gets the activate event, it was trying to set the focus to the already deleted subwindow.
>>
>> Leland
>
> Thanks, that fixes it for me in the case I mentioned before. However,
> the same thing still happens when I press OK on the preferences window
> (pretty much the same backtrace). I think in general the window can be
> sent the deactivate event after the other one has been activated, so it
> still gets the wrong focus.
>
Son of a !!!  Grrrr!

There's got to be a better way...

Leland


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Leland (Audacity Team)

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
In reply to this post by Dan Horgan
Dan Horgan wrote:

> On Fri, Jul 10, 2009 at 11:54:56PM -0500, Leland wrote:
>> This should now be fixed.
>>
>> When the "focus follows mouse" option is enabled, a subwindow of a different project can be returned by FindFocus(), but that is typically within the project that is being deleted.  When the remaining project window gets the activate event, it was trying to set the focus to the already deleted subwindow.
>>
>> Leland
>
> Thanks, that fixes it for me in the case I mentioned before. However,
> the same thing still happens when I press OK on the preferences window
> (pretty much the same backtrace). I think in general the window can be
> sent the deactivate event after the other one has been activated, so it
> still gets the wrong focus.
>
Alright Dan...can ya give it a try again?

Thanks much,

Leland


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Dan Horgan

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
On Sat, Jul 11, 2009 at 01:21:22PM -0500, Leland wrote:

> Dan Horgan wrote:
> > On Fri, Jul 10, 2009 at 11:54:56PM -0500, Leland wrote:
> >> This should now be fixed.
> >>
> >> When the "focus follows mouse" option is enabled, a subwindow of a different project can be returned by FindFocus(), but that is typically within the project that is being deleted.  When the remaining project window gets the activate event, it was trying to set the focus to the already deleted subwindow.
> >>
> >> Leland
> >
> > Thanks, that fixes it for me in the case I mentioned before. However,
> > the same thing still happens when I press OK on the preferences window
> > (pretty much the same backtrace). I think in general the window can be
> > sent the deactivate event after the other one has been activated, so it
> > still gets the wrong focus.
> >
> Alright Dan...can ya give it a try again?
>
> Thanks much,
>
> Leland

Nice one, I think that's done it! I can't find a way to crash it now, at
least.

Incidentally, I don't know whether "P3 Preferences window: OK button
does not work when a tab is selected in the left-hand panel." was an
instance of this or something separate, but I can't reproduce that
problem any more.

Thanks,
Dan

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Gale (Audacity Team)

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink

| From Dan Horgan <[hidden email]>
| Sat, 11 Jul 2009 20:04:51 +0100
| Subject: [Audacity-devel] Focus "and on top" issues on Windows

> On Sat, Jul 11, 2009 at 01:21:22PM -0500, Leland wrote:
> > Dan Horgan wrote:
> > > On Fri, Jul 10, 2009 at 11:54:56PM -0500, Leland wrote:
> > >> This should now be fixed.
> > >>
> > >> When the "focus follows mouse" option is enabled, a subwindow of a different project can be returned by FindFocus(), but that is typically within the project that is being deleted.  When the remaining project window gets the activate event, it was trying to set the focus to the already deleted subwindow.
> > >>
> > >> Leland
> > >
> > > Thanks, that fixes it for me in the case I mentioned before. However,
> > > the same thing still happens when I press OK on the preferences window
> > > (pretty much the same backtrace). I think in general the window can be
> > > sent the deactivate event after the other one has been activated, so it
> > > still gets the wrong focus.
> > >
> > Alright Dan...can ya give it a try again?
> >
> > Thanks much,
> >
> > Leland
>
> Nice one, I think that's done it! I can't find a way to crash it now, at
> least.
>
> Incidentally, I don't know whether "P3 Preferences window: OK button
> does not work when a tab is selected in the left-hand panel." was an
> instance of this or something separate, but I can't reproduce that
> problem any more.

No, it wasn't a crash, or it would have been rated higher. It means
that when a tab is selected, you cannot hit ENTER to save and exit
preferences even though the OK button appears to be selected.
You have to use a mouse to click OK, or without a mouse, TAB
into the main part of the window, then ENTER will work. I will
clarify that on the Checklist.

The bug is still there on Windows. Can you just hit ENTER on Linux
with the tab selected? I'm still doing a clean checkout on Linux to see
if I can fix the compile problems I had yesterday...



Gale







------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Dan Horgan

Re: Focus "and on top" issues on Windows

Reply Threaded More More options
Print post
Permalink
On Sat, Jul 11, 2009 at 09:27:52PM +0100, Gale Andrews wrote:

> | From Dan Horgan <[hidden email]>
> | Sat, 11 Jul 2009 20:04:51 +0100
> | Subject: [Audacity-devel] Focus "and on top" issues on Windows
> > [snip]
> > Incidentally, I don't know whether "P3 Preferences window: OK button
> > does not work when a tab is selected in the left-hand panel." was an
> > instance of this or something separate, but I can't reproduce that
> > problem any more.
>
> No, it wasn't a crash, or it would have been rated higher. It means
> that when a tab is selected, you cannot hit ENTER to save and exit
> preferences even though the OK button appears to be selected.
> You have to use a mouse to click OK, or without a mouse, TAB
> into the main part of the window, then ENTER will work. I will
> clarify that on the Checklist.
>
> The bug is still there on Windows. Can you just hit ENTER on Linux
> with the tab selected? I'm still doing a clean checkout on Linux to see
> if I can fix the compile problems I had yesterday...
>
>
>
> Gale

Ah I see - I think I'd encountered a crash at that point before, so I
assumed that was the problem. Hitting ENTER seems to work fine here on
Linux, with or without clicking a tab first. It could be potentially be
something that varies by window manager though.

Thanks for the clarification!

Dan

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
audacity-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/audacity-devel