Fdo/Unittest cppunit modern api patch

[Helio Chissini de Castro]

Hello again

Here's the patch for test using modern cppunit api.
If a newer api, ( defined CPPUNIT_API ) is found on test, the new code is used,
otherwise old one ( cppunit < 1.11 )  is used.

[]'s

--
Helio Chissini de Castro
KDE Developer
Brasil/South America Primary Contact



_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

[Greg Boone]

I don’t really know this code all too well, so maybe someone else can comment. However, it generally looks ok.

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Helio Chissini de Castro
Sent: Tuesday, May 19, 2009 4:27 PM
To: [hidden email]
Subject: [fdo-internals] Fdo/Unittest cppunit modern api patch

Hello again

Here's the patch for test using modern cppunit api.
If a newer api, ( defined CPPUNIT_API ) is found on test, the new code is used,
otherwise old one ( cppunit < 1.11 )  is used.

[]'s

--
Helio Chissini de Castro
KDE Developer
Brasil/South America Primary Contact


_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

[Helio Chissini de Castro]

Greg Boone escreveu:
> I don’t really know this code all too well, so maybe someone else can comment. However, it generally looks ok.
>
Hi Greg.

I saw that you reverted the commit, ir breaking some compilation ?

_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

[Greg Boone]

Yes. It broke the FDO build using the cppunit files in Thirdparty.

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Helio Chissini de Castro
Sent: Tuesday, May 26, 2009 10:17 AM
To: FDO Internals Mail List
Subject: Re: [fdo-internals] Fdo/Unittest cppunit modern api patch

Greg Boone escreveu:
> I don’t really know this code all too well, so maybe someone else can comment. However, it generally looks ok.
>
Hi Greg.

I saw that you reverted the commit, ir breaking some compilation ?

_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

[Helio Chissini de Castro]

Greg Boone escreveu:
> Yes. It broke the FDO build using the cppunit files in Thirdparty.

Ok, seens like the Thirdparty old is providing same definition, which
invalidates the test.
So need a better version of patch.

The difficult about cppunit itself is that the code not provides a
proper version define, in a number style instead using a string. C
preprocessor don't have a string comparison for such cases.

Thanks for spot this
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals