Export MIDI

7 Messages

Gale Andrews

Export MIDI

Reply Threaded

Greg

Just had a quick play with Export MIDI. Nice to see this. A few tweaks
would be good (assuming any of these are not already planned):

* Let the user just enter the filename when saving, which then exports
as *.mid. This is analogous with normal practice exporting audio

* Allow the *.midi extension as well, without throwing a warning

* When the "saving with unrecognised file extension" warning occurs,
and you choose no, send the user back to the "Export MIDI As:"
dialogue.

* Like other file dialogues, the window includes zip files even when a
specific filter such as *.mid is chosen. Shouldn't we exclude these
from being considered a folder, like we did in 1.2.6?

* When only a MIDI is on screen, normal Export functions should be
greyed out.

* Undoing cut/copy/paste in MIDI tracks seems to empty the track
of data, with no way of getting it back (Redo does not help).

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Greg Williams-2

Re: Export MIDI

Reply Threaded

Gale,

These are all very good suggestions. Within a couple hours, I will be committing my changes on Mac that make scorealign on by default (and writing another email explaining how to use it, what works / doesn't work, etc.), and will begin implementing most of these tweaks throughout next week. I had tried one or two of the suggestions before my commit, but ran into some problems, so I'll be giving them another shot.

On a side note, your final bullet seems to be reporting a bug that I thought my most recent commit had fixed. Could you please describe more specifically what actions you took?

Thanks,
-Greg

On Fri, Aug 8, 2008 at 12:59 PM, <gale@...> wrote:

Greg

Just had a quick play with Export MIDI. Nice to see this. A few tweaks
would be good (assuming any of these are not already planned):

* Let the user just enter the filename when saving, which then exports
as *.mid. This is analogous with normal practice exporting audio

* Allow the *.midi extension as well, without throwing a warning

* When the "saving with unrecognised file extension" warning occurs,
and you choose no, send the user back to the "Export MIDI As:"
dialogue.

* Like other file dialogues, the window includes zip files even when a
specific filter such as *.mid is chosen. Shouldn't we exclude these
from being considered a folder, like we did in 1.2.6?

* When only a MIDI is on screen, normal Export functions should be
greyed out.

* Undoing cut/copy/paste in MIDI tracks seems to empty the track
of data, with no way of getting it back (Redo does not help).

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Gale Andrews

Re: Export MIDI

Reply Threaded

| From "Greg Williams" <gswillia@...>
| Fri, 8 Aug 2008 17:35:05 -0400
| Subject: [Audacity-devel] Export MIDI
> On a side note, your final bullet seems to be reporting a bug that
> I thought my most recent commit had fixed. Could you please describe
> more specifically what actions you took?
> > * Undoing cut/copy/paste in MIDI tracks seems to empty the track
> > of data, with no way of getting it back (Redo does not help).

* Import a MIDI
* Select a region.
* Edit > Cut
* Home (but cursor position does not matter)
* Edit > Paste
* Edit > Undo Paste
* All note data disappears
* Edit > Redo Paste reselects the paste region
but does not restore either the pasted data
or the lost data.

I'm not sure I really like the current solution for showing the
selection region in the note track, which is to make the notes
white with a border of the note colour. I find this a little
confusing and also does not provide sufficient contrast. Also
how good this looks or otherwise depends on the theme in use.

Would it be possible to use a fixed (say off-white) colour for the
part of the selection region in the note track, irrespective of the theme,
and not change the note colours? Or even just denote the region
edges in the track by two vertical lines?

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Greg Williams-2

Re: Export MIDI

Reply Threaded

Thanks for the information regarding how to replicate the bug. It's the exact bug that I thought I had fixed. I'll definitely look into it again.

Roger and I had talked about what we were going to do about the highlighting of notes, since neither of us found it appealing either. (Another reason it's not preferred is that the first note in the selected region is always highlighted, but most editing commands -- cut and copy, off the top of my head -- do not actually affect it.)

We decided that the best way to go about changing it would be to change the background color of the selected region and leave the note color intact, in the same way that the background color of a WaveTrack is changed. So we're basically in agreement with you there.

However, I was thinking that it would probably be best to use the same dark grey that is currently used for selected sections of WaveTracks, that way everything matches in the end. (If we wanted to keep the "stripes" along the NoteTrack for selected regions, I don't think it would be much of a problem.) The actual color choice is fairly irrelevant, though, and we can decide on it later.

Changing the coloring of a selected region of a NoteTrack is up on my list of things to take care of, but I imagine it's going to take me a while to figure out how to do, since I'm not all that familiar with GUI, wxWidgets, etc. Unless anyone has any objections or other ideas, I'll be implementing it as described above.

Thanks,
-Greg

On Fri, Aug 8, 2008 at 7:18 PM, Gale Andrews <gale@...> wrote:

| From "Greg Williams" <gswillia@...>
| Fri, 8 Aug 2008 17:35:05 -0400
| Subject: [Audacity-devel] Export MIDI

> On a side note, your final bullet seems to be reporting a bug that
> I thought my most recent commit had fixed. Could you please describe
> more specifically what actions you took?

> > * Undoing cut/copy/paste in MIDI tracks seems to empty the track
> > of data, with no way of getting it back (Redo does not help).

* Import a MIDI
* Select a region.
* Edit > Cut
* Home (but cursor position does not matter)
* Edit > Paste
* Edit > Undo Paste
* All note data disappears
* Edit > Redo Paste reselects the paste region
but does not restore either the pasted data
or the lost data.

I'm not sure I really like the current solution for showing the
selection region in the note track, which is to make the notes
white with a border of the note colour. I find this a little
confusing and also does not provide sufficient contrast. Also
how good this looks or otherwise depends on the theme in use.

Would it be possible to use a fixed (say off-white) colour for the
part of the selection region in the note track, irrespective of the theme,
and not change the note colours? Or even just denote the region
edges in the track by two vertical lines?

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Gale Andrews

Re: Export MIDI

Reply Threaded

| From "Greg Williams" <gswillia@...>
| Fri, 8 Aug 2008 20:03:54 -0400
| Subject: [Audacity-devel] Export MIDI

> Roger and I had talked about what we were going to do about the highlighting
> of notes, since neither of us found it appealing either. (Another reason
> it's not preferred is that the first note in the selected region is always
> highlighted, but most editing commands -- cut and copy, off the top of my
> head -- do not actually affect it.)
>
> We decided that the best way to go about changing it would be to change the
> background color of the selected region and leave the note color intact, in
> the same way that the background color of a WaveTrack is changed. So we're
> basically in agreement with you there.
>
> However, I was thinking that it would probably be best to use the same dark
> grey that is currently used for selected sections of WaveTracks, that way
> everything matches in the end. (If we wanted to keep the "stripes" along
> the NoteTrack for selected regions, I don't think it would be much of a
> problem.) The actual color choice is fairly irrelevant, though, and we can
> decide on it later.
>
> Changing the coloring of a selected region of a NoteTrack is up on my list
> of things to take care of, but I imagine it's going to take me a while to
> figure out how to do, since I'm not all that familiar with GUI, wxWidgets,
> etc. Unless anyone has any objections or other ideas, I'll be implementing
> it as described above.

The only reason I didn't suggest using the dark grey of the current
default theme is that it's too close to colour 10 on the MIDI Track
Panel. Of course you could solve that by changing that colour (light
yellow, which makes it less like the mute colour)? I'd agree if the
Note Track could have the same selection colour as for other tracks,
that would be preferable.

Thanks

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Greg Williams-2

Re: Export MIDI

Reply Threaded

Hey all,

Regarding a previous conversation with Gale (seen below), I've been working on changing the behavior of NoteTracks when they are selected. Unfortunately, I've looked for the place where the highlighting takes place for a couple of days now, but to no avail. Any tips as to where I can find it? Even a tip in the right general direction would be appreciated.

Thanks,
-Greg

On 8/9/08, Gale Andrews <gale@...> wrote:

| From "Greg Williams" <gswillia@...>

| Fri, 8 Aug 2008 20:03:54 -0400

| Subject: [Audacity-devel] Export MIDI

> Roger and I had talked about what we were going to do about the highlighting
> of notes, since neither of us found it appealing either.  (Another reason
> it's not preferred is that the first note in the selected region is always
> highlighted, but most editing commands -- cut and copy, off the top of my
> head -- do not actually affect it.)
>
> We decided that the best way to go about changing it would be to change the
> background color of the selected region and leave the note color intact, in
> the same way that the background color of a WaveTrack is changed.  So we're
> basically in agreement with you there.
>
> However, I was thinking that it would probably be best to use the same dark
> grey that is currently used for selected sections of WaveTracks, that way
> everything matches in the end.  (If we wanted to keep the "stripes" along
> the NoteTrack for selected regions, I don't think it would be much of a
> problem.)  The actual color choice is fairly irrelevant, though, and we can
> decide on it later.
>
> Changing the coloring of a selected region of a NoteTrack is up on my list
> of things to take care of, but I imagine it's going to take me a while to
> figure out how to do, since I'm not all that familiar with GUI, wxWidgets,
> etc.  Unless anyone has any objections or other ideas, I'll be implementing
> it as described above.

The only reason I didn't suggest using the dark grey of the current
default theme is that it's too close to colour 10 on the MIDI Track
Panel. Of course you could solve that by changing that colour (light
yellow, which makes it less like the mute colour)? I'd agree if the
Note Track could have the same selection colour as for other tracks,
that would be preferable.

Thanks

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Greg Williams-2

Re: Export MIDI

Reply Threaded

Some javascript/style in this post has been disabled (why?)

Disregard -- I've found it. Turns out I was barking up the wrong tree.

Thanks,
-Greg

On 8/18/08, Greg Williams <gswillia@...> wrote:

Hey all,

Regarding a previous conversation with Gale (seen below), I've been working on changing the behavior of NoteTracks when they are selected. Unfortunately, I've looked for the place where the highlighting takes place for a couple of days now, but to no avail. Any tips as to where I can find it? Even a tip in the right general direction would be appreciated.

Thanks,
-Greg

On 8/9/08, Gale Andrews <gale@...> wrote:

| From "Greg Williams" <gswillia@...>

| Fri, 8 Aug 2008 20:03:54 -0400

| Subject: [Audacity-devel] Export MIDI

> Roger and I had talked about what we were going to do about the highlighting
> of notes, since neither of us found it appealing either.  (Another reason
> it's not preferred is that the first note in the selected region is always
> highlighted, but most editing commands -- cut and copy, off the top of my
> head -- do not actually affect it.)
>
> We decided that the best way to go about changing it would be to change the
> background color of the selected region and leave the note color intact, in
> the same way that the background color of a WaveTrack is changed.  So we're
> basically in agreement with you there.
>
> However, I was thinking that it would probably be best to use the same dark
> grey that is currently used for selected sections of WaveTracks, that way
> everything matches in the end.  (If we wanted to keep the "stripes" along
> the NoteTrack for selected regions, I don't think it would be much of a
> problem.)  The actual color choice is fairly irrelevant, though, and we can
> decide on it later.
>
> Changing the coloring of a selected region of a NoteTrack is up on my list
> of things to take care of, but I imagine it's going to take me a while to
> figure out how to do, since I'm not all that familiar with GUI, wxWidgets,
> etc.  Unless anyone has any objections or other ideas, I'll be implementing
> it as described above.

The only reason I didn't suggest using the dark grey of the current
default theme is that it's too close to colour 10 on the MIDI Track
Panel. Of course you could solve that by changing that colour (light
yellow, which makes it less like the mute colour)? I'd agree if the
Note Track could have the same selection colour as for other tracks,
that would be preferable.

Thanks

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel