Export MIDI refined, NoteTrack selection behavior changed
|
|
Greg Williams-2
|
With my most recent commit, I've incorporated a bunch of suggestions into the "Export MIDI" option, and I've changed the way that Audacity shows that a portion of a NoteTrack has been selected.
The following are the suggestions received for Export MIDI (thanks, Gale!): >Let the user just enter the filename when saving, which then exports as *.mid. This is analogous with normal practice exporting audio Done. >Allow the *.midi extension as well, without throwing a warning Done. For consistency, I also allowed *.midi files to be imported (this was disallowed before, with an "Incorrect Filetype" error message). >When the "saving with unrecognised file extension" warning occurs, and you choose no, send the user back to the "Export MIDI As:" dialogue. Done. >Like other file dialogues, the window includes zip files even when a specific filter such as *.mid is chosen. Shouldn't we exclude these from being considered a folder, like we did in 1.2.6? I couldn't figure this one out, but it seems to apply to most file dialogues, so at least it's consistent for now, and when it's fixed on the other file dialogues, I'll look at the code that excludes zip files and transfer it over. >When only a MIDI is on screen, normal Export functions should be greyed out. To fix this, I changed instances of TracksExistFlag in Export to WaveTracksExistFlag, and TracksSelectedFlag in Export Selection to WaveTracksSelectedFlag, since I'm fairly certain that the only types of tracks to consider for export are Wave, Note, and Label. If this is incorrect, please let me know and I can go back and fix it. (I left Export Labels and Export Multiple alone.) >Undoing cut/copy/paste in MIDI tracks seems to empty the track of data, with no way of getting it back (Redo does not help). Sure enough, this was a bug I had fixed, and I cannot replicate it on my machine. I checked the CVS repository, and the fix seems to be in there. If an update doesn't fix this bug, please let me know and I'll look into it again. Also, when a portion of a NoteTrack is selected, the old behavior was to color the inside of the notes white. This has been replaced with keeping the color of the notes intact, and instead changing the background color of the selected portion of the NoteTrack (which matches the background color of a selected WaveTrack quite nicely, if I do say so myself). Although it was originally planned to change the color of MIDI Channel 10 due to similarity, the new background turns out not to be similar enough to warrant a change to the color of the channel. However, if anyone feels otherwise (perhaps taking into consideration colorblind users), let me know and I can change things around. As usual, if anything breaks, USE_MIDI can be turned off in the config files until a more permanent solution is found. Thanks for all feedback. -Greg ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ audacity-devel mailing list audacity-devel@... https://lists.sourceforge.net/lists/listinfo/audacity-devel |
||||
Gale Andrews
|
| From "Greg Williams" <gswillia@...> | Tue, 19 Aug 2008 20:24:59 -0400 | Subject: [Audacity-devel] Export MIDI refined, NoteTrack selection behavior changed > With my most recent commit, I've incorporated a bunch of suggestions > into the "Export MIDI" option, and I've changed the way that Audacity > shows that> a portion of a NoteTrack has been selected. Thanks for all the fixes. > >When only a MIDI is on screen, normal Export functions should be greyed > out. To fix this, I changed instances of TracksExistFlag in Export to > WaveTracksExistFlag, and TracksSelectedFlag in Export Selection to > WaveTracksSelectedFlag, since I'm fairly certain that the only types of > tracks to consider for export are Wave, Note, and Label. If this is > incorrect, please let me know and I can go back and fix it. (I left Export > Labels and Export Multiple alone.) I think Export Multiple should simply be greyed out when there are no audio tracks on screen (at least until Export MIDI supports it). Are there plans that it should do so, or support export of selections? One definite problem with leaving it enabled currently is that once you have a note track and label track, export multiple and thence audio export is allowed, resulting in a string of unplayable files. If Note Track isn't going to support export multiple/export selection then I think export multiple should be moved up to join Export and Export Selection as an audio only command. > * Undoing cut/copy/paste in MIDI tracks seems to empty the track of data, > with no way of getting it back (Redo does not help). > > Sure enough, this was a bug I had fixed, and I cannot replicate it on my > machine. I checked the CVS repository, and the fix seems to be in there. > If an update doesn't fix this bug, please let me know and I'll look into it > again. Bug still there for me on Windows after update (and it also occurs if an audio track is present as well as the note track and an edit in the audio track is undone). > Also, when a portion of a NoteTrack is selected, the old behavior was to > color the inside of the notes white. This has been replaced with keeping > the color of the notes intact, and instead changing the background color of > the selected portion of the NoteTrack (which matches the background color of > a selected WaveTrack quite nicely, if I do say so myself). Although it was > originally planned to change the color of MIDI Channel 10 due to similarity, > the new background turns out not to be similar enough to warrant a change to > the color of the channel. However, if anyone feels otherwise (perhaps > taking into consideration colorblind users), let me know and I can change > things around. I don't have problems seeing the colour of note 10 through a selection region though I think a colour not so closely associated both with the interface and with the note mute colour would be better. You could say my suggestion of light yellow might be too much like the focus colour, but my 2p would still be to try some kind of light colour. I'll also add that I can't actually read "7" and "8" on those two notes. Make the text white? I've got more some ideas, many of which may already be in your plans or discounted as not possible: * Can we support drag and drop of MIDI-type files when USE_MIDI is defined, rather than give an error ? * How about allowing MIDI-type files in the Recent Files list? * Most MIDIs I imported have more notes in the track above C2 which is not obvious when first imported at default height. How about an upwards pointing arrow indicating this if there is data in C3 upwards? * Note Tracks don't scale when vertically dragged as audio tracks do, and don't respond to Fit Vertically * It is not possible to click on the track panel to select all of a note track as you do for audio tracks. * When there are audio tracks and a note track, but only a note track is selected, should Export and Export Selection be greyed? Not sure about this, the audio export does work fine. * Title in NoteTrack should take the file name of the file, not remain as "Note Track" * What about *.kar files (that support lyrics)? Most MIDI editors/players that don't support lyrics still display the notes and/or play .kar files. And I would expect there are *kar files around that contain no lyrics but are just mis-named MIDI files. * I get a replicable crash if I have two note tracks, cut or copy from one of them and then select both to paste into. * Then of course Crash Recovery knows nothing of those note tracks... Thanks Gale ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ audacity-devel mailing list audacity-devel@... https://lists.sourceforge.net/lists/listinfo/audacity-devel |
||||||||||||||||||
| Free Forum Powered by Nabble | Forum Help |