Duplications & debt - REST/XMLRPC and WebDAV

[vmassol]

Hi Asiri,

I see there's 10% of code duplication in the webdav module:
http://nemo.sonarsource.org/project/index/181898

This is the highest of all modules. Do you think you could have a look?

Second worst is REST with 5%
http://nemo.sonarsource.org/components/index/178319

In term of technical debt, WebDAV module is also high with 9.5% and  
the highest is the XMLRPC module with 12.2%.

Thanks
-Vincent

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs

[Florin Ciubotaru]

Hi,

On 10/18/2009 9:58 AM, Vincent Massol wrote:

> Hi Asiri,
>
> I see there's 10% of code duplication in the webdav module:
> http://nemo.sonarsource.org/project/index/181898
>
> This is the highest of all modules. Do you think you could have a look?
>
> Second worst is REST with 5%
> http://nemo.sonarsource.org/components/index/178319
>    

We should have a common implementation for most API features and just
expose those in XML-RPC, REST, GWT-RPC, etc.
There is also some code duplication which occurs for each servlet that
needs to initialize the old context and XWiki class.
> In term of technical debt, WebDAV module is also high with 9.5% and
> the highest is the XMLRPC module with 12.2%.
>
>    
Yes, xmlrpc seems a bit messy right now. I'd like to work on extending
and refactoring this module during the 2.1 time frame.

Thanks,
Florin Ciubotaru
> Thanks
> -Vincent
>
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs
>
>    

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs

[Fabio Mancinelli-4]

On Oct 18, 2009, at 8:58 AM, Vincent Massol wrote:

> Hi Asiri,
>
> I see there's 10% of code duplication in the webdav module:
> http://nemo.sonarsource.org/project/index/181898
>
> This is the highest of all modules. Do you think you could have a  
> look?
>
> Second worst is REST with 5%
> http://nemo.sonarsource.org/components/index/178319
>

I am still working on the REST module.

> In term of technical debt, WebDAV module is also high with 9.5% and
> the highest is the XMLRPC module with 12.2%.
>
I don't understand where the technical debt ratio comes from (what  
does it estimate actually?).

The XMLRPC module is very dumb : it contains only an interface  
defining the XMLRPC API, a client that makes calling XMLRPC easier,  
and some xwiki-specific model class for transferring information.  
There is almost no logic there. I don't understand where this debt  
comes from.

Thanks,
-Fabio
_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs

[vmassol]

On Oct 18, 2009, at 12:32 PM, Fabio Mancinelli wrote:

>
> On Oct 18, 2009, at 8:58 AM, Vincent Massol wrote:
>
>> Hi Asiri,
>>
>> I see there's 10% of code duplication in the webdav module:
>> http://nemo.sonarsource.org/project/index/181898
>>
>> This is the highest of all modules. Do you think you could have a
>> look?
>>
>> Second worst is REST with 5%
>> http://nemo.sonarsource.org/components/index/178319
>>
> I am still working on the REST module.
>
>> In term of technical debt, WebDAV module is also high with 9.5% and
>> the highest is the XMLRPC module with 12.2%.
>>
> I don't understand where the technical debt ratio comes from (what
> does it estimate actually?).

I think it's related to the findbugs errors.

-Vincent

>
> The XMLRPC module is very dumb : it contains only an interface
> defining the XMLRPC API, a client that makes calling XMLRPC easier,
> and some xwiki-specific model class for transferring information.
> There is almost no logic there. I don't understand where this debt
> comes from.
>
> Thanks,
> -Fabio

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs

[Asiri Rathnayake]

Hi Vincent,

On Sun, Oct 18, 2009 at 12:28 PM, Vincent Massol <[hidden email]> wrote:

> Hi Asiri,
>
> I see there's 10% of code duplication in the webdav module:
> http://nemo.sonarsource.org/project/index/181898
>
> This is the highest of all modules. Do you think you could have a look?
>

I'd be glad to :)

WebDAV module is still dependant on xwiki-core, I was waiting for a chance
to refactor it. Although, I suspect that this could take some effort.

Do you want me to:

1) Just fix duplications & improve the code.

2) Refactor the module to get rid of xwiki-core dependancy as well.

I will start with 1).

Thanks.

- Asiri

>
> Second worst is REST with 5%
> http://nemo.sonarsource.org/components/index/178319
>
> In term of technical debt, WebDAV module is also high with 9.5% and
> the highest is the XMLRPC module with 12.2%.
>
> Thanks
> -Vincent
>
> _______________________________________________
> devs mailing list
> [hidden email]
> http://lists.xwiki.org/mailman/listinfo/devs
>

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs

[vmassol]

On Oct 19, 2009, at 4:33 AM, Asiri Rathnayake wrote:

> Hi Vincent,
>
> On Sun, Oct 18, 2009 at 12:28 PM, Vincent Massol  
> <[hidden email]> wrote:
>
>> Hi Asiri,
>>
>> I see there's 10% of code duplication in the webdav module:
>> http://nemo.sonarsource.org/project/index/181898
>>
>> This is the highest of all modules. Do you think you could have a  
>> look?
>>
>
> I'd be glad to :)
>
> WebDAV module is still dependant on xwiki-core, I was waiting for a  
> chance
> to refactor it. Although, I suspect that this could take some effort.
>
> Do you want me to:
>
> 1) Just fix duplications & improve the code.
>
> 2) Refactor the module to get rid of xwiki-core dependancy as well.
>
> I will start with 1).

For me this is an ongoing process to improve/refactor/clean up  
existing code. It's not something we should do 100% of our time but  
more as a background thread with a low priority but that runs all the  
time. 1) and 2) are fine but don't stop everything you're doing to do  
them (it should not endanger anything you're working on). Instead work  
on them small steps at a time.

Thanks
-Vincent

>
> Thanks.
>
> - Asiri
>
>
>>
>> Second worst is REST with 5%
>> http://nemo.sonarsource.org/components/index/178319
>>
>> In term of technical debt, WebDAV module is also high with 9.5% and
>> the highest is the XMLRPC module with 12.2%.
>>
>> Thanks
>> -Vincent

_______________________________________________
devs mailing list
[hidden email]
http://lists.xwiki.org/mailman/listinfo/devs