Audacity

›

audacity-devel

Cosmetic Bug dragging behind Windows Task Bar

15 Messages

Gale Andrews

Reply Threaded

Windows XP SP3

There seems a cosmetic bug in CVS that means when you drag a toolbar
outside the Audacity window to the Taskbar, it does not sit on top of
the Taskbar but disappears behind it. It occurs whether the Task Bar is
at bottom of the screen or elsewhere. Regression on 1.2.6. Can anyone
else confirm this (may be Jan already knows :=)

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Jan Kolar

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

gale@... napsal(a):

> Windows XP SP3
>
> There seems a cosmetic bug in CVS that means when you drag a toolbar
> outside the Audacity window to the Taskbar, it does not sit on top of
> the Taskbar but disappears behind it. It occurs whether the Task Bar is
> at bottom of the screen or elsewhere. Regression on 1.2.6. Can anyone
> else confirm this (may be Jan already knows :=)
>
>
> Gale
>
>

Gale, fortunately I never needed on-top floating toolbars in beta since
I used 1.2.6 for recording.
(Hence I did not know.)
The behaviour of beta toolbars towards Windows Taskbar is the same as
towards other application windows. I think most of them should indeed be
on-top.

1.2.6
floating control toolbar is on top.
Details: on top of all including Windows Tasks bar, (OK)
and including Thunderbird's save-as menu (OK)
[but not on top of windows start menu or Thunderbird's
menus (OK)]

1.3.6a1 (Jun 1 2008):
They are not on top.
They respect the current front-to-back order of application windows.
In short, they behave as normal child windows including that Windows
Tasks bar stays on top of them.

Without looking into the source, I think that the main difference would
be that in 1.2.6, the floating tool bars have STAY_ON_TOP, while in
1.3.6a they do not have this flag. Indeed, in sources I found only the
Indicator (what is this?) having STAY_ON_TOP.

I think this is just a feature (and I would not dare to complain about)
but I also think that many of the toolbars should be ON_TOP.
(Yes: Control, Mixer(=volumes), Meter, Device(=source selectors) and
the like, including Transcription Bar, and Selection ToolBar
Not: Tools, Edit and the like)

I understand that default wxPanel (or wxToolbars) will not have
STAY_ON_TOP, since this is makes no sense in most applications like
text/picture editors etc.

I also briefly greped WX sources and noticed
wxFLAGS_MEMBER(wxSTAY_ON_TOP)
in two files. It worries me a bit: I guess it means STAY_ON_TOP is
explicitly allowed/implemented for dialogs and frames and perhaps not in
general?? (Are tollbars/panels derived from frames?)

Jan

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Martyn Shaw-2

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

Jan Kolar wrote:

> Indeed, in sources I found only the
> Indicator (what is this?) having STAY_ON_TOP.

It's the blue indicator that tells you where a floating toolbar will
dock if you drag it over the dock. Also known as a 'blue meanie'.

Martyn

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Jan Kolar

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

Martyn Shaw napsal(a):

> Jan Kolar wrote:
>
>
>> Indeed, in sources I found only the
>> Indicator (what is this?) having STAY_ON_TOP.
>>
>
> It's the blue indicator that tells you where a floating toolbar will
> dock if you drag it over the dock. Also known as a 'blue meanie'.
>
> Martyn
>
>

Yes, thanks. It indeed stays on top of everything, even if switching by
Alt-Tab to another application.
An assertion says it (or its friends) ignores lost mouse capture event.
The first is cosmetic but the second is a serious thing that applies to
any situation when mouse is captured.

Jan

> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> audacity-devel mailing list
> audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Leland (Audacity Team)

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

In reply to this post by Jan Kolar

Jan Kolar wrote:
> I also briefly greped WX sources and noticed
> wxFLAGS_MEMBER(wxSTAY_ON_TOP)
> in two files. It worries me a bit: I guess it means STAY_ON_TOP is
> explicitly allowed/implemented for dialogs and frames and perhaps not in
> general?? (Are tollbars/panels derived from frames?)
>
STAY_ON_TOP could be used for toolbars and was used in the past, but the
problem is that they stay on top of ALL windows, not just Audacity. So,
if you were to add the flag and CTRL+TAB to another app, the Audacity
toolbar would be in your way.

What is used is wxFRAME_FLOAT_ON_PARENT which causes to the toolbar to
be "hidden" when Audacity is no longer the active application. And, it
should keep the toolbar "on top" of the owning Audacity window.

Leland

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Leland (Audacity Team)

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

In reply to this post by Jan Kolar

Jan Kolar wrote:
> Yes, thanks. It indeed stays on top of everything, even if switching by
> Alt-Tab to another application.
> An assertion says it (or its friends) ignores lost mouse capture event.
> The first is cosmetic but the second is a serious thing that applies to
> any situation when mouse is captured.
>
Good catch...working on a solution now.

Leland

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Gale Andrews

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

In reply to this post by Leland (Audacity Team)

| From Leland <leland@...>
| Thu, 24 Jul 2008 18:24:20 -0500
| Subject: [Audacity-devel] Cosmetic Bug dragging behind Windows Task Bar

> Jan Kolar wrote:
> > I also briefly greped WX sources and noticed
> > wxFLAGS_MEMBER(wxSTAY_ON_TOP)
> > in two files. It worries me a bit: I guess it means STAY_ON_TOP is
> > explicitly allowed/implemented for dialogs and frames and perhaps not in
> > general?? (Are tollbars/panels derived from frames?)
> >
> STAY_ON_TOP could be used for toolbars and was used in the past, but the
> problem is that they stay on top of ALL windows, not just Audacity. So,
> if you were to add the flag and CTRL+TAB to another app, the Audacity
> toolbar would be in your way.

Right - thanks, Leland. I actually thought I once had an app with floating
toolbars that stayed on top of the Taskbar, but disappeared when the app
was no longer active. Better as it is now I think - autohide the Windows
TaskBar if you want to float the Toolbar that far.

While we're on the subject, Jan reminded us a while ago that the Export
Options dialogues are flagged with STAY_ON_TOP, so do just that. I
remarked tongue-in-cheek that this was helpful when writing the manual,
but more seriously, would it be better if these dialogues were modal?
Or was the reasoning you might want to switch apps. to check the player
application or something like that?
.

Gale

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Leland (Audacity Team)

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

In reply to this post by Jan Kolar

Jan Kolar wrote:
> Yes, thanks. It indeed stays on top of everything, even if switching by
> Alt-Tab to another application.
> An assertion says it (or its friends) ignores lost mouse capture event.
> The first is cosmetic but the second is a serious thing that applies to
> any situation when mouse is captured.
>
The lost capture issue should now be fixed in all cases where
CaptureMouse() was used...not just the toolbars.

I was unable to lose capture on OSX. Didn't try Linux.

Leland

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Jan Kolar

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

In reply to this post by Leland (Audacity Team)

Leland napsal(a):

> Jan Kolar wrote:
>
>> I also briefly greped WX sources and noticed
>> wxFLAGS_MEMBER(wxSTAY_ON_TOP)
>> in two files. It worries me a bit: I guess it means STAY_ON_TOP is
>> explicitly allowed/implemented for dialogs and frames and perhaps not in
>> general?? (Are tollbars/panels derived from frames?)
>>
>>
> STAY_ON_TOP could be used for toolbars and was used in the past, but the
> problem is that they stay on top of ALL windows, not just Audacity. So,
> if you were to add the flag and CTRL+TAB to another app, the Audacity
> toolbar would be in your way.
>
>

I think that the meaning of STAY_ON_TOP is exactly "stay on top of ALL
windows, not just Audacity".
I think that selected toolbars should perhaps behave just like that, but
I do not know how that would be implemented in current CVS.

Jan

> What is used is wxFRAME_FLOAT_ON_PARENT which causes to the toolbar to
> be "hidden" when Audacity is no longer the active application. And, it
> should keep the toolbar "on top" of the owning Audacity window.
>
> Leland
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> audacity-devel mailing list
> audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Jan Kolar

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

In reply to this post by Leland (Audacity Team)

Leland napsal(a):

> Jan Kolar wrote:
>
>> Yes, thanks. It indeed stays on top of everything, even if switching by
>> Alt-Tab to another application.
>> An assertion says it (or its friends) ignores lost mouse capture event.
>> The first is cosmetic but the second is a serious thing that applies to
>> any situation when mouse is captured.
>>
>>
> The lost capture issue should now be fixed in all cases where
> CaptureMouse() was used...not just the toolbars.
>

I should test it, but unfortunately I decided to update rarely :-(
(much time to fix all on cygwin, with my slow computer, still.)

> I was unable to lose capture on OSX. Didn't try Linux.
>

Haha, just made some 1.3.6a1(?) crash 10second from start by lost mouse
capture. I did not expect _that_ to be very likely.

Generally I expect capture loss when some window pops up,
e.g., due new USB HDD connected (hapend at least once from two
experiments I did - with label boundary adjust, crash),
software update allert, virus allert, IE finally getting the page and
swapping through...

I think on XP, the sequence for toolbars was more complicated:
I am dragging floating toolbar (holding mouse, indicator is visible)
I press Alt Tab (indicator stays on top of whatever)
I go to windows TaskBar where I do right-click work to minimize
Audacity (Assertion, but I do not see any effects otherwise(?)).
For label boundary ajust, just Alt-Tab was enough.

Jan

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Leland (Audacity Team)

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

Jan Kolar wrote:
>
> I think on XP, the sequence for toolbars was more complicated:
> I am dragging floating toolbar (holding mouse, indicator is visible)
> I press Alt Tab (indicator stays on top of whatever)
> I go to windows TaskBar where I do right-click work to minimize
> Audacity (Assertion, but I do not see any effects otherwise(?)).
> For label boundary ajust, just Alt-Tab was enough.
>
Are you sure you updated properly? Is was extremely easy to force the
assertion for every case where we CaptureMouse(), but now I'm unable to
make it happen at all under XP.

Leland

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Martyn Shaw-2

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

Leland

I've updated and tested and the only problem I can still find is on
the label boundary. Left-click and drag the left/right boundary to
move the label. While mouse still down, Alt-Tab to another app.,
release the mouse. Switch back to Audacity. Now the label edge
circle is white and shouldn't be. Another click on it and it crashes.

A simpler way is to put a break point in
TrackPanel::HandleLabelTrackMouseEvent after if(event.LeftDown()), and
then click the label handle. The first time at the braekpoint, lTrack
is fine, the second it isn't.

Gotta go, food awaits!
Martyn

Leland wrote:

> Jan Kolar wrote:
>> I think on XP, the sequence for toolbars was more complicated:
>> I am dragging floating toolbar (holding mouse, indicator is visible)
>> I press Alt Tab (indicator stays on top of whatever)
>> I go to windows TaskBar where I do right-click work to minimize
>> Audacity (Assertion, but I do not see any effects otherwise(?)).
>> For label boundary ajust, just Alt-Tab was enough.
>>
> Are you sure you updated properly? Is was extremely easy to force the
> assertion for every case where we CaptureMouse(), but now I'm unable to
> make it happen at all under XP.
>
> Leland
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> audacity-devel mailing list
> audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Leland (Audacity Team)

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

Martyn Shaw wrote:
> Leland
>
> I've updated and tested and the only problem I can still find is on
> the label boundary. Left-click and drag the left/right boundary to
> move the label. While mouse still down, Alt-Tab to another app.,
> release the mouse. Switch back to Audacity. Now the label edge
> circle is white and shouldn't be. Another click on it and it crashes.
>
Ah yes, I see now. Seems my solution for the TrackPanel was overly
simplistic. Will take another crack.

Leland

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Leland (Audacity Team)

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

In reply to this post by Martyn Shaw-2

Martyn Shaw wrote:
> Leland
>
> I've updated and tested and the only problem I can still find is on
> the label boundary. Left-click and drag the left/right boundary to
> move the label. While mouse still down, Alt-Tab to another app.,
> release the mouse. Switch back to Audacity. Now the label edge
> circle is white and shouldn't be. Another click on it and it crashes.
>
Update and try again...

Leland

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Martyn Shaw-2

Re: Cosmetic Bug dragging behind Windows Task Bar

Reply Threaded

That seems to have got it!

Martyn

Leland wrote:

> Martyn Shaw wrote:
>> Leland
>>
>> I've updated and tested and the only problem I can still find is on
>> the label boundary. Left-click and drag the left/right boundary to
>> move the label. While mouse still down, Alt-Tab to another app.,
>> release the mouse. Switch back to Audacity. Now the label edge
>> circle is white and shouldn't be. Another click on it and it crashes.
>>
> Update and try again...
>
> Leland
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> audacity-devel mailing list
> audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>