Bugfix: ISO_Level3_Shift was breaking composition

8 messages

Bugfix: ISO_Level3_Shift was breaking composition

Reply Threaded

Hello. I send the bugfix to the bug that pressing modifier level3_shift
(usually right alt) was breaking the composition
Vladimir Serbinenko
Index: src/scim_compose_key.cpp
===================================================================
--- src/scim_compose_key.cpp (revision 114)
+++ src/scim_compose_key.cpp (working copy)
@@ -92,6 +92,8 @@
#define SCIM_NUM_COMPOSE_SEQS (sizeof (__scim_compose_seqs) / sizeof
(__scim_compose_seqs [0]))

static uint16 __scim_compose_ignores [] = {
+ SCIM_KEY_ISO_Level3_Shift,
+ SCIM_KEY_ISO_Group_Shift,
SCIM_KEY_Mode_switch,
SCIM_KEY_Shift_L,
SCIM_KEY_Shift_R,

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Scim-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/scim-devel

Ryo Dairiki-2

Re: Bugfix: ISO_Level3_Shift was breaking composition

Reply Threaded

Hi phcoder,

Thank you for sending me a patch.
But I'm sorry to say that, I can't see exactly what this patch is.
Please give me a testcase. :)

(We Japanese don't use Iso3Shift, so I don't know well about it)

Regards,
Ryo Dairiki <[hidden email]>

phcoder wrote:

> Hello. I send the bugfix to the bug that pressing modifier level3_shift
> (usually right alt) was breaking the composition
> Vladimir Serbinenko
> Index: src/scim_compose_key.cpp
> ===================================================================
> --- src/scim_compose_key.cpp (revision 114)
> +++ src/scim_compose_key.cpp (working copy)
> @@ -92,6 +92,8 @@
> #define SCIM_NUM_COMPOSE_SEQS (sizeof (__scim_compose_seqs) / sizeof
> (__scim_compose_seqs [0]))
>
> static uint16 __scim_compose_ignores [] = {
> + SCIM_KEY_ISO_Level3_Shift,
> + SCIM_KEY_ISO_Group_Shift,
> SCIM_KEY_Mode_switch,
> SCIM_KEY_Shift_L,
> SCIM_KEY_Shift_R,
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Scim-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/scim-devel
>
>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Scim-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/scim-devel

phcoder

Re: Bugfix: ISO_Level3_Shift was breaking composition

Reply Threaded

Hello. On some european keyboard you can actually have four symbols per
button: normal, shift+key, lev3+key, lev3+shift+key (rarely used). lev3
is usually right alt but can also be configured for other keys (e.g. on
my keyboard both left alt and left super are configured as lev3, so no
problem if I miss the key). And on the combinations with lev3 you can
find a lot of dead keys. So let's say you compose a serie of 3 symbols
(very used in Vietnamese): a+b+c. And let's say that b is on lev3
combination but a isn't. Normally you would expect all 3 symbols to
compose together. But you enter the key sequence:
a+(lev3+b)+c
And the moment you push lev3, "a" is lost so only two symbols are composed.
Actually this bug is already on the bugtracker since quite a while:
https://sourceforge.net/tracker/index.php?func=detail&aid=1957234&group_id=108454&atid=650539
Vladimir 'phcoder' Serbinenko
Ryo Dairiki wrote:

> Hi phcoder,
>
> Thank you for sending me a patch.
> But I'm sorry to say that, I can't see exactly what this patch is.
> Please give me a testcase. :)
>
> (We Japanese don't use Iso3Shift, so I don't know well about it)
>
> Regards,
> Ryo Dairiki <[hidden email]>
>
> phcoder wrote:
>> Hello. I send the bugfix to the bug that pressing modifier level3_shift
>> (usually right alt) was breaking the composition
>> Vladimir Serbinenko
>> Index: src/scim_compose_key.cpp
>> ===================================================================
>> --- src/scim_compose_key.cpp (revision 114)
>> +++ src/scim_compose_key.cpp (working copy)
>> @@ -92,6 +92,8 @@
>> #define SCIM_NUM_COMPOSE_SEQS (sizeof (__scim_compose_seqs) / sizeof
>> (__scim_compose_seqs [0]))
>>
>> static uint16 __scim_compose_ignores [] = {
>> + SCIM_KEY_ISO_Level3_Shift,
>> + SCIM_KEY_ISO_Group_Shift,
>> SCIM_KEY_Mode_switch,
>> SCIM_KEY_Shift_L,
>> SCIM_KEY_Shift_R,
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Scim-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>
>>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Scim-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/scim-devel

phcoder

Re: Bugfix: ISO_Level3_Shift was breaking composition

Reply Threaded

In reply to this post by Ryo Dairiki-2

Hello. This patch was commited to CVS instead of SVN (up-to-date scim
uses SVN). Is there a particular reason for it or was it just by mistake?
Vladimir Serbinenko
Ryo Dairiki wrote:

Ryo Dairiki-2

Re: Bugfix: ISO_Level3_Shift was breaking composition

Reply Threaded

Sorry, it was just by mistake. :(

Ryo

phcoder wrote:

> Hello. This patch was commited to CVS instead of SVN (up-to-date scim
> uses SVN). Is there a particular reason for it or was it just by mistake?
> Vladimir Serbinenko
> Ryo Dairiki wrote:
>
>> Hi phcoder,
>>
>> Thank you for sending me a patch.
>> But I'm sorry to say that, I can't see exactly what this patch is.
>> Please give me a testcase. :)
>>
>> (We Japanese don't use Iso3Shift, so I don't know well about it)
>>
>> Regards,
>> Ryo Dairiki <[hidden email]>
>>
>> phcoder wrote:
>>
>>> Hello. I send the bugfix to the bug that pressing modifier level3_shift
>>> (usually right alt) was breaking the composition
>>> Vladimir Serbinenko
>>> Index: src/scim_compose_key.cpp
>>> ===================================================================
>>> --- src/scim_compose_key.cpp (revision 114)
>>> +++ src/scim_compose_key.cpp (working copy)
>>> @@ -92,6 +92,8 @@
>>> #define SCIM_NUM_COMPOSE_SEQS (sizeof (__scim_compose_seqs) / sizeof
>>> (__scim_compose_seqs [0]))
>>>
>>> static uint16 __scim_compose_ignores [] = {
>>> + SCIM_KEY_ISO_Level3_Shift,
>>> + SCIM_KEY_ISO_Group_Shift,
>>> SCIM_KEY_Mode_switch,
>>> SCIM_KEY_Shift_L,
>>> SCIM_KEY_Shift_R,
>>>
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> _______________________________________________
>>> Scim-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>
>>>
>>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Scim-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Scim-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/scim-devel
>
>

phcoder

Re: Bugfix: ISO_Level3_Shift was breaking composition

Reply Threaded

Hello. I see that my patch still isn't commited to svn. If there is no
reason to refuse it could you commit it to svn?
Thanks
Vladimir 'phcoder' Serbinenko
Ryo Dairiki wrote:

> Sorry, it was just by mistake. :(
>
> Ryo
>
> phcoder wrote:
>> Hello. This patch was commited to CVS instead of SVN (up-to-date scim
>> uses SVN). Is there a particular reason for it or was it just by mistake?
>> Vladimir Serbinenko
>> Ryo Dairiki wrote:
>>
>>> Hi phcoder,
>>>
>>> Thank you for sending me a patch.
>>> But I'm sorry to say that, I can't see exactly what this patch is.
>>> Please give me a testcase. :)
>>>
>>> (We Japanese don't use Iso3Shift, so I don't know well about it)
>>>
>>> Regards,
>>> Ryo Dairiki <[hidden email]>
>>>
>>> phcoder wrote:
>>>
>>>> Hello. I send the bugfix to the bug that pressing modifier level3_shift
>>>> (usually right alt) was breaking the composition
>>>> Vladimir Serbinenko
>>>> Index: src/scim_compose_key.cpp
>>>> ===================================================================
>>>> --- src/scim_compose_key.cpp (revision 114)
>>>> +++ src/scim_compose_key.cpp (working copy)
>>>> @@ -92,6 +92,8 @@
>>>> #define SCIM_NUM_COMPOSE_SEQS (sizeof (__scim_compose_seqs) / sizeof
>>>> (__scim_compose_seqs [0]))
>>>>
>>>> static uint16 __scim_compose_ignores [] = {
>>>> + SCIM_KEY_ISO_Level3_Shift,
>>>> + SCIM_KEY_ISO_Group_Shift,
>>>> SCIM_KEY_Mode_switch,
>>>> SCIM_KEY_Shift_L,
>>>> SCIM_KEY_Shift_R,
>>>>
>>>> -------------------------------------------------------------------------
>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>> _______________________________________________
>>>> Scim-devel mailing list
>>>> [hidden email]
>>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>>
>>>>
>>>>
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> _______________________________________________
>>> Scim-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Scim-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>
>>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Scim-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/scim-devel

Ryo Dairiki-2

Re: Bugfix: ISO_Level3_Shift was breaking composition

Reply Threaded

Hi,

I've been writing the progress-report for Master's degree lately.
It's due to the next week, so I don't have time now.

Don't worry, I won't forget your patch.
I'll import it as soon as the current work finishes.

Ryo

phcoder wrote:

> Hello. I see that my patch still isn't commited to svn. If there is no
> reason to refuse it could you commit it to svn?
> Thanks
> Vladimir 'phcoder' Serbinenko
> Ryo Dairiki wrote:
>
>> Sorry, it was just by mistake. :(
>>
>> Ryo
>>
>> phcoder wrote:
>>
>>> Hello. This patch was commited to CVS instead of SVN (up-to-date scim
>>> uses SVN). Is there a particular reason for it or was it just by mistake?
>>> Vladimir Serbinenko
>>> Ryo Dairiki wrote:
>>>
>>>
>>>> Hi phcoder,
>>>>
>>>> Thank you for sending me a patch.
>>>> But I'm sorry to say that, I can't see exactly what this patch is.
>>>> Please give me a testcase. :)
>>>>
>>>> (We Japanese don't use Iso3Shift, so I don't know well about it)
>>>>
>>>> Regards,
>>>> Ryo Dairiki <[hidden email]>
>>>>
>>>> phcoder wrote:
>>>>
>>>>
>>>>> Hello. I send the bugfix to the bug that pressing modifier level3_shift
>>>>> (usually right alt) was breaking the composition
>>>>> Vladimir Serbinenko
>>>>> Index: src/scim_compose_key.cpp
>>>>> ===================================================================
>>>>> --- src/scim_compose_key.cpp (revision 114)
>>>>> +++ src/scim_compose_key.cpp (working copy)
>>>>> @@ -92,6 +92,8 @@
>>>>> #define SCIM_NUM_COMPOSE_SEQS (sizeof (__scim_compose_seqs) / sizeof
>>>>> (__scim_compose_seqs [0]))
>>>>>
>>>>> static uint16 __scim_compose_ignores [] = {
>>>>> + SCIM_KEY_ISO_Level3_Shift,
>>>>> + SCIM_KEY_ISO_Group_Shift,
>>>>> SCIM_KEY_Mode_switch,
>>>>> SCIM_KEY_Shift_L,
>>>>> SCIM_KEY_Shift_R,
>>>>>
>>>>> -------------------------------------------------------------------------
>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>>> _______________________________________________
>>>>> Scim-devel mailing list
>>>>> [hidden email]
>>>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>>>
>>>>>
>>>>>
>>>>>
>>>> -------------------------------------------------------------------------
>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>> _______________________________________________
>>>> Scim-devel mailing list
>>>> [hidden email]
>>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>>
>>>>
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> _______________________________________________
>>> Scim-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>
>>>
>>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Scim-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Scim-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/scim-devel
>
>

Ryo Dairiki-2

Re: Bugfix: ISO_Level3_Shift was breaking composition

Reply Threaded

This patch has just been imported into SVN repository. :)

Ryo

Ryo Dairiki wrote:

> Hi,
>
> I've been writing the progress-report for Master's degree lately.
> It's due to the next week, so I don't have time now.
>
> Don't worry, I won't forget your patch.
> I'll import it as soon as the current work finishes.
>
> Ryo
>
> phcoder wrote:
>
>> Hello. I see that my patch still isn't commited to svn. If there is no
>> reason to refuse it could you commit it to svn?
>> Thanks
>> Vladimir 'phcoder' Serbinenko
>> Ryo Dairiki wrote:
>>
>>
>>> Sorry, it was just by mistake. :(
>>>
>>> Ryo
>>>
>>> phcoder wrote:
>>>
>>>
>>>> Hello. This patch was commited to CVS instead of SVN (up-to-date scim
>>>> uses SVN). Is there a particular reason for it or was it just by mistake?
>>>> Vladimir Serbinenko
>>>> Ryo Dairiki wrote:
>>>>
>>>>
>>>>
>>>>> Hi phcoder,
>>>>>
>>>>> Thank you for sending me a patch.
>>>>> But I'm sorry to say that, I can't see exactly what this patch is.
>>>>> Please give me a testcase. :)
>>>>>
>>>>> (We Japanese don't use Iso3Shift, so I don't know well about it)
>>>>>
>>>>> Regards,
>>>>> Ryo Dairiki <[hidden email]>
>>>>>
>>>>> phcoder wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Hello. I send the bugfix to the bug that pressing modifier level3_shift
>>>>>> (usually right alt) was breaking the composition
>>>>>> Vladimir Serbinenko
>>>>>> Index: src/scim_compose_key.cpp
>>>>>> ===================================================================
>>>>>> --- src/scim_compose_key.cpp (revision 114)
>>>>>> +++ src/scim_compose_key.cpp (working copy)
>>>>>> @@ -92,6 +92,8 @@
>>>>>> #define SCIM_NUM_COMPOSE_SEQS (sizeof (__scim_compose_seqs) / sizeof
>>>>>> (__scim_compose_seqs [0]))
>>>>>>
>>>>>> static uint16 __scim_compose_ignores [] = {
>>>>>> + SCIM_KEY_ISO_Level3_Shift,
>>>>>> + SCIM_KEY_ISO_Group_Shift,
>>>>>> SCIM_KEY_Mode_switch,
>>>>>> SCIM_KEY_Shift_L,
>>>>>> SCIM_KEY_Shift_R,
>>>>>>
>>>>>> -------------------------------------------------------------------------
>>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>>>> _______________________________________________
>>>>>> Scim-devel mailing list
>>>>>> [hidden email]
>>>>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> -------------------------------------------------------------------------
>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>>> _______________________________________________
>>>>> Scim-devel mailing list
>>>>> [hidden email]
>>>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>>>
>>>>>
>>>>>
>>>> -------------------------------------------------------------------------
>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>> _______________________________________________
>>>> Scim-devel mailing list
>>>> [hidden email]
>>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>>
>>>>
>>>>
>>>>
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> _______________________________________________
>>> Scim-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>>
>>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Scim-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/scim-devel
>>
>>
>>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Scim-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/scim-devel
>
>