A couple of issue in FFmpeg Options dialog

[Leland (AudacityTeam)]

Hi LRN,

There's a 1-off problem in the codec list.  And I often times get a
crash when using "Other FFmpeg-Compatible Files" during Export or it
just doesn't export anything.

Leland


-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Richard Ash (audacity-help)]

On Sun, 2008-07-06 at 03:03 -0500, Leland wrote:
> There's a 1-off problem in the codec list.  And I often times get a
> crash when using "Other FFmpeg-Compatible Files" during Export or it
> just doesn't export anything.

Whilst we are here, can I raise a bunch of compiler warnings:
export/ExportFFmpeg.cpp: In member function ‘void
ExportFFmpegOptions::OnFormatList(wxCommandEvent&)’:
export/ExportFFmpeg.cpp:612: warning: unused variable ‘tags’

Is tags supposed to be used in some other function? Right now it
certainly isn't being used for anything.

export/ExportFFmpeg.cpp: In member function ‘bool
ExportFFmpeg::AddTags(Tags*)’:
export/ExportFFmpeg.cpp:2008: warning: second operand of conditional has
no effect
export/ExportFFmpeg.cpp:2008: warning: third operand of conditional has
no effect
export/ExportFFmpeg.cpp:2015: warning: second operand of conditional has
no effect
export/ExportFFmpeg.cpp:2015: warning: third operand of conditional has
no effect
export/ExportFFmpeg.cpp:2022: warning: second operand of conditional has
no effect
export/ExportFFmpeg.cpp:2022: warning: third operand of conditional has
no effect
export/ExportFFmpeg.cpp:2029: warning: second operand of conditional has
no effect
export/ExportFFmpeg.cpp:2029: warning: third operand of conditional has
no effect

I don't quite understand what the construct you are using is supposed to
do, and I'm fairly sure it won't be working. An old-fashioned if
statement might be clearer, and it only gets executed once per export so
there isn't a performance issue.

Richard


-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

[LRN]

Richard Ash wrote:
> On Sun, 2008-07-06 at 03:03 -0500, Leland wrote:
>    
>> There's a 1-off problem in the codec list.  And I often times get a
>> crash when using "Other FFmpeg-Compatible Files" during Export or it
>> just doesn't export anything.
>>      
>
>    
Dialog is still unfinished. I committed it only because it is doesn't
breaks the build and it annoyed me (i had to remove it from the
ExportFFmpeg.cpp before committing this file).
"Other FFmpeg-Compatible Files" just doesn't works. That's it.
> Whilst we are here, can I raise a bunch of compiler warnings:
> export/ExportFFmpeg.cpp: In member function ‘void
> ExportFFmpegOptions::OnFormatList(wxCommandEvent&)’:
> export/ExportFFmpeg.cpp:612: warning: unused variable ‘tags’
>
>    
> Is tags supposed to be used in some other function? Right now it
> certainly isn't being used for anything.
>    
Yeah, AFAIR it is supposed to be used to filter-out list of codecs.
Though i'm still unsure about just how good this idea is. codec_tag
member of AVOutputFormat is supposed to be hidden from external
applications...

> export/ExportFFmpeg.cpp: In member function ‘bool
> ExportFFmpeg::AddTags(Tags*)’:
> export/ExportFFmpeg.cpp:2008: warning: second operand of conditional has
> no effect
> export/ExportFFmpeg.cpp:2008: warning: third operand of conditional has
> no effect
> export/ExportFFmpeg.cpp:2015: warning: second operand of conditional has
> no effect
> export/ExportFFmpeg.cpp:2015: warning: third operand of conditional has
> no effect
> export/ExportFFmpeg.cpp:2022: warning: second operand of conditional has
> no effect
> export/ExportFFmpeg.cpp:2022: warning: third operand of conditional has
> no effect
> export/ExportFFmpeg.cpp:2029: warning: second operand of conditional has
> no effect
> export/ExportFFmpeg.cpp:2029: warning: third operand of conditional has
> no effect
>
> I don't quite understand what the construct you are using is supposed to
> do, and I'm fairly sure it won't be working. An old-fashioned if
> statement might be clearer, and it only gets executed once per export so
> there isn't a performance issue.
>
>    

OK, i'll look into it.

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel