Wow, thanks, Martyn. Thanks to you, too! - V
> Hi Vaughan
>
> You have fixed heaps recently, some of which I've looked at for ages.
> Thanks! :-)
>
> Martyn
>
> Vaughan Johnson wrote:
>
>> Martyn Shaw wrote:
>>
>>> Hi Vaughan
>>>
>>> Does this actually fix anything much? OK, Esc will work when you
>>> first call up the dialog (since you are focused on the buttons), but
>>> does it still work when you tab through to the GVerb sliders? Not
>>> here, but maybe I didn't understand you and made a different change.
>>>
>>>
>> Nope, but I think this will significantly help VI users, for whom I
>> think the ESC capability is most important. They can at least bail out
>> when it opens if this is in.
>>
>> I think it's a worthwhile fix for now, but that for a full fix it's
>> probably necessary to restructure these dialogs such that OK and Cancel
>> are at the top level of the sizer structure and all the tabs and
>> subordinate controls funnel up to them rather than the
>> dialog/frame/window itself.
>>
>
> Fair enough, and there's not enough time to do everything.
>
> I don't think I saw any structural difference between
> LadspaEffectDialog and Amplify, however.
>
>
>>> It looks like a change to many dialogs in order to make a couple
>>> function better. I think I'd rather see it left as it is.
>>>
>>>
>> Any obvious likely harm to the other dialogs built using
>> CreateStdButtonSizer()?
>>
>
> Apart from the focus being different now when you open them? Amplify
> for example used to have the 'Amplification (dB):' text box focused
> on, now it's the OK button. Not a big issue but quite a visible one.
>
>
>>> Since wxScrolledWindow didn't seem to be behaving its self, I've been
>>> trying to add a 'ConnectEsc' in a similar way to 'ConnectFocus' to
>>> LadspaEffect, without success. I tried adding it to wxSizer
>>> *paramSizer and to wxScrolledWindow *w but it doesn't seem to get hit,
>>> but I'm very much a novice at these things.
>>>
>>> TTFN
>>> Martyn
>>>
>>> void LadspaEffectDialog::ConnectEsc(wxSizer *c)
>>> {
>>> c->GetEventHandler()->Connect(wxID_CANCEL,
>>>
>>> wxCommandEventHandler(LadspaEffectDialog::OnCancel));
>>> }
>>>
>>>
>> Yes, there seem to be lots of paths through this stuff, to do the same
>> thing. I've tried a bunch of EVT_KEY_DOWN and EVT_CHAR events to catch
>> some of these keyboard things, and many never get invoked.
>>
>
> Same here. I still think the problem relates to wxScrolledWindow. We
> only have 3 of these in Audacity, in LadspaEffect, VampEffect and
> ShuttleGui. The ShuttleGui one is used in Tags and escapes just fine,
> without your changes. Maybe that's the way to go with any restructuring?
>
>
>> I still think it's worth committing. Heck, for ~3 weeks to 1.3.6, we can
>> try it out.
>>
>> - V
>>
>
> I guess it's done now! And as you say, for 3 weeks...
>
> Hey, you have fixed heaps of things recently, some of which I've
> looked at for ages. Thanks! :-)
>
> TTFN
> Martyn
>
>
>>> Vaughan Johnson wrote:
>>>
>>>
>>>> Figured out a fix to the other ESC problems (prefs, ladspa, vst),
>>>> which is to change CreateStdButtonSizer() to make the OK button not
>>>> only the default, but SetFocus() on it.
>>>>
>>>> Drawback is that, e.g., in Preferences, the categories wxTreebook on
>>>> the left is no longer under immediate keyboard control -- you have to
>>>> tab from OK to Cancel to that control. Also, if you are in the
>>>> category wxTreebook, ESC doesn't work (but ENTER for OK does work).
>>>>
>>>> So, is that preferable to having the category control act as 1st in
>>>> keyboard control order? I think so, and it doesn't matter as much for
>>>> the plugins. Will work on other stuff in the meantime, but if no
>>>> objections, will commit this in a few hours.
>>>>
>>>> - V
>>>>
>>>>
>>>> -------------------------------------------------------------------------
>>>>
>>>> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
>>>> Don't miss this year's exciting event. There's still time to save
>>>> $100. Use priority code J8TL2D2.
>>>>
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
>>>>
>>>> _______________________________________________
>>>> Audacity-devel mailing list
>>>>
Audacity-devel@...
>>>>
https://lists.sourceforge.net/lists/listinfo/audacity-devel>>>>
>>>>
>>>>
>>> -------------------------------------------------------------------------
>>> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
>>> Don't miss this year's exciting event. There's still time to save
>>> $100. Use priority code J8TL2D2.
>>>
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
>>>
>>> _______________________________________________
>>> Audacity-devel mailing list
>>>
Audacity-devel@...
>>>
https://lists.sourceforge.net/lists/listinfo/audacity-devel>>>
>>>
>>>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
> Don't miss this year's exciting event. There's still time to save $100.
> Use priority code J8TL2D2.
>
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone> _______________________________________________
> Audacity-devel mailing list
>
Audacity-devel@...
>
https://lists.sourceforge.net/lists/listinfo/audacity-devel>
>
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
