| From Vaughan Johnson <
vaughan@...>
| Mon, 28 Jul 2008 11:54:37 -0700
| Subject: [Audacity-devel] [Fwd: some bugs / suggestions]
> Richard Ash wrote:
> > On Sat, 2008-07-26 at 01:49 +0100, Martyn Shaw wrote:
> >
> >> I note that there is a restriction on the rate that files may be
> >> imported at (100000), although I don't understand why, and it's
> >> probably (?) not current.
> >>
> >
> > Should definitely be increased at both ends for project opening. We do
> > need to make sure that XML read and write functions actually work OK
> > (and don't have hidden limits like ints or 5-digit decimal numbers
> > internally). In other words, I'd expect a risk of breakage when we take
> > the test away.
> >
> > It is definitely something to do whilst we are in an alpha stage, so it
> > gets sorted out.
> >
> Sounds right to me. I just copied the limits, as Leland saw. And right
> on about doing it now.
In case we want it on the Checklist so not to lose sight of it, what
needs to be done besides Martyn's fix from a couple of days ago
(below)? This certainly copes with importing WAVs at 1000 Hz and
292 000 Hz, and project files containing tracks at these rates.
Gale
Update of /cvsroot/audacity/audacity-src/src
In directory sc8-pr-cvs11.sourceforge.net:/tmp/cvs-serv30643
Modified Files:
WaveTrack.cpp
Log Message:
Increase range of allowable project sample rates read in.
Index: WaveTrack.cpp
===================================================================
RCS file: /cvsroot/audacity/audacity-src/src/WaveTrack.cpp,v
retrieving revision 1.129
retrieving revision 1.130
diff -u -d -r1.129 -r1.130
--- WaveTrack.cpp 23 Jul 2008 15:31:51 -0000 1.129
+++ WaveTrack.cpp 26 Jul 2008 23:32:45 -0000 1.130
@@ -1390,7 +1390,7 @@
// mRate is an int, but "rate" in the project file is a float.
if (!XMLValueChecker::IsGoodString(strValue) ||
!Internat::CompatibleToDouble(strValue, &dblValue) ||
- (dblValue < 100.0) || (dblValue > 100000.0)) // same bounds as ImportRawDialog::OnOK
+ (dblValue < 1.0) || (dblValue > 1000 000.0)) // allow
a large range to be read
return false;
mRate = lrint(dblValue);
}
l
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/_______________________________________________
audacity-devel mailing list
audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
